database_consistency 0.8.11 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 964b3ab9787dba65ec8981c690f93ec0b0c5a7848e7e0b835ef2aa9a9a415025
-  data.tar.gz: '09d5264224cf230a7d08157101c16d5fe8fcb180684876265dcb16c6c3ecc3f1'
+  metadata.gz: 538febddc734f33fc864270c7fcafda018dfae709ee0e462ccb63324054dd796
+  data.tar.gz: 4f8dd5fba8b01d8227b0a5b38a1148a3d29b6ef16712edb1b3d5a05bab2d7791
 SHA512:
-  metadata.gz: 661de8be036f7cd5640e6240e3abd605a013bda1fe2b7fcd52243c88d0b0251f9a57ba852117ec75827d125873f982c9c060d991ace7fff296312f7a3bf390c6
-  data.tar.gz: e87befd21bc84b26608b1ded54a6e0199958e4fe9993071db93d511b6ab223c0cb468851f472ab927f7a46f4c2b9d4ce15bb6649a01e64641a1551d05eb6385c
+  metadata.gz: c0ea2899794381c9e1c16b3ad10667aa5798aec73130e8abf6c5688829473de58facfbf15c68db5fb89509fa9d0a855a5828c044b2e4b501d465ef9f43300ad5
+  data.tar.gz: 7d0a59b4772578f7a2338df73de0c534020234e93ea620f48271328e5feaf7a8d7fada08ac9688ca8fe4c62c4bdf300f4689561e7108213b558346e8b9abc279

data/lib/database_consistency.rb

@@ -33,11 +33,17 @@ require 'database_consistency/checkers/validator_checkers/missing_unique_index_c
 require 'database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker'
 require 'database_consistency/checkers/validators_fraction_checkers/column_presence_checker'
 
+require 'database_consistency/checkers/index_checkers/index_checker'
+require 'database_consistency/checkers/index_checkers/unique_index_checker'
+require 'database_consistency/checkers/index_checkers/redundant_index_checker'
+require 'database_consistency/checkers/index_checkers/redundant_unique_index_checker'
+
 require 'database_consistency/processors/base_processor'
 require 'database_consistency/processors/associations_processor'
 require 'database_consistency/processors/validators_processor'
 require 'database_consistency/processors/columns_processor'
 require 'database_consistency/processors/validators_fractions_processor'
+require 'database_consistency/processors/indexes_processor'
 
 # The root module
 module DatabaseConsistency

data/lib/database_consistency/checkers/index_checkers/index_checker.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # The base class for table checkers
+    class IndexChecker < BaseChecker
+      attr_reader :model, :index
+
+      def initialize(model, index)
+        @model = model
+        @index = index
+      end
+
+      def column_or_attribute_name
+        @column_or_attribute_name ||= index.name.to_s
+      end
+
+      def table_or_model_name
+        @table_or_model_name ||= model.name.to_s
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/index_checkers/redundant_index_checker.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks redundant database indexes
+    class RedundantIndexChecker < IndexChecker
+      # Message templates
+      REDUNDANT_INDEX = 'index is redundant as (%index) covers it'
+
+      private
+
+      # We skip check when:
+      #  - index is unique
+      def preconditions
+        !index.unique
+      end
+
+      # Table of possible statuses
+      # | validation | status |
+      # | ---------- | ------ |
+      # | provided   | ok     |
+      # | redundant  | fail   |
+      #
+      def check
+        if covered_by_index
+          report_template(:fail, render_message)
+        else
+          report_template(:ok)
+        end
+      end
+
+      def render_message
+        REDUNDANT_INDEX.sub('%index', covered_by_index.name)
+      end
+
+      def covered_by_index
+        @covered_by_index ||=
+          model.connection.indexes(model.table_name).find do |another_index|
+            next if index.name == another_index.name
+
+            clause_equals?(another_index) && include_index_as_prefix?(another_index)
+          end
+      end
+
+      def clause_equals?(another_index)
+        another_index.where == index.where
+      end
+
+      def include_index_as_prefix?(another_index)
+        another_index_columns = Helper.extract_index_columns(another_index.columns)
+        index_columns == another_index_columns.first(index_columns.size)
+      end
+
+      def index_columns
+        @index_columns ||= Helper.extract_index_columns(index.columns)
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks redundant database indexes
+    class RedundantUniqueIndexChecker < IndexChecker
+      # Message templates
+      REDUNDANT_UNIQUE_INDEX = 'index uniqueness is redundant as (%index) covers it'
+
+      private
+
+      # We skip check when:
+      #  - index is not unique
+      def preconditions
+        index.unique
+      end
+
+      # Table of possible statuses
+      # | validation | status |
+      # | ---------- | ------ |
+      # | provided   | ok     |
+      # | redundant  | fail   |
+      #
+      def check
+        if covered_by_index
+          report_template(:fail, render_message)
+        else
+          report_template(:ok)
+        end
+      end
+
+      def render_message
+        REDUNDANT_UNIQUE_INDEX.sub('%index', covered_by_index.name)
+      end
+
+      def covered_by_index
+        @covered_by_index ||=
+          model.connection.indexes(model.table_name).find do |another_index|
+            next if index.name == another_index.name
+
+            another_index.unique && clause_equals?(another_index) && contain_index?(another_index)
+          end
+      end
+
+      def clause_equals?(another_index)
+        another_index.where == index.where
+      end
+
+      def contain_index?(another_index)
+        another_index_columns = Helper.extract_index_columns(another_index.columns)
+        index_columns & another_index_columns == another_index_columns
+      end
+
+      def index_columns
+        @index_columns ||= Helper.extract_index_columns(index.columns)
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/index_checkers/unique_index_checker.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks missing uniqueness validator
+    class UniqueIndexChecker < IndexChecker
+      # Message templates
+      VALIDATOR_MISSING = 'index is unique in the database but do not have uniqueness validator'
+
+      private
+
+      # We skip check when:
+      #  - index is not unique
+      def preconditions
+        index.unique
+      end
+
+      # Table of possible statuses
+      # | validation | status |
+      # | ---------- | ------ |
+      # | provided   | ok     |
+      # | missing    | fail   |
+      #
+      def check
+        if valid?
+          report_template(:ok)
+        else
+          report_template(:fail, VALIDATOR_MISSING)
+        end
+      end
+
+      def valid?
+        uniqueness_validators = model.validators.select { |validator| validator.kind == :uniqueness }
+
+        uniqueness_validators.any? do |validator|
+          validator.attributes.any? do |attribute|
+            sorted_index_columns == Helper.sorted_uniqueness_validator_columns(attribute, validator, model)
+          end
+        end
+      end
+
+      def sorted_index_columns
+        @sorted_index_columns ||= Helper.extract_index_columns(index.columns).sort
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
       MISSING_INDEX = 'model should have proper unique index in the database'
 
       def column_or_attribute_name
-        @column_or_attribute_name ||= index_columns.join('+')
+        @column_or_attribute_name ||= Helper.uniqueness_validator_columns(attribute, validator, model).join('+')
       end
 
       private
@@ -33,42 +33,12 @@ module DatabaseConsistency
 
       def unique_index
         @unique_index ||= model.connection.indexes(model.table_name).find do |index|
-          index.unique && extract_index_columns(index.columns).sort == sorted_index_columns
+          index.unique && Helper.extract_index_columns(index.columns).sort == sorted_uniqueness_validator_columns
         end
       end
 
-      # @return [Array<String>]
-      def extract_index_columns(index_columns)
-        return index_columns unless index_columns.is_a?(String)
-
-        index_columns.split(',')
-                     .map(&:strip)
-                     .map { |str| str.gsub(/lower\(/i, 'lower(') }
-                     .map { |str| str.gsub(/\(([^)]+)\)::\w+/, '\1') }
-                     .map { |str| str.gsub(/'([^)]+)'::\w+/, '\1') }
-      end
-
-      def index_columns
-        @index_columns ||= ([wrapped_attribute_name] + scope_columns).map(&:to_s)
-      end
-
-      def scope_columns
-        @scope_columns ||= Array.wrap(validator.options[:scope]).map do |scope_item|
-          model._reflect_on_association(scope_item)&.foreign_key || scope_item
-        end
-      end
-
-      def sorted_index_columns
-        @sorted_index_columns ||= index_columns.sort
-      end
-
-      # @return [String]
-      def wrapped_attribute_name
-        if validator.options[:case_sensitive].nil? || validator.options[:case_sensitive]
-          attribute
-        else
-          "lower(#{attribute})"
-        end
+      def sorted_uniqueness_validator_columns
+        @sorted_uniqueness_validator_columns ||= Helper.sorted_uniqueness_validator_columns(attribute, validator, model)
       end
     end
   end

data/lib/database_consistency/helper.rb

@@ -34,5 +34,39 @@ module DatabaseConsistency
 
       associations
     end
+
+    # @return [Array<String>]
+    def extract_index_columns(index_columns)
+      return index_columns unless index_columns.is_a?(String)
+
+      index_columns.split(',')
+                   .map(&:strip)
+                   .map { |str| str.gsub(/lower\(/i, 'lower(') }
+                   .map { |str| str.gsub(/\(([^)]+)\)::\w+/, '\1') }
+                   .map { |str| str.gsub(/'([^)]+)'::\w+/, '\1') }
+    end
+
+    def sorted_uniqueness_validator_columns(attribute, validator, model)
+      uniqueness_validator_columns(attribute, validator, model).sort
+    end
+
+    def uniqueness_validator_columns(attribute, validator, model)
+      ([wrapped_attribute_name(attribute, validator)] + scope_columns(validator, model)).map(&:to_s)
+    end
+
+    def scope_columns(validator, model)
+      Array.wrap(validator.options[:scope]).map do |scope_item|
+        model._reflect_on_association(scope_item)&.foreign_key || scope_item
+      end
+    end
+
+    # @return [String]
+    def wrapped_attribute_name(attribute, validator)
+      if validator.options[:case_sensitive].nil? || validator.options[:case_sensitive]
+        attribute
+      else
+        "lower(#{attribute})"
+      end
+    end
   end
 end

data/lib/database_consistency/processors/base_processor.rb

@@ -8,7 +8,8 @@ module DatabaseConsistency
         ColumnsProcessor,
         ValidatorsProcessor,
         AssociationsProcessor,
-        ValidatorsFractionsProcessor
+        ValidatorsFractionsProcessor,
+        IndexesProcessor
       ].flat_map do |processor|
         processor.new(configuration).reports
       end

data/lib/database_consistency/processors/indexes_processor.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Processors
+    # The class to process indexes
+    class IndexesProcessor < BaseProcessor
+      CHECKERS = [
+        Checkers::UniqueIndexChecker,
+        Checkers::RedundantIndexChecker,
+        Checkers::RedundantUniqueIndexChecker
+      ].freeze
+
+      private
+
+      def check # rubocop:disable Metrics/AbcSize
+        Helper.parent_models.flat_map do |model|
+          next unless configuration.enabled?(model.name.to_s)
+
+          indexes = ActiveRecord::Base.connection.indexes(model.table_name)
+
+          indexes.flat_map do |index|
+            enabled_checkers.map do |checker_class|
+              checker = checker_class.new(model, index)
+              checker.report_if_enabled?(configuration)
+            end
+          end
+        end.compact
+      end
+    end
+  end
+end

data/lib/database_consistency/templates/rails_defaults.yml

@@ -5,3 +5,5 @@ ActiveStorage::Attachment:
   enabled: false
 ActiveStorage::Blob:
   enabled: false
+ActiveStorage::VariantRecord:
+  enabled: false

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '0.8.11'
+  VERSION = '1.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 0.8.11
+  version: 1.1.1
 platform: ruby
 authors:
 - Evgeniy Demin
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-19 00:00:00.000000000 Z
+date: 2021-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -122,7 +122,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-description:
+description: 
 email:
 - lawliet.djez@gmail.com
 executables:
@@ -140,6 +140,10 @@ files:
 - lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb
 - lib/database_consistency/checkers/column_checkers/null_constraint_checker.rb
 - lib/database_consistency/checkers/column_checkers/primary_key_type_checker.rb
+- lib/database_consistency/checkers/index_checkers/index_checker.rb
+- lib/database_consistency/checkers/index_checkers/redundant_index_checker.rb
+- lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb
+- lib/database_consistency/checkers/index_checkers/unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/belongs_to_presence_checker.rb
 - lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/validator_checker.rb
@@ -154,6 +158,7 @@ files:
 - lib/database_consistency/processors/associations_processor.rb
 - lib/database_consistency/processors/base_processor.rb
 - lib/database_consistency/processors/columns_processor.rb
+- lib/database_consistency/processors/indexes_processor.rb
 - lib/database_consistency/processors/validators_fractions_processor.rb
 - lib/database_consistency/processors/validators_processor.rb
 - lib/database_consistency/rescue_error.rb
@@ -165,7 +170,7 @@ homepage: https://github.com/djezzzl/database_consistency
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -181,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.8
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints
   with the application validations.