database_consistency 0.6.9 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56965231dae6fdb2965490bad30361b322f4305c960504ebbca47c49ed03a7fc
-  data.tar.gz: 5d29b7c7096b799d79cd52848e28d5fda4dd8d0b27ea6391b9ee3851d4287343
+  metadata.gz: 1c53856db0000e888ce0b385047256cd0876cf1fad3e65c2c664ed903eeea876
+  data.tar.gz: 9d3511a92644e1e47fbbbc2a4a35a5bdce4ac4f3a7082fa4219d53a7638c8ec3
 SHA512:
-  metadata.gz: 81a45931d30f3a43e6a84c643861d931fc99bd1f9bebf3d468d0ce44dbb985932bfff2073d96a83acc795a052858f29a6b0b83d940119a1b51a76ff9ed326b3b
-  data.tar.gz: e5941f1c7164476948e0eee87a9a78fc9bbae94062acccfa07514b234000e684caf9f2014a0655646dc24d0ac57de8848b97b3c975c6cccdc8fe1016ea412a42
+  metadata.gz: 86eed4e23e719d58de24cb8f6d641c9b9eb47a405e5a82204fe61a0464b3e6186eff9eab8812fe810fc38c44dd093ac05f3eca2539553ed8f43ada5b3ba72d14
+  data.tar.gz: f1db1582acbcd9a073b4a346dac0d282f2262aeb31f680231fc189a2cdf73de9d63468f700848a392a0fc8927c56da61c3953db348f1edd36869b9f5e8fe0d29

data/lib/database_consistency.rb

@@ -11,15 +11,15 @@ require 'database_consistency/writers/base_writer'
 require 'database_consistency/writers/simple_writer'
 
 require 'database_consistency/checkers/base_checker'
-require 'database_consistency/checkers/association_checker'
-require 'database_consistency/checkers/column_checker'
-require 'database_consistency/checkers/validator_checker'
-
-require 'database_consistency/checkers/column_presence_checker'
-require 'database_consistency/checkers/null_constraint_checker'
-require 'database_consistency/checkers/belongs_to_presence_checker'
-require 'database_consistency/checkers/missing_unique_index_checker'
-require 'database_consistency/checkers/missing_index_checker'
+require 'database_consistency/checkers/association_checkers/association_checker'
+require 'database_consistency/checkers/association_checkers/missing_index_checker'
+require 'database_consistency/checkers/column_checkers/column_checker'
+require 'database_consistency/checkers/column_checkers/null_constraint_checker'
+require 'database_consistency/checkers/column_checkers/length_constraint_checker'
+require 'database_consistency/checkers/validator_checkers/validator_checker'
+require 'database_consistency/checkers/validator_checkers/column_presence_checker'
+require 'database_consistency/checkers/validator_checkers/belongs_to_presence_checker'
+require 'database_consistency/checkers/validator_checkers/missing_unique_index_checker'
 
 require 'database_consistency/processors/base_processor'
 require 'database_consistency/processors/associations_processor'

data/lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks missing presence validator
+    class LengthConstraintChecker < ColumnChecker
+      # Message templates
+      VALIDATOR_MISSING = 'column has limit in the database but do not have length validator'
+      GREATER_LIMIT = 'column has greater limit in the database than in length validator'
+      LOWER_LIMIT = 'column has lower limit in the database than in length validator'
+
+      VALIDATOR_CLASS =
+        if defined?(ActiveRecord::Validations::LengthValidator)
+          ActiveRecord::Validations::LengthValidator
+        else
+          ActiveModel::Validations::LengthValidator
+        end
+
+      private
+
+      # We skip check when:
+      #  - column hasn't limit constraint
+      def preconditions
+        !column.limit.nil?
+      end
+
+      # Table of possible statuses
+      # | validation | status  |
+      # | ---------- | ------- |
+      # | provided   | ok      |
+      # | small      | warning |
+      # | missing    | fail    |
+      def check
+        return report_template(:fail, VALIDATOR_MISSING) unless validator
+
+        if valid?(:==)
+          report_template(:ok)
+        elsif valid?(:<)
+          report_template(:warning, GREATER_LIMIT)
+        else
+          report_template(:fail, LOWER_LIMIT)
+        end
+      end
+
+      def valid?(sign)
+        %i[maximum is].each do |option|
+          return validator.options[option].public_send(sign, column.limit) if validator.options[option]
+        end
+
+        false
+      end
+
+      def validator
+        @validator ||= model.validators.grep(VALIDATOR_CLASS).find do |validator|
+          Helper.check_inclusion?(validator.attributes, column.name)
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/processors/columns_processor.rb

@@ -5,7 +5,8 @@ module DatabaseConsistency
     # The class to process columns
     class ColumnsProcessor < BaseProcessor
       CHECKERS = [
-        Checkers::NullConstraintChecker
+        Checkers::NullConstraintChecker,
+        Checkers::LengthConstraintChecker
       ].freeze
 
       private

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '0.6.9'
+  VERSION = '0.7.0'
 end

data/lib/database_consistency/writers/simple_writer.rb

@@ -35,6 +35,7 @@ module DatabaseConsistency
       def status_text(result)
         color = case result.status
                 when :ok then :green
+                when :warning then :yellow
                 when :fail then :red
                 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 0.6.9
+  version: 0.7.0
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-19 00:00:00.000000000 Z
+date: 2019-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -138,15 +138,16 @@ extra_rdoc_files: []
 files:
 - bin/database_consistency
 - lib/database_consistency.rb
-- lib/database_consistency/checkers/association_checker.rb
+- lib/database_consistency/checkers/association_checkers/association_checker.rb
+- lib/database_consistency/checkers/association_checkers/missing_index_checker.rb
 - lib/database_consistency/checkers/base_checker.rb
-- lib/database_consistency/checkers/belongs_to_presence_checker.rb
-- lib/database_consistency/checkers/column_checker.rb
-- lib/database_consistency/checkers/column_presence_checker.rb
-- lib/database_consistency/checkers/missing_index_checker.rb
-- lib/database_consistency/checkers/missing_unique_index_checker.rb
-- lib/database_consistency/checkers/null_constraint_checker.rb
-- lib/database_consistency/checkers/validator_checker.rb
+- lib/database_consistency/checkers/column_checkers/column_checker.rb
+- lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb
+- lib/database_consistency/checkers/column_checkers/null_constraint_checker.rb
+- lib/database_consistency/checkers/validator_checkers/belongs_to_presence_checker.rb
+- lib/database_consistency/checkers/validator_checkers/column_presence_checker.rb
+- lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb
+- lib/database_consistency/checkers/validator_checkers/validator_checker.rb
 - lib/database_consistency/configuration.rb
 - lib/database_consistency/helper.rb
 - lib/database_consistency/processors/associations_processor.rb