data_sanity 0.1.5 → 0.1.6

data/lib/data_sanity/inspector.rb

@@ -14,12 +14,18 @@ module DataSanity
     end
 
     def investigate
-      @models.each do |model_string|
-        model = model_string.constantize
-        validate_all(model) if @all
-        if @random
-          validate_criteria(model, @criteria[model_string]) and return if @criteria && @criteria[model_string].present?
-          validate_random(model)
+      if @all
+        @models.each do |model_string|
+          model = model_string.constantize
+          validate_all(model) if @all
+        end
+      elsif @criteria
+        @criteria.keys.each do |model|
+          validate_criteria(model.constantize, @criteria[model])
+        end
+      else
+        @models.each do |model_string|
+          validate_random(model_string.constantize)
         end
       end
     end

data/lib/data_sanity/version.rb

@@ -1,3 +1,3 @@
 module DataSanity
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/spec/data_sanity/inspector_spec.rb

@@ -54,19 +54,19 @@ describe "DataSanity::Inspector" do
         DataInspector.first.primary_key_value.should == first_person.id.to_s
         YAML.load(DataInspector.first.validation_errors).should == first_person.errors.full_messages
       end
-      
+
       it "should check for errors on the model and populate fields in DataInspector even if valid? raises exception" do
         inspector = DataSanity::Inspector.new
-        
+
         exception = Exception.new
-        
+
         booming_mock = mock(:person)
         booming_mock.should_receive(:valid?).and_raise(exception)
         Person.should_receive(:all).and_return([booming_mock])
 
         inspector.investigate
         DataInspector.count.should == 1
-        
+
         YAML.load(DataInspector.first.validation_errors).should_not be_blank
       end
     end
@@ -121,8 +121,8 @@ describe "DataSanity::Inspector" do
           Car.new(:name => "Santro", :make => "HHH", :color => "NotAColor", :person => Person.last).save(:validate => false)
 
           inspector.investigate
-          DataInspector.count.should == 3
-          DataInspector.all.collect(&:table_name).should == ["Car", "Person", "Person"]
+          DataInspector.count.should == 2
+          DataInspector.all.collect(&:table_name).should == ["Person", "Person"]
         end
 
         it "should check all distinct values of field for which a criteria exists" do
@@ -144,14 +144,19 @@ describe "DataSanity::Inspector" do
           update_data_sanity_criteria(criteria_car_make)
           inspector = DataSanity::Inspector.new(:validate => "random", :records_per_model => "2")
 
-          5.times { |i| Car.new(:name => "Car Name#{i}", :make => "Brand1").save(:validate => false) }
-          5.times { |i| Car.new(:name => "Car Name#{i}", :make => "Brand2").save(:validate => false) }
+          Car.new(:name => "Car Name1", :make => "Brand1").save(:validate => false)
+          Car.new(:name => "Car Name2", :make => "Brand2").save(:validate => false)
+          Car.new(:name => "Car Name3", :make => "Brand1").save(:validate => false)
+          Car.new(:name => "Car Name4", :make => "Brand2").save(:validate => false)
+          Car.new(:name => "Car Name5", :make => "Brand1").save(:validate => false)
+          Car.new(:name => "Car Name6", :make => "Brand2").save(:validate => false)
+          Car.new(:name => "Car Name7", :make => "Brand3").save(:validate => false)
 
           inspector.investigate
 
-          DataInspector.count.should == 4
-          DataInspector.all.collect(&:table_name).should == ["Car", "Car", "Car", "Car"]
-          Car.find(DataInspector.all.collect(&:primary_key_value)).collect(&:make).should == ["Brand1", "Brand1", "Brand2", "Brand2"]
+          DataInspector.count.should == 5
+          DataInspector.all.collect(&:table_name).uniq.should == ["Car"]
+          Car.find(DataInspector.all.collect(&:primary_key_value)).collect(&:make).sort.should == ["Brand1", "Brand1", "Brand2", "Brand2", "Brand3"]
         end
 
         it "should select minimum of records_per_model and records matching a criteria" do
@@ -166,6 +171,19 @@ describe "DataSanity::Inspector" do
           DataInspector.count.should == 4
         end
 
+        it "should be able to look at multiple criteria" do
+          update_data_sanity_criteria(criteria_multiple)
+          inspector = DataSanity::Inspector.new(:validate => "random", :records_per_model => "1")
+
+          2.times { |i| Car.new(:name => "Car Name#{i}", :make => "Brand1").save(:validate => false) }
+          2.times { Person.new(:name => "Saju").save(:validate => false) }
+
+          inspector.investigate
+
+          DataInspector.count.should == 2
+          DataInspector.all.collect(&:table_name).sort.should == ["Person", "Car"].sort
+        end
+
         after :each do
           cleanup_data_sanity_criteria
         end
@@ -182,4 +200,9 @@ describe "DataSanity::Inspector" do
   make"
   end
 
+  def criteria_multiple
+    "Car:
+Person:"
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: data_sanity
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 1
-  - 5
-  version: 0.1.5
+  - 6
+  version: 0.1.6
 platform: ruby
 authors: 
 - Habibullah, Rahul, Jigyasa, Jyotsna, Hephzibah, Garima
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-04-10 00:00:00 Z
+date: 2012-04-13 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rails