data_sanity 0.0.8 → 0.0.9

data/lib/data_sanity/inspector.rb

@@ -6,7 +6,7 @@ module DataSanity
     attr_accessor :all, :random, :criteria, :models, :records_per_model
 
     def initialize options = {}
-      options[:validate] == :random ? @random = true : @all = true
+      options[:validate] == "random" ? @random = true : @all = true
       @records_per_model = options[:records_per_model] || CONSIDERED_RECORDS
       @models = load_models
       file_path = "#{Rails.root}/config/data_sanity_criteria.yml"

data/lib/data_sanity/tasks.rb

@@ -3,16 +3,14 @@ namespace :data_sanity do
     desc 'Create data inspector model for data sanity results'
     task :migrate => :environment do
       Dir.chdir("#{Rails.root}") do
-        system "rails g migration create_data_inspector"
-        system "rails g migration add_columns_to_data_inspector table_name:string table_primary_key:string primary_key_value:string validation_errors:text"
+        system "rails generate model DataInspector table_name:string table_primary_key:string primary_key_value:string validation_errors:text"
       end
     end
 
     desc 'Destroy data inspector model for data sanity results'
-    task :rollback do
+    task :rollback => :environment do
       Dir.chdir("#{Rails.root}") do
-        system "rails destroy migration add_columns_to_data_inspector"
-        system "rails destroy migration create_data_inspector"
+        system "rails destroy model DataInspector"
       end
     end
   end
@@ -23,4 +21,9 @@ namespace :data_sanity do
       system "cp #{SOURCE_PATH}/data_sanity/templates/data_sanity_criteria.yml #{Rails.root}/config/."
     end
   end
+
+  desc 'Data Sanity run investigation'
+  task :investigate, :validate, :records_per_model do |t, args|
+    DataSanity::Inspector.new(args).investigate
+  end
 end

data/lib/data_sanity/version.rb

@@ -1,3 +1,3 @@
 module DataSanity
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/lib/data_sanity.rb

@@ -4,5 +4,4 @@ SOURCE_PATH = File.dirname(__FILE__)
 
 require SOURCE_PATH + "/data_sanity/inspector"
 require SOURCE_PATH + "/data_sanity/railtie"
-require SOURCE_PATH + "/data_sanity/models/data_inspector"
 require SOURCE_PATH + "/data_sanity/version"

data/spec/data_sanity/inspector_spec.rb

@@ -11,14 +11,14 @@ describe "DataSanity::Inspector" do
     end
 
     it "should set random switch, populate default records_per_model and populate all models of the applications" do
-      inspector = DataSanity::Inspector.new :validate => :random
+      inspector = DataSanity::Inspector.new :validate => "random"
       inspector.random.should be_true
       inspector.records_per_model.should == 1
       inspector.models.should == ["Car", "Person"]
     end
 
     it "should set random switch, populate records_per_model and populate all models of the applications" do
-      inspector = DataSanity::Inspector.new :validate => :random, :records_per_model => 5
+      inspector = DataSanity::Inspector.new :validate => "random", :records_per_model => 5
       inspector.random.should be_true
       inspector.records_per_model.should == 5
       inspector.models.should == ["Car", "Person"]
@@ -58,13 +58,13 @@ describe "DataSanity::Inspector" do
 
     describe "random" do
       it "should check for models with no data" do
-        inspector = DataSanity::Inspector.new :validate => :random
+        inspector = DataSanity::Inspector.new :validate => "random"
         inspector.investigate
         DataInspector.count.should == 0
       end
 
       it "should check for errors on the model and populate fields in DataInspector" do
-        inspector = DataSanity::Inspector.new(:validate => :random, :records_per_model => 2)
+        inspector = DataSanity::Inspector.new(:validate => "random", :records_per_model => 2)
 
         Person.new(:name => "InValid-Record").save(:validate => false)
         Person.new(:name => "UnderAge", :age => 1).save(:validate => false)
@@ -81,13 +81,13 @@ describe "DataSanity::Inspector" do
         end
 
         it "should check for models with no data" do
-          inspector = DataSanity::Inspector.new :validate => :random
+          inspector = DataSanity::Inspector.new :validate => "random"
           inspector.investigate
           DataInspector.count.should == 0
         end
 
         it "should check for errors on model based on criteria picked from data_sanity_criteria.yml" do
-          inspector = DataSanity::Inspector.new(:validate => :random)
+          inspector = DataSanity::Inspector.new(:validate => "random")
 
           2.times { Person.new(:name => "Raju").save(:validate => false) }
           2.times { Person.new(:name => "Saju").save(:validate => false) }
@@ -103,7 +103,7 @@ describe "DataSanity::Inspector" do
 
         it "should check all distinct values of field for which a criteria exists" do
           update_data_sanity_criteria("Car:\n  make")
-          inspector = DataSanity::Inspector.new(:validate => :random)
+          inspector = DataSanity::Inspector.new(:validate => "random")
 
           5.times { |i| Car.new(:name => "Car Name#{i}", :make => "Brand1").save(:validate => false) }
           5.times { |i| Car.new(:name => "Car Name#{i}", :make => "Brand2").save(:validate => false) }

data/spec/support/sample_app/Gemfile

@@ -1,5 +1,6 @@
 source 'http://rubygems.org'
 
 gem 'rails', '3.0.6'
+gem 'rake', '0.8.7'
 gem 'sqlite3'
 gem 'data_sanity', :path => "~/data_sanity"

data/spec/support/sample_app/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
 
-ActiveRecord::Schema.define(:version => 20111205065701) do
+ActiveRecord::Schema.define(:version => 20111205042538) do
 
   create_table "cars", :force => true do |t|
     t.string   "name"
@@ -21,15 +21,6 @@ ActiveRecord::Schema.define(:version => 20111205065701) do
     t.datetime "updated_at"
   end
 
-  create_table "data_inspectors", :force => true do |t|
-    t.string   "table_name"
-    t.string   "table_primary_key"
-    t.string   "primary_key_value"
-    t.text     "validation_errors"
-    t.datetime "created_at"
-    t.datetime "updated_at"
-  end
-
   create_table "people", :force => true do |t|
     t.string   "name"
     t.integer  "age"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: data_sanity
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 0
-  - 8
-  version: 0.0.8
+  - 9
+  version: 0.0.9
 platform: ruby
 authors: 
 - Habibullah, Rahul, Jigyasa, Jyotsna, Hephzibah, Garima
@@ -95,13 +95,11 @@ files:
 - data_sanity.gemspec
 - lib/data_sanity.rb
 - lib/data_sanity/inspector.rb
-- lib/data_sanity/models/data_inspector.rb
 - lib/data_sanity/railtie.rb
 - lib/data_sanity/tasks.rb
 - lib/data_sanity/templates/data_sanity_criteria.yml
 - lib/data_sanity/version.rb
 - spec/data_sanity/inspector_spec.rb
-- spec/data_sanity/models/data_inspector_spec.rb
 - spec/spec_helper.rb
 - spec/support/helper.rb
 - spec/support/sample_app/.gitignore
@@ -186,7 +184,6 @@ specification_version: 3
 summary: Gem for checking data sanity
 test_files: 
 - spec/data_sanity/inspector_spec.rb
-- spec/data_sanity/models/data_inspector_spec.rb
 - spec/spec_helper.rb
 - spec/support/helper.rb
 - spec/support/sample_app/.gitignore

data/lib/data_sanity/models/data_inspector.rb

@@ -1,4 +0,0 @@
-require 'active_record'
-
-class DataInspector < ActiveRecord::Base
-end

data/spec/data_sanity/models/data_inspector_spec.rb

@@ -1,6 +0,0 @@
-require 'spec_helper'
-
-
-describe "DataInspector" do
-
-end