data_sanity 0.0.7 → 0.0.8

data/lib/data_sanity/inspector.rb

@@ -10,7 +10,7 @@ module DataSanity
       @records_per_model = options[:records_per_model] || CONSIDERED_RECORDS
       @models = load_models
       file_path = "#{Rails.root}/config/data_sanity_criteria.yml"
-      @criteria = File.exists?(file_path) ? (YAML.load File.open(file_path).read) : false
+      @criteria = (File.exists?(file_path) ? (YAML.load File.open(file_path).read) : false) rescue false
     end
 
     def investigate
@@ -43,6 +43,7 @@ module DataSanity
 
     def validate_criteria(model, criteria)
       criteria.each do |attribute, values|
+        values = (model.select("DISTINCT(#{attribute})").collect(&attribute.to_sym)) if values.blank?
         values.each do |value|
           results = model.where(attribute.to_sym => value)
           count = results.count

data/lib/data_sanity/tasks.rb

@@ -18,9 +18,9 @@ namespace :data_sanity do
   end
 
   desc 'Creating a sample criteria file'
-  task :citeria do
+  task :criteria do
     Dir.chdir("#{Rails.root}") do
-      system "cp #{File.open('./templates/data_sanity_criteria.yml').read} config/."
+      system "cp #{SOURCE_PATH}/data_sanity/templates/data_sanity_criteria.yml #{Rails.root}/config/."
     end
   end
 end

data/lib/data_sanity/templates/data_sanity_criteria.yml

@@ -2,9 +2,6 @@
 # This is a sample criteria.
 # Start with Model Name and
 #<Model Name>:    # Criteria-Rule to be applied
-#  <field name>:  # Anthing mentioned is considered for validations against mentioned below distinct values
-#    - 'Raju'     # Various values field can take
-#    - 'Saju'
-#    - 'Taju'
-#  <age>          # Anthing mentioned is considered for validations against all possible distinct values
+#  <field name>: ['Raju', 'kaju', 'Taju']  # Field is considered for validations against distinct values in array
+#  <age>                                   # Field is considered for validations against all possible distinct values
 ############################################

data/lib/data_sanity/version.rb

@@ -1,3 +1,3 @@
 module DataSanity
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/lib/data_sanity.rb

@@ -1,6 +1,8 @@
 require "rails"
 
-require File.dirname(__FILE__) + "/data_sanity/inspector"
-require File.dirname(__FILE__) + "/data_sanity/railtie"
-require File.dirname(__FILE__) + "/data_sanity/models/data_inspector"
-require File.dirname(__FILE__) + "/data_sanity/version"
+SOURCE_PATH = File.dirname(__FILE__)
+
+require SOURCE_PATH + "/data_sanity/inspector"
+require SOURCE_PATH + "/data_sanity/railtie"
+require SOURCE_PATH + "/data_sanity/models/data_inspector"
+require SOURCE_PATH + "/data_sanity/version"

data/spec/data_sanity/inspector_spec.rb

@@ -93,13 +93,29 @@ describe "DataSanity::Inspector" do
           2.times { Person.new(:name => "Saju").save(:validate => false) }
           2.times { Car.new(:name => "Santro").save(:validate => false) }
           Person.new(:age => 20).save(:validate => false)
-          car = Car.new(:name => "800", :make => "Maruti", :color => "Black", :person => Person.first).save(:validate => false)
+          Car.new(:name => "800", :make => "Maruti", :color => "Black", :person => Person.first).save(:validate => false)
+          Car.new(:name => "Santro", :make => "HHH", :color => "NotAColor", :person => Person.last).save(:validate => false)
 
           inspector.investigate
           DataInspector.count.should == 3
           DataInspector.all.collect(&:table_name).should == ["Car", "Person", "Person"]
         end
 
+        it "should check all distinct values of field for which a criteria exists" do
+          update_data_sanity_criteria("Car:\n  make")
+          inspector = DataSanity::Inspector.new(:validate => :random)
+
+          5.times { |i| Car.new(:name => "Car Name#{i}", :make => "Brand1").save(:validate => false) }
+          5.times { |i| Car.new(:name => "Car Name#{i}", :make => "Brand2").save(:validate => false) }
+
+          inspector.investigate
+
+          DataInspector.count.should == 2
+          DataInspector.all.collect(&:table_name).should == ["Car", "Car"]
+          Car.find(DataInspector.first.primary_key_value).make.should == "Brand1"
+          Car.find(DataInspector.last.primary_key_value).make.should == "Brand2"
+        end
+
         after :each do
           cleanup_data_sanity_criteria
         end

data/spec/data_sanity/models/data_inspector_spec.rb

@@ -3,5 +3,4 @@ require 'spec_helper'
 
 describe "DataInspector" do
 
-
 end

data/spec/support/helper.rb

@@ -28,6 +28,14 @@ def setup_data_sanity_criteria
   end
 end
 
+def update_data_sanity_criteria(criteria)
+  Dir.chdir("#{Rails.root}") do
+    file = File.open("config/data_sanity_criteria.yml", "w")
+    file << criteria
+    file.close
+  end
+end
+
 def cleanup_data_sanity_criteria
   Dir.chdir("#{Rails.root}") do
     system "rm config/data_sanity_criteria.yml"

data/spec/support/sample_app/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
 
-ActiveRecord::Schema.define(:version => 20111205042922) do
+ActiveRecord::Schema.define(:version => 20111205065701) do
 
   create_table "cars", :force => true do |t|
     t.string   "name"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: data_sanity
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 15
   prerelease: 
   segments: 
   - 0
   - 0
-  - 7
-  version: 0.0.7
+  - 8
+  version: 0.0.8
 platform: ruby
 authors: 
 - Habibullah, Rahul, Jigyasa, Jyotsna, Hephzibah, Garima