data_porter 2.8.0 → 2.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31999033cc55a873fc7eb19520cd1e4a970accea6ee00f1c137b3f17c64f23d9
-  data.tar.gz: f23524c9154af04b4c02ad6196a4fd036a5dc1e5c8f788c7807d1383e1462f9b
+  metadata.gz: a04398e443f704b747eff3f3b585e05f839cabd2f92ecf7871874811a079f15c
+  data.tar.gz: ade55b5a550d628acaf5f8d0e8cc0652fabcb2c7505b59bd14367e7ab56557cf
 SHA512:
-  metadata.gz: 28faa4317369a57e1fca2999a54232a2404ae25034d90d2bdc42ad1b7dd4f090397f98e4c9643c0e5e5029c41d9dcaf37d3003068bf454b56b3fea1b837c7a98
-  data.tar.gz: dada848b7498e58080cff0a1147a5b345eb996feb0c0eb7f715c611283767c782afa66899115da8436592aa9588a3cfb1541403e07ad2446b792cc8850a8cd5e
+  metadata.gz: 9647861c80be730b057a74854c91569bbc2e6e7d922cff5bffd28d7d4268f2a55e83bc08247b4ea93b2c9991e1ac2da1da3f4e71970b71225d9c08e5440ca7d6
+  data.tar.gz: b96e83067441054e1a0140c7b826043984d7fcc0d6c7b7f7ee7fe2a09d416365670a7bce7ed1eeb703d6949ee9dd24d7c791b06978d12d8c52929fa17b4553c6

data/CHANGELOG.md

@@ -7,6 +7,29 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.9.1] - 2026-03-11
+
+### Changed
+
+- **Record data keys normalized to strings** -- `record.data` now uses `HashWithIndifferentAccess`, so both `record.data["key"]` and `record.data[:key]` work consistently. Sources, RecordBuilder, ColumnTransformer, and RecordValidator all produce string keys. No breaking change for existing Targets
+- **Delete on mapping and preview** -- Imports in `mapping` and `previewing` status now show a Delete button with confirmation. Previously only `completed` and `failed` imports could be deleted. The preview Cancel button (which set status to `failed` without deleting) is replaced by Delete
+
+## [2.9.0] - 2026-03-11
+
+### Added
+
+- **`header_row` DSL** -- Skip leading description/metadata rows in CSV and XLSX files. Declare `header_row 2` in Target DSL to treat the 3rd row (0-indexed) as headers. Also configurable at runtime via `config["header_row"]` on individual imports
+- **Long text cell handling** -- Preview table cells with long content are truncated with ellipsis and show full text on hover via `title` tooltip. Inline edit switches to `<textarea>` for values over 50 characters with auto-height resize. Ctrl+Enter to save in textarea mode
+
+### Fixed
+
+- **Dry run persistence** -- Dry run now wraps `persist` in a rolled-back `ActiveRecord::Base.transaction` instead of calling persist without rollback, which was creating real records
+- **Rack 3 params compatibility** -- `permitted_column_mapping` in `MappingManagement` now handles `Rack::QueryParser::Params` via duck-typing instead of `params.require().permit!`
+- **Trailing blank headers** -- `fallback_headers` strips trailing empty columns from CSV/XLSX header rows that caused phantom mapping slots in the UI
+- **Empty data rows** -- CSV and XLSX `fetch` methods now filter out rows where all values are blank, preventing hundreds of false "incomplete" records
+- **Turbo form compatibility** -- Mapping form renders with `data-turbo="false"` to prevent Turbo Drive from intercepting multipart form submissions in host apps
+- **POST route aliases** -- `update_mapping` and `update_record` now accept both POST and PATCH to work around Turbo/UJS method override issues
+
 ## [2.8.0] - 2026-03-08
 
 ### Added

data/app/assets/javascripts/data_porter/inline_edit_controller.js

@@ -13,8 +13,9 @@ export default class extends Controller {
     cell.textContent = ""
     cell.classList.add("dp-cell--editing")
 
-    var input = document.createElement("input")
-    input.type = "text"
+    var isLong = value.length > 50
+    var input = document.createElement(isLong ? "textarea" : "input")
+    if (!isLong) input.type = "text"
     input.className = "dp-inline-input"
     input.value = value
     input.dataset.lineNumber = cell.dataset.lineNumber
@@ -22,18 +23,22 @@ export default class extends Controller {
 
     var self = this
     input._blurHandler = function(e) { self.save(e) }
-    input._keyHandler = function(e) { self.handleKey(e) }
+    input._keyHandler = function(e) { self.handleKey(e, isLong) }
     input.addEventListener("blur", input._blurHandler)
     input.addEventListener("keydown", input._keyHandler)
     cell.appendChild(input)
     this.autoSize(input)
-    input.addEventListener("input", function() { self.autoSize(input) })
+    if (isLong) this.autoHeight(input)
+    input.addEventListener("input", function() {
+      self.autoSize(input)
+      if (isLong) self.autoHeight(input)
+    })
     input.focus()
     input.select()
   }
 
-  handleKey(event) {
-    if (event.key === "Enter") {
+  handleKey(event, isTextarea) {
+    if (event.key === "Enter" && (!isTextarea || event.ctrlKey || event.metaKey)) {
       event.preventDefault()
       event.target.blur()
     } else if (event.key === "Escape") {
@@ -176,6 +181,11 @@ export default class extends Controller {
     document.body.removeChild(span)
   }
 
+  autoHeight(textarea) {
+    textarea.style.height = "auto"
+    textarea.style.height = textarea.scrollHeight + "px"
+  }
+
   moveToNext(currentCell, reverse) {
     var cells = Array.from(this.cellTargets)
     var index = cells.indexOf(currentCell)

data/app/assets/stylesheets/data_porter/inline_edit.css

@@ -52,6 +52,14 @@
   z-index: 10;
 }
 
+textarea.dp-inline-input {
+  resize: none;
+  overflow: hidden;
+  min-height: 2.5rem;
+  white-space: pre-wrap;
+  word-break: break-word;
+}
+
 .dp-inline-input:focus {
   box-shadow: 0 0 0 3px rgba(79, 70, 229, 0.15);
 }

data/app/assets/stylesheets/data_porter/table.css

@@ -30,6 +30,16 @@
   font-size: 0.875rem;
   color: var(--dp-gray-700);
   border-bottom: 1px solid var(--dp-gray-100);
+  max-width: 15rem;
+  overflow: hidden;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+}
+
+.dp-table td.dp-cell--editing {
+  max-width: none;
+  overflow: visible;
+  white-space: normal;
 }
 
 .dp-table tbody tr:last-child td {

data/app/controllers/data_porter/concerns/mapping_management.rb

@@ -69,7 +69,9 @@ module DataPorter
       end
 
       def permitted_column_mapping
-        raw = params.require(:column_mapping).permit!.to_h
+        raw = params[:column_mapping]
+        raw = raw.to_unsafe_h if raw.respond_to?(:to_unsafe_h)
+        raw = raw.to_h unless raw.is_a?(Hash)
         valid_names = valid_column_names
         raw.transform_values { |v| valid_names.include?(v) ? v : "" }
       end

data/app/views/data_porter/imports/show.html.erb

@@ -42,6 +42,11 @@
           templates: @templates,
           default_mapping: @default_mapping
         ).call %>
+    <div class="dp-actions">
+      <%= button_to t("data_porter.imports.delete"), import_path(@import),
+            method: :delete, class: "dp-btn dp-btn--danger",
+            data: { turbo_confirm: t("data_porter.imports.delete_confirm") } %>
+    </div>
   <% end %>
 
   <% if @import.previewing? %>
@@ -71,8 +76,9 @@
         <%= button_to t("data_porter.imports.back_to_mapping"), back_to_mapping_import_path(@import),
               method: :post, class: "dp-btn dp-btn--secondary" %>
       <% end %>
-      <%= button_to t("data_porter.imports.cancel"), cancel_import_path(@import),
-            method: :post, class: "dp-btn dp-btn--danger" %>
+      <%= button_to t("data_porter.imports.delete"), import_path(@import),
+            method: :delete, class: "dp-btn dp-btn--danger",
+            data: { turbo_confirm: t("data_porter.imports.delete_confirm") } %>
     </div>
   <% end %>
 

data/config/routes.rb

@@ -11,7 +11,9 @@ DataPorter::Engine.routes.draw do
       post :back_to_mapping
       post :dry_run
       post :resume
+      post :update_mapping
       patch :update_mapping
+      post :update_record
       patch :update_record
       get :status
       get :export_rejects

data/lib/data_porter/column_transformer.rb

@@ -41,10 +41,8 @@ module DataPorter
     end
 
     def self.resolve_key(data, name)
-      return name.to_s if data.key?(name.to_s)
-      return name if data.key?(name)
-
-      nil
+      key = name.to_s
+      key if data.key?(key)
     end
 
     def self.custom_transformers

data/lib/data_porter/components/mapping/form.rb

@@ -22,6 +22,7 @@ module DataPorter
             action: @action_url,
             method: "post",
             class: "dp-mapping-form",
+            data_turbo: "false",
             data_controller: "data-porter--mapping",
             data_data_porter__mapping_required_columns_value: required_columns_json
           ) { render_form_body }

data/lib/data_porter/components/preview/table.rb

@@ -62,7 +62,9 @@ module DataPorter
 
         def render_cell(record, col)
           value = cell_value(record, col)
-          td(**cell_attrs(record, col, value)) { value }
+          attrs = cell_attrs(record, col, value)
+          attrs[:title] = value if value.length > 30
+          td(**attrs) { value }
         end
 
         def render_errors_cell(record)
@@ -70,7 +72,7 @@ module DataPorter
         end
 
         def cell_value(record, col)
-          (record.data[col.name.to_s] || record.data[col.name]).to_s
+          record.data[col.name.to_s].to_s
         end
 
         def row_attrs(record)

data/lib/data_porter/orchestrator/dry_runner.rb

@@ -19,8 +19,13 @@ module DataPorter
       end
 
       def dry_run_record(record, context)
-        @target.persist(record, context: context)
-        record.dry_run_passed = true
+        ActiveRecord::Base.transaction do
+          @target.persist(record, context: context)
+          record.dry_run_passed = true
+          raise ActiveRecord::Rollback
+        end
+      rescue ActiveRecord::Rollback
+        nil
       rescue StandardError => e
         record.dry_run_passed = false
         record.add_error(e.message)

data/lib/data_porter/orchestrator/record_builder.rb

@@ -40,7 +40,7 @@ module DataPorter
 
       def extract_data(row, columns)
         columns.each_with_object({}) do |col, hash|
-          hash[col.name] = row[col.name] || row[col.name.to_s]
+          hash[col.name.to_s] = row[col.name.to_s] || row[col.name]
         end
       end
     end

data/lib/data_porter/record_revalidator.rb

@@ -24,9 +24,10 @@ module DataPorter
     def normalize_keys(record)
       @columns.each do |col|
         string_key = col.name.to_s
-        next unless record.data.key?(string_key) && !record.data.key?(col.name)
+        next if record.data.key?(string_key)
+        next unless record.data.key?(col.name)
 
-        record.data[col.name] = record.data.delete(string_key)
+        record.data[string_key] = record.data.delete(col.name)
       end
     end
   end

data/lib/data_porter/record_updater.rb

@@ -32,10 +32,7 @@ module DataPorter
       record.data[key] = value
     end
 
-    def resolve_key(data, column)
-      return column.to_sym if data.key?(column.to_sym)
-      return column.to_s if data.key?(column.to_s)
-
+    def resolve_key(_data, column)
       column.to_s
     end
 

data/lib/data_porter/record_validator.rb

@@ -8,7 +8,7 @@ module DataPorter
 
     def validate(record)
       @columns.each do |col|
-        value = record.data[col.name]
+        value = record.data[col.name.to_s]
         validate_required(record, col, value)
         validate_type(record, col, value)
       end

data/lib/data_porter/sources/api.rb

@@ -13,7 +13,7 @@ module DataPorter
         records = extract_records(parsed, api)
 
         Array(records).map do |hash|
-          hash.transform_keys { |k| k.parameterize(separator: "_").to_sym }
+          hash.transform_keys { |k| k.parameterize(separator: "_") }
         end
       end
 

data/lib/data_porter/sources/base.rb

@@ -32,24 +32,31 @@ module DataPorter
 
       def user_map(row)
         user_mapping.each_with_object({}) do |(header, column), hash|
-          hash[column.to_sym] = row[header]
+          hash[column.to_s] = row[header]
         end
       end
 
       def explicit_map(row, mappings)
         mappings.each_with_object({}) do |(header, column), hash|
-          hash[column] = row[header]
+          hash[column.to_s] = row[header]
         end
       end
 
       def auto_map(row)
-        row.to_h.transform_keys { |k| k.parameterize(separator: "_").to_sym }
+        row.to_h.transform_keys { |k| k.parameterize(separator: "_") }
+      end
+
+      def header_row_index
+        config = @data_import.config
+        from_config = config["header_row"] if config.is_a?(Hash)
+        from_config&.to_i || @target_class._header_row || 0
       end
 
       def fallback_headers(raw_headers)
-        return raw_headers if raw_headers.any?(&:present?)
+        stripped = raw_headers.reverse.drop_while(&:blank?).reverse
+        return stripped if stripped.any?(&:present?)
 
-        raw_headers.each_with_index.map { |_, i| "col_#{i + 1}" }
+        stripped.each_with_index.map { |_, i| "col_#{i + 1}" }
       end
     end
   end

data/lib/data_porter/sources/csv.rb

@@ -13,14 +13,16 @@ module DataPorter
       end
 
       def headers
-        first_line = csv_content.lines.first
-        raw = ::CSV.parse_line(first_line, **extra_options).map(&:to_s)
+        line = csv_content.lines[header_row_index]
+        raw = ::CSV.parse_line(line, **extra_options).map(&:to_s)
         fallback_headers(raw)
       end
 
       def fetch
         rows = []
-        ::CSV.parse(csv_content, **csv_options) do |row|
+        ::CSV.parse(effective_csv_content, **csv_options) do |row|
+          next if row.to_h.values.all? { |v| v.to_s.strip.empty? }
+
           rows << apply_csv_mapping(row)
         end
         rows
@@ -32,6 +34,13 @@ module DataPorter
         @csv_content ||= ensure_utf8(@content || download_file)
       end
 
+      def effective_csv_content
+        offset = header_row_index
+        return csv_content if offset.zero?
+
+        csv_content.lines.drop(offset).join
+      end
+
       def download_file
         @data_import.file.download
       end
@@ -67,8 +76,8 @@ module DataPorter
       end
 
       def detect_separator
-        first_line = csv_content.lines.first.to_s
-        SEPARATORS.max_by { |sep| first_line.count(sep) }
+        header_line = csv_content.lines[header_row_index].to_s
+        SEPARATORS.max_by { |sep| header_line.count(sep) }
       end
     end
   end

data/lib/data_porter/sources/json.rb

@@ -15,7 +15,7 @@ module DataPorter
         records = extract_records(parsed)
 
         Array(records).map do |hash|
-          hash.transform_keys { |k| k.parameterize(separator: "_").to_sym }
+          hash.transform_keys { |k| k.parameterize(separator: "_") }
         end
       end
 

data/lib/data_porter/sources/xlsx.rb

@@ -13,8 +13,8 @@ module DataPorter
 
       def headers
         sheet = target_sheet
-        first_row = sheet.simple_rows.first
-        raw = first_row&.values&.map(&:to_s) || []
+        header = sheet.simple_rows.drop(header_row_index).first
+        raw = header&.values&.map(&:to_s) || []
         fallback_headers(raw)
       ensure
         cleanup
@@ -36,10 +36,21 @@ module DataPorter
 
       def parse_sheet(sheet)
         rows = sheet.simple_rows.to_a
-        return [] if rows.size <= 1
+        offset = header_row_index
+        return [] if rows.size <= offset + 1
 
-        headers = rows.first.values.map(&:to_s)
-        rows.drop(1).map { |row| build_row(headers, row) }
+        headers = extract_headers(rows, offset)
+        extract_data_rows(rows, offset, headers)
+      end
+
+      def extract_headers(rows, offset)
+        rows[offset].values.map(&:to_s)
+      end
+
+      def extract_data_rows(rows, offset, headers)
+        rows.drop(offset + 1)
+            .reject { |row| row.values.all? { |v| v.to_s.strip.empty? } }
+            .map { |row| build_row(headers, row) }
       end
 
       def build_row(headers, row)

data/lib/data_porter/store_models/import_record.rb

@@ -10,8 +10,12 @@ module DataPorter
 
       attribute :line_number, :integer
       attribute :status, :string, default: "pending"
-      attribute :data, default: -> { {} }
+      attribute :data, default: -> { HashWithIndifferentAccess.new }
       attribute :errors_list, Error.to_array_type, default: -> { [] }
+
+      def data=(value)
+        super(value.is_a?(Hash) ? value.with_indifferent_access : value)
+      end
       attribute :warnings, Error.to_array_type, default: -> { [] }
       attribute :target_id, :integer
       attribute :dry_run_passed, :boolean, default: false
@@ -29,7 +33,7 @@ module DataPorter
       end
 
       def attributes
-        data.symbolize_keys.compact
+        data.stringify_keys.compact.with_indifferent_access
       end
 
       def determine_status!

data/lib/data_porter/target.rb

@@ -11,7 +11,7 @@ module DataPorter
       attr_reader :_label, :_model_name, :_icon, :_sources,
                   :_columns, :_csv_mappings, :_dedup_keys, :_json_root,
                   :_api_config, :_dry_run_enabled, :_params, :_webhooks,
-                  :_bulk_config
+                  :_bulk_config, :_header_row
 
       def label(value)
         @_label = value
@@ -65,6 +65,10 @@ module DataPorter
         @_dry_run_enabled = true
       end
 
+      def header_row(value)
+        @_header_row = value.to_i
+      end
+
       def params(&)
         @_params = []
         instance_eval(&)

data/lib/data_porter/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DataPorter
-  VERSION = "2.8.0"
+  VERSION = "2.9.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: data_porter
 version: !ruby/object:Gem::Version
-  version: 2.8.0
+  version: 2.9.1
 platform: ruby
 authors:
 - Seryl Lounis