data_migrater 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d23aa11964d870b88a42f582ada1573f58a781d08a359cc25eea5e2dbf7dab62
-  data.tar.gz: cd3bbe075f0cc3ff091284ef1a00c23c27a8f725989f269cb33eebd2f7c07ebb
+  metadata.gz: f399d2a9cb8f0b2b4308d800542e259b9944d208ff2ed31ecdf8c001dbbc3861
+  data.tar.gz: 75dda4543f8a3eefac6c7158763891f51dbd73585653a0dfaeee89022f691663
 SHA512:
-  metadata.gz: 8fadf53e7bd9f4eaeb709847d5f73b6a53369eca3a93ee766d0192e56195a940122cc330b687ff93a346f8ca550f7eeb150f2b71d0dd757818f4631330ed0d29
-  data.tar.gz: e6beaa0daecc1926844ee50fe15684a673e5710b7bb3e68ae7eefcc31b508e634079a4fc78649953b1ed1e07257a741bada5640e5327b792d556beb5cc5cccff
+  metadata.gz: ec764ed1b0e4804054925a43443fc470f1e14d5698e0979cc3dccd264661e91ce8a77cfbe199c2d8ca9364d98c134445003a2c88121bfe0ff82cfcb77f3cc0f6
+  data.tar.gz: 644d8766d959b196401874fbaa7edfcfc32b3590dd0ebcf11a6a37c51b58ec891202c29c0a27837bb14a54c65d46fcfcea8e3c01565173a9dec8e239d815e48a

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## v1.1.0
+
+### Fixes
+
+- Does not raise error when file does not exist locally;
+- Does not try to delete a non existent file locally.
+
+### Updates
+
+- `csv_delete` now deletes the local file too.
+
 ## v1.0.0
 
 ### Break

data/README.md

@@ -187,7 +187,7 @@ end
 
 ### CSV Delete
 
-You can delete the S3 file from your migration after process the CSV.
+You can delete the S3 and local file from your migration after process the CSV.
 
 ```ruby
 class MyDataMigration

data/lib/data_migrater/csv.rb

@@ -8,7 +8,9 @@ module DataMigrater
 
     included do
       def csv(processor: ::SmarterCSV)
-        s3.download if csv_options.delete(:provider) == :s3
+        s3.download if s3_provider?
+
+        return [] unless File.exist?(csv_path)
 
         processor.process csv_path, csv_options
       end
@@ -20,7 +22,9 @@ module DataMigrater
       end
 
       def csv_delete
-        s3.delete
+        s3.delete if s3_provider?
+
+        File.delete(csv_path) if File.exist?(csv_path)
       end
 
       private
@@ -41,12 +45,16 @@ module DataMigrater
         self.class.csv_options
       end
 
+      def s3
+        @s3 ||= DataMigrater::S3.new(csv_bucket, s3_credentials, csv_path)
+      end
+
       def s3_credentials
         csv_options.delete(:credentials) || {}
       end
 
-      def s3
-        @s3 ||= DataMigrater::S3.new(csv_bucket, s3_credentials, csv_path)
+      def s3_provider?
+        @s3_provider ||= csv_options.delete(:provider) == :s3
       end
     end
 

data/lib/data_migrater/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DataMigrater
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/spec/csv/csv_delete_spec.rb

@@ -3,21 +3,65 @@
 require 'spec_helper'
 
 RSpec.describe '#csv_delete' do
-  let!(:s3) { instance_double 'DataMigrater::S3' }
+  context 'when provider is s3' do
+    let!(:s3) { instance_double 'DataMigrater::S3' }
 
-  before do
-    stub_const 'Dummy', Class.new
+    before do
+      stub_const 'Dummy', Class.new
 
-    Dummy.class_eval { include DataMigrater::CSV }
-    Dummy.class_eval { data_csv provider: :s3 }
+      Dummy.class_eval { include DataMigrater::CSV }
+      Dummy.class_eval { data_csv provider: :s3 }
 
-    allow(DataMigrater::S3).to receive(:new)
-      .with('data-migrater', {}, 'db/data_migrate/support/csv/dummy.csv').and_return s3
+      allow(DataMigrater::S3).to receive(:new)
+        .with('data-migrater', {}, 'db/data_migrate/support/csv/dummy.csv').and_return s3
+    end
+
+    it 'delegates delete to s3 object and deletes the existent file' do
+      allow(File).to receive(:exist?).and_return true
+
+      expect(s3).to receive(:delete)
+
+      expect(File).to receive(:delete).with 'db/data_migrate/support/csv/dummy.csv'
+
+      Dummy.new.csv_delete
+    end
+  end
+
+  context 'when has no provider' do
+    before do
+      stub_const 'Dummy', Class.new
+
+      Dummy.class_eval { include DataMigrater::CSV }
+      Dummy.class_eval { data_csv }
+    end
+
+    it 'does not delegates delete to s3 object' do
+      expect(DataMigrater::S3).not_to receive(:new)
+
+      Dummy.new.csv_delete
+    end
+
+    it 'deletes the existent file' do
+      allow(File).to receive(:exist?).and_return true
+
+      expect(File).to receive(:delete).with 'db/data_migrate/support/csv/dummy.csv'
+
+      Dummy.new.csv_delete
+    end
   end
 
-  it 'delegates delete to s3 object' do
-    expect(s3).to receive(:delete)
+  context 'when local file does not exist' do
+    before do
+      stub_const 'Dummy', Class.new
+
+      Dummy.class_eval { include DataMigrater::CSV }
+      Dummy.class_eval { data_csv dir: 'missing/path' }
+    end
+
+    it 'does not delete the file' do
+      expect(File).not_to receive(:delete)
 
-    Dummy.new.csv_delete
+      Dummy.new.csv_delete
+    end
   end
 end

data/spec/csv/csv_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe '#data_csv' do
-  context 'when path is not about s3' do
+  context 'when has no provider' do
     before do
       stub_const 'Dummy', Class.new
 
@@ -39,6 +39,8 @@ RSpec.describe '#data_csv' do
 
       allow(DataMigrater::S3).to receive(:new)
         .with('data-migrater', {}, 'db/data_migrate/support/csv/dummy.csv').and_return double(download: true)
+
+      allow(File).to receive(:exist?).and_return true
     end
 
     it 'reads csv from s3' do
@@ -47,4 +49,23 @@ RSpec.describe '#data_csv' do
       Dummy.new.csv
     end
   end
+
+  context 'when file does not exist locally' do
+    before do
+      stub_const 'Dummy', Class.new
+
+      Dummy.class_eval { include DataMigrater::CSV }
+      Dummy.class_eval { data_csv dir: 'missing/path' }
+    end
+
+    it 'does not process' do
+      expect(::SmarterCSV).not_to receive(:process)
+
+      Dummy.new.csv
+    end
+
+    it 'returns an empty array' do
+      expect(Dummy.new.csv).to eq []
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: data_migrater
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Washington Botelho
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-23 00:00:00.000000000 Z
+date: 2019-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord