data_migrate 9.1.0 → 9.2.0

data/spec/data_migrate/data_migrator_spec.rb

@@ -3,7 +3,8 @@
 require "spec_helper"
 
 describe DataMigrate::DataMigrator do
-  let(:subject) { DataMigrate::DataMigrator }
+  let(:described_class) { DataMigrate::DataMigrator }
+
   let(:db_config) do
     {
       adapter: "sqlite3",
@@ -13,8 +14,8 @@ describe DataMigrate::DataMigrator do
 
   before do
     ActiveRecord::Base.establish_connection(db_config)
-    ::ActiveRecord::SchemaMigration.create_table
-    DataMigrate::DataSchemaMigration.create_table
+    DataMigrate::RailsHelper.schema_migration.create_table
+    DataMigrate::RailsHelper.data_schema_migration.create_table
   end
 
   after do
@@ -23,12 +24,14 @@ describe DataMigrate::DataMigrator do
   end
 
   describe ".load_migrated" do
+    let(:migrator) { DataMigrate::RailsHelper.data_migrator(:up, []) }
+
     it "loads migrated versions" do
-      DataMigrate::DataSchemaMigration.create(version: 20090000000000)
-      ::ActiveRecord::SchemaMigration.create(version: 20100000000000)
-      DataMigrate::DataSchemaMigration.create(version: 20110000000000)
-      ::ActiveRecord::SchemaMigration.create(version: 20120000000000)
-      migrated = subject.new(:up, []).load_migrated
+      DataMigrate::RailsHelper.data_schema_migration.create_version(20090000000000)
+      DataMigrate::RailsHelper.schema_create_version(20100000000000)
+      DataMigrate::RailsHelper.data_schema_migration.create_version(20110000000000)
+      DataMigrate::RailsHelper.schema_create_version(20120000000000)
+      migrated = migrator.load_migrated
       expect(migrated.count).to eq 2
       expect(migrated).to include 20090000000000
       expect(migrated).to include 20110000000000
@@ -38,7 +41,7 @@ describe DataMigrate::DataMigrator do
   describe :create_data_schema_table do
     it "creates the data_migrations table" do
       ActiveRecord::Migration.drop_table("data_migrations") rescue nil
-      subject.create_data_schema_table
+      described_class.create_data_schema_table
       expect(
         ActiveRecord::Base.connection.table_exists?("data_migrations")
       ).to eq true
@@ -47,7 +50,7 @@ describe DataMigrate::DataMigrator do
 
   describe "#migrations_status" do
     it "returns all migrations statuses" do
-      status = subject.migrations_status
+      status = described_class.migrations_status
       expect(status.length).to eq 2
       expect(status.first).to eq ["down", "20091231235959", "Some name"]
       expect(status.second).to eq ["down", "20171231235959", "Super update"]
@@ -57,19 +60,19 @@ describe DataMigrate::DataMigrator do
   describe :match do
     context "when the file does not match" do
       it "returns nil" do
-        expect(subject.match("not_a_data_migration_file")).to be_nil
+        expect(described_class.match("not_a_data_migration_file")).to be_nil
       end
     end
 
     context "when the file doesn't end in .rb" do
       it "returns nil" do
-        expect(subject.match("20091231235959_some_name.rb.un~")).to be_nil
+        expect(described_class.match("20091231235959_some_name.rb.un~")).to be_nil
       end
     end
 
     context "when the file matches" do
       it "returns a valid MatchData object" do
-        match_data = subject.match("20091231235959_some_name.rb")
+        match_data = described_class.match("20091231235959_some_name.rb")
 
         expect(match_data[0]).to eq "20091231235959_some_name.rb"
         expect(match_data[1]).to eq "20091231235959"

data/spec/data_migrate/data_schema_migration_spec.rb

@@ -1,16 +1,33 @@
 require 'spec_helper'
 
 describe DataMigrate::DataSchemaMigration do
-  let(:subject) { DataMigrate::DataSchemaMigration }
-  describe :table_name do
-    it "returns correct table name" do
-      expect(subject.table_name).to eq("data_migrations")
+  if DataMigrate::RailsHelper.rails_version_equal_to_or_higher_than_7_1
+    let(:connection) { double(:connection) }
+    let(:subject) { DataMigrate::DataSchemaMigration.new(connection) }
+
+    describe :table_name do
+      it "returns correct table name" do
+        expect(subject.table_name).to eq("data_migrations")
+      end
+    end
+
+    describe :index_name do
+      it "returns correct primary key name" do
+        expect(subject.primary_key).to eq("version")
+      end
+    end
+  else
+    let(:subject) { DataMigrate::DataSchemaMigration }
+    describe :table_name do
+      it "returns correct table name" do
+        expect(subject.table_name).to eq("data_migrations")
+      end
     end
-  end
 
-  describe :index_name do
-    it "returns correct primary key name" do
-      expect(subject.primary_key).to eq("version")
+    describe :index_name do
+      it "returns correct primary key name" do
+        expect(subject.primary_key).to eq("version")
+      end
     end
   end
 end

data/spec/data_migrate/data_spec.rb

@@ -55,7 +55,7 @@ describe DataMigrate::Data do
 
         sql_select = <<-SQL
           SELECT version
-          FROM #{DataMigrate::DataSchemaMigration.table_name}
+          FROM #{DataMigrate::RailsHelper.data_schema_migration.table_name}
         SQL
 
         db_list_data = ActiveRecord::Base.connection.

data/spec/data_migrate/database_tasks_spec.rb

@@ -8,12 +8,6 @@ describe DataMigrate::DatabaseTasks do
   let(:data_migrations_path) {
     DataMigrate.config.data_migrations_path
   }
-  let(:db_config) do
-    {
-      adapter: "sqlite3",
-      database: "spec/db/test.db"
-    }
-  end
 
   before do
     # In a normal Rails installation, db_dir would defer to
@@ -27,14 +21,10 @@ describe DataMigrate::DatabaseTasks do
     allow(DataMigrate::Tasks::DataMigrateTasks).to receive(:migrations_paths) {
       data_migrations_path
     }
-    ActiveRecord::Base.establish_connection(db_config)
-    if Gem::Dependency.new("railties", ">= 6.1").match?("railties", Gem.loaded_specs["railties"].version)
-      hash_config = ActiveRecord::DatabaseConfigurations::HashConfig.new('test', 'test', db_config)
-      config_obj = ActiveRecord::DatabaseConfigurations.new([hash_config])
-      allow(ActiveRecord::Base).to receive(:configurations).and_return(config_obj)
-    else
-      ActiveRecord::Base.configurations[:test] = db_config
-    end
+    ActiveRecord::Base.establish_connection({ adapter: "sqlite3", database: "spec/db/test.db" })
+    hash_config = ActiveRecord::DatabaseConfigurations::HashConfig.new('test', 'test', { adapter: "sqlite3", database: "spec/db/test.db" })
+    config_obj = ActiveRecord::DatabaseConfigurations.new([hash_config])
+    allow(ActiveRecord::Base).to receive(:configurations).and_return(config_obj)
   end
 
   context "migrations" do
@@ -44,7 +34,7 @@ describe DataMigrate::DatabaseTasks do
     end
 
     before do
-      ActiveRecord::SchemaMigration.create_table
+      DataMigrate::RailsHelper.schema_migration.create_table
 
       allow(DataMigrate::SchemaMigration).to receive(:migrations_paths) {
         migration_path
@@ -69,22 +59,47 @@ describe DataMigrate::DatabaseTasks do
     end
 
     describe :forward do
-
       it "run forward default amount of times" do
         subject.forward
-        versions = DataMigrate::DataSchemaMigration.normalized_versions
+        versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
         expect(versions.count).to eq(1)
       end
 
       it "run forward defined number of times" do
         subject.forward(2)
-        versions = DataMigrate::DataSchemaMigration.normalized_versions
+        versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
         expect(versions.count).to eq(1)
         expect(versions.first).to eq "20091231235959"
-        versions = ActiveRecord::SchemaMigration.normalized_versions
+        versions = DataMigrate::RailsHelper.schema_migration.normalized_versions
         expect(versions.count).to eq(1)
         expect(versions.first).to eq "20131111111111"
       end
     end
+
+    if DataMigrate::RailsHelper.rails_version_equal_to_or_higher_than_7_0
+      describe :schema_dump_path do
+        before do
+          allow(ActiveRecord::Base).to receive(:configurations).and_return(ActiveRecord::DatabaseConfigurations.new([db_config]))
+        end
+
+        context "for primary database" do
+          let(:db_config) { ActiveRecord::DatabaseConfigurations::HashConfig.new("development", "primary", {} ) }
+
+          context "for :ruby db format" do
+            it 'returns the data schema path' do
+              allow(ActiveRecord).to receive(:schema_format).and_return(:ruby)
+              expect(subject.schema_dump_path(db_config)).to eq("db/data_schema.rb")
+            end
+          end
+
+          context "for :sql db format" do
+            it 'returns the data schema path' do
+              allow(ActiveRecord).to receive(:schema_format).and_return(:sql)
+              expect(subject.schema_dump_path(db_config, :sql)).to eq("db/data_schema.rb")
+            end
+          end
+        end
+      end
+    end
   end
 end

data/spec/data_migrate/migration_context_spec.rb

@@ -5,10 +5,17 @@ require "spec_helper"
 describe DataMigrate::DataMigrator do
   let(:context) { DataMigrate::MigrationContext.new("spec/db/data") }
   let(:schema_context) { ActiveRecord::MigrationContext.new("spec/db/migrate", ActiveRecord::Base.connection.schema_migration) }
+  let(:db_config) do
+    {
+      adapter: "sqlite3",
+      database: "spec/db/test.db"
+    }
+  end
 
   before do
-    ActiveRecord::SchemaMigration.create_table
-    DataMigrate::DataSchemaMigration.create_table
+    ActiveRecord::Base.establish_connection(db_config)
+    DataMigrate::RailsHelper.schema_migration.create_table
+    DataMigrate::RailsHelper.data_schema_migration.create_table
   end
 
   after do
@@ -20,7 +27,7 @@ describe DataMigrate::DataMigrator do
     it "migrates existing file" do
       context.migrate(nil)
       context.migrations_status
-      versions = DataMigrate::DataSchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
       expect(versions.count).to eq(2)
       expect(versions).to include("20091231235959")
       expect(versions).to include("20171231235959")
@@ -29,7 +36,7 @@ describe DataMigrate::DataMigrator do
     it "undo migration" do
       context.migrate(nil)
       context.run(:down, 20171231235959)
-      versions = DataMigrate::DataSchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
       expect(versions.count).to eq(1)
       expect(versions).to include("20091231235959")
     end
@@ -46,7 +53,7 @@ describe DataMigrate::DataMigrator do
 
     it "runs a specific migration" do
       context.run(:up, 20171231235959)
-      versions = DataMigrate::DataSchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
       expect(versions.count).to eq(1)
       expect(versions).to include("20171231235959")
     end
@@ -74,7 +81,7 @@ describe DataMigrate::DataMigrator do
       expect {
         context.rollback
       }.to output(/Undoing SuperUpdate/).to_stdout
-      versions = DataMigrate::DataSchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
       expect(versions.count).to eq(1)
       expect(versions).to include("20091231235959")
     end
@@ -85,7 +92,7 @@ describe DataMigrate::DataMigrator do
       expect {
         context.rollback(2)
       }.to output(/Undoing SomeName/).to_stdout
-      versions = DataMigrate::DataSchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
       expect(versions.count).to eq(0)
     end
 
@@ -94,7 +101,7 @@ describe DataMigrate::DataMigrator do
       expect {
         context.rollback(2)
       }.to output(/Undoing SomeName/).to_stdout
-      versions = DataMigrate::DataSchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.data_schema_migration.normalized_versions
       expect(versions.count).to eq(0)
     end
   end

data/spec/data_migrate/schema_dumper_spec.rb

@@ -9,9 +9,12 @@ describe DataMigrate::SchemaDumper do
   end
 
   before do
-    ActiveRecord::SchemaMigration.create_table
-    DataMigrate::DataSchemaMigration.create_table
-    DataMigrate::DataSchemaMigration.create(fixture_file_timestamps.map { |t| { version: t } })
+    DataMigrate::RailsHelper.schema_migration.create_table
+    DataMigrate::RailsHelper.data_schema_migration.create_table
+
+    fixture_file_timestamps.map do |t|
+      DataMigrate::RailsHelper.data_schema_migration.create_version(t)
+    end
   end
 
   after do

data/spec/data_migrate/schema_migration_spec.rb

@@ -8,10 +8,17 @@ describe DataMigrate::SchemaMigration do
   let(:fixture_file_timestamps) do
     %w[20091231235959 20101231235959 20111231235959]
   end
+  let(:db_config) do
+    {
+      adapter: "sqlite3",
+      database: "spec/db/test.db"
+    }
+  end
 
   before do
-    ActiveRecord::SchemaMigration.create_table
-    DataMigrate::DataSchemaMigration.create_table
+    ActiveRecord::Base.establish_connection(db_config)
+    DataMigrate::RailsHelper.schema_migration.create_table
+    DataMigrate::RailsHelper.data_schema_migration.create_table
   end
 
   after do
@@ -38,7 +45,7 @@ describe DataMigrate::SchemaMigration do
       expect {
         subject.run(:up, migration_path, 20202020202011)
       }.to output(/20202020202011 DbMigration: migrating/).to_stdout
-      versions = ActiveRecord::SchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.schema_migration.normalized_versions
       expect(versions.first).to eq("20202020202011")
     end
 
@@ -49,7 +56,7 @@ describe DataMigrate::SchemaMigration do
         subject.run(:down, migration_path, 20202020202011)
       }.to output(/Undoing DbMigration/).to_stdout
 
-      versions = ActiveRecord::SchemaMigration.normalized_versions
+      versions = DataMigrate::RailsHelper.schema_migration.normalized_versions
 
       expect(versions.count).to eq(0)
     end
@@ -61,9 +68,9 @@ describe DataMigrate::SchemaMigration do
       let(:paths) { ['spec/db/migrate', 'spec/db/migrate/other'] }
       let(:specification_name) { "primary" }
       let(:config_options) do
-        if Gem::Dependency.new("railties", "~> 6.0").match?("railties", Gem.loaded_specs["railties"].version)
+        if Gem::Dependency.new("railties", "~> 6.1").match?("railties", Gem.loaded_specs["railties"].version)
           { env_name: Rails.env, spec_name: specification_name }
-        elsif Gem::Dependency.new("railties", "~> 7.0").match?("railties", Gem.loaded_specs["railties"].version)
+        else
           { env_name: Rails.env, name: specification_name }
         end
       end

data/spec/data_migrate/status_service_spec.rb

@@ -33,9 +33,12 @@ describe DataMigrate::StatusService do
     end
 
     before do
-      ActiveRecord::SchemaMigration.create_table
-      DataMigrate::DataSchemaMigration.create_table
-      DataMigrate::DataSchemaMigration.create(fixture_file_timestamps.map { |t| { version: t } })
+      DataMigrate::RailsHelper.schema_migration.create_table
+      DataMigrate::RailsHelper.data_schema_migration.create_table
+
+      fixture_file_timestamps.map do |t|
+        DataMigrate::RailsHelper.data_schema_migration.create_version(t)
+      end
 
       subject.dump(connection_db_config, stream)
       stream.rewind

data/spec/data_migrate/tasks/data_migrate_tasks_spec.rb

@@ -3,17 +3,17 @@
 require "spec_helper"
 
 describe DataMigrate::Tasks::DataMigrateTasks do
-  let(:connection_db_config) do
-    if Gem::Dependency.new("railties", ">= 6.1").match?("railties", Gem.loaded_specs["railties"].version)
-      ActiveRecord::Base.connection_db_config
-    else
-      ActiveRecord::Base.configurations.configs_for.first
-    end
+  let(:db_config) do
+    {
+      adapter: "sqlite3",
+      database: "spec/db/test.db"
+    }
   end
 
   before do
-    ActiveRecord::SchemaMigration.create_table
-    DataMigrate::DataSchemaMigration.create_table
+    ActiveRecord::Base.establish_connection(db_config)
+    DataMigrate::RailsHelper.schema_migration.create_table
+    DataMigrate::RailsHelper.data_schema_migration.create_table
   end
 
   after do

data/spec/db/data/20091231235959_some_name.rb

@@ -1,4 +1,4 @@
-class SomeName < ActiveRecord::Migration[6.0]
+class SomeName < ActiveRecord::Migration[6.1]
   def up
     puts "Doing data migration"
   end

data/spec/db/data/20171231235959_super_update.rb

@@ -1,4 +1,4 @@
-class SuperUpdate < ActiveRecord::Migration[6.0]
+class SuperUpdate < ActiveRecord::Migration[6.1]
   def up
     puts "Doing SuperUpdate"
   end

data/spec/db/migrate/20131111111111_late_migration.rb

@@ -1,4 +1,4 @@
-class LateMigration < ActiveRecord::Migration[6.0]
+class LateMigration < ActiveRecord::Migration[6.1]
   def up
     puts "Doing schema LateMigration"
   end

data/spec/db/migrate/20202020202011_db_migration.rb

@@ -1,4 +1,4 @@
-class DbMigration < ActiveRecord::Migration[6.0]
+class DbMigration < ActiveRecord::Migration[6.1]
   def up
     puts "Doing schema migration"
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: data_migrate
 version: !ruby/object:Gem::Version
-  version: 9.1.0
+  version: 9.2.0
 platform: ruby
 authors:
 - Andrew J Vargo
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-29 00:00:00.000000000 Z
+date: 2023-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -18,28 +18,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -201,14 +201,18 @@ files:
 - Appraisals
 - Changelog.md
 - Gemfile
+- Gemfile.lock
 - Gemfile.rails6.1
 - LICENSE
 - README.md
 - Rakefile
 - data_migrate.gemspec
-- gemfiles/rails_6.0.gemfile
 - gemfiles/rails_6.1.gemfile
+- gemfiles/rails_6.1.gemfile.lock
 - gemfiles/rails_7.0.gemfile
+- gemfiles/rails_7.0.gemfile.lock
+- gemfiles/rails_7.1.gemfile
+- gemfiles/rails_7.1.gemfile.lock
 - lib/capistrano/data_migrate.rb
 - lib/capistrano/data_migrate/migrate.rb
 - lib/data_migrate.rb
@@ -217,8 +221,8 @@ files:
 - lib/data_migrate/data_schema.rb
 - lib/data_migrate/data_schema_migration.rb
 - lib/data_migrate/database_tasks.rb
-- lib/data_migrate/legacy_migrator.rb
 - lib/data_migrate/migration_context.rb
+- lib/data_migrate/rails_helper.rb
 - lib/data_migrate/railtie.rb
 - lib/data_migrate/schema_dumper.rb
 - lib/data_migrate/schema_migration.rb
@@ -235,7 +239,6 @@ files:
 - spec/data_migrate/data_schema_migration_spec.rb
 - spec/data_migrate/data_spec.rb
 - spec/data_migrate/database_tasks_spec.rb
-- spec/data_migrate/legacy_migrator_spec.rb
 - spec/data_migrate/migration.rb
 - spec/data_migrate/migration_context_spec.rb
 - spec/data_migrate/schema_dumper_spec.rb

data/lib/data_migrate/legacy_migrator.rb

@@ -1,22 +0,0 @@
-module DataMigrate
-  class LegacyMigrator
-    def initialize(migrations_paths = "db/data")
-      @migrations_paths = migrations_paths || "db/data"
-    end
-
-    def migrate
-      dates =
-        DataMigrate::DataMigrator.migrations(@migrations_paths).collect(&:version)
-      legacy = ActiveRecord::SchemaMigration.where(version: dates)
-      legacy.each do |v|
-        begin
-          version = v.version
-          puts "Creating #{version} in data schema"
-          DataMigrate::DataSchemaMigration.create(version: version)
-        rescue ActiveRecord::RecordNotUnique
-          nil
-        end
-      end
-    end
-  end
-end

data/spec/data_migrate/legacy_migrator_spec.rb

@@ -1,38 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-describe DataMigrate::LegacyMigrator do
-  let(:context) {
-    DataMigrate::MigrationContext.new("spec/db/data")
-  }
-
-  before do
-    ActiveRecord::SchemaMigration.create_table
-    DataMigrate::DataSchemaMigration.create_table
-  end
-
-  after do
-    ActiveRecord::Migration.drop_table("data_migrations") rescue nil
-    ActiveRecord::Migration.drop_table("schema_migrations") rescue nil
-  end
-
-  it "migrate legacy migrations to be in correct table" do
-    # simulate creation of legacy data migration when
-    # it was recorded in schema table
-    ActiveRecord::SchemaMigration.create(version: "20091231235959")
-
-    # create one migration in correct place
-    DataMigrate::DataSchemaMigration.create(version: "20171231235959")
-
-    migrated = DataMigrate::DataMigrator.new(:up, []).load_migrated
-    expect(migrated.count).to eq 1
-
-    DataMigrate::LegacyMigrator.new("spec/db/data").migrate
-
-    # after migacy migrator has been run, we should have records
-    # of both migrations
-    migrated = DataMigrate::DataMigrator .new(:up, []).load_migrated
-    expect(migrated.count).to eq 2
-  end
-end