data_maker 2.1.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9a061d848d0e5650d842c87de33f1af6e97f0122
-  data.tar.gz: 675d93a217f05443beb16715afa39bfc008e52cd
+  metadata.gz: c01f3f8689201348ddcc873d4ebab520b16288b3
+  data.tar.gz: 992b306f797ce68ecb39a42e41bb1bc7e865ce69
 SHA512:
-  metadata.gz: a5a58550b718417b53d241db5a3c77e550d5aa7ee5dab14c135770adbe5d07505c1d11af836298ffebb545e36b0f8bf6c21245cf6b6bb08d652f99210f298d41
-  data.tar.gz: 9be312833f8a454aaae9a0b9b414a6e415c65f0bc949cf1c2f2819521c962ecd9227d81bc0b81334e8d0aadeed656d08330d967ab7ee73187869945db08356b1
+  metadata.gz: c2703317d322c3f855975a571dd39ae6ff8a0d7524090b4170ed478e388729fe408078da60c82dff000c382b98a3f21ff260cc89887b92f517a53d0dba6a882f
+  data.tar.gz: 94bdf132a89ec9beeba37d8bbf034d08de79b506096a7a4cc8e7ba72e46d0d075d9b55686077f9e05e18a93356310ef88acd8afd8bcb60b9308e322588ffe96e

data/data_maker.gemspec

@@ -22,22 +22,23 @@ Gem::Specification.new do |gem|
   # gem.bindir = 'bin'
   # gem.executables << 'data_maker-console'
 
-  gem.add_development_dependency 'simplecov', '~> 0.8.2', '>= 0.8.2'
-  gem.add_development_dependency 'coveralls', '~> 0.7.0', '>= 0.7.0' 
-  gem.add_development_dependency 'rake', '10.1.1', '>= 10.1.1'
-  gem.add_development_dependency 'rspec', '~> 3.1.0', '>= 3.1.0'
-  gem.add_development_dependency 'pry-byebug', '~> 3.1.0', '>= 3.1.0'
-  gem.add_development_dependency 'pry-rescue', '~> 1.4.1', '>= 1.4.1'
-  gem.add_development_dependency 'pry-stack_explorer', '~> 0.4.9.1', '>= 0.4.9.1'
+  gem.add_development_dependency 'simplecov'
+  gem.add_development_dependency 'coveralls'
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'pry-byebug'
+  gem.add_development_dependency 'pry-rescue'
+  gem.add_development_dependency 'pry-stack_explorer'
+  gem.add_development_dependency 'phonelib'
 
-  gem.add_runtime_dependency 'pry', '~> 0.10.1', '>= 0.10.1'
+  gem.add_runtime_dependency 'pry'
 
   gem.post_install_message = "To test out the generator execute command data_maker-console"
 
   gem.required_ruby_version = '>= 1.9.3'
 
   gem.require_path = 'lib'
-  gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  gem.test_files   = `git ls-files -- {test,spec,features}/*`.split("\n")
 
   # = MANIFEST =
   gem.files = %w[
@@ -47,6 +48,7 @@ Gem::Specification.new do |gem|
     Rakefile
     data_maker.gemspec
     lib/data_maker.rb
+    lib/data_maker/china/address.rb
     lib/data_maker/china/name.rb
     lib/data_maker/china/phone_number.rb
     lib/data_maker/data/china/name/first_names

data/lib/data_maker.rb

@@ -1,5 +1,5 @@
 module DataMaker
-  VERSION = "2.1.1"
+  VERSION = "2.1.2"
 
   require 'data_maker/utilities/array_utilities'
   require 'data_maker/utilities/module_utilities'

data/lib/data_maker/china/address.rb

@@ -0,0 +1,33 @@
+module DataMaker
+  module China
+    module Address
+      def self.street_address
+        "lastname and street suffix"
+      end
+
+      def self.street_name
+      end
+
+      def self.city
+      end
+
+      def self.city_prefix
+      end
+
+      def self.city_suffix
+      end
+
+      def self.unit_no
+      end
+
+      def self.postcode
+      end
+
+      def self.province
+      end
+
+      def self.full_address
+      end
+    end
+  end
+end

data/lib/data_maker/china/phone_number.rb

@@ -9,7 +9,7 @@ module DataMaker
       end
 
       def self.landline
-        number = PhoneNumberGenerator.new(LANDLINE_FORMAT)
+        number = PhoneNumberGenerator.new("landline")
         number.generate
       end
 
@@ -69,30 +69,41 @@ module DataMaker
 
         def eleven_digit_rule?(prefix)
           [
-            10,
-            311,
-            371,
-            376,
-            377,
-            379,
-            411,
-            431,
-            432,
-            451,
-            531,
-            532,
-            551,
-            571,
-            591,
-            731,
-            754,
-            755,
-            757,
-            760,
-            769,
-            791,
-            851,
-            871
+            '10',
+            '311',
+            '371',
+            '377',
+            '379',
+            '411',
+            '431',
+            '432',
+            '451',
+            '510',
+            '512',
+            '513',
+            '515',
+            '516',
+            '519',
+            '527',
+            '531',
+            '532',
+            '551',
+            '571',
+            '573',
+            '577',
+            '579',
+            '591',
+            '595',
+            '731',
+            '754',
+            '755',
+            '757',
+            '760',
+            '769',
+            '791',
+            '851',
+            '871',
+            '898'
           ].include?(prefix)
         end
       end

data/lib/data_maker/data/china/phone_number/landline_phone_prefixes

@@ -4,7 +4,6 @@
 23
 24
 25
-26
 27
 28
 29
@@ -67,7 +66,6 @@
 438
 439
 440
-448
 451
 452
 453
@@ -117,7 +115,6 @@
 530
 543
 546
-551
 552
 553
 554
@@ -131,7 +128,6 @@
 562
 563
 564
-565
 566
 571
 572
@@ -158,7 +154,6 @@
 633
 634
 635
-638
 662
 663
 668
@@ -262,7 +257,6 @@
 878
 879
 870
-881
 883
 886
 887

data/spec/lib/data_maker/china/phone_number_spec.rb

@@ -1,15 +1,23 @@
 require 'spec_helper'
 
 RSpec.describe DataMaker::China::PhoneNumber do
+
+  before :each do
+    Phonelib.default_country = 'CN'
+  end
+
   describe "#self.mobile" do
     it "generates a valid mobile number" do
       number = described_class.mobile
-      validate = DataMaker::Validators::ChinesePhoneNumber.new(number)
-      expect(validate.valid?).to be_truthy
+      expect(Phonelib.valid?(number)).to be_truthy
     end
   end
 
   describe "#self.landline" do
+    it "generates a valid landline number" do
+      number = described_class.landline
+      expect(Phonelib.valid?(number)).to be_truthy
+    end
   end
 
   describe "::GeneratePhoneNumber" do
@@ -38,11 +46,10 @@ RSpec.describe DataMaker::China::PhoneNumber do
     describe "#generate_number" do
       let(:generate) { generate_phone_number.generate }
 
-      # it "generates a valid phone number" do
-      #   number = generate
-      #   validate = DataMaker::Validators::ChinesePhoneNumber.new(number)
-      #   expect(validate.valid?).to be_truthy
-      # end
+      it "generates a valid phone number" do
+        number = generate
+        expect(Phonelib.valid?(number)).to be_truthy
+      end
 
       context "when format is mobile" do
         let(:format) { "mobile" }

data/spec/lib/data_maker/data_maker_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe DataMaker do
 
   describe "#VERSION" do
     # For each iteration of a version this would always get changed.
-    let(:current_version) { "2.1.1" }
+    let(:current_version) { "2.1.2" }
 
     it { expect(described_class).to be_const_defined(:VERSION) }
     it { expect(described_class::VERSION).to eq(current_version) }

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 require 'rspec'
 require 'simplecov'
 require 'coveralls'
+require 'phonelib'
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
   SimpleCov::Formatter::HTMLFormatter,

metadata

@@ -1,175 +1,141 @@
 --- !ruby/object:Gem::Specification
 name: data_maker
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.1.2
 platform: ruby
 authors:
 - Kareem Gan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-26 00:00:00.000000000 Z
+date: 2015-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.8.2
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.8.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.8.2
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.8.2
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.7.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.7.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 10.1.1
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.1.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 10.1.1
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.1.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.1.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-rescue
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.1
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.1
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-stack_explorer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.4.9.1
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.9.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: phonelib
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.9.1
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.9.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.1
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.10.1
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: '0'
 description: |2
      Data generation using yml files from different sources. This was originally forked from faker and ffaker gem
      respecetively.
@@ -185,6 +151,7 @@ files:
 - Rakefile
 - data_maker.gemspec
 - lib/data_maker.rb
+- lib/data_maker/china/address.rb
 - lib/data_maker/china/name.rb
 - lib/data_maker/china/phone_number.rb
 - lib/data_maker/data/china/name/first_names