dash-mario 0.16 → 0.17

data/lib/dash-fu/marios/ruby_gems.rb

@@ -6,7 +6,7 @@ module DashFu::Mario
     def setup(source, params)
       gem_name = params["gem_name"].to_s.strip
       source["source.name"] = "RubyGems: #{gem_name}"
-      source["metric.columns"] = [{ :id=>"downloads", :label=>"Downloads" }]
+      source["metric.columns"] = [{ id: "downloads", label: "Downloads" }]
       source["metric.totals"] = true
       source["gem_name"] = gem_name
     end
@@ -15,40 +15,39 @@ module DashFu::Mario
       raise "Missing gem name" if source["gem_name"].blank?
     end
 
-    def update(source, request)
+    def update(source, request, callback)
       gem_name = source["gem_name"]
-      uri = URI.parse("http://rubygems.org/api/v1/gems/#{Rack::Utils.escape gem_name}.json")
-      case response = Net::HTTP.get_response(uri)
-      when Net::HTTPOK
-        json = JSON.parse(response.body) rescue nil
-      when Net::HTTPNotFound
-        raise "Could not find the Gem #{gem_name}"
-      end
-      unless json
-        logger.error "RubyGems: #{response.code} #{response.message}"
-        raise "Last request didn't go as expected, trying again later"
-      end  
-
-      if source["version"]
-        current, latest = Gem::Version.new(source["version"]), Gem::Version.new(json["version"])
-        if latest > current
-          html = "released <a href=\"http://rubygems.org/gems/#{gem_name}/versions/#{latest}\">#{gem_name} version #{latest}</a>."
-          person = { :fullname=>"RubyGems", :identities=>"url:http://rubygems.org/", :photo_url=>"http://dash-fu.com/images/sources/ruby.png" }
-          yield :activity=>{ :uid=>"#{gem_name}-#{latest}", :url=>"http://rubygems.org/gems/#{gem_name}",
-                             :html=>html, :tags=>%w{release}, :person=>person }
+      session "rubygems.org" do |http|
+        http.get_json "/api/v1/gems/#{gem_name}.json" do |status, json|
+          case status
+          when 200
+            if source["version"]
+              current, latest = Gem::Version.new(source["version"]), Gem::Version.new(json["version"])
+              if latest > current
+                html = "released <a href=\"http://rubygems.org/gems/#{gem_name}/versions/#{latest}\">#{gem_name} version #{latest}</a>."
+                person = { fullname: "RubyGems", identities: "url:http://rubygems.org/", photo_url: "http://dash-fu.com/images/sources/ruby.png" }
+                callback.activity! uid: "#{gem_name}-#{latest}", url: "http://rubygems.org/gems/#{gem_name}",
+                                   html: html, tags: %w{release}, person: person
+              end
+            end
+            source["version"] = json["version"]
+            source.update json.slice(*%w{homepage_uri project_uri info authors info})
+            callback.set! downloads: json["downloads"]
+          when 404
+            callback.error! "Could not find the Gem #{gem_name}"
+          else
+            callback.error! "Last request didn't go as expected, trying again later"
+          end
         end
       end
-      source["version"] = json["version"]
-      source.update json.slice(*%w{homepage_uri project_uri info authors info})
-      yield :set=>{ :downloads=>json["downloads"] }
     end
 
     def meta(source)
-      [ { :title=>"Project", :text=>source["gem_name"], :url=>source["homepage_uri"] || source["project_uri"] },
-        { :text=>source["info"] },
-        { :title=>"Version", :text=>source["version"] },
-        { :title=>"Authors", :text=>source["authors"] },
-        { :title=>"Source", :text=>"RubyGems", :url=>source["project_uri"] } ]
+      [ { title: "Project", text: source["gem_name"], url: source["homepage_uri"] || source["project_uri"] },
+        { text: source["info"] },
+        { title: "Version", text: source["version"] },
+        { title: "Authors", text: source["authors"] },
+        { title: "Source", text: "RubyGems", url: source["project_uri"] } ]
     end
 
   end

data/test/backtweets_test.rb

@@ -21,7 +21,7 @@ test DashFu::Mario::Backtweets do
       end
 
       should "capture tweets" do
-        assert subject.columns.include?(:id=>"tweets", :label=>"Tweets")
+        assert subject.columns.include?(id: "tweets", label: "Tweets")
       end
     end
   end
@@ -48,96 +48,92 @@ test DashFu::Mario::Backtweets do
     end
 
     should "properly encode URL" do
-      stub_request(:get, /backtweets.com/).to_return :body=>interactions.first.response.body
+      stub_request(:get, /backtweets.com/).to_return body: interactions.first.response.body
       source.setup "url"=>"need&this=encoded"
       source.update
       assert_requested :get, "http://backtweets.com/search.json?key=#{mario.send :api_key}&q=need%26this%3Dencoded"
     end
 
     should "handle errors" do
-      stub_request(:get, interactions.first.uri).to_return :status=>500
-      assert_raise(RuntimeError) { source.update }
+      stub_request(:get, interactions.first.uri).to_return status: 500
+      source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
-    should "handle invlid document entity" do
-      stub_request(:get, interactions.first.uri).to_return :body=>"Not JSON"
-      assert_raise(RuntimeError) { source.update }
+    should "handle invalid document entity" do
+      stub_request(:get, interactions.first.uri).to_return body: "Not JSON"
+      source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
     should "capture number of tweets" do
       source.update
-      assert_equal({ :tweets=>11 }, source.metric.values)
+      assert_equal({ tweets: 2 }, source.metric.values)
     end
 
-    should "ignore previous tweets" do
-      source.update
-      assert source.activities.empty?
-    end
+    context "activity" do
+      setup { source.update }
+      subject { source.activity }
 
-    context "repeating" do
-      setup do
-        source.update
-        second = interactions.last
-        stub_request(:get, second.uri).to_return :body=>second.response.body
-        source.update
+      should "capture tweet identifier" do
+        assert_equal "20959239143", subject.uid
       end
 
-      should "capture new tweets" do
-        assert_equal 2, source.activities.count
+      should "capture tweet text" do
+        assert_equal <<-HTML, subject.html
+<a href="http://twitter.com/dude/20959239143">tweeted</a>:
+<blockquote>Super awesome <a href="http://vanity.labnotes.org/">http://j.mp/aOrUnsz</a></blockquote>
+        HTML
       end
 
-      context "activity" do
-        subject { source.activity }
+      should "capture tweet URL" do
+        assert_equal "http://twitter.com/dude/20959239143", subject.url
+      end
 
-        should "capture tweet identifier" do
-          assert_equal "20959239300", subject.uid
-        end
+      should "capture tweet timestamp" do
+        assert_equal Time.parse("2010-8-12T08:30:04").utc, subject.timestamp
+      end
 
-        should "capture tweet text" do
-          assert_equal <<-HTML, subject.html
-<a href="http://twitter.com/assaf/20959239300">tweeted</a>:
-<blockquote>Super awesome <a href="http://vanity.labnotes.org/">http://j.mp/aOrUnsz</a></blockquote>
-          HTML
-        end
+      should "tag as tweeter and mention" do
+        assert_contains subject.tags, "twitter"
+        assert_contains subject.tags, "mention"
+      end
 
-        should "capture tweet URL" do
-          assert_equal "http://twitter.com/assaf/20959239300", subject.url
-        end
+      should "be valid" do
+        assert subject.valid?
+      end
 
-        should "capture tweet timestamp" do
-          assert_equal Time.parse("2010-8-22T05:00:04").utc, subject.timestamp
-        end
+      context "author" do
+        subject { source.activity.person }
 
-        should "tag as tweeter and mention" do
-          assert_contains subject.tags, "twitter"
-          assert_contains subject.tags, "mention"
+        should "capture full name" do
+          assert_equal "dude", subject.fullname
         end
 
-        should "be valid" do
-          assert subject.valid?
+        should "capture screen name" do
+          assert_contains subject.identities, "twitter.com:dude"
         end
 
-        context "author" do
-          subject { source.activity.person }
-
-          should "capture full name" do
-            assert_equal "assaf", subject.fullname
-          end
+        should "capture photo" do
+          assert_equal "http://img.tweetimag.es/i/dude_n", subject.photo_url
+        end
+      end
+    end
 
-          should "capture screen name" do
-            assert_contains subject.identities, "twitter.com:assaf"
-          end
+    context "repeating" do
+      setup do
+        source.update
+        second = interactions.last
+        stub_request(:get, second.uri).to_return body: second.response.body
+        source.update
+      end
 
-          should "capture photo" do
-            assert_equal "http://twitter.com/account/profile_image/assaf", subject.photo_url
-          end
-        end
+      should "capture new tweets" do
+        assert_equal 3, source.activities.count
+        assert_match "The last of its kind", source.activity.html
       end
 
     end
-
   end
 
 
@@ -146,7 +142,7 @@ test DashFu::Mario::Backtweets do
     subject { source.meta }
 
     should "link to search results" do
-      assert subject.include?(:text=>"Search yourself", :url=>"http://backtweets.com/search?q=vanity.labnotes.org")
+      assert subject.include?(text: "Search yourself", url: "http://backtweets.com/search?q=vanity.labnotes.org")
     end
   end
 end

data/test/cassettes/backtweets.yml

@@ -22,8 +22,20 @@
       - Sat, 21 Aug 2010 05:31:10 GMT
       content-length: 
       - "4427"
-    body: "{\"totalresults\":\"11\",\"startindex\":1,\"itemsperpage\":25,\"tweets\":[{\"tweet_id\":\"20959239143\",\"tweet_from_user_id\":1501751,\"tweet_from_user\":\"olivM\",\"tweet_profile_image_url\":\"http:\\/\\/a0.twimg.com\\/profile_images\\/305156692\\/ls_3001_author30_normal.jpg\",\"tweet_created_at\":\"2010-08-12 08:30:04\",\"tweet_text\":\"Vanity : an Experiment Driven Development framework for Rails : <a href=\\\"http:\\/\\/vanity.labnotes.org\\/\\\">http:\\/\\/j.mp\\/aOrUnsz<\\/a> #AB_testing\"},{\"tweet_id\":\"20959192608\",\"tweet_from_user_id\":1501751,\"tweet_from_user\":\"olivM\",\"tweet_profile_image_url\":\"http:\\/\\/a0.twimg.com\\/profile_images\\/305156692\\/ls_3001_author30_normal.jpg\",\"tweet_created_at\":\"2010-08-12 08:29:02\",\"tweet_text\":\"Vanity : a serious A\\/B testing framework for Rails : <a href=\\\"http:\\/\\/vanity.labnotes.org\\/\\\">http:\\/\\/j.mp\\/aOrUns<\\/a> #AB_testing\"},{\"tweet_id\":\"20449872279\",\"tweet_from_user_id\":6291182,\"tweet_from_user\":\"tpitale\",\"tweet_profile_image_url\":\"http:\\/\\/a0.twimg.com\\/profile_images\\/972769472\\/tpitale_bio3_normal.jpg\",\"tweet_created_at\":\"2010-08-06 07:19:34\",\"tweet_text\":\"RT @assaf: Just pushed Vanity 1.4 <a href=\\\"http:\\/\\/vanity.labnotes.org\\/\\\">http:\\/\\/vanity.labnotes.org\\/<\\/a>\"},{\"tweet_id\":\"20449849489\",\"tweet_from_user_id\":2367111,\"tweet_from_user\":\"assaf\",\"tweet_profile_image_url\":\"http:\\/\\/a0.twimg.com\\/profile_images\\/30105312\\/profile-photo_normal.jpg\",\"tweet_created_at\":\"2010-08-06 07:19:01\",\"tweet_text\":\"Just pushed Vanity 1.4 <a href=\\\"http:\\/\\/vanity.labnotes.org\\/\\\">http:\\/\\/vanity.labnotes.org\\/<\\/a>\"},{\"tweet_id\":\"20162966374\",\"tweet_from_user_id\":657013,\"tweet_from_user\":\"pelargir\",\"tweet_profile_image_url\":\"http:\\/\\/a0.twimg.com\\/profile_images\\/767173052\\/5775_128094836287_699146287_3006700_7689164_n_normal.jpg\",\"tweet_created_at\":\"2010-08-02 19:42:59\",\"tweet_text\":\"Started an A\\/B test for teascript.com using the Vanity gem for Rails. Impressed so far. <a href=\\\"http:\\/\\/vanity.labnotes.org\\\">http:\\/\\/vanity.labnotes.org<\\/a>\"},{\"tweet_id\":\"19699432401\",\"tweet_from_user_id\":2367111,\"tweet_from_user\":\"assaf\",\"tweet_profile_image_url\":\"http:\\/\\/a0.twimg.com\\/profile_images\\/30105312\\/profile-photo_normal.jpg\",\"tweet_created_at\":\"2010-07-28 00:56:07\",\"tweet_text\":\"It took a lot of tinkering, but wkhtmltopdf eventually pulled it. Vanity PDF for offline reading <a href=\\\"http:\\/\\/vanity.labnotes.org\\/vanity.pdf\\\">http:\\/\\/vanity.labnotes.org\\/vanity.pdf<\\/a>\"},{\"tweet_id\":\"19590974913\",\"tweet_from_user_id\":14431640,\"tweet_from_user\":\"timothykephart\",\"tweet_profile_image_url\":\"http:\\/\\/a3.twimg.com\\/profile_images\\/282590443\\/test_normal.jpg\",\"tweet_created_at\":\"2010-07-26 17:49:36\",\"tweet_text\":\"RT @shiftb: whoa, just found an awesome A\\/B test framework for rails <a href=\\\"http:\\/\\/vanity.labnotes.org\\/\\\">http:\\/\\/vanity.labnotes.org\\/<\\/a> anyone used it before?@ChronoPositron\"},{\"tweet_id\":\"19587439664\",\"tweet_from_user_id\":785148,\"tweet_from_user\":\"shiftb\",\"tweet_profile_image_url\":\"http:\\/\\/a3.twimg.com\\/profile_images\\/555784839\\/brandon_icon_normal.jpg\",\"tweet_created_at\":\"2010-07-26 16:52:19\",\"tweet_text\":\"whoa, just found an awesome A\\/B test framework for rails <a href=\\\"http:\\/\\/vanity.labnotes.org\\/\\\">http:\\/\\/vanity.labnotes.org\\/<\\/a> anyone used it before? #ExperimentDrivenDevelopment\"},{\"tweet_id\":\"18165123178\",\"tweet_from_user_id\":56644919,\"tweet_from_user\":\"readelicious\",\"tweet_profile_image_url\":\"http:\\/\\/a1.twimg.com\\/profile_images\\/312871002\\/delicious_normal.gif\",\"tweet_created_at\":\"2010-07-10 02:24:44\",\"tweet_text\":\"Vanity \\u2014 Welcome to Vanity <a href=\\\"http:\\/\\/vanity.labnotes.org\\/index.html\\\">http:\\/\\/goo.gl\\/fb\\/e0zLd<\\/a> #analytics #metrics\"},{\"tweet_id\":\"18144555877\",\"tweet_from_user_id\":2367111,\"tweet_from_user\":\"assaf\",\"tweet_profile_image_url\":\"http:\\/\\/a1.twimg.com\\/profile_images\\/30105312\\/profile-photo_normal.jpg\",\"tweet_created_at\":\"2010-07-09 20:11:50\",\"tweet_text\":\"@deepthawtz like this? <a href=\\\"http:\\/\\/vanity.labnotes.org\\/metrics.html\\\">http:\\/\\/vanity.labnotes.org\\/metrics.html<\\/a>\"},{\"tweet_id\":\"18027007347\",\"tweet_from_user_id\":15568945,\"tweet_from_user\":\"bermonpainter\",\"tweet_profile_image_url\":\"http:\\/\\/a3.twimg.com\\/profile_images\\/490420671\\/me_normal.jpg\",\"tweet_created_at\":\"2010-07-08 11:15:43\",\"tweet_text\":\"Checking out Vanity for some easy A\\/B testing for our apps. <a href=\\\"http:\\/\\/vanity.labnotes.org\\/\\\">http:\\/\\/vanity.labnotes.org\\/<\\/a> #rails #doublecompleterainbow T.T\"}]}"
     http_version: "1.1"
+    body: |-
+      { "totalresults": "2",
+        "startindex": 1,
+        "itemsperpage": 3,
+        "tweets": [
+          { "tweet_id": "20959239143",
+            "tweet_from_user_id": 1501751,
+            "tweet_from_user": "dude",
+            "tweet_profile_image_url": "http://a0.twimg.com/profile_images/305156692/ls_3001_author30_normal.jpg",
+            "tweet_created_at": "2010-08-12 08:30:04",
+            "tweet_text": "Super awesome <a href=\"http://vanity.labnotes.org/\">http://j.mp/aOrUnsz</a>" }
+         ]
+      }
 - !ruby/struct:VCR::HTTPInteraction 
   request: !ruby/struct:VCR::Request 
     method: :get
@@ -37,7 +49,7 @@
       content-type: 
       - application/json; charset=utf-8
     body: |-
-      { "totalresults": "11",
+      { "totalresults": "13",
         "startindex": 1,
         "itemsperpage": 3,
         "tweets": [
@@ -46,7 +58,7 @@
             "tweet_from_user": "assaf",
             "tweet_profile_image_url": "http://twitter.com/account/profile_image/assaf",
             "tweet_created_at": "2010-08-22 05:00:04",
-            "tweet_text": "Super awesome <a href=\"http://vanity.labnotes.org/\">http://j.mp/aOrUnsz</a>" },
+            "tweet_text": "The last of its kind" },
           { "tweet_id": "20959239200",
             "tweet_from_user_id": 2367111,
             "tweet_from_user": "assaf",
@@ -55,9 +67,9 @@
             "tweet_text": "Not as awesome" },
           { "tweet_id": "20959239143",
             "tweet_from_user_id": 1501751,
-            "tweet_from_user": "olivM",
+            "tweet_from_user": "dude",
             "tweet_profile_image_url": "http://a0.twimg.com/profile_images/305156692/ls_3001_author30_normal.jpg",
             "tweet_created_at": "2010-08-12 08:30:04",
-            "tweet_text": "Vanity : an Experiment Driven Development framework for Rails : <a href=\"http://vanity.labnotes.org/\">http://j.mp/aOrUnsz</a> #AB_testing" }
+            "tweet_text": "Super awesome <a href=\"http://vanity.labnotes.org/\">http://j.mp/aOrUnsz</a>" }
          ]
       }

data/test/github_issues_test.rb

@@ -16,11 +16,11 @@ test DashFu::Mario::GithubIssues do
       end
 
       should "capture open issues" do
-        assert subject.columns.include?(:id=>"open", :label=>"Open issues")
+        assert subject.columns.include?(id: "open", label: "Open issues")
       end
 
       should "capture closed issues" do
-        assert subject.columns.include?(:id=>"closed", :label=>"Closed issues")
+        assert subject.columns.include?(id: "closed", label: "Closed issues")
       end
     end
   end
@@ -51,30 +51,30 @@ test DashFu::Mario::GithubIssues do
     setup { source.setup "repo"=>"assaf/vanity" }
 
     should "handle 404" do
-      stub_request(:get, interactions.first.uri).to_return :status=>404
-      stub_request(:get, interactions.second.uri).to_return :status=>404
-      assert_raise(RuntimeError) { source.update }
+      stub_request(:get, interactions.first.uri).to_return status: 404
+      stub_request(:get, interactions.second.uri).to_return status: 404
+      source.update
       assert_equal "Could not find the repository assaf/vanity", source.last_error
     end
 
     should "handle 401" do
-      stub_request(:get, interactions.first.uri).to_return :status=>401
-      stub_request(:get, interactions.second.uri).to_return :status=>401
-      assert_raise(RuntimeError) { source.update }
+      stub_request(:get, interactions.first.uri).to_return status: 401
+      stub_request(:get, interactions.second.uri).to_return status: 401
+      source.update
       assert_equal "You are not authorized to access this repository, or invalid username/password", source.last_error
     end
 
     should "handle other error" do
-      stub_request(:get, interactions.first.uri).to_return :status=>500
-      stub_request(:get, interactions.second.uri).to_return :status=>500
-      assert_raise(RuntimeError) { source.update }
+      stub_request(:get, interactions.first.uri).to_return status: 500
+      stub_request(:get, interactions.second.uri).to_return status: 500
+      source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
     should "handle invlid document entity" do
-      stub_request(:get, interactions.first.uri).to_return :body=>"Not JSON"
-      stub_request(:get, interactions.last.uri).to_return :body=>"Not JSON"
-      assert_raise(RuntimeError) { source.update }
+      stub_request(:get, interactions.first.uri).to_return body: "Not JSON"
+      stub_request(:get, interactions.last.uri).to_return body: "Not JSON"
+      source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
@@ -88,98 +88,98 @@ test DashFu::Mario::GithubIssues do
       assert_equal 12, source.metric.values[:closed]
     end
 
-    should "not create any activity" do
-      source.update
-      assert source.activities.empty?
-    end
 
-    context "repeating" do
-      setup do
-        source.update
-        open = interactions.select { |i| i.uri =~ /open/ }
-        stub_request(:get, open.first.uri).to_return :body=>open.last.response.body
-        closed = interactions.select { |i| i.uri =~ /closed/ }
-        stub_request(:get, closed.first.uri).to_return :body=>closed.last.response.body
-        source.update
-      end
+    context "activity for open issue" do
+      setup { source.update }
+      subject { source.activities.first }
 
-      should "update open count" do
-        assert_equal 2, source.metric.values[:open]
+      should "capture issue URL" do
+        assert_equal "http://github.com/assaf/vanity/issues#issue/21", subject.url
       end
 
-      should "update closed count" do
-        assert_equal 2, source.metric.values[:closed]
+      should "use SHA1 for ID" do
+        assert_match /^[0-9a-f]{40}$/, subject.uid
       end
 
-      should "create activity for each issue opened or closed" do
-        assert_equal 2, source.activities.count
+      should "capture issue creation time" do
+        assert_equal Time.parse("2010/08/19 19:59:31 UTC"), subject.timestamp
       end
 
-      context "activity for open issue" do
-        subject { source.activities.first }
+      should "capture issue title" do
+        assert_equal <<-HTML, subject.html
+opened <a href="http://github.com/assaf/vanity/issues#issue/21">issue 21</a> on assaf/vanity:
+<blockquote>Vanity 1.4.0 seems to have issues with Bundler</blockquote>
+        HTML
+      end
 
-        should "capture issue URL" do
-          assert_equal "http://github.com/assaf/vanity/issues#issue/22", subject.url
-        end
+      should "tag as issue and open" do
+        assert_contains subject.tags, "issue"
+        assert_contains subject.tags, "opened"
+      end
 
-        should "use SHA1 for ID" do
-          assert_match /^[0-9a-f]{40}$/, subject.uid
-        end
+      should "be valid" do
+        assert subject.valid?
+      end
+    end
 
-        should "capture issue creation time" do
-          assert_equal Time.parse("2010/03/17 22:32:02 UTC"), subject.timestamp
-        end
+    context "activity for closed issue" do
+      setup { source.update }
+      subject { source.activities.last }
 
-        should "capture issue title" do
-          assert_equal <<-HTML, subject.html
-opened <a href="http://github.com/assaf/vanity/issues#issue/22">issue 22</a> on assaf/vanity:
-<blockquote>Option to use Google Analytics for A/B testing</blockquote>
-          HTML
-        end
+      should "capture issue URL" do
+        assert_equal "http://github.com/assaf/vanity/issues#issue/18", subject.url
+      end
 
-        should "tag as issue and open" do
-          assert_contains subject.tags, "issue"
-          assert_contains subject.tags, "opened"
-        end
+      should "use SHA1 for ID" do
+        assert_match /^[0-9a-f]{40}$/, subject.uid
+      end
 
-        should "be valid" do
-          assert subject.valid?
-        end
+      should "capture issue closing time" do
+        assert_equal Time.parse("2010/07/03 02:16:42 UTC"), subject.timestamp
       end
 
-      context "activity for closed issue" do
-        subject { source.activities.last }
+      should "capture issue title" do
+        assert_equal <<-HTML, subject.html
+closed <a href="http://github.com/assaf/vanity/issues#issue/18">issue 18</a> on assaf/vanity:
+<blockquote>Passwords not supported for the Redis config</blockquote>
+        HTML
+      end
 
-        should "capture issue URL" do
-          assert_equal "http://github.com/assaf/vanity/issues#issue/19", subject.url
-        end
+      should "tag as issue and closed" do
+        assert_contains subject.tags, "issue"
+        assert_contains subject.tags, "closed"
+      end
 
-        should "use SHA1 for ID" do
-          assert_match /^[0-9a-f]{40}$/, subject.uid
-        end
+      should "be valid" do
+        assert subject.valid?
+      end
+    end
 
-        should "capture issue closing time" do
-          assert_equal Time.parse("2010/07/03 04:16:42 UTC"), subject.timestamp
-        end
 
-        should "capture issue title" do
-          assert_equal <<-HTML, subject.html
-closed <a href="http://github.com/assaf/vanity/issues#issue/19">issue 19</a> on assaf/vanity:
-<blockquote>Passwords not supported for the Redis config</blockquote>
-          HTML
-        end
+    context "repeating" do
+      setup do
+        source.update
+        source.activities.clear
+        open = interactions.select { |i| i.uri =~ /open/ }
+        stub_request(:get, open.first.uri).to_return body: open.last.response.body
+        closed = interactions.select { |i| i.uri =~ /closed/ }
+        stub_request(:get, closed.first.uri).to_return body: closed.last.response.body
+        source.update
+      end
 
-        should "tag as issue and closed" do
-          assert_contains subject.tags, "issue"
-          assert_contains subject.tags, "closed"
-        end
+      should "update open count" do
+        assert_equal 2, source.metric.values[:open]
+      end
 
-        should "be valid" do
-          assert subject.valid?
-        end
+      should "update closed count" do
+        assert_equal 2, source.metric.values[:closed]
       end
 
+      should "create activity for each issue opened or closed" do
+        assert_equal 2, source.activities.count
+      end
     end
+
   end
 
 
@@ -188,7 +188,7 @@ closed <a href="http://github.com/assaf/vanity/issues#issue/19">issue 19</a> on
     subject { source.meta }
 
     should "link to repository" do
-      assert_contains subject, :title=>"On Github", :url=>"http://github.com/assaf/vanity/issues"
+      assert_contains subject, title: "On Github", url: "http://github.com/assaf/vanity/issues"
     end
   end
 end