dash-bees 0.21 → 0.22

data/test/github_issues_test.rb

@@ -1,195 +1,214 @@
 require_relative "setup"
 
-test DashFu::Bee::GithubIssues do
-  context "setup" do
-    setup { source.setup "repo"=>"assaf/vanity" }
+describe "GitHub Issues" do
+  testing :github_issues
 
-    context "metric" do
-      subject { source.metric }
+  describe "setup" do
+    before { source.setup "repo"=>"assaf/vanity" }
 
-      should "use repository name" do
-        assert_equal "Github Issues for assaf/vanity", subject.name
-      end
+    it "should use repository name" do
+      assert_equal "GitHub issues for assaf/vanity", source.name
+    end
+
+    it "should set origin from repository name" do
+      assert_equal "assaf/vanity", source.origin[:text]
+      assert_equal "http://github.com/assaf/vanity", source.origin[:url]
+    end
+
+    it "should set icon to the octocat" do
+      assert_equal "http://dash-fu.com/images/sources/github.png", source.fields[ICON]
+    end
+
+    it "should accept repository URL" do
+      source.setup "repo"=>"http://github.com/assaf/vanity", "branch"=>"master"
+      assert_equal "GitHub issues for assaf/vanity", source.name
+    end
 
-      should "measure totals" do
-        assert subject.totals
+    describe "metric" do
+      it "should measure totals" do
+        assert source.metric.totals
       end
 
-      should "capture open issues" do
-        assert subject.columns.include?(id: "open", label: "Open issues")
+      it "should capture open issues" do
+        assert source.metric.columns.include?(id: "open", label: "Open issues")
       end
 
-      should "capture closed issues" do
-        assert subject.columns.include?(id: "closed", label: "Closed issues")
+      it "should capture closed issues" do
+        assert source.metric.columns.include?(id: "closed", label: "Closed issues")
       end
     end
   end
 
 
-  context "validation" do
-    should "raise error if repository name missing" do
-      assert_raise(RuntimeError) { source.setup "repo"=>" " }
+  describe "validation" do
+    it "should raise error if repository name missing" do
+      assert_raises(RuntimeError) { source.setup "repo"=>" " }
     end
 
-    should "raise error if repository name not user/repo" do
-      assert_raise(RuntimeError) { source.setup "repo"=>"vanity" }
+    it "should raise error if repository name not user/repo" do
+      assert_raises(RuntimeError) { source.setup "repo"=>"vanity" }
     end
 
-    should "allow alphanumeric, minus and underscore" do
+    it "should allow alphanumeric, minus and underscore" do
       source.setup "repo"=>"assaf/the-vanity_0"
       assert source.valid?
     end
 
-    should "create valid source" do
+    it "should create valid source" do
       source.setup "repo"=>"assaf/vanity"
       assert source.valid?
     end
   end
 
 
-  context "update" do
-    setup { source.setup "repo"=>"assaf/vanity" }
+  describe "update" do
+    before { source.setup "repo"=>"assaf/vanity" }
 
-    should "handle 404" do
+    it "should handle 404" do
       stub_request(:get, interactions.first.uri).to_return status: 404
       stub_request(:get, interactions.second.uri).to_return status: 404
       source.update
       assert_equal "Could not find the repository assaf/vanity", source.last_error
     end
 
-    should "handle 401" do
+    it "should handle 401" do
       stub_request(:get, interactions.first.uri).to_return status: 401
       stub_request(:get, interactions.second.uri).to_return status: 401
       source.update
       assert_equal "You are not authorized to access this repository, or invalid username/password", source.last_error
     end
 
-    should "handle other error" do
+    it "should handle other error" do
       stub_request(:get, interactions.first.uri).to_return status: 500
       stub_request(:get, interactions.second.uri).to_return status: 500
       source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
-    should "handle invlid document entity" do
+    it "should handle invlid document entity" do
       stub_request(:get, interactions.first.uri).to_return body: "Not JSON"
       stub_request(:get, interactions.last.uri).to_return body: "Not JSON"
       source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
-    should "capture number of open issues" do
+    it "should capture number of open issues" do
       source.update
       assert_equal 9, source.metric.values[:open]
     end
 
-    should "capture number of closed issues" do
+    it "should capture number of closed issues" do
       source.update
       assert_equal 12, source.metric.values[:closed]
     end
 
 
-    context "activity for open issue" do
-      setup { source.update }
-      subject { source.activities.first }
+    describe "activity for open issue" do
+      before { source.update }
+      def activity
+        source.activities.first
+      end
 
-      should "capture issue URL" do
-        assert_equal "http://github.com/assaf/vanity/issues#issue/21", subject.url
+      it "should capture issue URL" do
+        assert_equal "http://github.com/assaf/vanity/issues#issue/21", activity.url
       end
 
-      should "use SHA1 for ID" do
-        assert_match /^[0-9a-f]{40}$/, subject.uid
+      it "should use SHA1 for ID" do
+        assert_match /^[0-9a-f]{40}$/, activity.uid
       end
 
-      should "capture issue creation time" do
-        assert_equal Time.parse("2010/08/19 19:59:31 UTC"), subject.timestamp
+      it "should capture issue creation time" do
+        assert_equal Time.parse("2010/08/19 19:59:31 UTC"), activity.timestamp
       end
 
-      should "capture issue title" do
-        assert_equal <<-HTML, subject.html
+      it "should capture issue title" do
+        assert_equal <<-HTML, activity.html
 opened <a href="http://github.com/assaf/vanity/issues#issue/21">issue 21</a> on assaf/vanity:
 <blockquote>Vanity 1.4.0 seems to have issues with Bundler</blockquote>
         HTML
       end
 
-      should "tag as issue and open" do
-        assert_contains subject.tags, "issue"
-        assert_contains subject.tags, "opened"
+      it "should tag as issue and open" do
+        assert activity.tags.include?("issue")
+        assert activity.tags.include?("opened")
       end
 
-      should "be valid" do
-        assert subject.valid?
+      it "should be public" do
+        assert activity.public?
       end
 
-      context "person" do
-        subject { source.activities.first.person }
+      it "should be valid" do
+        assert activity.valid?
+      end
 
-        should "be GitHub" do
-          assert_equal "GitHub", subject.fullname
+      describe "person" do
+        it "should be GitHub" do
+          assert_equal "GitHub", person.fullname
         end
 
-        should "have site as identity" do
-          assert_contains subject.identities, "site:github.com"
+        it "should have site as identity" do
+          assert person.identities.include?("site:github.com")
         end
 
-        should "use octocat as photo" do
-          assert_equal "http://github.com/images/error/octocat_happy.gif", subject.photo_url
+        it "should use octocat as photo" do
+          assert_equal "http://dash-fu.com/images/sources/github.png", person.photo_url
         end
       end
     end
 
-    context "activity for closed issue" do
-      setup { source.update }
-      subject { source.activities.last }
+    describe "activity for closed issue" do
+      before { source.update }
 
-      should "capture issue URL" do
-        assert_equal "http://github.com/assaf/vanity/issues#issue/18", subject.url
+      it "should capture issue URL" do
+        assert_equal "http://github.com/assaf/vanity/issues#issue/18", activity.url
       end
 
-      should "use SHA1 for ID" do
-        assert_match /^[0-9a-f]{40}$/, subject.uid
+      it "should use SHA1 for ID" do
+        assert_match /^[0-9a-f]{40}$/, activity.uid
       end
 
-      should "capture issue closing time" do
-        assert_equal Time.parse("2010/07/03 02:16:42 UTC"), subject.timestamp
+      it "should capture issue closing time" do
+        assert_equal Time.parse("2010/07/03 02:16:42 UTC"), activity.timestamp
       end
 
-      should "capture issue title" do
-        assert_equal <<-HTML, subject.html
+      it "should capture issue title" do
+        assert_equal <<-HTML, activity.html
 closed <a href="http://github.com/assaf/vanity/issues#issue/18">issue 18</a> on assaf/vanity:
 <blockquote>Passwords not supported for the Redis config</blockquote>
         HTML
       end
 
-      should "tag as issue and closed" do
-        assert_contains subject.tags, "issue"
-        assert_contains subject.tags, "closed"
+      it "should tag as issue and closed" do
+        assert activity.tags.include?("issue")
+        assert activity.tags.include?("closed")
       end
 
-      should "be valid" do
-        assert subject.valid?
+      it "should be public" do
+        assert activity.public?
       end
 
-      context "person" do
-        subject { source.activities.first.person }
+      it "should be valid" do
+        assert activity.valid?
+      end
 
-        should "be GitHub" do
-          assert_equal "GitHub", subject.fullname
+      describe "person" do
+        it "should be GitHub" do
+          assert_equal "GitHub", person.fullname
         end
 
-        should "have site as identity" do
-          assert_contains subject.identities, "site:github.com"
+        it "should have site as identity" do
+          assert person.identities.include?("site:github.com")
         end
 
-        should "use octocat as photo" do
-          assert_equal "http://github.com/images/error/octocat_happy.gif", subject.photo_url
+        it "should use octocat as photo" do
+          assert_equal "http://dash-fu.com/images/sources/github.png", person.photo_url
         end
       end
     end
 
 
-    context "repeating" do
-      setup do
+    describe "repeating" do
+      before do
         source.update
         source.activities.clear
         open = interactions.select { |i| i.uri =~ /open/ }
@@ -199,28 +218,19 @@ closed <a href="http://github.com/assaf/vanity/issues#issue/18">issue 18</a> on
         source.update
       end
 
-      should "update open count" do
+      it "should update open count" do
         assert_equal 2, source.metric.values[:open]
       end
 
-      should "update closed count" do
+      it "should update closed count" do
         assert_equal 2, source.metric.values[:closed]
       end
 
-      should "create activity for each issue opened or closed" do
+      it "should create activity for each issue opened or closed" do
         assert_equal 2, source.activities.count
       end
     end
 
   end
 
-
-  context "meta" do
-    setup { source.setup "repo"=>"assaf/vanity" }
-    subject { source.meta }
-
-    should "link to repository" do
-      assert_contains subject, title: "On GitHub", url: "http://github.com/assaf/vanity/issues"
-    end
-  end
 end

data/test/github_test.rb

@@ -1,149 +1,164 @@
 require_relative "setup"
 
-test DashFu::Bee::Github do
-  context "setup" do
-    setup { source.setup "repo"=>"assaf/vanity", "branch"=>"master" }
+describe "GitHub" do
+  testing :github
 
-    should "default branch to master" do
+  describe "setup" do
+    before { source.setup "repo"=>"assaf/vanity", "branch"=>"master" }
+
+    it "should use repository name" do
+      assert_equal "GitHub: assaf/vanity", source.name
+    end
+
+    it "should default branch to master" do
       source.setup "repo"=>"assaf/vanity", "branch"=>" "
-      assert_equal "master", source.state["branch"]
+      assert_equal "master", source.fields["branch"]
+    end
+    
+    it "should set origin from repository name" do
+      assert_equal "assaf/vanity", source.origin[:text]
+      assert_equal "http://github.com/assaf/vanity", source.origin[:url]
     end
 
-    context "metric" do
-      subject { source.metric }
+    it "should set icon to the octocat" do
+      assert_equal "http://dash-fu.com/images/sources/github.png", source.fields[ICON]
+    end
 
-      should "use repository name" do
-        assert_equal "GitHub: assaf/vanity", subject.name
-      end
+    it "should accept repository URL" do
+      source.setup "repo"=>"http://github.com/assaf/vanity", "branch"=>"master"
+      assert_equal "GitHub: assaf/vanity", source.name
+    end
 
-      should "measure totals" do
-        assert subject.totals
+    describe "metric" do
+      it "should measure totals" do
+        assert source.metric.totals
       end
 
-      should "capture commits" do
-        assert subject.columns.include?(:id=>"commits", :label=>"Commits")
+      it "should capture commits" do
+        assert source.metric.columns.include?(:id=>"commits", :label=>"Commits")
       end
 
-      should "capture watchers" do
-        assert subject.columns.include?(:id=>"watchers", :label=>"Watchers")
+      it "should capture watchers" do
+        assert source.metric.columns.include?(:id=>"watchers", :label=>"Watchers")
       end
 
-      should "capture forks" do
-        assert subject.columns.include?(:id=>"forks", :label=>"Forks")
+      it "should capture forks" do
+        assert source.metric.columns.include?(:id=>"forks", :label=>"Forks")
       end
     end
   end
 
 
-  context "validation" do
-    should "raise error if repository name missing" do
-      assert_raise(RuntimeError) { source.setup "repo"=>" ", "branch"=>"master" }
+  describe "validation" do
+    it "should raise error if repository name missing" do
+      assert_raises(RuntimeError) { source.setup "repo"=>" ", "branch"=>"master" }
     end
 
-    should "raise error if repository name not user/repo" do
-      assert_raise(RuntimeError) { source.setup "repo"=>"vanity", "branch"=>"master" }
+    it "should raise error if repository name not user/repo" do
+      assert_raises(RuntimeError) { source.setup "repo"=>"vanity", "branch"=>"master" }
     end
 
-    should "allow alphanumeric, minus and underscore" do
+    it "should allow alphanumeric, minus and underscore" do
       source.setup "repo"=>"assaf/the-vanity_0", "branch"=>"master"
       assert source.valid?
     end
 
-    should "create valid source" do
+    it "should create valid source" do
       source.setup "repo"=>"assaf/vanity", "branch"=>"master"
       assert source.valid?
     end
   end
 
 
-  context "update" do
-    setup { source.setup "repo"=>"assaf/vanity", "branch"=>"master" }
+  describe "update" do
+    before { source.setup "repo"=>"assaf/vanity", "branch"=>"master" }
 
-    should "handle 404" do
+    it "should handle 404" do
       stub_request(:get, interactions.first.uri).to_return :status=>404
       source.update
       assert_equal "Could not find the repository assaf/vanity", source.last_error
     end
 
-    should "handle 401" do
+    it "should handle 401" do
       stub_request(:get, interactions.first.uri).to_return :status=>401
       source.update
       assert_equal "You are not authorized to access this repository, or invalid username/password", source.last_error
     end
 
-    should "handle other error" do
+    it "should handle other error" do
       stub_request(:get, interactions.first.uri).to_return :status=>500
       source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
-    should "handle invlid document entity" do
+    it "should handle invlid document entity" do
       stub_request(:get, interactions.first.uri).to_return :body=>"Not JSON"
       source.update
       assert_equal "Last request didn't go as expected, trying again later", source.last_error
     end
 
-    should "capture number of commits" do
+    it "should capture number of commits" do
       source.update
       assert_equal 35, source.metric.values[:commits]
     end
 
-    should "capture number of wacthers" do
+    it "should capture number of wacthers" do
       source.update
       assert_equal 534, source.metric.values[:watchers]
     end
 
-    should "capture number of forks" do
+    it "should capture number of forks" do
       source.update
       assert_equal 36, source.metric.values[:forks]
     end
 
 
-    context "activity" do
-      setup { source.update }
-      subject { source.activity }
+    describe "activity" do
+      before { source.update }
 
-      should "capture commit URL" do
-        assert_equal "http://github.com/assaf/vanity/commit/dd154a9fdd2ac534b62b55b8acac2fd092d6543a", subject.url
+      it "should capture commit URL" do
+        assert_equal "http://github.com/assaf/vanity/commit/dd154a9fdd2ac534b62b55b8acac2fd092d6543a", activity.url
       end
 
-      should "capture commit SHA" do
-        assert_equal "dd154a9fdd2ac534b62b55b8acac2fd092d6543a", subject.uid
+      it "should capture commit SHA" do
+        assert_equal "dd154a9fdd2ac534b62b55b8acac2fd092d6543a", activity.uid
       end
 
-      should "capture timestamp" do
-        assert_equal Time.parse("2010-08-06T00:18:01-07:00 UTC").utc, subject.timestamp
+      it "should capture timestamp" do
+        assert_equal Time.parse("2010-08-06T00:18:01-07:00 UTC").utc, activity.timestamp
       end
 
-      should "capture push" do
-        assert_match %{pushed to master at <a href="http://github.com/assaf/vanity">assaf/vanity</a>:}, subject.html
+      it "should capture push" do
+        assert_match %{pushed to master at <a href="http://github.com/assaf/vanity">assaf/vanity</a>:}, activity.html
       end
 
-      should "tag as push" do
-        assert_contains subject.tags, "push"
+      it "should tag as push" do
+        assert activity.tags.include?("push")
       end
 
-      should "be valid" do
-        subject.validate
-        assert subject.valid?
+      it "should be public" do
+        assert activity.public?
       end
 
-      context "person" do
-        subject { source.activity.person }
+      it "should be valid" do
+        activity.validate
+        assert activity.valid?
+      end
 
-        should "capture full name" do
-          assert_equal "Assaf Arkin", subject.fullname
+      describe "person" do
+        it "should capture full name" do
+          assert_equal "Assaf Arkin", person.fullname
         end
 
-        should "capture email" do
-          assert_equal "assaf@labnotes.org", subject.email
+        it "should capture email" do
+          assert_equal "assaf@labnotes.org", person.email
         end
 
-        should "capture identity" do
-          assert_contains subject.identities, "github.com:assaf"
+        it "should capture identity" do
+          assert person.identities.include?("github.com:assaf")
         end
 
-        should "not trip on empty login" do
+        it "should not trip on empty login" do
           commits = interactions.select { |i| i.uri =~ /commits\/list/ }
           stub_request(:get, commits.first.uri).to_return :body=>commits.last.response.body
           source.update
@@ -153,19 +168,21 @@ test DashFu::Bee::Github do
         end
       end
 
-      context "commit message" do
-        subject { (Nokogiri::HTML(source.activity.html)/"blockquote").map(&:inner_text).join("\n") }
+      describe "commit message" do
+        def subject
+          (Nokogiri::HTML(source.activity.html)/"blockquote").map(&:inner_text).join("\n")
+        end
 
-        should "start with commit SHA" do
+        it "should start with commit SHA" do
           assert_match /^dd154a9 /, subject
         end
 
-        should "include first 50 characters of message" do
+        it "should include first 50 characters of message" do
           with_message "This is a very long message and we're only going to show the first 50 characters of it."
           assert_equal 50, subject[/\s(.*)/, 1].length
         end
 
-        should "use only first line of message" do
+        it "should use only first line of message" do
           with_message "This message is made\nof two lines"
           assert_match "This message is made", subject[/\s(.*)/, 1]
         end
@@ -180,25 +197,25 @@ test DashFu::Bee::Github do
         end
       end
 
-      context "sequential commits" do
-        setup do
+      describe "sequential commits" do
+        before do
           source.activities.clear
           interaction = interactions.select { |i| i.uri =~ /commits\/list/ }.last
           stub_request(:get, interaction.uri).to_return :body=>interaction.response.body
           source.update
+          @message = (Nokogiri::HTML(source.activity.html)/"blockquote")
         end
-        subject { (Nokogiri::HTML(source.activity.html)/"blockquote") }
 
-        should "show as multiple activities" do
+        it "should show as multiple activities" do
           assert_equal 4, source.activities.count # 4 commits -> 3 activities
         end
 
-        should "merge related commits into single activity" do
-          assert_equal 2, subject.length   # last one has two commits
+        it "should merge related commits into single activity" do
+          assert_equal 2, @message.length   # last one has two commits
         end
 
-        should "merge related commits in order they were listed" do
-          first, second = subject.map { |bq| bq.inner_text.strip }
+        it "should merge related commits in order they were listed" do
+          first, second = @message.map { |bq| bq.inner_text.strip }
           assert_equal "cc156a9 Most recent commit", first
           assert_equal "dd156a9 Not most recent commit", second
         end
@@ -207,8 +224,8 @@ test DashFu::Bee::Github do
     end
 
 
-    context "repeating" do
-      setup do
+    describe "repeating" do
+      before do
         source.update
         repo = interactions.select { |i| i.uri =~ /repos\/show/ }
         stub_request(:get, repo.first.uri).to_return :body=>repo.last.response.body
@@ -217,15 +234,15 @@ test DashFu::Bee::Github do
         source.update
       end
 
-      should "update watchers" do
+      it "should update watchers" do
         assert_equal 555, source.metric.values[:watchers]
       end
 
-      should "update forks" do
+      it "should update forks" do
         assert_equal 38, source.metric.values[:forks]
       end
 
-      should "capture new number of commits" do
+      it "should capture new number of commits" do
         assert_equal 40, source.metric.values[:commits]
       end
     end
@@ -233,29 +250,24 @@ test DashFu::Bee::Github do
   end
 
 
-  context "meta" do
-    setup { source.setup "repo"=>"assaf/vanity", "branch"=>"master" }
-    subject { source.meta }
-
-    should "link to repository" do
-      assert_contains subject, :title=>"Repository", :text=>"assaf/vanity", :url=>"http://github.com/assaf/vanity"
-    end
+  describe "meta" do
+    before { source.setup "repo"=>"assaf/vanity", "branch"=>"master" }
 
-    should "include project description" do
-      assert_contains subject, :text=>"Experiment Driven Development for Ruby"
+    it "should include project description" do
+      assert source.meta.include?(:text=>"Experiment Driven Development for Ruby")
     end
 
-    should "link to project home page" do
-      assert_contains subject, :title=>"Home page", :url=>"http://vanity.labnotes.org"
+    it "should link to project home page" do
+      assert source.meta.include?(:title=>"Home page", :url=>"http://vanity.labnotes.org")
     end
 
-    should "list branch name" do
-      assert_contains subject, :title=>"Branch", :text=>"master"
+    it "should list branch name" do
+      assert source.meta.include?(:title=>"Branch", :text=>"master")
     end
 
-    should "show last commit message" do
-      assert_contains subject, :title=>"Commit", :text=>"Gemfile changes necessary to pass test suite.",
-        :url=>"http://github.com/assaf/vanity/commit/dd154a9fdd2ac534b62b55b8acac2fd092d6543a"
+    it "should show last commit message" do
+      assert source.meta.include?(:title=>"Commit", :text=>"Gemfile changes necessary to pass test suite.",
+        :url=>"http://github.com/assaf/vanity/commit/dd154a9fdd2ac534b62b55b8acac2fd092d6543a")
     end
   end
 end