darthjee-core_ext 2.0.0 → 3.0.0

data/lib/darthjee/core_ext/hash/keys_sorter.rb

@@ -63,6 +63,7 @@ module Darthjee
         def change_value(value)
           return value unless recursive
           return value unless value.is_a?(Hash)
+
           self.class.new(value).sort
         end
       end

data/lib/darthjee/core_ext/hash/transformable.rb

@@ -68,7 +68,7 @@ module Darthjee
         #            #   c: 'c->1'
         #            # }
         def map_to_hash
-          map do |key, value|
+          to_h do |key, value|
             [key, yield(key, value)]
           end.to_h
         end

data/lib/darthjee/core_ext/hash.rb

@@ -55,8 +55,8 @@ module Darthjee
       #   hash.chain_fetch(:a, :c, :d) { 10 } # returns 10
       #   hash.chain_fetch(:a, :c, :d) { |key, _| key } # returns :c
       #   hash.chain_fetch(:a, :c, :d) { |_, missing| missing } # returns [:d]
-      def chain_fetch(*keys, &block)
-        ::Hash::ChainFetcher.new(self, *keys, &block).fetch
+      def chain_fetch(*keys, &)
+        ::Hash::ChainFetcher.new(self, *keys, &).fetch
       end
     end
   end

data/lib/darthjee/core_ext/numeric.rb

@@ -14,8 +14,9 @@ module Darthjee
       # @example
       #   10.percent_of(30) # returns 33.33333333333333
       def percent_of(total)
-        return Float::INFINITY if total&.zero?
-        (to_f / total.to_f) * 100.0
+        return Float::INFINITY if total.to_f&.zero?
+
+        (to_f / total) * 100.0
       end
     end
   end

data/lib/darthjee/core_ext/object.rb

@@ -33,9 +33,7 @@ module Darthjee
       #   {}.trueful?  # returns true
       #   "".trueful?  # returns true
       def trueful?
-        # rubocop: disable Style/DoubleNegation
         !!self
-        # rubocop: enable Style/DoubleNegation
       end
     end
   end

data/lib/darthjee/core_ext/version.rb

@@ -2,6 +2,6 @@
 
 module Darthjee
   module CoreExt
-    VERSION = '2.0.0'
+    VERSION = '3.0.0'
   end
 end

data/spec/integration/readme/class_spec.rb

@@ -19,7 +19,7 @@ describe Class do
 
       it 'returns the same instance' do
         expect(instance.name)
-          .to be_equal(other.name)
+          .to equal(other.name)
       end
     end
 
@@ -44,7 +44,7 @@ describe Class do
 
       it 'returns the same instance' do
         expect(instance.name)
-          .to be_equal(other.name)
+          .to equal(other.name)
       end
     end
 
@@ -98,7 +98,7 @@ describe Class do
       end
 
       it 'returns the same instance for both methods' do
-        expect(instance.cars).to be_equal(instance.houses)
+        expect(instance.cars).to equal(instance.houses)
       end
 
       context 'when setting cars' do

data/spec/integration/readme/hash_spec.rb

@@ -1,5 +1,9 @@
 # frozen_string_literal: true
 
+require 'spec_helper'
+
+# frozen_string_literal: true
+
 describe Hash do
   describe 'readme' do
     describe '#chain_fetch' do
@@ -357,9 +361,14 @@ describe Hash do
         expect(hash.sort_keys.keys)
           .to eq(%i[a b])
       end
+
+      it 'does not change the original hash' do
+        expect { hash.sort_keys }
+          .not_to change(hash, :keys)
+      end
     end
 
-    describe '#sort_keys' do
+    describe '#sort_keys!' do
       subject(:hash) { { b: 1, a: 2 } }
 
       it 'sort hash keys' do

data/spec/integration/yard/darthjee/core_ext/array_spec.rb

@@ -20,7 +20,7 @@ describe Array do
       let(:array) { [{ a: { b: 1 }, b: 2 }, { a: { b: 3 }, b: 4 }] }
 
       describe 'when passing just the first key' do
-        it 'returns the array mapped ' do
+        it 'returns the array mapped' do
           expect(array.mapk(:a)).to eq([{ b: 1 }, { b: 3 }])
         end
       end

data/spec/integration/yard/darthjee/core_ext/class/default_value_spec.rb

@@ -19,8 +19,8 @@ describe Class do
         end
 
         it 'returns the same instance accros instances of the class' do
-          expect(instance.name).not_to be_equal('John')
-          expect(instance.name).to be_equal(klass.new.name)
+          expect(instance.name).not_to equal('John')
+          expect(instance.name).to equal(klass.new.name)
         end
       end
     end
@@ -42,13 +42,13 @@ describe Class do
         end
 
         it 'returns the same instance accros instances of the class' do
-          expect(instance.name).not_to be_equal('John')
-          expect(instance.name).to be_equal(klass.new.name)
+          expect(instance.name).not_to equal('John')
+          expect(instance.name).to equal(klass.new.name)
         end
 
         it 'returns the same instance for all methods' do
-          expect(instance.nick_name).not_to be_equal('John')
-          expect(instance.name).to be_equal(instance.nick_name)
+          expect(instance.nick_name).not_to equal('John')
+          expect(instance.name).to equal(instance.nick_name)
         end
       end
     end
@@ -57,6 +57,7 @@ describe Class do
       let(:klass) do
         Class.new do
           attr_writer :name
+
           default_reader :name, 'John Doe'
         end
       end
@@ -96,6 +97,7 @@ describe Class do
       let(:klass) do
         Class.new do
           attr_writer :cars, :houses
+
           default_readers :cars, :houses, 'none'
         end
       end
@@ -134,8 +136,8 @@ describe Class do
         end
 
         it 'returns the same instance for all methods' do
-          expect(instance.cars).not_to be_equal('none')
-          expect(instance.cars).to be_equal(instance.houses)
+          expect(instance.cars).not_to equal('none')
+          expect(instance.cars).to equal(instance.houses)
         end
       end
     end

data/spec/integration/yard/darthjee/core_ext/hash/deep_hash_constructor_spec.rb

@@ -10,10 +10,10 @@ describe Darthjee::CoreExt::Hash::DeepHashConstructor do
       {
         'account.person.name[0]' => 'John',
         'account.person.name[1]' => 'Wick',
-        'account.person.age'     =>  20,
-        'account.number'         => '102030',
-        :'house.number'          => 67,
-        :'house.zip'             => 12_345
+        'account.person.age' => 20,
+        'account.number' => '102030',
+        :'house.number' => 67,
+        :'house.zip' => 12_345
       }
     end
 
@@ -22,14 +22,14 @@ describe Darthjee::CoreExt::Hash::DeepHashConstructor do
         {
           'account' => {
             'person' => {
-              'name'   => %w[John Wick],
-              'age'    =>  20
+              'name' => %w[John Wick],
+              'age' => 20
             },
             'number' => '102030'
           },
           'house' => {
             'number' => 67,
-            'zip'    => 12_345
+            'zip' => 12_345
           }
         }
       end
@@ -46,12 +46,12 @@ describe Darthjee::CoreExt::Hash::DeepHashConstructor do
           'account' => {
             %w[person name[0]] => 'John',
             %w[person name[1]] => 'Wick',
-            %w[person age]     =>  20,
-            %w[number]         => '102030'
+            %w[person age] => 20,
+            %w[number] => '102030'
           },
           'house' => {
             %w[number] => 67,
-            %w[zip]    => 12_345
+            %w[zip] => 12_345
           }
         }
       end

data/spec/integration/yard/darthjee/core_ext/hash/squasher_spec.rb

@@ -21,10 +21,10 @@ describe Darthjee::CoreExt::Hash::Squasher do
         {
           'person[0].name[0]' => 'John',
           'person[0].name[1]' => 'Wick',
-          'person[0].age'     => 22,
+          'person[0].age' => 22,
           'person[1].name[0]' => 'John',
           'person[1].name[1]' => 'Constantine',
-          'person[1].age'     => 25
+          'person[1].age' => 25
         }
       end
 
@@ -48,7 +48,7 @@ describe Darthjee::CoreExt::Hash::Squasher do
       let(:expected) do
         {
           'person> name' => 'John',
-          'person> age'  => 22
+          'person> age' => 22
         }
       end
 

data/spec/integration/yard/darthjee/core_ext/hash/transformable_spec.rb

@@ -21,7 +21,7 @@ describe Hash do
       end
     end
 
-    describe '#exclusive_merge' do
+    describe '#exclusive_merge!' do
       subject(:hash) { { a: 1, b: 2, c: 3 } }
 
       let(:other)    { { b: 4, 'c' => 5, e: 6 } }
@@ -86,9 +86,9 @@ describe Hash do
       subject(:hash) do
         {
           'person[0]_name_first' => 'John',
-          'person[0]_name_last'  => 'Doe',
+          'person[0]_name_last' => 'Doe',
           'person[1]_name_first' => 'John',
-          'person[1]_name_last'  => 'Wick'
+          'person[1]_name_last' => 'Wick'
         }
       end
 

data/spec/integration/yard/darthjee/core_ext/hash/transposeable_spec.rb

@@ -22,7 +22,7 @@ describe Darthjee::CoreExt::Hash::Transposeable do
       end
     end
 
-    describe '#transpose' do
+    describe '#transpose!' do
       it 'transpose rows and keys' do
         expect { hash.transpose! }.to change { hash }
           .to(

data/spec/integration/yard/darthjee/core_ext/hash/value_changer_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 describe Darthjee::CoreExt::Hash::ValueChanger do
   describe 'yard' do
-    subject(:changer) { described_class.new(options, &block) }
+    subject(:changer) { described_class.new(**options, &block) }
 
     describe '#initialize' do
       let(:options) { { recursive: false, skip_inner: false } }

data/spec/lib/array_spec.rb

@@ -201,6 +201,7 @@ describe Array do
         end
 
         it { expect(value).to eq('2') }
+
         it 'calls the mapping only until it returns a valid value' do
           expect(transformer).to have_received(:transform).exactly(2)
         end
@@ -267,7 +268,7 @@ describe Array do
           filtered
         end
 
-        it { expect(filtered).to eq(array[1..-1].map(&:to_s)) }
+        it { expect(filtered).to eq(array[1..].map(&:to_s)) }
 
         it 'calls the mapping only once per element' do
           expect(transformer).to have_received(:transform).exactly(4)

data/spec/lib/darthjee/core_ext/hash/value_changer_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Darthjee::CoreExt::Hash::ValueChanger do
-  subject(:changer) { described_class.new(options, &block) }
+  subject(:changer) { described_class.new(**options, &block) }
 
   let(:block) { proc { |value| value.to_s.size } }
 

data/spec/lib/hash_spec.rb

@@ -216,12 +216,6 @@ describe Hash do
       it { expect(list).not_to be_empty }
     end
 
-    context 'when mapping returns empty arrays' do
-      let(:block) { proc { [] } }
-
-      it { expect(list).not_to be_empty }
-    end
-
     context 'when mapping returns empty strings' do
       let(:block) { proc { '' } }
 
@@ -259,7 +253,7 @@ describe Hash do
           list
         end
 
-        it { expect(list).to eq(hash.values[1..-1].map(&:to_s)) }
+        it { expect(list).to eq(hash.values[1..].map(&:to_s)) }
 
         it 'calls the mapping only once for each value' do
           expect(transformer).to have_received(:transform).exactly(4)

data/spec/lib/symbol_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 describe Symbol do
   describe '#camelize' do
-    it { expect(:sym.camelize).to be_kind_of(described_class) }
+    it { expect(:sym.camelize).to be_a(described_class) }
 
     context 'when called with upper option' do
       it 'camelize the symbol' do
@@ -26,7 +26,7 @@ describe Symbol do
   end
 
   describe '#underscore' do
-    it { expect(:symBol.underscore).to be_kind_of(described_class) }
+    it { expect(:symBol.underscore).to be_a(described_class) }
 
     context 'when called with upper option' do
       it 'underscore the symbol' do

data/spec/spec_helper.rb

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
 require 'simplecov'
+require 'simplecov_json_formatter'
 
-SimpleCov.profiles.define 'gem' do
+SimpleCov.start do
   add_filter '/spec/'
+
+  SimpleCov.formatter = SimpleCov::Formatter::JSONFormatter if ENV['COVERAGE_JSON'] == 'true'
 end
 
-SimpleCov.start 'gem'
 require 'pry-nav'
 require 'darthjee/core_ext'
 

data/spec/support/models/client.rb

@@ -9,7 +9,8 @@ class Client
     requested << id
 
     return unless existing_ids.include?(id)
-    { id: id }
+
+    { id: }
   end
 
   def requested

data/spec/support/models/dummy_iterator.rb

@@ -5,11 +5,11 @@ class DummyIterator
     @array = array
   end
 
-  def map(*args, &block)
-    @array.map(*args, &block)
+  def map(*, &)
+    @array.map(*, &)
   end
 
-  def each(*args, &block)
-    @array.each(*args, &block)
+  def each(*, &)
+    @array.each(*, &)
   end
 end

data/spec/support/models/hash/value_changer/dummy.rb

@@ -18,6 +18,7 @@ class Hash
       def eql?(other)
         return true if equals?(other)
         return false unless other.is_a?(self.class)
+
         a.value == value
       end
     end

data/spec/support/shared_examples/array/array_random.rb

@@ -3,13 +3,12 @@
 shared_examples 'a method that returns a random element' do |method|
   let(:array) { [7, 5, 3] }
 
-  (0..2).each do |index|
+  3.times do |index|
     context "when random returns #{index}" do
       let!(:expected) { array[index] }
 
       before do
-        allow(Random).to receive(:rand)
-          .with(array.size) { index }
+        allow(Random).to receive(:rand).and_return(index)
       end
 
       it 'returns the randomized index of the array' do

data/spec/support/shared_examples/hash/chain_hash_keys_changer.rb

@@ -60,7 +60,7 @@ shared_examples 'a method that is able to chain change keys' do |method|
     end
 
     context 'when options are given' do
-      let(:options) { { recursive: recursive } }
+      let(:options) { { recursive: } }
 
       context 'with recursion' do
         let(:recursive) { true }

data/spec/support/shared_examples/hash/hash_keys_changer.rb

@@ -27,7 +27,7 @@ end
 
 shared_examples 'a method that is able to change keys' do |method|
   let(:foo_sym_transformation) do
-    hash.public_send(method) { |k| "foo_#{k}".to_sym }
+    hash.public_send(method) { |k| :"foo_#{k}" }
   end
 
   context 'with simple level hash' do
@@ -52,7 +52,7 @@ shared_examples 'a method that is able to change keys' do |method|
 
   context 'with recursive hash' do
     let(:hash) { { 'a' => 1, b: { c: 3, 'd' => 4 } } }
-    let(:result) { hash.public_send(method, options) { |k| "foo_#{k}" } }
+    let(:result) { hash.public_send(method, **options) { |k| "foo_#{k}" } }
     let(:expected) do
       { 'foo_a' => 1, 'foo_b' => { 'foo_c' => 3, 'foo_d' => 4 } }
     end
@@ -64,7 +64,7 @@ shared_examples 'a method that is able to change keys' do |method|
     end
 
     context 'when options are given' do
-      let(:options) { { recursive: recursive } }
+      let(:options) { { recursive: } }
 
       context 'with recursion' do
         let(:recursive) { true }

data/spec/support/shared_examples/hash/map_to_hash.rb

@@ -4,7 +4,7 @@ shared_examples 'an array with map_to_hash method' do
   describe '#map_to_hash' do
     subject(:hash) { %w[word1 wooord2] }
 
-    let(:mapping_block) { proc { |word| word.length } }
+    let(:mapping_block) { proc(&:length) }
     let(:mapped)        { hash.map_to_hash(&mapping_block) }
     let(:expected)      { { 'word1' => 5, 'wooord2' => 7 } }
 

data/spec/support/shared_examples/hash/remap.rb

@@ -57,18 +57,18 @@ shared_examples 'a method that remaps the keys' do |method|
     end
   end
 
-  context 'when remap has original array keys' do
+  context 'when remap swap keys' do
     let(:remap) { { b: :a, a: :b } }
 
-    it 'does not remap the keys' do
+    it 'swap keys' do
       expect(result).to eq(b: 1, a: 2)
     end
   end
 
-  context 'when remap has original array keys' do
+  context 'when remap has one of the keys swapped' do
     let(:remap) { { a: :b, b: :c } }
 
-    it 'does not remap the keys' do
+    it 'swap just that key' do
       expect(result).to eq(b: 1, c: 2)
     end
   end

data/spec/support/shared_examples/hash/value_changer.rb

@@ -103,7 +103,7 @@ shared_examples 'a method that change the hash values' do |method|
 
     it 'ignore hash and does not work recursively when option is passed' do
       options = { skip_inner: false, recursive: false }
-      result = hash.public_send(method, options) do |value|
+      result = hash.public_send(method, **options) do |value|
         value.is_a?(Hash) ? value : value + 1
       end
       expect(result).to eq(a: 2, b: 3, c: { d: 3, e: 4 })
@@ -142,7 +142,7 @@ shared_examples 'a method that change the hash values' do |method|
 
     it 'ignore hash and does not work recursively when option is passed' do
       options = { skip_inner: false, recursive: false }
-      result = hash.public_send(method, options) do |value|
+      result = hash.public_send(method, **options) do |value|
         value.is_a?(Array) ? value : value + 1
       end
       expect(result).to eq(a: 2, b: 3, c: [{ d: 3 }, { e: { f: 4 } }, 5])