darthjee-core_ext 1.7.4 → 3.0.0

data/spec/lib/darthjee/core_ext/hash/deep_hash_constructor_spec.rb

@@ -3,167 +3,27 @@
 require 'spec_helper'
 
 describe Darthjee::CoreExt::Hash::DeepHashConstructor do
-  let(:subject)   { described_class.new('.') }
-  let(:deep_hash) { subject.deep_hash(hash) }
+  subject(:constructor) { described_class.new('.') }
 
-  describe '.deep_hash' do
-    let(:hash) do
-      {
-        'person.name' => 'Some name',
-        'person.age' => 22,
-        'status' => :success,
-        'vehicle.fuel' => 'GASOLINE',
-        'vehicle.doors' => 4
-      }
-    end
-
-    let(:expected) do
-      {
-        'person' => { 'name' => 'Some name', 'age' => 22 },
-        'vehicle' => { 'fuel' => 'GASOLINE', 'doors' => 4 },
-        'status' => :success
-      }
-    end
-
-    it 'build a deep hash' do
-      expect(deep_hash).to eq(expected)
-    end
-
-    context 'with indexed keys' do
-      let(:hash) do
-        {
-          'person[0].name' => 'First person',
-          'person[0].age' => 22,
-          'person[1].name' => 'Second person',
-          'person[1].age' => 27,
-          'device[0]' => 'GEAR_LOCK',
-          'device[1]' => 'GPS',
-          'zipCode' => '122345-123'
-        }
-      end
-
-      let(:expected) do
-        {
-          'person' => [
-            { 'name' => 'First person', 'age' => 22 },
-            { 'name' => 'Second person', 'age' => 27 }
-          ],
-          'device' => %w[GEAR_LOCK GPS],
-          'zipCode' => '122345-123'
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(deep_hash).to eq(expected)
-      end
-    end
-
-    context 'with a n level hash' do
-      let(:hash) do
-        {
-          'quote_request.personal.person.name' => 'Some name',
-          'quote_request.personal.person.age' => 22,
-          'quote_request.insurance.vehicle.fuel' => 'GASOLINE',
-          'quote_request.insurance.vehicle.doors' => 4,
-          'request.status' => :success,
-          'trials' => 3
-        }
-      end
-
-      let(:expected) do
-        {
-          'quote_request' => {
-            'personal' => {
-              'person' => { 'name' => 'Some name', 'age' => 22 }
-            },
-            'insurance' => {
-              'vehicle' => { 'fuel' => 'GASOLINE', 'doors' => 4 }
-            }
-          },
-          'request' => { 'status' => :success },
-          'trials' => 3
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(deep_hash).to eq(expected)
-      end
-    end
-
-    context 'with a n level hash and arrays' do
-      let(:hash) do
-        {
-          'quote_request.personal.person[0].name' => 'Some name 1',
-          'quote_request.personal.person[0].age' => 22,
-          'quote_request.personal.person[1].name' => 'Some name 2',
-          'quote_request.personal.person[1].age' => 23,
-          'request[0].status.clazz' => String,
-          'request[1].status.clazz' => Integer,
-          'request[2].status.clazz' => Date,
-          'trials' => 3
-        }
-      end
-
-      let(:expected) do
-        {
-          'quote_request' => {
-            'personal' => {
-              'person' => [
-                { 'name' => 'Some name 1', 'age' => 22 },
-                { 'name' => 'Some name 2', 'age' => 23 }
-              ]
-            }
-          },
-          'request' => [
-            { 'status' => { 'clazz' => String } },
-            { 'status' => { 'clazz' => Integer } },
-            { 'status' => { 'clazz' => Date } }
-          ],
-          'trials' => 3
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(deep_hash).to eq(expected)
-      end
-    end
+  let(:hash) do
+    {
+      'person.name' => 'John',
+      'person.age' => '22'
+    }
+  end
 
-    context 'with custom separator' do
-      let(:subject) { described_class.new('_') }
-      let(:hash) do
-        {
-          'person_name' => 'Some name',
-          'person_age' => 22,
-          'status' => :success,
-          'vehicle_fuel' => 'GASOLINE',
-          'vehicle_doors' => 4
-        }
-      end
+  describe '#deep_hash' do
+    it_behaves_like 'a method that returns a deep hash' do
+      subject(:constructor) { described_class.new(*args) }
 
-      it 'build a deep hash with arrays' do
-        expect(deep_hash).to eq(expected)
-      end
+      let(:result) { constructor.deep_hash(hash) }
     end
 
-    context 'with custom separator on n level deep hash' do
-      let(:subject) { described_class.new('_') }
-      let(:hash) do
-        {
-          'person_name_clazz' => String
-        }
-      end
-
-      let(:expected) do
-        {
-          'person' => {
-            'name' => { 'clazz' => String }
-          }
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(deep_hash).to eq(expected)
-      end
+    it 'does changes hash' do
+      expect { constructor.deep_hash(hash) }
+        .to change { hash }
+        .from('person.name' => 'John', 'person.age' => '22')
+        .to('person' => { 'name' => 'John', 'age' => '22' })
     end
   end
 end

data/spec/lib/darthjee/core_ext/hash/keys_sorter_spec.rb

@@ -3,9 +3,10 @@
 require 'spec_helper'
 
 describe Darthjee::CoreExt::Hash::KeysSorter do
-  it_behaves_like 'a class with a keys sort method' do
-    subject { described_class.new(hash, **options) }
+  subject { described_class.new(hash, **options) }
 
-    let(:result) { subject.sort }
-  end
+  let(:result) { subject.sort }
+
+  it_behaves_like 'a class with a keys sort method'
+  it_behaves_like 'a class with a keys sort method that changes original'
 end

data/spec/lib/darthjee/core_ext/hash/squasher_spec.rb

@@ -3,7 +3,13 @@
 require 'spec_helper'
 
 describe Darthjee::CoreExt::Hash::Squasher do
-  it_behaves_like 'a class that has a method to squash a hash' do
-    let(:squashed) { described_class.squash(hash) }
+  describe '#squash' do
+    it_behaves_like 'a method to squash a hash' do
+      let(:squashed) { described_class.new.squash(hash) }
+    end
+
+    it_behaves_like 'a method to squash a hash', '/' do
+      let(:squashed) { described_class.new('/').squash(hash) }
+    end
   end
 end

data/spec/lib/darthjee/core_ext/hash/value_changer_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Darthjee::CoreExt::Hash::ValueChanger do
-  subject(:changer) { described_class.new(options, &block) }
+  subject(:changer) { described_class.new(**options, &block) }
 
   let(:block) { proc { |value| value.to_s.size } }
 
@@ -216,8 +216,8 @@ describe Darthjee::CoreExt::Hash::ValueChanger do
         expect(changer.change(object)).to eq(expected)
       end
 
-      it 'does not change original array' do
-        expect { changer.change(object) }.not_to(change { array })
+      it 'change original array' do
+        expect { changer.change(object) }.to(change { array })
       end
     end
 
@@ -230,16 +230,8 @@ describe Darthjee::CoreExt::Hash::ValueChanger do
         expect(changer.change(object)).to eq(expected)
       end
 
-      it 'does not change original array' do
-        expect { changer.change(object) }.not_to(change { array })
-      end
-    end
-
-    context 'when object is not an array or hash' do
-      let(:object) { Object.new }
-
-      it 'returns object' do
-        expect(changer.change(object)).to eq(object)
+      it 'changes original array' do
+        expect { changer.change(object) }.to(change { array })
       end
     end
   end

data/spec/lib/hash_spec.rb

@@ -16,16 +16,64 @@ describe Hash do
     let(:result) { hash.chain_fetch(*keys, &block) }
   end
 
-  it_behaves_like 'a class that has a method to squash a hash' do
-    let(:squashed) { hash.squash }
+  describe '#squash' do
+    subject(:hash) { { a: { b: { c: 10 } } } }
+
+    it_behaves_like 'a method to squash a hash' do
+      let(:squashed) { hash.squash }
+    end
+
+    it_behaves_like 'a method to squash a hash', '/' do
+      let(:squashed) { hash.squash('/') }
+    end
+
+    it 'does not change the hash' do
+      expect { hash.squash }
+        .not_to(change { hash })
+    end
+  end
+
+  describe '#squash!' do
+    subject(:hash) { { a: { b: { c: 10 } } } }
+
+    it_behaves_like 'a method to squash a hash' do
+      let(:squashed) { hash.squash! }
+    end
+
+    it_behaves_like 'a method to squash a hash', '/' do
+      let(:squashed) { hash.squash!('/') }
+    end
+
+    it 'does not change the hash' do
+      expect { hash.squash! }
+        .to change { hash }
+        .from(a: { b: { c: 10 } })
+        .to('a.b.c' => 10)
+    end
   end
 
   it_behaves_like 'a hash with map_to_hash method' do
     let(:mapped) { hash.map_to_hash(&mapping_block) }
   end
 
-  it_behaves_like 'a class with a keys sort method' do
-    let(:result) { hash.sort_keys(**options) }
+  describe '#sort_keys!' do
+    it_behaves_like 'a class with a keys sort method' do
+      let(:result) { hash.sort_keys!(**options) }
+    end
+
+    it_behaves_like 'a class with a keys sort method that changes original' do
+      let(:result) { hash.sort_keys!(**options) }
+    end
+  end
+
+  describe '#sort_keys' do
+    it_behaves_like 'a class with a keys sort method' do
+      let(:result) { hash.sort_keys(**options) }
+    end
+
+    it_behaves_like 'a class with a keys sort method that not change self' do
+      let(:result) { hash.sort_keys(**options) }
+    end
   end
 
   describe '#exclusive_merge' do
@@ -59,159 +107,38 @@ describe Hash do
   describe '#to_deep_hash' do
     subject(:hash) do
       {
-        'person.name' => 'Some name',
-        'person.age' => 22,
-        'status' => :success,
-        'vehicle.fuel' => 'GASOLINE',
-        'vehicle.doors' => 4
+        'person.name' => 'John',
+        'person.age' => '22'
       }
     end
 
-    let(:expected) do
-      {
-        'person' => { 'name' => 'Some name', 'age' => 22 },
-        'vehicle' => { 'fuel' => 'GASOLINE', 'doors' => 4 },
-        'status' => :success
-      }
-    end
-
-    it 'build a deep hash' do
-      expect(hash.to_deep_hash).to eq(expected)
-    end
-
-    context 'with indexed keys' do
-      subject(:hash) do
-        {
-          'person[0].name' => 'First person',
-          'person[0].age' => 22,
-          'person[1].name' => 'Second person',
-          'person[1].age' => 27,
-          'device[0]' => 'GEAR_LOCK',
-          'device[1]' => 'GPS',
-          'zipCode' => '122345-123'
-        }
-      end
-
-      let(:expected) do
-        {
-          'person' => [
-            { 'name' => 'First person', 'age' => 22 },
-            { 'name' => 'Second person', 'age' => 27 }
-          ],
-          'device' => %w[GEAR_LOCK GPS],
-          'zipCode' => '122345-123'
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(hash.to_deep_hash).to eq(expected)
-      end
+    it_behaves_like 'a method that returns a deep hash' do
+      let(:result) { hash.to_deep_hash(*args) }
     end
 
-    context 'with a n level hash' do
-      subject(:hash) do
-        {
-          'quote_request.personal.person.name' => 'Some name',
-          'quote_request.personal.person.age' => 22,
-          'quote_request.insurance.vehicle.fuel' => 'GASOLINE',
-          'quote_request.insurance.vehicle.doors' => 4,
-          'request.status' => :success,
-          'trials' => 3
-        }
-      end
-
-      let(:expected) do
-        {
-          'quote_request' => {
-            'personal' => {
-              'person' => { 'name' => 'Some name', 'age' => 22 }
-            },
-            'insurance' => {
-              'vehicle' => { 'fuel' => 'GASOLINE', 'doors' => 4 }
-            }
-          },
-          'request' => { 'status' => :success },
-          'trials' => 3
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(hash.to_deep_hash).to eq(expected)
-      end
+    it 'does not change hash' do
+      expect { hash.to_deep_hash }
+        .not_to(change { hash })
     end
+  end
 
-    context 'with a n level hash and arrays' do
-      subject(:hash) do
-        {
-          'quote_request.personal.person[0].name' => 'Some name 1',
-          'quote_request.personal.person[0].age' => 22,
-          'quote_request.personal.person[1].name' => 'Some name 2',
-          'quote_request.personal.person[1].age' => 23,
-          'request[0].status.clazz' => String,
-          'request[1].status.clazz' => Integer,
-          'request[2].status.clazz' => Date,
-          'trials' => 3
-        }
-      end
-
-      let(:expected) do
-        {
-          'quote_request' => {
-            'personal' => {
-              'person' => [
-                { 'name' => 'Some name 1', 'age' => 22 },
-                { 'name' => 'Some name 2', 'age' => 23 }
-              ]
-            }
-          },
-          'request' => [
-            { 'status' => { 'clazz' => String } },
-            { 'status' => { 'clazz' => Integer } },
-            { 'status' => { 'clazz' => Date } }
-          ],
-          'trials' => 3
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(hash.to_deep_hash).to eq(expected)
-      end
+  describe '#to_deep_hash!' do
+    subject(:hash) do
+      {
+        'person.name' => 'John',
+        'person.age' => '22'
+      }
     end
 
-    context 'with custom separator' do
-      subject(:hash) do
-        {
-          'person_name' => 'Some name',
-          'person_age' => 22,
-          'status' => :success,
-          'vehicle_fuel' => 'GASOLINE',
-          'vehicle_doors' => 4
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(hash.to_deep_hash('_')).to eq(expected)
-      end
+    it_behaves_like 'a method that returns a deep hash' do
+      let(:result) { hash.to_deep_hash!(*args) }
     end
 
-    context 'with custom separator on n level deep hash' do
-      subject(:hash) do
-        {
-          'person_name_clazz' => String
-        }
-      end
-
-      let(:expected) do
-        {
-          'person' => {
-            'name' => { 'clazz' => String }
-          }
-        }
-      end
-
-      it 'build a deep hash with arrays' do
-        expect(hash.to_deep_hash('_')).to eq(expected)
-      end
+    it 'does changes hash' do
+      expect { hash.to_deep_hash! }
+        .to change { hash }
+        .from('person.name' => 'John', 'person.age' => '22')
+        .to('person' => { 'name' => 'John', 'age' => '22' })
     end
   end
 
@@ -283,6 +210,18 @@ describe Hash do
       it { expect(list).to be_empty }
     end
 
+    context 'when mapping returns empty arrays' do
+      let(:block) { proc { [] } }
+
+      it { expect(list).not_to be_empty }
+    end
+
+    context 'when mapping returns empty strings' do
+      let(:block) { proc { '' } }
+
+      it { expect(list).not_to be_empty }
+    end
+
     context 'when block returns false' do
       let(:block) { proc { false } }
 
@@ -314,7 +253,8 @@ describe Hash do
           list
         end
 
-        it { expect(list).to eq(hash.values[1..-1].map(&:to_s)) }
+        it { expect(list).to eq(hash.values[1..].map(&:to_s)) }
+
         it 'calls the mapping only once for each value' do
           expect(transformer).to have_received(:transform).exactly(4)
         end

data/spec/lib/object_spec.rb

@@ -34,4 +34,36 @@ describe Object do
       end
     end
   end
+
+  # rubocop: disable RSpec/PredicateMatcher
+  describe '#trueful?' do
+    context 'when object is an empty array' do
+      it { expect([].trueful?).to be_truthy }
+    end
+
+    context 'when object is an empty hash' do
+      it { expect({}.trueful?).to be_truthy }
+    end
+
+    context 'when object is an empty string' do
+      it { expect(''.trueful?).to be_truthy }
+    end
+
+    context 'when object is a simple object' do
+      it { expect(described_class.new.trueful?).to be_truthy }
+    end
+
+    context 'when object is true' do
+      it { expect(true.trueful?).to be_truthy }
+    end
+
+    context 'when object is nil' do
+      it { expect(nil.trueful?).not_to be_truthy }
+    end
+
+    context 'when object is false' do
+      it { expect(false.trueful?).not_to be_truthy }
+    end
+  end
+  # rubocop: enable RSpec/PredicateMatcher
 end

data/spec/lib/symbol_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 describe Symbol do
   describe '#camelize' do
-    it { expect(:sym.camelize).to be_kind_of(described_class) }
+    it { expect(:sym.camelize).to be_a(described_class) }
 
     context 'when called with upper option' do
       it 'camelize the symbol' do
@@ -26,7 +26,7 @@ describe Symbol do
   end
 
   describe '#underscore' do
-    it { expect(:symBol.underscore).to be_kind_of(described_class) }
+    it { expect(:symBol.underscore).to be_a(described_class) }
 
     context 'when called with upper option' do
       it 'underscore the symbol' do

data/spec/spec_helper.rb

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
 require 'simplecov'
+require 'simplecov_json_formatter'
 
-SimpleCov.profiles.define 'gem' do
+SimpleCov.start do
   add_filter '/spec/'
+
+  SimpleCov.formatter = SimpleCov::Formatter::JSONFormatter if ENV['COVERAGE_JSON'] == 'true'
 end
 
-SimpleCov.start 'gem'
 require 'pry-nav'
 require 'darthjee/core_ext'
 

data/spec/support/models/client.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+class Client
+  def initialize(existing_ids)
+    @existing_ids = existing_ids
+  end
+
+  def request(id)
+    requested << id
+
+    return unless existing_ids.include?(id)
+
+    { id: }
+  end
+
+  def requested
+    @requested ||= []
+  end
+
+  private
+
+  attr_reader :existing_ids
+end

data/spec/support/models/dummy_iterator.rb

@@ -5,11 +5,11 @@ class DummyIterator
     @array = array
   end
 
-  def map(*args, &block)
-    @array.map(*args, &block)
+  def map(*, &)
+    @array.map(*, &)
   end
 
-  def each(*args, &block)
-    @array.each(*args, &block)
+  def each(*, &)
+    @array.each(*, &)
   end
 end

data/spec/support/models/hash/value_changer/dummy.rb

@@ -18,6 +18,7 @@ class Hash
       def eql?(other)
         return true if equals?(other)
         return false unless other.is_a?(self.class)
+
         a.value == value
       end
     end

data/spec/support/shared_examples/array/array_random.rb

@@ -3,13 +3,12 @@
 shared_examples 'a method that returns a random element' do |method|
   let(:array) { [7, 5, 3] }
 
-  (0..2).each do |index|
+  3.times do |index|
     context "when random returns #{index}" do
       let!(:expected) { array[index] }
 
       before do
-        allow(Random).to receive(:rand)
-          .with(array.size) { index }
+        allow(Random).to receive(:rand).and_return(index)
       end
 
       it 'returns the randomized index of the array' do

data/spec/support/shared_examples/hash/chain_hash_keys_changer.rb

@@ -60,7 +60,7 @@ shared_examples 'a method that is able to chain change keys' do |method|
     end
 
     context 'when options are given' do
-      let(:options) { { recursive: recursive } }
+      let(:options) { { recursive: } }
 
       context 'with recursion' do
         let(:recursive) { true }