darthjee-core_ext 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e119db2a6c2d8eb97f42b48b82500d93f81665fb
-  data.tar.gz: 9fa9cbda6ad8a1feef1f57eb917df0b0391d8a52
+  metadata.gz: 5e4db49fb26170a6468253694dc8710568992db8
+  data.tar.gz: 903f2881ee71e1af4ee05d2e3715e9b3de77f347
 SHA512:
-  metadata.gz: 4f904ea861ca6e47029632718356f0802d4f828bb4343ea5fd14db142406a6ec95c4462c28b2010bab2eb410af6b71539a08e87e34ec5cc849062239f8f05529
-  data.tar.gz: 90afdb065d5f08e91ee76927ff2487d0f848ae903af8c036f42ac89e318a1b34b2b24f2343165b2aff9059197a6a066012763252159028642e57518a7039af8f
+  metadata.gz: bf30dc4d88125615001e78ee47801387b850df4923a002c18b8a00b28f611725c7c1ece40f29a85ee809d5ef44105f6943a0a8451537b8104d09142558462250
+  data.tar.gz: 918aad79466a050cd855c59eb48022314c0ac4532389b3f0b82b0bbefd5ab342544a6c71a3bec1d0edc46fe257e37f4db8c896e3bb4e58c847126b039a7f4c92

data/.gitignore

@@ -1,2 +1,3 @@
 coverage
 pkg
+Gemfile.lock

data/README.md

@@ -1,6 +1,10 @@
 Core_Ext
 ========
 
+[![Code Climate](https://codeclimate.com/github/darthjee/core_ext/badges/gpa.svg)](https://codeclimate.com/github/darthjee/core_ext)
+[![Test Coverage](https://codeclimate.com/github/darthjee/core_ext/badges/coverage.svg)](https://codeclimate.com/github/darthjee/core_ext/coverage)
+[![Issue Count](https://codeclimate.com/github/darthjee/core_ext/badges/issue_count.svg)](https://codeclimate.com/github/darthjee/core_ext)
+
 # Usage
 This project adds some new methods to the core ruby classes
 
@@ -20,7 +24,7 @@ gem 'darthjee-core_ext'
 bundle install darthjee-core_ext
 ```
 
-#methods added
+# methods added
 
 ## Array
 [ARRAY_README.md](ARRAY_README.md)

data/circle.yml

@@ -0,0 +1,10 @@
+dependencies:
+  post:
+    - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+    - chmod +x ./cc-test-reporter
+
+test:
+  pre:
+    - ./cc-test-reporter before-build
+  override:
+    - bundle exec rspec; ./cc-test-reporter after-build --exit-code $?

data/lib/darthjee/core_ext/version.rb

@@ -1,5 +1,5 @@
 module Darthjee
   module CoreExt
-    VERSION = '1.3.0'
+    VERSION = '1.3.1'
   end
 end

data/lib/hash/value_changer.rb

@@ -30,15 +30,16 @@ class Hash::ValueChanger
   end
 
   def change_array(array)
-    array = array.to_a
+    method = %w(map! map).find { |m| array.respond_to? m }
 
-    array.each.with_index do |value, index|
+    array.public_send(method) do |value|
       if value.respond_to?(:change_values)
-        value = value.change_values(options, &block)
+        value.change_values(options, &block)
       elsif is_iterable?(value)
-        value = change_array(value)
+        change_array(value)
+      else
+        new_value(value)
       end
-      array[index] = value
     end
   end
 

data/spec/support/models/hash/value_changer/dummy.rb

@@ -7,6 +7,10 @@ class Hash::ValueChanger::Dummy
     @value = value
   end
 
+  def as_json
+    { val: value }
+  end
+
   def eql?(other)
     return true if equals?(other)
     return false unless other.is_a?(self.class)

data/spec/support/models/hash/value_changer/dummy_iteractor.rb

@@ -3,7 +3,7 @@ class Hash::ValueChanger::DummyIteractor
     @array = array
   end
 
-  delegate :each, :to_a, to: :array
+  delegate :each, :map, :to_a, to: :array
 
   private
 

data/spec/support/shared_examples/value_changer.rb

@@ -1,5 +1,6 @@
 shared_examples 'a class with change_values method' do
   let(:subject) { { a: 1, b: 2, c: { d: 3, e: 4 } } }
+  let(:inner_hash) { subject[:c] }
 
   describe :change_values do
     it_behaves_like 'a method that change the hash values', :change_values
@@ -9,6 +10,23 @@ shared_examples 'a class with change_values method' do
         subject.change_values { |value| value + 1 }
       end.not_to change { subject }
     end
+
+    it 'does not change original hash' do
+      expect do
+        subject.change_values { |value| value + 1 }
+      end.not_to change { inner_hash }
+    end
+
+    context 'when using an array' do
+      let(:subject) { { a: [{ b: 1}]} }
+      let(:inner_array) { subject[:a] }
+
+      it 'does not change original hash' do
+        expect do
+          subject.change_values { |value| value + 1 }
+        end.not_to change { inner_array }
+      end
+    end
   end
 
   describe :change_values! do
@@ -19,6 +37,23 @@ shared_examples 'a class with change_values method' do
         subject.change_values! { |value| value + 1 }
       end.to change { subject }
     end
+
+    it 'changes original hash' do
+      expect do
+        subject.change_values! { |value| value + 1 }
+      end.to change { inner_hash }
+    end
+
+    context 'when using an array' do
+      let(:subject) { { a: [{ b: 1}]} }
+      let(:inner_array) { subject[:a] }
+
+      it 'changes original hash' do
+        expect do
+          subject.change_values! { |value| value + 1 }
+        end.to change { inner_array }
+      end
+    end
   end
 end
 
@@ -50,26 +85,26 @@ shared_examples 'a method that change the hash values' do |method|
   end
 
   context 'when using deeply nested arrays' do
-    let(:subject) { { a: 1, b: 2, c: [{ d: 3 }, { e: { f: 4 } } ] } }
+    let(:subject) { { a: 1, b: 2, c: [{ d: 3 }, { e: { f: 4 } }, 5 ] } }
 
     it 'goes recursivly true arrays' do
-      expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: { f: 5 } }])
+      expect(subject.public_send(method) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: { f: 5 } }, 6])
     end
 
     it 'does not work recursively when parameter is passed as false' do
-      expect(subject.public_send(method, recursive: false) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 3 }, { e: { f: 4 } }])
+      expect(subject.public_send(method, recursive: false) { |value| value + 1 }).to eq(a: 2, b: 3, c: [{ d: 3 }, { e: { f: 4 } }, 5])
     end
 
     it 'does not ignore array when option is passed' do
-      expect(subject.public_send(method, skip_inner: false) { |value| value.is_a?(Array) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: 12)
+      expect(subject.public_send(method, skip_inner: false) { |value| value.is_a?(Array) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: 13)
     end
 
     it 'ignores array when option is passed' do
-      expect(subject.public_send(method, skip_inner: true) { |value| value.is_a?(Array) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: { f: 5 } }])
+      expect(subject.public_send(method, skip_inner: true) { |value| value.is_a?(Array) ? 10 + value.size : value + 1 }).to eq(a: 2, b: 3, c: [{ d: 4 }, { e: { f: 5 } }, 6])
     end
 
     it 'ignore hash and does not work recursively when option is passed' do
-      expect(subject.public_send(method, skip_inner: false, recursive: false) { |value| value.is_a?(Array) ? value : value + 1 }).to eq(a: 2, b: 3, c: [{ d: 3 }, { e: { f: 4 } }])
+      expect(subject.public_send(method, skip_inner: false, recursive: false) { |value| value.is_a?(Array) ? value : value + 1 }).to eq(a: 2, b: 3, c: [{ d: 3 }, { e: { f: 4 } }, 5])
     end
   end
 
@@ -88,5 +123,25 @@ shared_examples 'a method that change the hash values' do |method|
       end
     end
 
+    context 'when using mapping inner array with inner object into a new hash' do
+      let(:object) { Hash::ValueChanger::Dummy.new(2) }
+      let(:array) { Hash::ValueChanger::DummyIteractor.new(object) }
+      let(:subject) { { a: 1, b: array } }
+      let(:result) do
+        subject.public_send(method, skip_inner: false) do |value|
+          if value.is_a?(Numeric)
+            value + 10
+          elsif value.is_a?(Hash) || value.is_a?(Hash::ValueChanger::DummyIteractor)
+            value
+          else
+            value.as_json
+          end
+        end
+      end
+
+      it 'process the object after processing the array' do
+        expect(result).to eq(a: 11, b: [{ val: 12 }])
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: darthjee-core_ext
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Darthjee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-12 00:00:00.000000000 Z
+date: 2017-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -134,11 +134,11 @@ files:
 - ARRAY_README.md
 - ENUMERABLE_README.md
 - Gemfile
-- Gemfile.lock
 - HASH_README.md
 - LICENSE
 - README.md
 - Rakefile
+- circle.yml
 - core_ext.gemspec
 - lib/array.rb
 - lib/array/hash_builder.rb

data/Gemfile.lock

@@ -1,62 +0,0 @@
-PATH
-  remote: .
-  specs:
-    darthjee-core_ext (1.3.0)
-      activesupport (~> 5.1.1)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (5.1.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    coderay (1.1.1)
-    concurrent-ruby (1.0.5)
-    diff-lcs (1.2.5)
-    docile (1.1.5)
-    i18n (0.8.4)
-    json (2.1.0)
-    method_source (0.8.2)
-    minitest (5.10.2)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    pry-nav (0.2.4)
-      pry (>= 0.9.10, < 0.11.0)
-    rake (11.3.0)
-    rspec (2.99.0)
-      rspec-core (~> 2.99.0)
-      rspec-expectations (~> 2.99.0)
-      rspec-mocks (~> 2.99.0)
-    rspec-core (2.99.2)
-    rspec-expectations (2.99.2)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.99.4)
-    simplecov (0.14.1)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.1)
-    slop (3.6.0)
-    thread_safe (0.3.6)
-    tzinfo (1.2.3)
-      thread_safe (~> 0.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 1.6)
-  darthjee-core_ext!
-  pry (~> 0.10.4)
-  pry-nav (~> 0.2.4)
-  rake (~> 11.3.0)
-  rspec (~> 2.14)
-  rspec-mocks (~> 2.99.4)
-  simplecov (~> 0.14.1)
-
-BUNDLED WITH
-   1.15.1