darksky_ruby_client 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d5de6788b9b993237d23881ecffdf89613b0ed16
-  data.tar.gz: f1434deabeaf47eb81a65bd916d55cbe21266fe4
+  metadata.gz: 01d5dd2dc927fee5d68600a9494a032737dcd55f
+  data.tar.gz: 86ca2ce2d194773ec09f7e7ab5a63b2cd950380b
 SHA512:
-  metadata.gz: d73402afe16116467f0aa979de67257d92a74b6879e762216d477f0fbb3ec33a147116dd00b07eb036def9c6d25af07bd02cfc4a1578009f4b9edebb18f0f9fa
-  data.tar.gz: acc5b8fb1c4f01f980d18d9d71de341e72f51436caf71da93a49a5fd5a924f9d3ef9b0103ae7b8d51a2cfe0d6d2ca1a03c91b5b5a3e2f3ae7a0f698c68d6674f
+  metadata.gz: 66c47760124957f164c301251435644e6f68a445fa3225bde8c5a363319319500ada9acb9ddb45bbec4a1823e04f281fb3b2abebaa61ee353494891cfea9d674
+  data.tar.gz: 2c31deb3251328201b8d69d8414cf165f0ffa6820096cb07acff2651a0b7b903899d4b995d0cc2992e2fc820c28e6da5ff764da81a69c3453dc4719ffdaf83d1

data/.travis.yml

@@ -1,5 +1,7 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4.1
+  - 2.4.2
+  - 2.3.5
+  - 2.2.8
 before_install: gem install bundler -v 1.16.0

data/README.md

@@ -1,5 +1,7 @@
 # DarkskyRubyClient
 [![Gem Version](https://badge.fury.io/rb/darksky_ruby_client.svg)](https://badge.fury.io/rb/darksky_ruby_client)
+[![Build Status](https://travis-ci.org/appcot/darksky_ruby_client.svg?branch=master)](https://travis-ci.org/appcot/darksky_ruby_client)
+[![Documentation](http://img.shields.io/badge/docs-rdoc.info-blue.svg)](http://www.rubydoc.info/github/appcot/darksky_ruby_client)
 
 This Client for more convenient use of the DarkSky API.
 
@@ -31,6 +33,16 @@ client = DarkskyRubyClient::Client.new('your Dark Sky secret key')
 client.weather_forecast('latitude', 'longitude')
 ```
 
+Options example
+```ruby
+require 'darksky_ruby_client'
+client = DarkskyRubyClient::Client.new('your Dark Sky secret key')
+client.weather_forecast('latitude', 'longitude', lang: "en", exclude: "daily")
+```
+Sets options after the second argument.
+Available options are exclude, extend, lang, units.
+See https://darksky.net/dev/docs#forecast-request for more details.
+
 Parallel requests.
 ```ruby
 require 'darksky_ruby_client'

data/darksky_ruby_client.gemspec

@@ -27,4 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.16"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "vcr"
 end

data/lib/darksky_ruby_client/client.rb

@@ -9,7 +9,8 @@ module DarkskyRubyClient
     @@base_url = 'https://api.darksky.net/forecast/'
 
     #TODO logger
-    @log = Logger.new('/tmp/log')
+    @@logger ||= Logger.new(STDOUT)
+    @@logger.level = Logger::ERROR
 
     # Don't need this method to use until the base_url of darksky api has changed.
     def base_url
@@ -67,17 +68,19 @@ module DarkskyRubyClient
     # * si: SI units
     # Please check with https://darksky.net/dev/docs#forecast-request for available SI units.
     def weather_forecast(lat, long, **options)
-      @request_url = @@base_url + @secret_key + '/' + lat + ',' + long + '/'
+      @request_url = "#{@@base_url}#{@secret_key}/#{lat},#{long}"
+      multiple_parameters = false
       unless options.empty? then
         options.each {|key, value|
           if [:exclude, :extend, :lang, :units].include?(key)
-            if @request_url[-1] == '/'
+            unless multiple_parameters then
               @request_url << '?' + key.to_s + '=' + value
+              multiple_parameters = true
             else
               @request_url << '&' + key.to_s + '=' + value
             end
           else
-            @log.warn("invalid options key \"#{key}\".")
+            @@logger.warn("invalid options key \"#{key}\".")
           end
         }
       end
@@ -147,7 +150,7 @@ module DarkskyRubyClient
           if response.code == 200
             @responses[place_name] = JSON.parse(response.body)
           else
-            @log.error("HTTP request failed: " + response.code.to_s)
+            @@logger.error("HTTP request failed: " + response.code.to_s)
           end
         end
         hydra.queue @client

data/lib/darksky_ruby_client/version.rb

@@ -1,3 +1,3 @@
 module DarkskyRubyClient
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: darksky_ruby_client
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - appcot
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-24 00:00:00.000000000 Z
+date: 2017-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This Client for more convenient use of the DarkSky API.
 email:
 - appcot.2013@gmail.com