darksky_ruby_client 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcaae1546f66eed78cfd11f2e92e2f2b2f624e78
-  data.tar.gz: 0c86237cb7c95f186beb61f1cbca4c9cd1371272
+  metadata.gz: d5de6788b9b993237d23881ecffdf89613b0ed16
+  data.tar.gz: f1434deabeaf47eb81a65bd916d55cbe21266fe4
 SHA512:
-  metadata.gz: 6fefae976ece55e79d17be76ca2831a9170789e863ba601d1bddb8a01b35d73a076c7ab26565ab8883ae9c5ea713bcd8f102c6d0db5779bd22ff1292b68498a8
-  data.tar.gz: c8ca7bb9d72b62c9dff542134255d13e0b3b363778ca80e84b858aa6072ddfd9c59a8383b29091226b818a4af6bb3358619fa70b9661c10d05d8e11bc714da01
+  metadata.gz: d73402afe16116467f0aa979de67257d92a74b6879e762216d477f0fbb3ec33a147116dd00b07eb036def9c6d25af07bd02cfc4a1578009f4b9edebb18f0f9fa
+  data.tar.gz: acc5b8fb1c4f01f980d18d9d71de341e72f51436caf71da93a49a5fd5a924f9d3ef9b0103ae7b8d51a2cfe0d6d2ca1a03c91b5b5a3e2f3ae7a0f698c68d6674f

data/lib/darksky_ruby_client/client.rb

@@ -29,12 +29,12 @@ module DarkskyRubyClient
       @responses = {}
     end
     
-    # A single request for forecast request
+    # Single request for the forecast api.
     # @param [String] lat The latitude of a location (in decimal degrees). 
     # @param [String] long The longitude of a location (in decimal degrees). 
-    # @param [Hash] options Use if you want to specify "explicit, extend, lang, units".
+    # @param [String] options Use if you want to specify "explicit, extend, lang, units".
     # Please check https://darksky.net/dev/docs#forecast-request for details. 
-    # @option options [String] :exclude
+    # @option options [String] exclude
     # exlude=[blocks] e.g. exclude: "currently,flags"
     # Exclude some number of data blocks from the API response. 
     # This is useful for reducing latency and saving cache space. 
@@ -45,17 +45,17 @@ module DarkskyRubyClient
     # * daily
     # * alerts
     # * flags
-    # @option options [String] :extend
-    # extend=[hourly] e.g. hourly: "24"
+    # @option options [String] extend
+    # extend=[hourly] e.g. extend: "24"
     # When present, return hour-by-hour data for the next 168 hours, instead of the next 48. 
     # When using this option, we strongly recommend enabling HTTP compression.
-    # @option options [String] :lang
+    # @option options [String] lang
     # e.g. lang: "en"
     # Return summary properties in the desired language. 
     # (Note that units in the summary will be set according to the units parameter, 
     # so be sure to set both parameters appropriately.)
     # Please check with https://darksky.net/dev/docs#forecast-request for available languages.
-    # @option options [String] :units
+    # @option options [String] units
     # units=[units] e.g. units: "auto"
     # Return weather conditions in the requested units. 
     # [units] should be one of the following:
@@ -71,11 +71,10 @@ module DarkskyRubyClient
       unless options.empty? then
         options.each {|key, value|
           if [:exclude, :extend, :lang, :units].include?(key)
-            p @request_url[-1]
             if @request_url[-1] == '/'
-              @request_url = '?' + key.to_s + '=' + value
+              @request_url << '?' + key.to_s + '=' + value
             else
-              @request_url = '&' + key.to_s + '=' + value
+              @request_url << '&' + key.to_s + '=' + value
             end
           else
             @log.warn("invalid options key \"#{key}\".")
@@ -83,10 +82,59 @@ module DarkskyRubyClient
         }
       end
       init_client
-      run unless @parallel_requests
+      unless @parallel_requests
+        run
+        JSON.parse(@res.body) if @res.code == 200
+      end
     end
 
-    # TODO Parallel requests
+    # Parallel request for the forecast api.
+    # @param [Hash] locations Must set it in two dimensional hash
+    # and must follow the specified format.
+    # {
+    #   :place_name => {
+    #     :latitude => "latitude value",
+    #     :longitude => "longitude value"
+    #   },
+    #   :place_name => {
+    #     :latitude => "latitude value",
+    #     :longitude => "longitude value"
+    #   }
+    # }
+    # @param [String] options Use if you want to specify "explicit, extend, lang, units".
+    # Please check https://darksky.net/dev/docs#forecast-request for details. 
+    # @option options [String] exclude
+    # exlude=[blocks] e.g. exclude: "currently,flags"
+    # Exclude some number of data blocks from the API response. 
+    # This is useful for reducing latency and saving cache space. 
+    # The value blocks should be a comma-delimeted list (without spaces) of any of the following:
+    # * currently
+    # * minutely
+    # * hourly
+    # * daily
+    # * alerts
+    # * flags
+    # @option options [String] extend
+    # extend=[hourly] e.g. extend: "24"
+    # When present, return hour-by-hour data for the next 168 hours, instead of the next 48. 
+    # When using this option, we strongly recommend enabling HTTP compression.
+    # @option options [String] lang
+    # e.g. lang: "en"
+    # Return summary properties in the desired language. 
+    # (Note that units in the summary will be set according to the units parameter, 
+    # so be sure to set both parameters appropriately.)
+    # Please check with https://darksky.net/dev/docs#forecast-request for available languages.
+    # @option options [String] units
+    # units=[units] e.g. units: "auto"
+    # Return weather conditions in the requested units. 
+    # [units] should be one of the following:
+    # * auto: automatically select units based on geographic location
+    # * ca: same as si, except that windSpeed and windGust are in kilometers per hour
+    # * uk2: same as si, except that nearestStormDistance and visibility are in miles, 
+    #        and windSpeed and windGust in miles per hour
+    # * us: Imperial units (the default)
+    # * si: SI units
+    # Please check with https://darksky.net/dev/docs#forecast-request for available SI units.
     def some_weather_forecast(locations, **options)
       @parallel_requests = true
       hydra = Typhoeus::Hydra.new
@@ -96,7 +144,11 @@ module DarkskyRubyClient
         longitude = location[:longitude] if location.include?(:longitude)
         weather_forecast(latitude, longitude, options)
         @client.on_complete do |response|
-          @responses[place_name] = response
+          if response.code == 200
+            @responses[place_name] = JSON.parse(response.body)
+          else
+            @log.error("HTTP request failed: " + response.code.to_s)
+          end
         end
         hydra.queue @client
         @client
@@ -112,7 +164,7 @@ module DarkskyRubyClient
 
     # Run a request.
     def run
-      @client.run
+      @res = @client.run
     end
   end
 end

data/lib/darksky_ruby_client/version.rb

@@ -1,3 +1,3 @@
 module DarkskyRubyClient
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: darksky_ruby_client
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - appcot