darksky-api 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a0d324adb3f3ca70e81b924293c2ddfe13074c2f9678d4ca02dbfcc9fa505f2
-  data.tar.gz: 9a6a530b42eb6b4f5a296f18e921911803399d494d796e2a01a0c47b79670d59
+  metadata.gz: e6d016e9642f5018a07312d3caa96e4d49f43a63a8de2415b9a5aa2128cbf9f2
+  data.tar.gz: d68c72019164491f10fc8a708e57c6700003a59eabedeb1d51eae01ca66b82ca
 SHA512:
-  metadata.gz: e83781a530fd0aec046da02ea3ba14a7161c9048861d9a9729a1e3c74f9a8520f1aa7a6a8b7997e79f1e10fc1954b4a66ce75725da814a75f4599f3e98a50e2c
-  data.tar.gz: 1fb64f1a6fa35ce39c5f51fc9fbd0effeb6272e9270d9faed379922ab8d3aa788e0afc49a079503c7d63c6404e9f62a9cf597a0652cc03c6234b31104a03e80c
+  metadata.gz: 8461aaf0495eb088df3c6af3b5ef36bb9052cd7218a64045dcc741f7d4f8eb432bf943efeb5d1384fbeebfdfd366e32ac1338720f06907bd4986ccefefdb83a1
+  data.tar.gz: bf40943663be48d5bd9af37ac90d11cbcf0e99c60e72d53cb996c1f1b90b72e1635551ea961c4c972b553033c156a3f43b9f4cac39e781079ab6e1d51f952fb1

data/.rubocop.yml

@@ -22,3 +22,9 @@ Metrics/LineLength:
 
 Metrics/ClassLength:
   Max: 200
+
+Metrics/PerceivedComplexity:
+  Max: 15
+
+Metrics/CyclomaticComplexity:
+  Max: 15

data/Gemfile

@@ -4,7 +4,3 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in darksky_api.gemspec
 gemspec
-
-# dependencies
-gem 'json', '~> 2.1'
-gem 'rest-client', '~> 2.0'

data/Gemfile.lock

@@ -1,13 +1,15 @@
 PATH
   remote: .
   specs:
-    darksky-api (0.1.1)
+    darksky-api (0.1.4)
       json (~> 2.1)
       rest-client (~> 2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.3.0)
+    docile (1.1.5)
     domain_name (0.5.20170404)
       unf (>= 0.0.5, < 1.0.0)
     http-cookie (1.0.3)
@@ -18,14 +20,33 @@ GEM
     mime-types-data (3.2016.0521)
     minitest (5.10.3)
     netrc (0.11.0)
+    parallel (1.12.1)
+    parser (2.4.0.2)
+      ast (~> 2.3)
+    powerpack (0.1.1)
+    rainbow (3.0.0)
     rake (10.5.0)
     rest-client (2.0.2)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
+    rubocop (0.52.1)
+      parallel (~> 1.10)
+      parser (>= 2.4.0.2, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.9.0)
+    simplecov (0.15.1)
+      docile (~> 1.1.0)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.4)
+    unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
@@ -33,10 +54,10 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 1.16)
   darksky-api!
-  json (~> 2.1)
   minitest (~> 5.0)
   rake (~> 10.0)
-  rest-client (~> 2.0)
+  rubocop (~> 0.52)
+  simplecov (~> 0.15)
 
 BUNDLED WITH
    1.16.0

data/darksky-api.gemspec

@@ -25,4 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'minitest', '~> 5.0'
   spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rubocop', '~> 0.52'
+  spec.add_development_dependency 'simplecov', '~> 0.15'
 end

data/lib/darksky-api.rb

@@ -1,6 +1,7 @@
 require 'darksky-api/version'
 require 'darksky-api/config'
 require 'darksky-api/location'
+require 'darksky-api/common-methods'
 require 'darksky-api/current'
 require 'darksky-api/day'
 

data/lib/darksky-api/common-methods.rb

@@ -0,0 +1,261 @@
+module DarkSky
+  class CommonMethods
+    # abstract class, should not be instantiated
+    # @raise NotImplementedError
+    def initialize
+      raise NotImplementedError,
+            'This is an abstract class, and should be be instantiated'
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.apparent_temperature #=> apparent temperature at location
+    # @since 0.1.4
+    # @return [Numeric] current apparent temperature at location
+    def apparent_temperature
+      data[:apparentTemperature]
+    end
+    alias wind_chill apparent_temperature
+    alias heat_index apparent_temperature
+    alias feels_like apparent_temperature
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.cloud_cover #=> cloud cover at location
+    # @since 0.1.4
+    # @return [Numeric] current cloud cover at location
+    def cloud_cover
+      data[:cloudCover]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.dew_point #=> dew point at location
+    # @since 0.1.4
+    # @return [Numeric] current dew point at location
+    def dew_point
+      data[:dewPoint]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.humidity #=> humidity at location
+    # @since 0.1.4
+    # @return [Numeric] current humidity at location
+    def humidity
+      data[:humidity]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.icon #=> icon representation
+    # @since 0.1.4
+    # @return [String] icon representation of current weather at location
+    def icon
+      data[:icon]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.ozone #=> ozone level at location
+    # @since 0.1.4
+    # @return [Numeric] current ozone level at location
+    def ozone
+      data[:ozone]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.precip_intensity #=> precipitation intensity at location
+    # @since 0.1.4
+    # @return [Numeric] current precipitation intensity at location
+    def precip_intensity
+      data[:precipIntensity]
+    end
+
+    # @example
+    #   location = DarkSky::Locaiton.new [45, -90]
+    #   location.current.precip_intensity_text #=> text representation of precipitation intensity at location
+    # @since 0.1.4
+    # @return [String] text representation of precipitation intensity at location
+    def precip_intensity_text
+      _precip_intensity_text(precip_intensity)
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.precip_probability #=> precipitation probability at location
+    # @since 0.1.4
+    # @return [Numeric] current precipitation probability at location
+    def precip_probability
+      data[:precipProbability]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.precip_type #=> precipitation type at location
+    # @since 0.1.4
+    # @return [String | nil] current precipitation type at location
+    def precip_type
+      data[:precipType]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.pressure #=> barometric pressure at location
+    # @since 0.1.4
+    # @return [Numeric] current barometric pressure at location
+    def pressure
+      data[:pressure]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.summary #=> summary of weather at location
+    # @since 0.1.4
+    # @return [String] summary of weather at location
+    def summary
+      data[:summary]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.uv_index #=> UV index at location
+    # @since 0.1.4
+    # @return [Numeric] current UV index at location
+    def uv_index
+      data[:uvIndex]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.visibility #=> visibility at location
+    # @since 0.1.4
+    # @return [Numeric] current visibility at location
+    def visibility
+      data[:visibility]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.wind_bearing #=> wind bearing at location
+    # @since 0.1.4
+    # @return [Numeric] current wind bearing at location
+    def wind_bearing
+      data[:windBearing]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.wind_bearing_text #=> text representation of bearing (N, NW, etc.)
+    # @since 0.1.4
+    # @return [String] text representation of bearing
+    def wind_bearing_text
+      _bearing_text(wind_bearing)
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.wind_gust #=> wind gust at location
+    # @since 0.1.4
+    # @return [Numeric] current wind gust at location
+    def wind_gust
+      data[:windGust]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.wind_speed #=> wind speed at location
+    # @since 0.1.4
+    # @return [Numeric] current wind speed at location
+    def wind_speed
+      data[:windSpeed]
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.clear?
+    # @since 0.1.0
+    # @return [Boolean] if icon is 'clear' variant
+    def clear?
+      %w[clear-day clear-night].include? icon
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.rainy?
+    # @since 0.1.0
+    # @return [Boolean] if icon is 'rain'
+    def rainy?
+      icon == 'rain'
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.snowy?
+    # @since 0.1.0
+    # @return [Boolean] if icon is 'snow'
+    def snowy?
+      icon == 'snow'
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.sleet?
+    # @since 0.1.0
+    # @return [Boolean] if icon is 'sleet'
+    def sleet?
+      icon == 'sleet'
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.windy?
+    # @since 0.1.0
+    # @return [Boolean] if icon is 'wind'
+    def windy?
+      icon == 'wind'
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.foggy?
+    # @since 0.1.0
+    # @return [Boolean] if icon is 'fog'
+    def foggy?
+      icon == 'fog'
+    end
+
+    # @example
+    #   location = DarkSky::Location.new [45, -90]
+    #   location.current.cloudy?
+    # @since 0.1.0
+    # @return [Boolean] if icon is 'cloudy' or variant
+    def cloudy?
+      %w[cloudy partly-cloudy-day partly-cloudy-night].include? icon
+    end
+
+    private
+
+    # convert precip intensity to text
+    # keep this a separate method for testing purposes
+    # @since 0.1.4
+    # @return [String] text representation of precipitation intensity
+    def _precip_intensity_text(intensity)
+      if intensity >= 0.400
+        'heavy'
+      elsif intensity >= 0.100
+        'moderate'
+      elsif intensity >= 0.017
+        'light'
+      elsif intensity >= 0.002
+        'sporadic'
+      end
+    end
+
+    def _bearing_text(degree)
+      directions = %w[N NNE NE ENE E ESE SE SSE S SSW SW WSW W WNW NW NNW]
+      directions[degree / 22.5 + 0.5]
+    end
+  end
+end

data/lib/darksky-api/current.rb

@@ -1,6 +1,6 @@
 module DarkSky
   class Location
-    class Current
+    class Current < CommonMethods
       # automatically called by `Location`
       # @since 0.1.0
       # @param [Location] location where to get data from
@@ -8,117 +8,6 @@ module DarkSky
         @location = location
       end
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.apparent_temperature #=> apparent temperature at location
-      # @since 0.1.0
-      # @return [Numeric] current apparent temperature at location
-      def apparent_temperature
-        data[:apparentTemperature]
-      end
-      alias wind_chill apparent_temperature
-      alias heat_index apparent_temperature
-      alias feels_like apparent_temperature
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.cloud_cover #=> cloud cover at location
-      # @since 0.1.0
-      # @return [Numeric] current cloud cover at location
-      def cloud_cover
-        data[:cloudCover]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.dew_point #=> dew point at location
-      # @since 0.1.0
-      # @return [Numeric] current dew point at location
-      def dew_point
-        data[:dewPoint]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.humidity #=> humidity at location
-      # @since 0.1.0
-      # @return [Numeric] current humidity at location
-      def humidity
-        data[:humidity]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.icon #=> icon representation
-      # @since 0.1.0
-      # @return [String] icon representation of current weather at location
-      def icon
-        data[:icon]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.clear?
-      # @since 0.1.0
-      # @return [Boolean] if icon is 'clear' variant
-      def clear?
-        %w[clear-day clear-night].include? icon
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.rainy?
-      # @since 0.1.0
-      # @return [Boolean] if icon is 'rain'
-      def rainy?
-        icon == 'rain'
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.snowy?
-      # @since 0.1.0
-      # @return [Boolean] if icon is 'snow'
-      def snowy?
-        icon == 'snow'
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.sleet?
-      # @since 0.1.0
-      # @return [Boolean] if icon is 'sleet'
-      def sleet?
-        icon == 'sleet'
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.windy?
-      # @since 0.1.0
-      # @return [Boolean] if icon is 'wind'
-      def windy?
-        icon == 'wind'
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.foggy?
-      # @since 0.1.0
-      # @return [Boolean] if icon is 'fog'
-      def foggy?
-        icon == 'fog'
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.cloudy?
-      # @since 0.1.0
-      # @return [Boolean] if icon is 'cloudy' or variant
-      def cloudy?
-        %w[cloudy partly-cloudy-day partly-cloudy-night].include? icon
-      end
-
       # @example
       #   location = DarkSky::Location.new [45, -90]
       #   location.current.nearest_storm_bearing #=> nearest storm bearing at location
@@ -134,8 +23,7 @@ module DarkSky
       # @since 0.1.0
       # @return [String] text representation of bearing
       def nearest_storm_bearing_text
-        directions = %w[N NNE NE ENE E ESE SE SSE S SSW SW WSW W WNW NW NNW]
-        directions[nearest_storm_bearing / 22.5 + 0.5]
+        _bearing_text(nearest_storm_bearing)
       end
 
       # @example
@@ -147,77 +35,6 @@ module DarkSky
         data[:nearestStormDistance]
       end
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.ozone #=> ozone level at location
-      # @since 0.1.0
-      # @return [Numeric] current ozone level at location
-      def ozone
-        data[:ozone]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.precip_intensity #=> precipitation intensity at location
-      # @since 0.1.0
-      # @return [Numeric] current precipitation intensity at location
-      def precip_intensity
-        data[:precipIntensity]
-      end
-
-      # @example
-      #   location = DarkSky::Locaiton.new [45, -90]
-      #   location.current.precip_intensity_text #=> text representation of precipitation intensity at location
-      # @since 0.1.0
-      # @return [String] text representation of precipitation intensity at location
-      def precip_intensity_text
-        if precip_intensity >= 0.400
-          'heavy'
-        elsif precip_intensity >= 0.100
-          'moderate'
-        elsif precip_intensity >= 0.017
-          'light'
-        elsif precip_intensity >= 0.002
-          'very light'
-        end
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.precip_probability #=> precipitation probability at location
-      # @since 0.1.0
-      # @return [Numeric] current precipitation probability at location
-      def precip_probability
-        data[:precipProbability]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.precip_type #=> precipitation type at location
-      # @since 0.1.0
-      # @return [String | nil] current precipitation type at location
-      def precip_type
-        data[:precipType]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.pressure #=> barometric pressure at location
-      # @since 0.1.0
-      # @return [Numeric] current barometric pressure at location
-      def pressure
-        data[:pressure]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.summary #=> summary of weather at location
-      # @since 0.1.0
-      # @return [String] summary of weather at location
-      def summary
-        data[:summary]
-      end
-
       # @example
       #   location = DarkSky::Location.new [45, -90]
       #   location.current.temperature #=> temperature at location
@@ -227,61 +44,6 @@ module DarkSky
         data[:temperature]
       end
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.uv_index #=> UV index at location
-      # @since 0.1.0
-      # @return [Numeric] current UV index at location
-      def uv_index
-        data[:uvIndex]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.visibility #=> visibility at location
-      # @since 0.1.0
-      # @return [Numeric] current visibility at location
-      def visibility
-        data[:visibility]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.wind_bearing #=> wind bearing at location
-      # @since 0.1.0
-      # @return [Numeric] current wind bearing at location
-      def wind_bearing
-        data[:windBearing]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.wind_bearing_text #=> text representation of bearing (N, NW, etc.)
-      # @since 0.1.0
-      # @return [String] text representation of bearing
-      def wind_bearing_text
-        directions = %w[N NNE NE ENE E ESE SE SSE S SSW SW WSW W WNW NW NNW]
-        directions[wind_bearing / 22.5 + 0.5]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.wind_gust #=> wind gust at location
-      # @since 0.1.0
-      # @return [Numeric] current wind gust at location
-      def wind_gust
-        data[:windGust]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.current.wind_speed #=> wind speed at location
-      # @since 0.1.0
-      # @return [Numeric] current wind speed at location
-      def wind_speed
-        data[:windSpeed]
-      end
-
       private
 
       # helper to avoid typing this many times over

data/lib/darksky-api/day.rb

@@ -1,6 +1,6 @@
 module DarkSky
   class Location
-    class Day
+    class Day < CommonMethods
       # automatically called by `Location`
       # @since 0.1.3
       # @param [Location] location where to get data from
@@ -59,24 +59,6 @@ module DarkSky
       end
       alias low_temperature_time temperature_low_time
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.icon #=> icon representation
-      # @since 0.1.3
-      # @return [String] icon representation of weather on day
-      def icon
-        data[:icon]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.summary #=> summary of weather
-      # @since 0.1.3
-      # @return [String] summary of weather on day
-      def summary
-        data[:summary]
-      end
-
       # @example
       #   location = DarkSky::Location.new [45, -90]
       #   location.today.sunrise_time #=> sunrise time on day
@@ -113,33 +95,7 @@ module DarkSky
       # @return [String] textual representation of moon phase
       def moon_phase_text
         # separate method for easy unit testing
-        _moon_phase_text moon_phase
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.precip_intensity #=> precipitation intensity on day
-      # @since 0.1.3
-      # @return [Numeric] precipitation intensity on day
-      def precip_intensity
-        data[:precipIntensity]
-      end
-
-      # @example
-      #   location = DarkSky::Locaiton.new [45, -90]
-      #   location.today.precip_intensity_text #=> text representation of precipitation intensity on day
-      # @since 0.1.3
-      # @return [String] text representation of precipitation intensity on day
-      def precip_intensity_text
-        if precip_intensity >= 0.400
-          'heavy'
-        elsif precip_intensity >= 0.100
-          'moderate'
-        elsif precip_intensity >= 0.017
-          'light'
-        elsif precip_intensity >= 0.002
-          'very light'
-        end
+        _moon_phase_text(moon_phase)
       end
 
       # @example
@@ -157,15 +113,7 @@ module DarkSky
       # @since 0.1.3
       # @return [String] text representation of maximum precipitation intensity on day
       def precip_intensity_max_text
-        if precip_intensity_max >= 0.400
-          'heavy'
-        elsif precip_intensity_max >= 0.100
-          'moderate'
-        elsif precip_intensity_max >= 0.017
-          'light'
-        elsif precip_intensity_max >= 0.002
-          'very light'
-        end
+        _precip_intensity_text(precip_intensity_max)
       end
 
       # @example
@@ -177,24 +125,6 @@ module DarkSky
         Time.at data[:precipIntensityMaxTime] if data[:precipIntensityMaxTime]
       end
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.precip_probability #=> precipitation probability on day
-      # @since 0.1.3
-      # @return [Numeric] precipitation probability
-      def precip_probability
-        data[:precipProbability]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.precip_type #=> precipitation type on day
-      # @since 0.1.3
-      # @return [String | nil] current precipitation type on day
-      def precip_type
-        data[:precipType]
-      end
-
       # @example
       #   location = DarkSky::Location.new [45, -90]
       #   location.today.precip_accumulation #=> precipitation accumulation on day
@@ -272,51 +202,6 @@ module DarkSky
       alias low_wind_chill_time apparent_temperature_low_time
       alias wind_chill_low_time apparent_temperature_low_time
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.dew_point #=> dew point on day
-      # @since 0.1.3
-      # @return [Numeric] dew point on day
-      def dew_point
-        data[:dewPoint]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.humidity #=> humidity on day
-      # @since 0.1.3
-      # @return [Numeric] humidity on day
-      def humidity
-        data[:humidity]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.pressure #=> barometric pressue on day
-      # @since 0.1.3
-      # @return [Numeric] barometric pressure on day
-      def pressure
-        data[:pressure]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.wind_speed #=> wind speed on day
-      # @since 0.1.3
-      # @return [Numeric] wind speed on day
-      def wind_speed
-        data[:windSpeed]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.wind_gust #=> wind gust on day
-      # @since 0.1.3
-      # @return [Numeric] wind gust on day
-      def wind_gust
-        data[:windGust]
-      end
-
       # @example
       #   location = DarkSky::Location.new [45, -90]
       #   location.today.wind_gust_time #=> wind gust time on day
@@ -326,33 +211,6 @@ module DarkSky
         Time.at data[:windGustTime]
       end
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.wind_bearing #=> wind bearing on day
-      # @since 0.1.3
-      # @return [Numeric] wind bearing on day
-      def wind_bearing
-        data[:windBearing]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.cloud_cover #=> cloud cover on day
-      # @since 0.1.3
-      # @return [Numeric] cloud cover on day
-      def cloud_cover
-        data[:cloudCover]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.uv_index #=> UV index on day
-      # @since 0.1.3
-      # @return [Numeric] UV index on day
-      def uv_index
-        data[:uvIndex]
-      end
-
       # @example
       #   location = DarkSky::Location.new [45, -90]
       #   location.today.uv_index_time #=> max UV index time on day
@@ -362,24 +220,6 @@ module DarkSky
         Time.at data[:uvIndexTime]
       end
 
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.visibility #=> visibility on day
-      # @since 0.1.3
-      # @return [Numeric] visibility on day
-      def visibility
-        data[:visibility]
-      end
-
-      # @example
-      #   location = DarkSky::Location.new [45, -90]
-      #   location.today.ozone #=> ozone on day
-      # @since 0.1.3
-      # @return [Numeric] ozone on day
-      def ozone
-        data[:ozone]
-      end
-
       private
 
       # helper to avoid typing this many times over
@@ -394,7 +234,7 @@ module DarkSky
       # keep this a separate method for testing purposes
       # @since 0.1.3
       # @return [String] text representation of moon phase
-      def _moon_phase_text(phase) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/LineLength
+      def _moon_phase_text(phase)
         if phase < 0.05
           'new moon'
         elsif phase < 0.20

data/lib/darksky-api/location.rb

@@ -19,7 +19,7 @@ module DarkSky
 
     # @example
     #   location = DarkSky::Location.new [45, -90]
-    #   location.units #=> :si
+    #   location.units #=> :auto
     # @since 0.1.2
     # @return [Symbol] what unit system is being used
     attr_reader :units
@@ -46,11 +46,13 @@ module DarkSky
     # @param [Numeric] cache_duration requests within this many seconds will be parsed on existing data
     # @param [Symbol | String] units what unit system to use
     # @param [Symbol | String] language what language to return results in
+    # @param [Boolean] prefetch immediately perform an API request upon initialization?
     def initialize(
       location = [0, 0],
       cache_duration: 300,
       units: :auto,
-      language: :en
+      language: :en,
+      prefetch: false
     )
       # initial value to avoid errors
       @cache_time = 1
@@ -59,24 +61,22 @@ module DarkSky
       @location = location
       @cache_duration = cache_duration # in seconds
       @language = language.to_sym
+      @units = units.to_sym
 
       # aliases for some unit systems
-      units = units.to_sym
-      if units == :uk
-        @units == :uk2
-      elsif units == :canada
-        @units == :ca
-      else
-        @units = units
-      end
+      @units = :uk2 if @units == :uk
+      @units = :ca if @units == :canada
 
       # initialize classes for namespace
       @current = Current.new self
+
+      # perform API request if prefetch is true
+      full_data if prefetch
     end
 
     # update cache if necessary and get latest data
     # @example
-    #   location = DarkSky::Location.new
+    #   location = DarkSky::Location.new [45, -90]
     #   location.full_data
     # @since 0.1.0
     # @return [Hash] raw data (in full) from DarkSky

data/lib/darksky-api/version.rb

@@ -1,4 +1,4 @@
 module DarkSky
-  # version of this library (follows SemVer)
-  VERSION = '0.1.3'.freeze
+  # version of this library (follows SemVer for versions >= 1.0.0)
+  VERSION = '0.1.4'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: darksky-api
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Jacob Pratt
@@ -80,6 +80,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.52'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.52'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.15'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.15'
 description: 
 email:
 - the.z.cuber@gmail.com
@@ -99,6 +127,7 @@ files:
 - bin/setup
 - darksky-api.gemspec
 - lib/darksky-api.rb
+- lib/darksky-api/common-methods.rb
 - lib/darksky-api/config.rb
 - lib/darksky-api/current.rb
 - lib/darksky-api/day.rb