dap 0.1.23 → 0.1.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a7825d15d19bfc4d5e8c3186b3061cfbdeec4544
-  data.tar.gz: 44db06642179239ec8cd0dd5a74b942d7ddd2099
+  metadata.gz: '0480b56123e964ee478eabdc10cb36ca9058a96a'
+  data.tar.gz: 02e2db3f819c59e9fd788d1b94a3e393c911757b
 SHA512:
-  metadata.gz: 39b2014c7ff8dae7f9b7fc682e11ced8a440e6851f7a3a2f66e2650e8b003ace087bbd1dbf61e4edbf6a9c1187dc5f30d08120e07caa5d57d5bf35da5562af16
-  data.tar.gz: d8ba566df260622890b602b21dd41cf5a69e90da230532640ccc4d9d0dfc3805e298c73df92f84ffed31b823b340a28d482b7c6a5aeea1bb186f8bc4686d6278
+  metadata.gz: 217ad924d85b8c6c96c1a2b24e58f1858f838fd52d4df2552fadf672a08995dac8648a9efeed46a0d4b5c5cee93493388c33a0fc2bc4703fbd163ed51ee546f4
+  data.tar.gz: 54608828054846803c7c2f803e86578d79bb8c4749d2e16384874d2e053a91baabb977d41930d5725858536297dd6fa114d69e13d55a5422d8ec4e1721537a03

data/CONTRIBUTING.md

@@ -141,4 +141,4 @@ When a new version of dap is to be released, you _must_ follow the instructions
 
 ## Misc tips on building dap
 
-Ruby often comes prepackaged on linux/mac os systems. Although the README already mentions using rbenv, it useful to make sure your envoiroment is actually using the rbenv version of ruby, gem, & bundler before running any ruby commands such as gem, bundle, ruby or dap itself utilizing the which command.
+Ruby often comes prepackaged on linux/mac os systems. Although the README already mentions using `rbenv`, it useful to make sure your envoiroment is actually using `rbenv` before running any ruby commands such as `gem`, `bundle`, `ruby` or `dap` itself utilizing the `which` command to confirm that the their paths indicate they came from `rbenv`.

data/README.md

@@ -46,7 +46,7 @@ gem install dap
 In its simplest form, DAP takes input, applies zero or more filters which modify the input, and then outputs the result.  The input, filters and output are separated by plus signs (`+`).  As seen from `dap -h`:
 
 ```
-Uage: dap  [input] + [filter] + [output]
+Usage: dap  [input] + [filter] + [output]
        --inputs
        --outputs
        --filters

data/lib/dap/filter/gquic.rb

@@ -1,3 +1,5 @@
+# Documentation on what the different gquic values are
+# https://github.com/quicwg/base-drafts/wiki/QUIC-Versions
 module Dap
    module Filter
 
@@ -22,9 +24,9 @@ module Dap
               step = 4
               while i < data.length 
                  version = data[i..i+4-1]
-                 # Versions start with the letter Q
-                 if data[i] == 'Q'
-                    versions.push(version)
+                 # Versions start with the letter Q followed by number e.g. 001 - 043
+                 if version =~ /^Q\d{3}$/
+                     versions.push(version)
                  end
                  i = i + step
               end

data/lib/dap/version.rb

@@ -1,3 +1,3 @@
 module Dap
-  VERSION = "0.1.23"
+  VERSION = "0.1.24"
 end

data/spec/dap/filter/gquic_filter_spec.rb

@@ -5,13 +5,27 @@ describe Dap::Filter::FilterDecodeGquicVersionsResult do
 
     let(:filter) { described_class.new(['data']) }
 
-    context 'testing gquic valid input' do
+    context 'testing gquic valid input base64 encoded output from the real world' do
       let(:decode) { filter.decode(Base64.decode64("DQAAAAECAwQFUTA0NFEwNDNRMDM5UTAzNQ=="))}
       it 'returns an hash w/ versions as list of versions' do
         expect(decode).to eq({"versions"=> ["Q044","Q043","Q039","Q035"]})
       end
     end
 
+    context 'testing gquic valid input artifical example' do
+      let(:decode) { filter.decode("aaaaaaaaaQ044Q043Q039Q035")}
+      it 'returns an hash w/ versions as list of versions' do
+        expect(decode).to eq({"versions"=> ["Q044","Q043","Q039","Q035"]})
+      end
+    end
+
+    context 'testing gquic valid versions with invalid versions' do
+      let(:decode) { filter.decode("aaaaaaaaaQ044R043R039Q035")}
+      it 'returns an hash w/ versions as list of versions' do
+        expect(decode).to eq({"versions"=> ["Q044", "Q035"]})
+      end
+    end
+
     context 'testing valid string but not gquic versions' do
       let(:decode) { filter.decode("H044R043E039L035") }
       it 'returns nil' do
@@ -19,6 +33,14 @@ describe Dap::Filter::FilterDecodeGquicVersionsResult do
       end
     end
 
+    # do not want ["Qy6j","Qrta","Ql3T","QkKf","QTUB"]
+    context 'testing valid string with Q in it but not gquic versions ' do
+      let(:decode) { filter.decode("aaaaaaaaaQy6jQrtaQl3TQkKfQTUB") }
+      it 'returns nil' do
+        expect(decode).to eq(nil)
+      end
+    end
+
     context 'testing gquic empty string input' do
       let(:decode) { filter.decode("") }
       it 'returns nil' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dap
 version: !ruby/object:Gem::Version
-  version: 0.1.23
+  version: 0.1.24
 platform: ruby
 authors:
 - Rapid7 Research
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-11 00:00:00.000000000 Z
+date: 2019-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -255,7 +255,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: 'DAP: The Data Analysis Pipeline'