danmayer-metric_fu 2.1.2

data/spec/generators/reek_spec.rb

@@ -0,0 +1,134 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Reek do
+  describe "emit" do
+    it "should include config parameters" do
+      MetricFu::Configuration.run do |config|
+        config.reek = {:config_file_pattern => 'lib/config/*.reek', :dirs_to_reek => []}
+      end
+      reek = MetricFu::Reek.new
+      reek.should_receive(:`).with(/--config lib\/config\/\*\.reek/).and_return("")
+      reek.emit
+    end
+  end
+
+  describe "analyze method" do
+    before :each do
+      @lines = <<-HERE
+"app/controllers/activity_reports_controller.rb" -- 4 warnings:
+ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
+ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
+ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
+ActivityReportsController#authorize_user has approx 6 statements (Long Method)
+
+"app/controllers/application.rb" -- 1 warnings:
+ApplicationController#start_background_task/block/block is nested (Nested Iterators)
+
+"app/controllers/link_targets_controller.rb" -- 1 warnings:
+LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
+
+"app/controllers/newline_controller.rb" -- 1 warnings:
+NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
+      HERE
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      reek = MetricFu::Reek.new
+      reek.instance_variable_set(:@output, @lines)
+      @matches = reek.analyze
+    end
+
+    it "should find the code smell's method name" do
+      smell = @matches.first[:code_smells].first
+      smell[:method].should == "ActivityReportsController#authorize_user"
+    end
+
+    it "should find the code smell's type" do
+      smell = @matches[1][:code_smells].first
+      smell[:type].should == "Nested Iterators"
+    end
+
+    it "should find the code smell's message" do
+      smell = @matches[1][:code_smells].first
+      smell[:message].should == "is nested"
+    end
+
+    it "should find the code smell's type" do
+      smell = @matches.first
+      smell[:file_path].should == "app/controllers/activity_reports_controller.rb"
+    end
+
+    it "should NOT insert nil smells into the array when there's a newline in the method call" do
+      @matches.last[:code_smells].should == @matches.last[:code_smells].compact
+      @matches.last.should == {:file_path=>"app/controllers/newline_controller.rb",
+                                :code_smells=>[{:type=>"Duplication",
+                                                  :method=>"\"",
+                                                  :message=>"multiple times"}]}
+      # Note: hopefully a temporary solution until I figure out how to deal with newlines in the method call more effectively -Jake 5/11/2009
+    end
+  end
+
+end
+
+describe Reek do
+  before :each do
+    MetricFu::Configuration.run {}
+    @reek = MetricFu::Reek.new
+    @lines11 = <<-HERE
+"app/controllers/activity_reports_controller.rb" -- 4 warnings:
+ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
+ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
+ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
+ActivityReportsController#authorize_user has approx 6 statements (Long Method)
+
+"app/controllers/application.rb" -- 1 warnings:
+ApplicationController#start_background_task/block/block is nested (Nested Iterators)
+
+"app/controllers/link_targets_controller.rb" -- 1 warnings:
+LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
+
+"app/controllers/newline_controller.rb" -- 1 warnings:
+NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
+      HERE
+    @lines12 = <<-HERE
+app/controllers/activity_reports_controller.rb -- 4 warnings (+3 masked):
+  ActivityReportsController#authorize_user calls current_user.primary_site_ids multiple times (Duplication)
+  ActivityReportsController#authorize_user calls params[id] multiple times (Duplication)
+  ActivityReportsController#authorize_user calls params[primary_site_id] multiple times (Duplication)
+  ActivityReportsController#authorize_user has approx 6 statements (Long Method)
+app/controllers/application.rb -- 1 warnings:
+  ApplicationController#start_background_task/block/block is nested (Nested Iterators)
+app/controllers/link_targets_controller.rb -- 1 warnings (+1 masked):
+  LinkTargetsController#authorize_user calls current_user.role multiple times (Duplication)
+app/controllers/newline_controller.rb -- 1 warnings:
+  NewlineController#some_method calls current_user.<< "new line\n" multiple times (Duplication)
+      HERE
+  end
+
+  context 'with Reek 1.1 output format' do
+    it 'reports 1.1 style when the output is empty' do
+      @reek.instance_variable_set(:@output, "")
+      @reek.should_not be_reek_12
+    end
+    it 'detects 1.1 format output' do
+      @reek.instance_variable_set(:@output, @lines11)
+      @reek.should_not be_reek_12
+    end
+
+    it 'massages empty output to be unchanged' do
+      @reek.instance_variable_set(:@output, "")
+      @reek.massage_for_reek_12.should be_empty
+    end
+  end
+
+  context 'with Reek 1.2 output format' do
+    it 'detects 1.2 format output' do
+      @reek.instance_variable_set(:@output, @lines12)
+      @reek.should be_reek_12
+    end
+
+    it 'correctly massages 1.2 output' do
+      @reek.instance_variable_set(:@output, @lines12)
+      @reek.massage_for_reek_12.should == @lines11
+    end
+  end
+end

data/spec/generators/roodi_spec.rb

@@ -0,0 +1,24 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Roodi do
+  describe "emit" do
+    it "should add config options when present" do
+      MetricFu::Configuration.run do |config|
+        config.roodi = {:roodi_config => 'lib/config/roodi_config.yml', :dirs_to_roodi => []}
+      end
+      roodi = MetricFu::Roodi.new
+      roodi.should_receive(:`).with(/-config=lib\/config\/roodi_config\.yml/).and_return("")
+      roodi.emit
+    end
+
+    it "should NOT add config options when NOT present" do
+      MetricFu::Configuration.run do |config|
+        config.roodi = {:dirs_to_roodi => []}
+      end
+      roodi = MetricFu::Roodi.new
+      roodi.stub(:`)
+      roodi.should_receive(:`).with(/-config/).never
+      roodi.emit
+    end
+  end
+end

data/spec/generators/saikuro_spec.rb

@@ -0,0 +1,74 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Saikuro do
+  describe "to_h method" do
+    before :all do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      saikuro = MetricFu::Saikuro.new
+      saikuro.stub!(:metric_directory).and_return(File.join(File.dirname(__FILE__), "..", "resources", "saikuro"))
+      saikuro.analyze
+      @output = saikuro.to_h
+    end
+
+    it "should find the filename of a file" do
+      @output[:saikuro][:files].first[:filename].should == 'app/controllers/users_controller.rb'
+    end
+
+    it "should find the name of the classes" do
+      @output[:saikuro][:classes].first[:name].should == "UsersController"
+      @output[:saikuro][:classes][1][:name].should == "SessionsController"
+    end
+
+    it "should put the most complex method first" do
+      @output[:saikuro][:methods].first[:name].should == "UsersController#create"
+      @output[:saikuro][:methods].first[:complexity].should == 4
+    end
+
+    it "should find the complexity of a method" do
+      @output[:saikuro][:methods].first[:complexity].should == 4
+    end
+
+    it "should find the lines of a method" do
+      @output[:saikuro][:methods].first[:lines].should == 15
+    end
+  end
+  
+  describe "per_file_info method" do
+    before :all do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      @saikuro = MetricFu::Saikuro.new
+      @saikuro.stub!(:metric_directory).and_return(File.join(File.dirname(__FILE__), "..", "resources", "saikuro"))
+      @saikuro.analyze
+      @output = @saikuro.to_h
+    end
+    
+    it "doesn't try to get information if the file does not exist" do
+      File.should_receive(:exists?).at_least(:once).and_return(false)
+      @saikuro.per_file_info('ignore_me')
+    end
+  end
+
+  describe "format_directories method" do
+    it "should format the directories" do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      saikuro = MetricFu::Saikuro.new
+
+      MetricFu.saikuro[:input_directory] = ["app", "lib"]
+
+      saikuro.format_directories.should == "\"app | lib\""
+    end
+  end
+
+  describe Saikuro::SFile do
+    describe "getting elements from a Saikuro result file" do
+     it "should parse nested START/END sections" do
+       path = File.join(File.dirname(__FILE__), "..", "resources", "saikuro_sfiles", "thing.rb_cyclo.html")
+        sfile = Saikuro::SFile.new path
+       sfile.elements.map { |e| e.complexity }.sort.should eql(["0","0","2"])
+      end
+    end
+  end
+end

data/spec/generators/stats_spec.rb

@@ -0,0 +1,74 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Stats do
+  describe "emit method" do
+    it "should gather the raw data" do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      stats = MetricFu::Stats.new
+      stats.should_receive(:`).with("rake stats > tmp/metric_fu/scratch/stats/stats.txt")
+      stats.emit
+    end
+  end
+
+  describe "analyze method" do
+    before :each do
+      @lines =  <<-HERE.gsub(/^\s*/, "")
+      +----------------------+-------+-------+---------+---------+-----+-------+
+      | Name                 | Lines |   LOC | Classes | Methods | M/C | LOC/M |
+      +----------------------+-------+-------+---------+---------+-----+-------+
+      | Controllers          |   470 |   382 |       7 |      53 |   7 |     5 |
+      | Helpers              |   128 |    65 |       0 |       6 |   0 |     8 |
+      | Models               |   351 |   285 |       9 |      31 |   3 |     7 |
+      | Libraries            |   305 |   183 |       2 |      30 |  15 |     4 |
+      | Model specs          |   860 |   719 |       0 |       2 |   0 |   357 |
+      | View specs           |     0 |     0 |       0 |       0 |   0 |     0 |
+      | Controller specs     |  1570 |  1308 |       1 |      10 |  10 |   128 |
+      | Helper specs         |   191 |   172 |       0 |       0 |   0 |     0 |
+      | Library specs        |    31 |    27 |       0 |       0 |   0 |     0 |
+      +----------------------+-------+-------+---------+---------+-----+-------+
+      | Total                |  3906 |  3141 |      19 |     132 |   6 |    21 |
+      +----------------------+-------+-------+---------+---------+-----+-------+
+        Code LOC: 915     Test LOC: 2226     Code to Test Ratio: 1:2.4
+
+      HERE
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      stats = MetricFu::Stats.new
+      File.should_receive(:open).and_return(mock("file", :read => @lines))
+      @results = stats.analyze
+    end
+
+    it "should get code Lines Of Code" do
+      @results[:codeLOC].should == 915
+    end
+
+    it "should get test Lines Of Code" do
+      @results[:testLOC].should == 2226
+    end
+
+    it "should get code to test ratio" do
+      @results[:code_to_test_ratio].should == 2.4
+    end
+
+    it "should get data on models" do
+      model_data = @results[:lines].find {|line| line[:name] == "Models"}
+      model_data[:classes].should == 9
+      model_data[:methods].should == 31
+      model_data[:loc].should == 285
+      model_data[:lines].should == 351
+      model_data[:methods_per_class].should == 3
+      model_data[:loc_per_method].should == 7
+    end
+  end
+
+  describe "to_h method" do
+    it "should put things into a hash" do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      stats = MetricFu::Stats.new
+      stats.instance_variable_set(:@stats, "the_stats")
+      stats.to_h[:stats].should == "the_stats"
+    end
+  end
+end

data/spec/graphs/engines/bluff_spec.rb

@@ -0,0 +1,19 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+
+describe "Bluff graphers responding to #graph!" do
+  it "should write chart file" do
+    MetricFu.configuration
+    graphs = {}
+    available_graphs = MetricFu::AVAILABLE_GRAPHS + [:stats]
+    available_graphs.each do |graph|
+      grapher_name = graph.to_s.gsub("MetricFu::",'').gsub(/\/(.?)/) { "::#{$1.upcase}" }.gsub(/(?:^|_)(.)/) { $1.upcase }
+      grapher_name =  grapher_name+"BluffGrapher"
+      graphs[graph] = MetricFu.const_get(grapher_name).new
+    end
+    graphs.each do |key, val|
+      val.graph!
+      output_dir = File.expand_path(File.join(MetricFu.output_directory))
+      lambda{ File.open(File.join(output_dir, "#{key.to_s.downcase}.js")) }.should_not raise_error
+    end
+  end
+end

data/spec/graphs/engines/gchart_spec.rb

@@ -0,0 +1,156 @@
+require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
+describe MetricFu::Grapher do
+  describe "require_graphing_gem" do
+    it "should give a warning if trying to use gchart but gem is not installed" do
+      MetricFu::Configuration.run {|config| config.graph_engine = :gchart}
+      MetricFu::Grapher.should_receive(:require).with('gchart').and_raise(LoadError)
+      MetricFu::Grapher.should_receive(:puts).with(/If you want to use google charts/)
+      MetricFu::Grapher.require_graphing_gem
+    end
+  end
+end
+
+describe MetricFu::GchartGrapher do
+  describe "determine_y_axis_scale" do
+    it "should set defaults when empty array" do
+      grapher = Object.new.extend(MetricFu::GchartGrapher)
+      grapher.determine_y_axis_scale([])
+      grapher.instance_variable_get(:@max_value).should == 10
+      grapher.instance_variable_get(:@yaxis).should == [0, 2, 4, 6, 8, 10]
+    end
+
+    it "should set max value of the graph above largest value" do
+      grapher = Object.new.extend(MetricFu::GchartGrapher)
+      grapher.determine_y_axis_scale([19])
+      grapher.instance_variable_get(:@max_value).should == 20
+
+      grapher.determine_y_axis_scale([20])
+      grapher.instance_variable_get(:@max_value).should == 25
+    end
+  end
+end
+
+describe "Gchart graphers" do
+  before :each do
+    MetricFu::Configuration.run {|config| config.graph_engine = :gchart}
+  end
+
+  describe "FlayGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = FlayGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Flay: duplication"),
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'flay.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+
+  describe "FlogGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = FlogGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Flog: code complexity"),
+        :stacked => false,
+        :bar_colors => MetricFu::GchartGrapher::COLORS[0..1],
+        :legend => ['average', 'top 5% average'],
+        :custom => "chdlp=t",
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'flog.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+
+  describe "RcovGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = RcovGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Rcov: code coverage"),
+        :max_value => 101,
+        :axis_with_labels => 'x,y',
+        :axis_labels => [grapher.labels.values, [0,20,40,60,80,100]],
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'rcov.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+
+  describe "ReekGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = ReekGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Reek: code smells"),
+        :stacked => false,
+        :bar_colors => MetricFu::GchartGrapher::COLORS,
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'reek.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+
+  describe "RoodiGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = RoodiGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Roodi: potential design problems"),
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'roodi.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+
+  describe "StatsGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = StatsGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Stats: LOC & LOT"),
+        :bar_colors => MetricFu::GchartGrapher::COLORS[0..1],
+        :legend => ['Lines of code', 'Lines of test'],
+        :custom => "chdlp=t",
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'stats.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+
+  describe "RailsBestPracticesGchartGrapher graph! method" do
+    it "should set static values for graph" do
+      grapher = RailsBestPracticesGchartGrapher.new
+      expected = {
+        :size => MetricFu::GchartGrapher::GCHART_GRAPH_SIZE,
+        :title => URI.escape("Rails Best Practices: design problems"),
+        :bar_colors => MetricFu::GchartGrapher::COLORS[0..1],
+        :legend => ['Problems'],
+        :custom => "chdlp=t",
+        :axis_with_labels => 'x,y',
+        :format => 'file',
+        :filename => File.join(MetricFu.output_directory, 'rails_best_practices.png'),
+      }
+      Gchart.should_receive(:line).with(hash_including(expected))
+      grapher.graph!
+    end
+  end
+end