danger 9.5.3 → 9.6.0

data/lib/danger/commands/init.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/commands/init_helpers/interviewer"
 require "danger/danger_core/dangerfile_generator"
 require "danger/ci_source/local_git_repo"
@@ -18,7 +20,7 @@ module Danger
     end
 
     def initialize(argv)
-      @bot_name = File.basename(Dir.getwd).split(".").first.capitalize + "Bot"
+      @bot_name = "#{File.basename(Dir.getwd).split('.').first.capitalize}Bot"
       super
       @ui = Interviewer.new(cork)
       ui.no_delay = argv.flag?("impatient", false)
@@ -63,7 +65,7 @@ module Danger
 
       ui.say "cat #{Dir.pwd}/Dangerfile\n".blue
       content.lines.each do |l|
-        ui.say "  " + l.chomp.green
+        ui.say "  #{l.chomp.green}"
       end
       ui.say ""
       ui.pause 2
@@ -118,7 +120,7 @@ module Danger
 
       if considered_an_oss_repo?
         ui.say "For Open Source projects, I'd recommend giving the token the smallest scope possible."
-        ui.say "This means only providing access to " + "public_repo".yellow + " in the token.\n\n"
+        ui.say "This means only providing access to #{'public_repo'.yellow} in the token.\n\n"
         ui.pause 1
         ui.say "This token limits Danger's abilities to just writing comments on OSS projects. I recommend"
         ui.say "this because the token can quite easily be extracted from the environment via pull requests."
@@ -126,10 +128,10 @@ module Danger
         ui.say "\nIt is important that you do not store this token in your repository, as GitHub will automatically revoke it when pushed.\n"
       elsif @is_open_source == "closed"
         ui.say "For Closed Source projects, I'd recommend giving the token access to the whole repo scope."
-        ui.say "This means only providing access to " + "repo".yellow + ", and its children in the token.\n\n"
+        ui.say "This means only providing access to #{'repo'.yellow}, and its children in the token.\n\n"
         ui.pause 1
-        ui.say "It's worth noting that you " + "should not".bold.white + " re-use this token for OSS repos."
-        ui.say "Make a new one for those repos with just " + "public_repo".yellow + "."
+        ui.say "It's worth noting that you #{'should not'.bold.white} re-use this token for OSS repos."
+        ui.say "Make a new one for those repos with just #{'public_repo'.yellow}."
         ui.pause 1
         ui.say "Additionally, don't forget to add your new GitHub account as a collaborator to your Closed Source project."
       end
@@ -184,13 +186,13 @@ module Danger
       danger = "bundle exec danger".yellow
       config = YAML.load(File.read(".travis.yml"))
       if config.kind_of?(Hash) && config["script"]
-        ui.say "Add " + "- ".yellow + danger + " as a new step in the " + "script".yellow + " section of your .travis.yml file."
+        ui.say "Add #{'- '.yellow}#{danger} as a new step in the #{'script'.yellow} section of your .travis.yml file."
       else
-        ui.say "I'd recommend adding " + "before_script: ".yellow + danger + " to the script section of your .travis.yml file."
+        ui.say "I'd recommend adding #{'before_script: '.yellow}#{danger} to the script section of your .travis.yml file."
       end
 
       ui.pause 1
-      ui.say "You shouldn't use " + "after_success, after_failure, after_script".red + " as they cannot fail your builds."
+      ui.say "You shouldn't use #{'after_success, after_failure, after_script'.red} as they cannot fail your builds."
     end
 
     def uses_circle
@@ -199,9 +201,9 @@ module Danger
 
       if config.kind_of?(Hash) && config["test"]
         if config["test"]["post"]
-          ui.say "Add " + danger + " as a new step in the " + "test:post:".yellow + " section of your circle.yml file."
+          ui.say "Add #{danger} as a new step in the #{'test:post:'.yellow} section of your circle.yml file."
         else
-          ui.say "Add " + danger + " as a new step in the " + "test:override:".yellow + " section of your circle.yml file."
+          ui.say "Add #{danger} as a new step in the #{'test:override:'.yellow} section of your circle.yml file."
         end
       else
         ui.say "Add this to the bottom of your circle.yml file:"
@@ -214,7 +216,7 @@ module Danger
     def unsure_ci
       danger = "bundle exec danger".yellow
       ui.say "As I'm not sure what CI you want to run Danger on based on the files in your repo, I'll just offer some generic"
-      ui.say "advice. You want to run " + danger + " after your tests have finished running, it should still be during the testing"
+      ui.say "advice. You want to run #{danger} after your tests have finished running, it should still be during the testing"
       ui.say "process so the build can fail."
     end
 
@@ -222,7 +224,7 @@ module Danger
       # https://travis-ci.org/artsy/eigen/settings
       ui.say "In order to add an environment variable, go to:"
       ui.link "https://travis-ci.org/#{current_repo_slug}/settings"
-      ui.say "\nThe name is " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Access Token."
+      ui.say "\nThe name is #{'DANGER_GITHUB_API_TOKEN'.yellow} and the value is the GitHub Personal Access Token."
       if @is_open_source
         ui.say 'Make sure to have "Display value in build log" enabled.'
       end
@@ -239,7 +241,7 @@ module Danger
         ui.say "I'll give you a minute to read it..."
         ui.wait_for_return
 
-        ui.say "On danger/danger we turn on " + "Permissive building of fork pull requests".yellow + " this exposes the token to Danger"
+        ui.say "On danger/danger we turn on #{'Permissive building of fork pull requests'.yellow} this exposes the token to Danger"
         ui.say "You can find this setting at:"
         ui.link "https://circleci.com/gh/#{current_repo_slug}/edit#advanced-settings\n"
         ui.say "I'll hold..."
@@ -248,12 +250,12 @@ module Danger
 
       ui.say "In order to expose an environment variable, go to:"
       ui.link "https://circleci.com/gh/#{current_repo_slug}/edit#env-vars"
-      ui.say "The name is " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Access Token."
+      ui.say "The name is #{'DANGER_GITHUB_API_TOKEN'.yellow} and the value is the GitHub Personal Access Token."
     end
 
     def unsure_token
-      ui.say "You need to expose a token called " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Access Token."
-      ui.say "Depending on the CI system, this may need to be done on the machine (in the " + "~/.bashprofile".yellow + ") or in a web UI somewhere."
+      ui.say "You need to expose a token called #{'DANGER_GITHUB_API_TOKEN'.yellow} and the value is the GitHub Personal Access Token."
+      ui.say "Depending on the CI system, this may need to be done on the machine (in the #{'~/.bashprofile'.yellow}) or in a web UI somewhere."
       ui.say "We have a guide for all supported CI systems on danger.systems:"
       ui.link "https://danger.systems/guides/getting_started.html#setting-up-danger-to-run-on-your-ci"
     end
@@ -270,9 +272,9 @@ module Danger
 
     def info
       ui.header "Useful info"
-      ui.say "- One of the best ways to test out new rules locally is via " + "bundle exec danger pr".yellow + "."
+      ui.say "- One of the best ways to test out new rules locally is via #{'bundle exec danger pr'.yellow}."
       ui.pause 0.6
-      ui.say "- You can have Danger output all of her variables to the console via the " + "--verbose".yellow + " option."
+      ui.say "- You can have Danger output all of her variables to the console via the #{'--verbose'.yellow} option."
       ui.pause 0.6
       ui.say "- You can look at the following Dangerfiles to get some more ideas:"
       ui.pause 0.6
@@ -286,7 +288,7 @@ module Danger
       ui.pause 0.6
 
       ui.say "And you're good to go. Danger is a collaboration between Orta Therox, Gem 'Danger' McShane and Felix Krause."
-      ui.say "If you like Danger, let others know. If you want to know more, follow " + "@orta".yellow + " and " + "@KrauseFx".yellow + " on Twitter."
+      ui.say "If you like Danger, let others know. If you want to know more, follow #{'@orta'.yellow} and #{'@KrauseFx'.yellow} on Twitter."
       ui.say "If you don't like Danger, help us improve the project! xxx"
     end
 

data/lib/danger/commands/init_helpers/interviewer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class Interviewer
     attr_accessor :no_delay, :no_waiting, :ui
@@ -33,7 +35,7 @@ module Danger
     end
 
     def link(url)
-      say " -> " + url.underlined + "\n"
+      say " -> #{url.underlined}\n"
     end
 
     def pause(time)
@@ -48,7 +50,7 @@ module Danger
 
     def run_command(command, output_command = nil)
       output_command ||= command
-      ui.puts "  " + output_command.magenta
+      ui.puts "  #{output_command.magenta}"
       system command
     end
 
@@ -58,7 +60,7 @@ module Danger
       print_info = proc do
         possible_answers.each_with_index do |answer, i|
           the_answer = i.zero? ? answer.underlined : answer
-          ui.print " " + the_answer
+          ui.print " #{the_answer}"
           ui.print(" /") if i != possible_answers.length - 1
         end
         ui.print " ]\n"
@@ -77,7 +79,7 @@ module Danger
         # default to first answer
         if answer == ""
           answer = possible_answers[0].downcase
-          ui.puts "Using: " + answer.yellow
+          ui.puts "Using: #{answer.yellow}"
         end
 
         break if possible_answers.map(&:downcase).include? answer

data/lib/danger/commands/local.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/commands/local_helpers/http_cache"
 require "danger/commands/local_helpers/local_setup"
 require "danger/commands/local_helpers/pry_setup"

data/lib/danger/commands/local_helpers/http_cache.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "pstore"
 
 module Danger

data/lib/danger/commands/local_helpers/local_setup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class LocalSetup
     attr_reader :dm, :cork
@@ -28,17 +30,14 @@ module Danger
         cork.puts "Running your Dangerfile against this PR - https://#{gh.host}/#{source.repo_slug}/pull/#{source.pull_request_id}"
       end
 
-      unless verbose
-        cork.puts "Turning on --verbose"
-        dm.verbose = true
-      end
+      dm.verbose = verbose
 
       cork.puts
 
       begin
         gh.fetch_details
       rescue Octokit::NotFound
-        cork.puts "Local repository was not found on GitHub. If you're trying to test a private repository please provide a valid API token through " + "DANGER_GITHUB_API_TOKEN".yellow + " environment variable."
+        cork.puts "Local repository was not found on GitHub. If you're trying to test a private repository please provide a valid API token through #{'DANGER_GITHUB_API_TOKEN'.yellow} environment variable."
         return
       end
 

data/lib/danger/commands/local_helpers/pry_setup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class PrySetup
     def initialize(cork)
@@ -19,7 +21,7 @@ module Danger
 
     attr_reader :cork
 
-    DANGERFILE_COPY = "_Dangerfile.tmp".freeze
+    DANGERFILE_COPY = "_Dangerfile.tmp"
 
     def validate_pry_available(command)
       Kernel.require "pry"

data/lib/danger/commands/mr.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+require "danger/commands/local_helpers/http_cache"
+require "danger/commands/local_helpers/pry_setup"
+require "faraday/http_cache"
+require "fileutils"
+require "tmpdir"
+
+module Danger
+  class MR < Runner
+    self.summary = "Run the Dangerfile locally against GitLab Merge Requests. Does not post to the MR. Usage: danger mr <URL>"
+    self.command = "mr"
+
+    def self.options
+      [
+        ["--clear-http-cache", "Clear the local http cache before running Danger locally."],
+        ["--pry", "Drop into a Pry shell after evaluating the Dangerfile."],
+        ["--dangerfile=<path/to/dangerfile>", "The location of your Dangerfile"]
+      ]
+    end
+
+    def initialize(argv)
+      show_help = true if argv.arguments == ["-h"]
+
+      @mr_url = argv.shift_argument
+      @clear_http_cache = argv.flag?("clear-http-cache", false)
+      dangerfile = argv.option("dangerfile", "Dangerfile")
+
+      # Currently CLAide doesn't support short option like -h https://github.com/CocoaPods/CLAide/pull/60
+      # when user pass in -h, mimic the behavior of passing in --help.
+      argv = CLAide::ARGV.new ["--help"] if show_help
+
+      super
+
+      @dangerfile_path = dangerfile if File.exist?(dangerfile)
+
+      if argv.flag?("pry", false)
+        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path, MR.command)
+      end
+    end
+
+    def validate!
+      super
+      unless @dangerfile_path
+        help! "Could not find a Dangerfile."
+      end
+      unless @mr_url
+        help! "Could not find a merge-request. Usage: danger mr <URL>"
+      end
+    end
+
+    def run
+      ENV["DANGER_USE_LOCAL_GIT"] = "YES"
+      ENV["LOCAL_GIT_MR_URL"] = @mr_url if @mr_url
+
+      configure_gitlab(ENV["DANGER_TMPDIR"] || Dir.tmpdir)
+
+      env = EnvironmentManager.new(ENV, cork)
+      dm = Dangerfile.new(env, cork)
+
+      LocalSetup.new(dm, cork).setup(verbose: verbose) do
+        dm.run(
+          Danger::EnvironmentManager.danger_base_branch,
+          Danger::EnvironmentManager.danger_head_branch,
+          @dangerfile_path,
+          nil,
+          nil,
+          nil,
+          false
+        )
+      end
+    end
+
+    private
+
+    def configure_gitlab(cache_dir)
+      # The require happens inline so that it won't cause exceptions when just using the `danger` gem.
+      require "gitlab"
+
+      # setup caching for GitLab calls to avoid hitting the API rate limit too quickly
+      cache_file = File.join(cache_dir, "danger_local_gitlab_cache")
+      HTTPCache.new(cache_file, clear_cache: @clear_http_cache)
+
+      # Configure GitLab client
+      Gitlab.configure do |config|
+        config.endpoint = ENV["DANGER_GITLAB_API_BASE_URL"] || ENV.fetch("CI_API_V4_URL", "https://gitlab.com/api/v4")
+        config.private_token = ENV["DANGER_GITLAB_API_TOKEN"]
+      end
+    end
+  end
+end

data/lib/danger/commands/plugins/plugin_json.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/plugin_support/plugin_parser"
 require "danger/plugin_support/plugin_file_resolver"
 

data/lib/danger/commands/plugins/plugin_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/plugin_support/plugin_parser"
 require "danger/plugin_support/plugin_file_resolver"
 require "danger/plugin_support/plugin_linter"

data/lib/danger/commands/plugins/plugin_readme.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/plugin_support/plugin_parser"
 require "danger/plugin_support/plugin_file_resolver"
 require "json"

data/lib/danger/commands/pr.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/commands/local_helpers/http_cache"
 require "danger/commands/local_helpers/pry_setup"
 require "faraday/http_cache"
@@ -7,8 +9,8 @@ require "tmpdir"
 
 module Danger
   class PR < Runner
-    self.summary = "Run the Dangerfile locally against Pull Requests (works with forks, too). Does not post to the PR. Usage: danger pr <URL>".freeze
-    self.command = "pr".freeze
+    self.summary = "Run the Dangerfile locally against Pull Requests (works with forks, too). Does not post to the PR. Usage: danger pr <URL>"
+    self.command = "pr"
 
     def self.options
       [

data/lib/danger/commands/runner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class Runner < CLAide::Command
     require "danger/commands/init"
@@ -6,6 +8,7 @@ module Danger
     require "danger/commands/staging"
     require "danger/commands/systems"
     require "danger/commands/pr"
+    require "danger/commands/mr"
 
     # manually set claide plugins as a subcommand
     require "claide_plugin"

data/lib/danger/commands/staging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/commands/local_helpers/pry_setup"
 require "fileutils"
 require "tmpdir"

data/lib/danger/commands/systems.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class Systems < Runner
     self.abstract_command = true
@@ -11,7 +13,7 @@ module Danger
 
     def run
       here = File.dirname(__FILE__)
-      ci_source_paths = Dir.glob(here + "/../ci_source/*.rb")
+      ci_source_paths = Dir.glob("#{here}/../ci_source/*.rb")
 
       require "yard"
       # Pull out all the Danger::CI subclasses docs

data/lib/danger/core_ext/file_list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/helpers/array_subclass"
 
 module Danger

data/lib/danger/core_ext/string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class String
   # @return [String] the plural form of self determined by count
   def danger_pluralize(count)
@@ -6,10 +8,10 @@ class String
 
   # @return [String] converts to underscored, lowercase form
   def danger_underscore
-    self.gsub(/::/, "/".freeze).
-      gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2'.freeze).
-      gsub(/([a-z\d])([A-Z])/, '\1_\2'.freeze).
-      tr("-".freeze, "_".freeze).
+    self.gsub(/::/, "/").
+      gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
+      gsub(/([a-z\d])([A-Z])/, '\1_\2').
+      tr("-", "_").
       downcase
   end
 

data/lib/danger/danger_core/dangerfile.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # So much was ripped direct from CocoaPods-Core - thanks!
 
 require "danger/danger_core/dangerfile_dsl"
@@ -185,8 +187,9 @@ module Danger
         contents.encode!("UTF-8")
       end
 
-      if contents.tr!("“”‘’‛", %(""'''))
-        # Changes have been made
+      sanitised_contents = contents.tr("“”‘’‛", %(""'''))
+      if sanitised_contents != contents
+        contents = sanitised_contents
         ui.puts "Your #{path.basename} has had smart quotes sanitised. " \
           "To avoid issues in the future, you should not use " \
           "TextEdit for editing it. If you are not using TextEdit, " \
@@ -217,7 +220,7 @@ module Danger
 
       ui.section("Results:") do
         %i(errors warnings messages).each do |key|
-          formatted = key.to_s.capitalize + ":"
+          formatted = "#{key.to_s.capitalize}:"
           title = case key
                   when :errors
                     formatted.red
@@ -271,7 +274,7 @@ module Danger
 
     def setup_for_running(base_branch, head_branch)
       env.ensure_danger_branches_are_setup
-      env.scm.diff_for_folder(".".freeze, from: base_branch, to: head_branch, lookup_top_level: true)
+      env.scm.diff_for_folder(".", from: base_branch, to: head_branch, lookup_top_level: true)
     end
 
     def run(base_branch, head_branch, dangerfile_path, danger_id, new_comment, remove_previous_comments, report_results = true)

data/lib/danger/danger_core/dangerfile_dsl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class Dangerfile
     # Anything inside this module is considered public API, and in the future

data/lib/danger/danger_core/dangerfile_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class DangerfileGenerator
     # returns the string for a Dangerfile based on a folder's contents'

data/lib/danger/danger_core/environment_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/ci_source/ci_source"
 require "danger/request_sources/request_source"
 
@@ -19,12 +21,12 @@ module Danger
 
     # @return [String] danger's default head branch
     def self.danger_head_branch
-      "danger_head".freeze
+      "danger_head"
     end
 
     # @return [String] danger's default base branch
     def self.danger_base_branch
-      "danger_base".freeze
+      "danger_base"
     end
 
     def initialize(env, ui = nil, danger_id = "danger")
@@ -87,13 +89,14 @@ module Danger
     private
 
     def get_repo_source(repo_url)
-      if repo_url =~ /github/i
+      case repo_url
+      when /github/i
         RequestSources::GitHub
-      elsif repo_url =~ /gitlab/i
+      when /gitlab/i
         RequestSources::GitLab
-      elsif repo_url =~ /bitbucket\.(org|com)/i
+      when /bitbucket\.(org|com)/i
         RequestSources::BitbucketCloud
-      elsif repo_url =~ /\.visualstudio\.com/i || repo_url =~ /dev\.azure\.com/i
+      when /\.visualstudio\.com/i, /dev\.azure\.com/i
         RequestSources::VSTS
       end
     end
@@ -112,12 +115,12 @@ module Danger
     end
 
     def ui_display_no_request_source_error_message(ui, env, title, subtitle)
-      ui.title "Could not set up API to Code Review site for Danger\n".freeze
+      ui.title "Could not set up API to Code Review site for Danger\n"
       ui.puts title
       ui.puts subtitle
-      ui.puts "\nFound these keys in your ENV: #{env.keys.join(', '.freeze)}."
-      ui.puts "\nFailing the build, Danger cannot run without API access.".freeze
-      ui.puts "You can see more information at https://danger.systems/guides/getting_started.html".freeze
+      ui.puts "\nFound these keys in your ENV: #{env.keys.join(', ')}."
+      ui.puts "\nFailing the build, Danger cannot run without API access."
+      ui.puts "You can see more information at https://danger.systems/guides/getting_started.html"
     end
 
     def travis_note

data/lib/danger/danger_core/executor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Danger
   class Executor
     def initialize(system_env)
@@ -61,7 +63,7 @@ module Danger
       unless EnvironmentManager.pr?(system_env)
         ci_name = EnvironmentManager.local_ci_source(system_env).name.split("::").last
 
-        msg = "Not a #{ci_name} #{commit_request(ci_name)} - skipping `danger` run. "
+        msg = +"Not a #{ci_name} #{commit_request(ci_name)} - skipping `danger` run. "
         # circle won't run danger properly if the commit is pushed and build runs before the PR exists
         # https://danger.systems/guides/troubleshooting.html#circle-ci-doesnt-run-my-build-consistently
         # the best solution is to enable `fail_if_no_pr`, and then re-run the job once the PR is up

data/lib/danger/danger_core/messages/base.rb

@@ -1,12 +1,17 @@
+# frozen_string_literal: true
+
 module Danger
   class BaseMessage
-    attr_accessor :message, :file, :line, :type
+    attr_accessor :message, :file, :line, :type, :start_line, :side, :start_side
 
-    def initialize(type:, message:, file: nil, line: nil)
+    def initialize(type:, message:, file: nil, line: nil, start_line: nil, side: nil, start_side: nil)
       @type = type
       @message = message
       @file = file
       @line = line
+      @start_line = start_line
+      @side = side
+      @start_side = start_side
     end
 
     def compare_by_file_and_line(other)

data/lib/danger/danger_core/messages/markdown.rb

@@ -4,8 +4,21 @@ require "danger/danger_core/messages/base"
 
 module Danger
   class Markdown < BaseMessage
-    def initialize(message, file = nil, line = nil)
-      super(type: :markdown, message: message, file: file, line: line)
+    VALID_SIDES = %w(LEFT RIGHT).freeze
+
+    def initialize(message, file = nil, line = nil, start_line: nil, side: nil, start_side: nil)
+      validate_side!(:side, side)
+      validate_side!(:start_side, start_side)
+
+      super(
+        type: :markdown,
+        message: message,
+        file: file,
+        line: line,
+        start_line: start_line,
+        side: side,
+        start_side: start_side
+      )
     end
 
     def ==(other)
@@ -14,20 +27,29 @@ module Danger
 
       other.message == message &&
         other.file == file &&
-        other.line == line
+        other.line == line &&
+        other.start_line == start_line &&
+        other.side == side &&
+        other.start_side == start_side
     end
 
     def hash
       h = 1
       h = h * 31 + message.hash
       h = h * 17 + file.hash
-      h * 17 + line.hash
+      h = h * 17 + line.hash
+      h = h * 17 + start_line.hash
+      h = h * 17 + side.hash
+      h * 17 + start_side.hash
     end
 
     def to_s
       extra = []
-      extra << "file: #{file}" unless file
-      extra << "line: #{line}" unless line
+      extra << "file: #{file}" if file
+      extra << "line: #{line}" if line
+      extra << "start_line: #{start_line}" if start_line
+      extra << "side: #{side}" if side
+      extra << "start_side: #{start_side}" if start_side
 
       "Markdown #{message} { #{extra.join ', '} }"
     end
@@ -37,5 +59,13 @@ module Danger
 
       compare_by_file_and_line(other)
     end
+
+    private
+
+    def validate_side!(name, value)
+      return if value.nil? || VALID_SIDES.include?(value)
+
+      raise ArgumentError, "#{name} must be LEFT or RIGHT"
+    end
   end
 end

data/lib/danger/danger_core/plugins/dangerfile_bitbucket_cloud_plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/plugin_support/plugin"
 
 module Danger