danger 9.3.0 → 9.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28e1b237f9fc7857aca64881f72c1c247ec9f83d0f22985866f7b7b59e407551
-  data.tar.gz: b1ffee7037fd3e8bfd25103557ec78f51792c1f24c46f2d5ce624b38c8582761
+  metadata.gz: 7310f8ce0107be43eb12fbf841273878fb0fd4c8e8a0f623689506a930c354cc
+  data.tar.gz: 1b187cc8027ed57b2f204f3e8222f4373baf40c63e94a35bdcc22079dfbc1d47
 SHA512:
-  metadata.gz: 1b196a2f4f291b2a961948bb56518921285142763c8265478d6050992756fb4fef2bcc33fdbfa15187e8384a16f68b20903fd41475ab55578a3dbcd5fea60d75
-  data.tar.gz: 81f1adb962e7031baf701487d29e37ccd7daeb499471adbc1c663e1da8db87333c312d1c9875fa6a571acba9a429d6cae3a49fac3cf2ff4270a9c157ff4df469
+  metadata.gz: dd4d4a9b2810edde68fb71823868c3566fd3f12141876f46d7b2b91c381901c328550e3f3521fcbcfd4faa27f16a435dc4f81e09e30708aef5e6ce103ef5dc32
+  data.tar.gz: b19572d95dfdc38061db32f12a77cdc4f7e21c5447f75214a489467140a3d3caee4e1ac3501a5a87aba5b1037614d20b5aa50a33ee0248b1480d489d2b7d3e6b

data/README.md

@@ -2,8 +2,7 @@
 
 [![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/orta/danger/blob/master/LICENSE)
 [![Gem](https://img.shields.io/gem/v/danger.svg?style=flat)](http://rubygems.org/gems/danger)
-[![Travis CI](https://img.shields.io/travis/danger/danger.svg?style=flat)](https://travis-ci.org/danger/danger)
-[![Join the community on Spectrum](https://withspectrum.github.io/badge/badge.svg)](https://spectrum.chat/danger)
+[![CI](https://github.com/danger/danger/actions/workflows/CI.yml/badge.svg)](https://github.com/danger/danger/actions/workflows/CI.yml)
 
 Formalize your Pull Request etiquette.
 

data/lib/danger/ci_source/azure_pipelines.rb

@@ -29,8 +29,6 @@ module Danger
   # which will automatically get your vsts domain and your project name needed for the vsts api.
   #
   class AzurePipelines < CI
-
-
     def self.validates_as_ci?(env)
       has_all_variables = ["AGENT_ID", "BUILD_SOURCEBRANCH", "BUILD_REPOSITORY_URI", "BUILD_REASON", "BUILD_REPOSITORY_NAME"].all? { |x| env[x] && !env[x].empty? }
 

data/lib/danger/ci_source/ci_source.rb

@@ -31,7 +31,7 @@ module Danger
     end
 
     def initialize(_env)
-      raise "Subclass and overwrite initialize"
+      raise "Subclass and overwrite initialize" if method(__method__).owner == Danger::CI
     end
   end
 end

data/lib/danger/ci_source/custom_ci_with_github.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "danger/request_sources/github/github"
 
 module Danger
@@ -31,6 +33,8 @@ module Danger
     end
 
     def initialize(env)
+      super
+
       self.repo_slug = env["GITHUB_REPOSITORY"]
       pull_request_event = JSON.parse(File.read(env["GITHUB_EVENT_PATH"]))
       self.pull_request_id = pull_request_event["number"]

data/lib/danger/ci_source/support/pull_request_finder.rb

@@ -146,7 +146,7 @@ module Danger
         require "danger/request_sources/bitbucket_server_api"
         project, slug = repo_slug.split("/")
         RequestSources::BitbucketServerAPI.new(project, slug, specific_pull_request_id, env)
-      
+
       when :vsts
         require "danger/request_sources/vsts_api"
         RequestSources::VSTSAPI.new(repo_slug, specific_pull_request_id, env)
@@ -181,7 +181,7 @@ module Danger
       elsif remote_url =~ %r{/pull-requests/}
         :bitbucket_server
       elsif remote_url =~ /\.visualstudio\.com/i || remote_url =~ /dev\.azure\.com/i
-        :vsts 
+        :vsts
       else
         :github
       end

data/lib/danger/request_sources/bitbucket_cloud.rb

@@ -70,18 +70,14 @@ module Danger
       def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [], danger_id: "danger", new_comment: false, remove_previous_comments: false)
         delete_old_comments(danger_id: danger_id) if !new_comment || remove_previous_comments
 
-        comment = generate_description(warnings: warnings, errors: errors, template: "bitbucket_server")
-        comment += "\n\n"
-
         warnings = update_inline_comments_for_kind!(:warnings, warnings, danger_id: danger_id)
         errors = update_inline_comments_for_kind!(:errors, errors, danger_id: danger_id)
         messages = update_inline_comments_for_kind!(:messages, messages, danger_id: danger_id)
         markdowns = update_inline_comments_for_kind!(:markdowns, markdowns, danger_id: danger_id)
 
-        has_comments = (warnings.count > 0 || errors.count > 0 || messages.count > 0 || markdowns.count > 0)
+        has_comments = (warnings.count.positive? || errors.count.positive? || messages.count.positive? || markdowns.count.positive?)
         if has_comments
-          comment = generate_description(warnings: warnings,
-                                         errors: errors)
+          comment = generate_description(warnings: warnings, errors: errors, template: "bitbucket_server")
           comment += "\n\n"
           comment += generate_comment(warnings: warnings,
                                       errors: errors,

data/lib/danger/scm_source/git_repo.rb

@@ -8,13 +8,9 @@ module Danger
 
     def diff_for_folder(folder, from: "master", to: "HEAD", lookup_top_level: false)
       self.folder = folder
-      git_top_level = folder
-      if lookup_top_level
-        Dir.chdir(folder) do
-          git_top_level = exec("rev-parse --show-toplevel")
-        end
-      end
-      repo = Git.open git_top_level
+      git_top_level = find_git_top_level_if_needed!(folder, lookup_top_level)
+
+      repo = Git.open(git_top_level)
 
       ensure_commitish_exists!(from)
       ensure_commitish_exists!(to)
@@ -168,6 +164,26 @@ module Danger
     def commit_is_ref?(commit)
       /[a-f0-9]{5,40}/ !~ commit
     end
+
+    def find_git_top_level_if_needed!(folder, lookup_top_level)
+      git_top_level = Dir.chdir(folder) { exec("rev-parse --show-toplevel") }
+      return git_top_level if lookup_top_level
+
+      # To keep backward compatibility, `GitRepo#diff_for_folder` expects folder
+      # to be top level git directory or requires `true` to `lookup_top_level`.
+      # https://github.com/danger/danger/pull/1178
+      return folder if compare_path(git_top_level, folder)
+
+      message = "#{folder} is not the top level git directory. Pass correct path or `true` to `lookup_top_level` option for `diff_for_folder`"
+      raise ArgumentError, message
+    end
+
+    # Compare given paths as realpath. Return true if both are same.
+    # `git rev-parse --show-toplevel` returns a path resolving symlink. In rspec, given path can
+    # be a temporary directory's path created under a symlinked directory `/var`.
+    def compare_path(path1, path2)
+      Pathname.new(path1).realdirpath == Pathname.new(path2).realdirpath
+    end
   end
 end
 

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "9.3.0".freeze
+  VERSION = "9.3.2".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 9.3.0
+  version: 9.3.2
 platform: ruby
 authors:
 - Orta Therox
 - Juanito Fatas
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-21 00:00:00.000000000 Z
+date: 2023-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -107,14 +107,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: kramdown
   requirement: !ruby/object:Gem::Requirement
@@ -163,14 +163,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
@@ -329,7 +329,7 @@ homepage: https://github.com/danger/danger
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -344,8 +344,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.
 test_files: []