danger 9.3.0 → 9.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28e1b237f9fc7857aca64881f72c1c247ec9f83d0f22985866f7b7b59e407551
-  data.tar.gz: b1ffee7037fd3e8bfd25103557ec78f51792c1f24c46f2d5ce624b38c8582761
+  metadata.gz: 719588ed490c1115e2439aabacb0dd400e1852bf03a0f25514b26dcb08e0ad9e
+  data.tar.gz: 7426ab63483923ceffd843789c473a46f7726b1f9057a74b558bbeeb2c6948d9
 SHA512:
-  metadata.gz: 1b196a2f4f291b2a961948bb56518921285142763c8265478d6050992756fb4fef2bcc33fdbfa15187e8384a16f68b20903fd41475ab55578a3dbcd5fea60d75
-  data.tar.gz: 81f1adb962e7031baf701487d29e37ccd7daeb499471adbc1c663e1da8db87333c312d1c9875fa6a571acba9a429d6cae3a49fac3cf2ff4270a9c157ff4df469
+  metadata.gz: 9fa39fb8d2a11ac973a1c4b7a9647bef1a0bfdd36411d403e1f3121b3a1b7490dbaa7489c17f018fa1ae88be4ceccc6ee213267ee32133dfbf162cb3bab93e6f
+  data.tar.gz: 01ba1c81cfdb4a37661826f913ed3227e1432fbbede1d69e6521eacfd4d6c8595f8a5140134c431446b591f81027797a4f93b67b674fcfd9c860d452575ea5fb

data/lib/danger/scm_source/git_repo.rb

@@ -8,13 +8,9 @@ module Danger
 
     def diff_for_folder(folder, from: "master", to: "HEAD", lookup_top_level: false)
       self.folder = folder
-      git_top_level = folder
-      if lookup_top_level
-        Dir.chdir(folder) do
-          git_top_level = exec("rev-parse --show-toplevel")
-        end
-      end
-      repo = Git.open git_top_level
+      git_top_level = find_git_top_level_if_needed!(folder, lookup_top_level)
+
+      repo = Git.open(git_top_level)
 
       ensure_commitish_exists!(from)
       ensure_commitish_exists!(to)
@@ -168,6 +164,26 @@ module Danger
     def commit_is_ref?(commit)
       /[a-f0-9]{5,40}/ !~ commit
     end
+
+    def find_git_top_level_if_needed!(folder, lookup_top_level)
+      git_top_level = Dir.chdir(folder) { exec("rev-parse --show-toplevel") }
+      return git_top_level if lookup_top_level
+
+      # To keep backward compatibility, `GitRepo#diff_for_folder` expects folder
+      # to be top level git directory or requires `true` to `lookup_top_level`.
+      # https://github.com/danger/danger/pull/1178
+      return folder if compare_path(git_top_level, folder)
+
+      message = "#{folder} is not the top level git directory. Pass correct path or `true` to `lookup_top_level` option for `diff_for_folder`"
+      raise ArgumentError, message
+    end
+
+    # Compare given paths as realpath. Return true if both are same.
+    # `git rev-parse --show-toplevel` returns a path resolving symlink. In rspec, given path can
+    # be a temporary directory's path created under a symlinked directory `/var`.
+    def compare_path(path1, path2)
+      Pathname.new(path1).realdirpath == Pathname.new(path2).realdirpath
+    end
   end
 end
 

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "9.3.0".freeze
+  VERSION = "9.3.1".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 9.3.0
+  version: 9.3.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-21 00:00:00.000000000 Z
+date: 2023-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -107,14 +107,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: kramdown
   requirement: !ruby/object:Gem::Requirement
@@ -163,14 +163,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement