danger 9.2.0 → 9.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ad61c252b1b62b1fb4e7aa07c2ef21727ada06dcfdd66e23ce70840ab37fcff
-  data.tar.gz: a1e98cfa27d937448822f2ece399fc157b5f30358ed675f976ccc7c20b7bfb5f
+  metadata.gz: 719588ed490c1115e2439aabacb0dd400e1852bf03a0f25514b26dcb08e0ad9e
+  data.tar.gz: 7426ab63483923ceffd843789c473a46f7726b1f9057a74b558bbeeb2c6948d9
 SHA512:
-  metadata.gz: f4531b7f35bccbfdc0df07dedae51b009e1a9a0bcf00d566293d28c143c1a00e29f3ef8f7e47421a6ff32e48cd8b2b640866392aab161d0e95d16d9eff6ad1b6
-  data.tar.gz: fcce02992e6488c454ca914e4a81be0d397cbd19b9f3e63cf058c05068606376020281b552cb489b9d88bf8d0958b6a99b442093d62123a095c3d4418955a1c1
+  metadata.gz: 9fa39fb8d2a11ac973a1c4b7a9647bef1a0bfdd36411d403e1f3121b3a1b7490dbaa7489c17f018fa1ae88be4ceccc6ee213267ee32133dfbf162cb3bab93e6f
+  data.tar.gz: 01ba1c81cfdb4a37661826f913ed3227e1432fbbede1d69e6521eacfd4d6c8595f8a5140134c431446b591f81027797a4f93b67b674fcfd9c860d452575ea5fb

data/lib/danger/ci_source/custom_ci_with_github.rb

@@ -0,0 +1,45 @@
+require "danger/request_sources/github/github"
+
+module Danger
+  # ### CI Setup
+  #
+  # Custom CI with GitHub
+  #
+  # This CI source is for custom, most likely internal, CI systems that are use GitHub as source control.
+  # An example could be argo-workflows or tekton hosted in your own Kubernetes cluster.
+  #
+  # The following environment variables are required:
+  # - `CUSTOM_CI_WITH_GITHUB` - Set to any value to indicate that this is a custom CI with GitHub
+  #
+  # ### Token Setup
+  #
+  # #### GitHub
+  # As you own the setup, it's up to you to add the environment variable for the `DANGER_GITHUB_API_TOKEN`.
+  #
+  class CustomCIWithGithub < CI
+    def self.validates_as_ci?(env)
+      env.key? "CUSTOM_CI_WITH_GITHUB"
+    end
+
+    def self.validates_as_pr?(env)
+      value = env["GITHUB_EVENT_NAME"]
+      ["pull_request", "pull_request_target"].include?(value)
+    end
+
+    def supported_request_sources
+      @supported_request_sources ||= [Danger::RequestSources::GitHub]
+    end
+
+    def initialize(env)
+      self.repo_slug = env["GITHUB_REPOSITORY"]
+      pull_request_event = JSON.parse(File.read(env["GITHUB_EVENT_PATH"]))
+      self.pull_request_id = pull_request_event["number"]
+      self.repo_url = pull_request_event["repository"]["clone_url"]
+
+      # if environment variable DANGER_GITHUB_API_TOKEN is not set, use env GITHUB_TOKEN
+      if (env.key? "CUSTOM_CI_WITH_GITHUB") && (!env.key? "DANGER_GITHUB_API_TOKEN")
+        env["DANGER_GITHUB_API_TOKEN"] = env["GITHUB_TOKEN"]
+      end
+    end
+  end
+end

data/lib/danger/commands/local.rb

@@ -49,7 +49,7 @@ module Danger
 
       configure_octokit(ENV["DANGER_TMPDIR"] || Dir.tmpdir)
 
-      env = EnvironmentManager.new(ENV, cork)
+      env = EnvironmentManager.new(ENV, cork, @danger_id)
       dm = Dangerfile.new(env, cork)
 
       LocalSetup.new(dm, cork).setup(verbose: verbose) do
@@ -57,7 +57,7 @@ module Danger
           Danger::EnvironmentManager.danger_base_branch,
           Danger::EnvironmentManager.danger_head_branch,
           @dangerfile_path,
-          nil,
+          @danger_id,
           nil,
           nil
         )

data/lib/danger/request_sources/bitbucket_cloud.rb

@@ -78,15 +78,20 @@ module Danger
         messages = update_inline_comments_for_kind!(:messages, messages, danger_id: danger_id)
         markdowns = update_inline_comments_for_kind!(:markdowns, markdowns, danger_id: danger_id)
 
-        comment += generate_comment(warnings: warnings,
-                                    errors: errors,
-                                    messages: messages,
-                                    markdowns: markdowns,
-                                    previous_violations: {},
-                                    danger_id: danger_id,
-                                    template: "bitbucket_server")
-
-        @api.post_comment(comment)
+        has_comments = (warnings.count > 0 || errors.count > 0 || messages.count > 0 || markdowns.count > 0)
+        if has_comments
+          comment = generate_description(warnings: warnings,
+                                         errors: errors)
+          comment += "\n\n"
+          comment += generate_comment(warnings: warnings,
+                                      errors: errors,
+                                      messages: messages,
+                                      markdowns: markdowns,
+                                      previous_violations: {},
+                                      danger_id: danger_id,
+                                      template: "bitbucket_server")
+          @api.post_comment(comment)
+        end
       end
 
       def update_pr_by_line!(message_groups:,

data/lib/danger/scm_source/git_repo.rb

@@ -8,13 +8,9 @@ module Danger
 
     def diff_for_folder(folder, from: "master", to: "HEAD", lookup_top_level: false)
       self.folder = folder
-      git_top_level = folder
-      if lookup_top_level
-        Dir.chdir(folder) do
-          git_top_level = exec("rev-parse --show-toplevel")
-        end
-      end
-      repo = Git.open git_top_level
+      git_top_level = find_git_top_level_if_needed!(folder, lookup_top_level)
+
+      repo = Git.open(git_top_level)
 
       ensure_commitish_exists!(from)
       ensure_commitish_exists!(to)
@@ -168,6 +164,26 @@ module Danger
     def commit_is_ref?(commit)
       /[a-f0-9]{5,40}/ !~ commit
     end
+
+    def find_git_top_level_if_needed!(folder, lookup_top_level)
+      git_top_level = Dir.chdir(folder) { exec("rev-parse --show-toplevel") }
+      return git_top_level if lookup_top_level
+
+      # To keep backward compatibility, `GitRepo#diff_for_folder` expects folder
+      # to be top level git directory or requires `true` to `lookup_top_level`.
+      # https://github.com/danger/danger/pull/1178
+      return folder if compare_path(git_top_level, folder)
+
+      message = "#{folder} is not the top level git directory. Pass correct path or `true` to `lookup_top_level` option for `diff_for_folder`"
+      raise ArgumentError, message
+    end
+
+    # Compare given paths as realpath. Return true if both are same.
+    # `git rev-parse --show-toplevel` returns a path resolving symlink. In rspec, given path can
+    # be a temporary directory's path created under a symlinked directory `/var`.
+    def compare_path(path1, path2)
+      Pathname.new(path1).realdirpath == Pathname.new(path2).realdirpath
+    end
   end
 end
 

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "9.2.0".freeze
+  VERSION = "9.3.1".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 9.2.0
+  version: 9.3.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-28 00:00:00.000000000 Z
+date: 2023-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -107,14 +107,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.13'
 - !ruby/object:Gem::Dependency
   name: kramdown
   requirement: !ruby/object:Gem::Requirement
@@ -163,14 +163,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
@@ -223,6 +223,7 @@ files:
 - lib/danger/ci_source/codemagic.rb
 - lib/danger/ci_source/codeship.rb
 - lib/danger/ci_source/concourse.rb
+- lib/danger/ci_source/custom_ci_with_github.rb
 - lib/danger/ci_source/dotci.rb
 - lib/danger/ci_source/drone.rb
 - lib/danger/ci_source/github_actions.rb
@@ -343,8 +344,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.