danger 8.4.5 → 9.3.0

data/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb

@@ -74,6 +74,8 @@ module Danger
     # @option opts [String] :github GitHub repo
     # @option opts [String] :gitlab GitLab repo
     # @option opts [String] :gem Gem name
+    # @option opts [String] :ref The name of branch, tag or commit
+    # @option opts [String] :branch Alias of :ref
     # @option opts [String] :path Path to Dangerfile
     # @return   [void]
     def import_dangerfile(opts)
@@ -82,9 +84,9 @@ module Danger
         import_dangerfile_from_github(opts)
       elsif opts.kind_of?(Hash)
         if opts.key?(:github)
-          import_dangerfile_from_github(opts[:github], opts[:branch], opts[:path])
+          import_dangerfile_from_github(opts[:github], opts[:ref] || opts[:branch], opts[:path])
         elsif opts.key?(:gitlab)
-          import_dangerfile_from_gitlab(opts[:gitlab], opts[:branch], opts[:path])
+          import_dangerfile_from_gitlab(opts[:gitlab], opts[:ref] || opts[:branch], opts[:path])
         elsif opts.key?(:path)
           import_dangerfile_from_path(opts[:path])
         elsif opts.key?(:gem)
@@ -132,7 +134,8 @@ module Danger
     #
     def import_dangerfile_from_path(path)
       raise "`import_dangerfile_from_path` requires a string" unless path.kind_of?(String)
-      local_path = File.join(path, "Dangerfile")
+
+      local_path = File.file?(path) ? path : File.join(path, "Dangerfile")
       @dangerfile.parse(Pathname.new(local_path))
     end
 
@@ -145,6 +148,7 @@ module Danger
     #
     def import_dangerfile_from_gem(name)
       raise "`import_dangerfile_from_gem` requires a string" unless name.kind_of?(String)
+
       spec = Gem::Specification.find_by_name(name)
       import_dangerfile_from_path(spec.gem_dir)
     rescue Gem::MissingSpecError
@@ -164,6 +168,7 @@ module Danger
     #
     def import_dangerfile_from_github(slug, branch = nil, path = nil)
       raise "`import_dangerfile_from_github` requires a string" unless slug.kind_of?(String)
+
       org, repo = slug.split("/")
       download_url = env.request_source.file_url(organisation: org, repository: repo, branch: branch, path: path || "Dangerfile")
       local_path = download(download_url)
@@ -196,6 +201,7 @@ module Danger
     #
     def import_dangerfile_from_url(url)
       raise "`import_dangerfile_from_url` requires a string" unless url.kind_of?(String)
+
       local_path = download(url)
       @dangerfile.parse(Pathname.new(local_path))
     end

data/lib/danger/danger_core/plugins/dangerfile_git_plugin.rb

@@ -22,7 +22,7 @@ module Danger
   #
   # @example Warn when there are merge commits in the diff
   #
-  #          if git.commits.any? { |c| c.message =~ /^Merge branch 'master'/ }
+  #          if git.commits.any? { |c| c.parents.count > 1 }
   #            warn 'Please rebase to get rid of the merge commits in this PR'
   #          end
   #
@@ -46,7 +46,7 @@ module Danger
 
     def initialize(dangerfile)
       super(dangerfile)
-      raise unless dangerfile.env.scm.class == Danger::GitRepo
+      raise unless dangerfile.env.scm.class == Danger::GitRepo # rubocop:disable Style/ClassEqualityComparison
 
       @git = dangerfile.env.scm
     end
@@ -128,7 +128,7 @@ module Danger
     # @return [Git::Diff::DiffFile] from the gem `git`
     #
     def diff_for_file(file)
-      (added_files + modified_files).include?(file) ? @git.diff[file] : nil
+      (added_files + modified_files + deleted_files).include?(file) ? @git.diff[file] : nil
     end
 
     # @!group Git Metadata
@@ -137,6 +137,7 @@ module Danger
     #
     def info_for_file(file)
       return nil unless modified_files.include?(file) || added_files.include?(file) || deleted_files.include?(file)
+
       stats = @git.diff.stats[:files][file]
       diff = @git.diff[file]
       {

data/lib/danger/danger_core/plugins/dangerfile_github_plugin.rb

@@ -76,6 +76,7 @@ module Danger
     # So that this init can fail.
     def self.new(dangerfile)
       return nil if dangerfile.env.request_source.class != Danger::RequestSources::GitHub
+
       super
     end
 
@@ -229,6 +230,7 @@ module Danger
       end
 
       return paths.first if paths.count < 2
+
       paths.first(paths.count - 1).join(", ") + " & " + paths.last
     end
 

data/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

@@ -65,7 +65,7 @@ module Danger
   #           message "Reviewer roulete rolled for: #{reviewer.to_hash['name']} (@#{reviewer.to_hash['username']})"
   #           gitlab.api.update_merge_request(project_id, mr_id, { assignee_id: reviewer.to_hash["id"] })
   #         end
-  # 
+  #
   #
   # @see  danger/danger
   # @tags core, gitlab
@@ -74,6 +74,7 @@ module Danger
     # So that this init can fail.
     def self.new(dangerfile)
       return nil if dangerfile.env.request_source.class != Danger::RequestSources::GitLab
+
       super
     end
 
@@ -240,6 +241,7 @@ module Danger
       end
 
       return paths.first if paths.count < 2
+
       paths.first(paths.count - 1).join(", ") + " & " + paths.last
     end
 

data/lib/danger/danger_core/plugins/dangerfile_local_only_plugin.rb

@@ -3,15 +3,15 @@ require "danger/plugin_support/plugin"
 # Danger
 module Danger
   # Handles interacting with local only plugin inside a Dangerfile.
-  # It is support pluggin for dry_run command and does not expose any methods.
+  # It is support plugin for dry_run command and does not expose any methods.
   # But you can still use other plugins like git
   #
-  # @example Check that added lines contains agreed form of words 
+  # @example Check that added lines contains agreed form of words
   #
   #       git.diff.each do |chunk|
   #         chunk.patch.lines.grep(/^\+/).each do |added_line|
   #           if added_line.gsub!(/(?<cancel>cancel)(?<rest>[^l[[:space:]][[:punct:]]]+)/i, '>>\k<cancel>-l-\k<rest><<')
-  #             fail "Single 'L' for cancellation-alike words in '#{added_line}'" 
+  #             fail "Single 'L' for cancellation-alike words in '#{added_line}'"
   #           end
   #         end
   #       end
@@ -23,6 +23,7 @@ module Danger
     # So that this init can fail.
     def self.new(dangerfile)
       return nil if dangerfile.env.request_source.class != Danger::RequestSources::LocalOnly
+
       super
     end
 

data/lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb

@@ -149,6 +149,7 @@ module Danger
 
       warnings.flatten.each do |warning|
         next if should_ignore_violation(warning)
+
         @warnings << Violation.new(warning, sticky, file, line, type: :warning) if warning
       end
     end
@@ -174,11 +175,12 @@ module Danger
 
       failures.flatten.each do |failure|
         next if should_ignore_violation(failure)
+
         @errors << Violation.new(failure, sticky, file, line, type: :error) if failure
       end
     end
 
-    alias_method :failure, :fail
+    alias failure fail
 
     # @!group Reporting
     # A list of all messages passed to Danger, including

data/lib/danger/danger_core/plugins/dangerfile_vsts_plugin.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require "danger/plugin_support/plugin"
 
 module Danger
@@ -58,6 +56,7 @@ module Danger
     # So that this init can fail.
     def self.new(dangerfile)
       return nil if dangerfile.env.request_source.class != Danger::RequestSources::VSTS
+
       super
     end
 
@@ -174,6 +173,7 @@ module Danger
       end
 
       return paths.first if paths.count < 2
+
       paths.first(paths.count - 1).join(", ") + " & " + paths.last
     end
 
@@ -184,7 +184,7 @@ module Danger
     end
 
     def branch_name(key)
-      repo_matches = @source.pr_json[key].to_s.match(%r{refs\/heads\/(.*)})
+      repo_matches = @source.pr_json[key].to_s.match(%r{refs/heads/(.*)})
       repo_matches[1] unless repo_matches.nil?
     end
   end

data/lib/danger/danger_core/standard_error.rb

@@ -37,9 +37,7 @@ module Danger
     #         be raised.
     #
     def contents
-      @contents ||= begin
-        dsl_path && File.exist?(dsl_path) && File.read(dsl_path)
-      end
+      @contents ||= dsl_path && File.exist?(dsl_path) && File.read(dsl_path)
     end
 
     # The message of the exception reports the content of podspec for the
@@ -104,6 +102,7 @@ module Danger
 
       trace_line = backtrace.find { |l| l.include?(dsl_path.to_s) } || trace_line
       return result unless trace_line
+
       line_numer = trace_line.split(":")[1].to_i - 1
       return result unless line_numer
 

data/lib/danger/helpers/comments_helper.rb

@@ -11,7 +11,7 @@ module Danger
       include Danger::Helpers::CommentsParsingHelper
 
       def markdown_parser(text)
-        Kramdown::Document.new(text, input: "GFM", smart_quotes: %w[apos apos quot quot])
+        Kramdown::Document.new(text, input: "GFM", smart_quotes: %w(apos apos quot quot))
       end
 
       # !@group Extension points
@@ -24,7 +24,9 @@ module Danger
       # @param [Bool] Should hide any generated link created
       #
       # @return [String] The Markdown compatible link
-      def markdown_link_to_message(message, _)
+      def markdown_link_to_message(message, hide_link)
+        return "" if hide_link
+
         "#{message.file}#L#{message.line}"
       end
 
@@ -86,9 +88,9 @@ module Danger
         @tables = tables
         @markdowns = markdowns.map(&:message)
         @danger_id = danger_id
-        @emoji_mapper = EmojiMapper.new(request_source.sub("_inline",""))
+        @emoji_mapper = EmojiMapper.new(request_source.sub("_inline", ""))
 
-        return ERB.new(File.read(md_template), 0, "-").result(binding)
+        return ERB.new(File.read(md_template), trim_mode: "-").result(binding)
       end
 
       def generate_comment(warnings: [], errors: [], messages: [], markdowns: [], previous_violations: {}, danger_id: "danger", template: "github")
@@ -117,7 +119,6 @@ module Danger
         @resolved = resolved
         request_source_name = template.sub("_message_group", "")
 
-
         apply_template(danger_id: danger_id,
                        markdowns: message_group.markdowns,
                        template: template,
@@ -147,8 +148,8 @@ module Danger
 
       def generate_description(warnings: nil, errors: nil, template: "github")
         emoji_mapper = EmojiMapper.new(template)
-        if errors.empty? && warnings.empty?
-          return ENV['DANGER_SUCCESS_MESSAGE'] || "All green. #{random_compliment}"
+        if (errors.nil? || errors.empty?) && (warnings.nil? || warnings.empty?)
+          return ENV["DANGER_SUCCESS_MESSAGE"] || "All green. #{random_compliment}"
         else
           message = "#{emoji_mapper.map('warning')} "
           message += "#{'Error'.danger_pluralize(errors.count)}. " unless errors.empty?

data/lib/danger/helpers/comments_parsing_helper.rb

@@ -29,6 +29,7 @@ module Danger
         tables.each do |table|
           match = danger_table?(table)
           next unless match
+
           title = match[1]
           kind = table_kind_from_title(title)
           next unless kind
@@ -51,8 +52,8 @@ module Danger
 
       private
 
-      GITHUB_OLD_REGEX = %r{<th width="100%"(.*?)</th>}im
-      NEW_REGEX = %r{<th.*data-danger-table="true"(.*?)</th>}im
+      GITHUB_OLD_REGEX = %r{<th width="100%"(.*?)</th>}im.freeze
+      NEW_REGEX = %r{<th.*data-danger-table="true"(.*?)</th>}im.freeze
 
       def danger_table?(table)
         # The old GitHub specific method relied on

data/lib/danger/helpers/emoji_mapper.rb

@@ -18,7 +18,7 @@ module Danger
     TYPE_TO_EMOJI = {
       error: "no_entry_sign",
       warning: "warning",
-      message: "book",
+      message: "book"
     }.freeze
 
     def initialize(template)

data/lib/danger/plugin_support/plugin.rb

@@ -18,7 +18,6 @@ module Danger
     # Since we have a reference to the Dangerfile containing all the information
     # We need to redirect the self calls to the Dangerfile
 
-    # rubocop:disable Style/MethodMissing
     def method_missing(method_sym, *arguments, **keyword_arguments, &block)
       if keyword_arguments.empty?
         @dangerfile.send(method_sym, *arguments, &block)

data/lib/danger/plugin_support/plugin_linter.rb

@@ -146,6 +146,7 @@ module Danger
     def apply_rules(json, type, rules)
       rules.each do |rule|
         next unless rule.function.call(json)
+
         rule.metadata = json
         rule.type = type
 

data/lib/danger/request_sources/bitbucket_cloud.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require "danger/helpers/comments_helper"
 require "danger/request_sources/bitbucket_cloud_api"
 require "danger/danger_core/message_group"
@@ -80,15 +78,20 @@ module Danger
         messages = update_inline_comments_for_kind!(:messages, messages, danger_id: danger_id)
         markdowns = update_inline_comments_for_kind!(:markdowns, markdowns, danger_id: danger_id)
 
-        comment += generate_comment(warnings: warnings,
-                                    errors: errors,
-                                    messages: messages,
-                                    markdowns: markdowns,
-                                    previous_violations: {},
-                                    danger_id: danger_id,
-                                    template: "bitbucket_server")
-
-        @api.post_comment(comment)
+        has_comments = (warnings.count > 0 || errors.count > 0 || messages.count > 0 || markdowns.count > 0)
+        if has_comments
+          comment = generate_description(warnings: warnings,
+                                         errors: errors)
+          comment += "\n\n"
+          comment += generate_comment(warnings: warnings,
+                                      errors: errors,
+                                      messages: messages,
+                                      markdowns: markdowns,
+                                      previous_violations: {},
+                                      danger_id: danger_id,
+                                      template: "bitbucket_server")
+          @api.post_comment(comment)
+        end
       end
 
       def update_pr_by_line!(message_groups:,
@@ -104,7 +107,6 @@ module Danger
                                             template: "bitbucket_server")
         summary_body += "\n\n"
 
-
         # this isn't the most elegant thing in the world, but we need the group
         # with file: nil, line: nil so we can combine its info in with the
         # summary_body
@@ -145,8 +147,8 @@ module Danger
 
           if kind == :markdown
             body = generate_inline_markdown_body(message,
-                                                danger_id: danger_id,
-                                                template: "bitbucket_server")
+                                                 danger_id: danger_id,
+                                                 template: "bitbucket_server")
           else
             body = generate_inline_comment_body(emoji, message,
                                                 danger_id: danger_id,
@@ -162,6 +164,7 @@ module Danger
       def delete_old_comments(danger_id: "danger")
         @api.fetch_comments.each do |c|
           next if c[:user][:uuid] != @api.my_uuid
+
           @api.delete_comment(c[:id]) if c[:content][:raw] =~ /generated_by_#{danger_id}/
         end
       end

data/lib/danger/request_sources/bitbucket_cloud_api.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# coding: utf-8
 
 require "danger/helpers/comments_helper"
 
@@ -57,7 +56,7 @@ module Danger
       def fetch_comments
         values = []
         # TODO: use a url parts encoder to encode the query
-        corrected_uuid = @my_uuid[1...-1] if !@my_uuid.nil? # Endpoint doesnt support curly brackets for this, so remove them for this
+        corrected_uuid = @my_uuid[1...-1] unless @my_uuid.nil? # Endpoint doesnt support curly brackets for this, so remove them for this
         uri = "#{pr_api_endpoint}/comments?pagelen=100&q=deleted+%7E+false+AND+user.uuid+%7E+%22#{corrected_uuid}%22"
 
         while uri
@@ -114,7 +113,7 @@ module Danger
         uri = URI.parse("https://bitbucket.org/site/oauth2/access_token")
         req = Net::HTTP::Post.new(uri.request_uri, { "Content-Type" => "application/json" })
         req.basic_auth oauth_key, oauth_secret
-        req.set_form_data({'grant_type' => 'client_credentials'})
+        req.set_form_data({ "grant_type" => "client_credentials" })
         res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
           http.request(req)
         end
@@ -177,7 +176,6 @@ module Danger
       def error_fetching_json(url, status_code)
         "Error fetching json for: #{url}, status code: #{status_code}"
       end
-
     end
   end
 end

data/lib/danger/request_sources/bitbucket_server.rb

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 require "danger/helpers/comments_helper"
 require "danger/request_sources/bitbucket_server_api"
 require "danger/request_sources/code_insights_api"
@@ -9,7 +7,7 @@ module Danger
   module RequestSources
     class BitbucketServer < RequestSource
       include Danger::Helpers::CommentsHelper
-      attr_accessor :pr_json
+      attr_accessor :pr_json, :dismiss_out_of_range_messages
 
       def self.env_vars
         [
@@ -25,12 +23,14 @@ module Danger
           "DANGER_BITBUCKETSERVER_CODE_INSIGHTS_REPORT_TITLE",
           "DANGER_BITBUCKETSERVER_CODE_INSIGHTS_REPORT_DESCRIPTION",
           "DANGER_BITBUCKETSERVER_CODE_INSIGHTS_REPORT_LOGO_URL",
-          "DANGER_BITBUCKETSERVER_VERIFY_SSL"
+          "DANGER_BITBUCKETSERVER_VERIFY_SSL",
+          "DANGER_BITBUCKETSERVER_DISMISS_OUT_OF_RANGE_MESSAGES"
         ]
       end
 
       def initialize(ci_source, environment)
         self.ci_source = ci_source
+        self.dismiss_out_of_range_messages = environment["DANGER_BITBUCKETSERVER_DISMISS_OUT_OF_RANGE_MESSAGES"] == "true"
 
         project, slug = ci_source.repo_slug.split("/")
         @api = BitbucketServerAPI.new(project, slug, ci_source.pull_request_id, environment)
@@ -58,6 +58,10 @@ module Danger
         self.pr_json = @api.fetch_pr_json
       end
 
+      def pr_diff
+        @pr_diff ||= @api.fetch_pr_diff
+      end
+
       def setup_danger_branches
         base_branch = self.pr_json[:toRef][:id].sub("refs/heads/", "")
         base_commit = self.pr_json[:toRef][:latestCommit]
@@ -134,12 +138,22 @@ module Danger
       end
 
       def main_violations_group(warnings: [], errors: [], messages: [], markdowns: [])
-        {
-          warnings: warnings.reject(&:inline?),
-          errors: errors.reject(&:inline?),
-          messages: messages.reject(&:inline?),
-          markdowns: markdowns.reject(&:inline?)
-        }
+        if dismiss_out_of_range_messages
+          {
+            warnings: warnings.reject(&:inline?),
+            errors: errors.reject(&:inline?),
+            messages: messages.reject(&:inline?),
+            markdowns: markdowns.reject(&:inline?)
+          }
+        else
+          in_diff = proc { |a| find_position_in_diff?(a.file, a.line) }
+          {
+            warnings: warnings.reject(&in_diff),
+            errors: errors.reject(&in_diff),
+            messages: messages.reject(&in_diff),
+            markdowns: markdowns.reject(&in_diff)
+          }
+        end
       end
 
       def inline_violations_group(warnings: [], errors: [], messages: [], markdowns: [])
@@ -148,6 +162,7 @@ module Danger
           next 1 unless b.file && b.line
 
           next a.line <=> b.line if a.file == b.file
+
           next a.file <=> b.file
         end
 
@@ -168,6 +183,28 @@ module Danger
         puts self.pr_json.to_json
         @api.update_pr_build_status(status, changeset, build_job_link, description)
       end
+
+      def find_position_in_diff?(file, line)
+        return nil if file.nil? || line.nil?
+        return nil if file.empty?
+
+        added_lines(file).include?(line)
+      end
+
+      def file_diff(file)
+        self.pr_diff[:diffs].find { |diff| diff[:destination] && diff[:destination][:toString] == file } || { hunks: [] }
+      end
+
+      def added_lines(file)
+        @added_lines ||= {}
+        @added_lines[file] ||= file_diff(file)[:hunks].map do |hunk|
+          hunk[:segments].select { |segment| segment[:type] == "ADDED" }.map do |segment|
+            segment[:lines].map do |line|
+              line[:destination]
+            end
+          end
+        end.flatten
+      end
     end
   end
 end

data/lib/danger/request_sources/bitbucket_server_api.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# coding: utf-8
 
 require "openssl"
 require "danger/helpers/comments_helper"
@@ -43,6 +42,11 @@ module Danger
         fetch_json(uri)
       end
 
+      def fetch_pr_diff
+        uri = URI("#{pr_api_endpoint}/diff?withComments=false")
+        fetch_json(uri)
+      end
+
       def fetch_last_comments
         uri = URI("#{pr_api_endpoint}/activities?limit=1000")
         fetch_json(uri)[:values].select { |v| v[:action] == "COMMENTED" }.map { |v| v[:comment] }
@@ -60,9 +64,9 @@ module Danger
       end
 
       def update_pr_build_status(status, changeset, build_job_link, description)
-         uri = URI("#{self.host}/rest/build-status/1.0/commits/#{changeset}")
-         body = build_status_body(status, build_job_link, description)
-         post(uri, body)
+        uri = URI("#{self.host}/rest/build-status/1.0/commits/#{changeset}")
+        body = build_status_body(status, build_job_link, description)
+        post(uri, body)
       end
 
       private
@@ -113,12 +117,12 @@ module Danger
       end
 
       def build_status_body(status, build_job_link, description)
-          body = Hash.new
-          body["state"] = status
-          body["key"] = self.key
-          body["url"] = build_job_link
-          body["description"] = description if description
-          return body.to_json
+        body = {}
+        body["state"] = status
+        body["key"] = self.key
+        body["url"] = build_job_link
+        body["description"] = description if description
+        return body.to_json
       end
     end
   end

data/lib/danger/request_sources/code_insights_api.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# coding: utf-8
 
 module Danger
   module RequestSources
@@ -38,7 +37,7 @@ module Danger
 
       def delete_report(commit)
         uri = URI(report_endpoint_at_commit(commit))
-        request = Net::HTTP::Delete.new(uri.request_uri, {"Content-Type" => "application/json"})
+        request = Net::HTTP::Delete.new(uri.request_uri, { "Content-Type" => "application/json" })
         request.basic_auth @username, @password
         response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: use_ssl) do |http|
           http.request(request)
@@ -50,7 +49,6 @@ module Danger
           # HTTP 4xx - 5xx
           abort "\nError deleting report from Code Insights API: #{response.code} (#{response.message}) - #{response.body}\n\n"
         end
-
       end
 
       def send_report(commit, inline_warnings, inline_errors, inline_messages)
@@ -64,15 +62,14 @@ module Danger
 
       def put_report(commit, inline_errors_count)
         uri = URI(report_endpoint_at_commit(commit))
-        request = Net::HTTP::Put.new(uri.request_uri, {"Content-Type" => "application/json"})
+        request = Net::HTTP::Put.new(uri.request_uri, { "Content-Type" => "application/json" })
         request.basic_auth @username, @password
-        request.body = {"title": @report_title,
+        request.body = { "title": @report_title,
                         "details": @report_description,
-                        "result": (inline_errors_count > 0) ? "FAIL" : "PASS",
+                        "result": inline_errors_count > 0 ? "FAIL" : "PASS",
                         "reporter": @username,
                         "link": "https://github.com/danger/danger",
-                        "logoURL": @logo_url
-        }.to_json
+                        "logoURL": @logo_url }.to_json
 
         response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: use_ssl) do |http|
           http.request(request)
@@ -103,8 +100,8 @@ module Danger
           annotations << violation_hash_with_severity(violation, "HIGH")
         end
 
-        body = {annotations: annotations}.to_json
-        request = Net::HTTP::Post.new(uri.request_uri, {"Content-Type" => "application/json"})
+        body = { annotations: annotations }.to_json
+        request = Net::HTTP::Post.new(uri.request_uri, { "Content-Type" => "application/json" })
         request.basic_auth @username, @password
         request.body = body
 
@@ -140,7 +137,6 @@ module Danger
       def use_ssl
         @host.include? "https://"
       end
-
     end
   end
 end