danger 8.4.2 → 9.2.0

data/lib/danger/request_sources/vsts_api.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require "base64"
 require "danger/helpers/comments_helper"
@@ -8,7 +8,7 @@ module Danger
     class VSTSAPI
       attr_accessor :host, :pr_api_endpoint, :min_api_version_for_comments
 
-      def initialize(_project, slug, pull_request_id, environment)
+      def initialize(slug, pull_request_id, environment)
         self.min_api_version_for_comments = "3.0"
 
         user_name = ""
@@ -27,17 +27,15 @@ module Danger
 
       def supports_comments?
         major_version = @api_version.split(".").first.to_i
-        minimun_version_for_comments = self.min_api_version_for_comments.split(".").first.to_i
+        minimum_version_for_comments = self.min_api_version_for_comments.split(".").first.to_i
 
-        major_version >= minimun_version_for_comments
+        major_version >= minimum_version_for_comments
       end
 
       def inspect
         inspected = super
 
-        if @token
-          inspected = inspected.sub! @token, "********".freeze
-        end
+        inspected.gsub!(@token, "********") if @token
 
         inspected
       end
@@ -46,6 +44,10 @@ module Danger
         @token && !@token.empty?
       end
 
+      def pull_request(*)
+        fetch_pr_json
+      end
+
       def fetch_pr_json
         uri = URI("#{pr_api_endpoint}?api-version=#{@api_version}")
         fetch_json(uri)
@@ -77,6 +79,38 @@ module Danger
         post(uri, body)
       end
 
+      def post_inline_comment(text, file, line)
+        uri = URI("#{pr_api_endpoint}/threads?api-version=#{@api_version}")
+        body = {
+          "comments" => [
+            {
+              "parentCommentId" => 0,
+              "content" => text,
+              "commentType" => 1
+            }
+          ],
+          "properties" => {
+            "Microsoft.TeamFoundation.Discussion.SupportsMarkdown" => {
+              "type" => "System.Int32",
+              "value" => 1
+            }
+          },
+          "status" => 1,
+          "threadContext" => {
+            "filePath" => file,
+            "rightFileEnd" => {
+              "line" => line + 1,
+              "offset" => 1
+            },
+            "rightFileStart" => {
+              "line" => line,
+              "offset" => 1
+            }
+          }
+        }.to_json
+        post(uri, body)
+      end
+
       def update_comment(thread, id, new_comment)
         uri = URI("#{pr_api_endpoint}/threads/#{thread}/comments/#{id}?api-version=#{@api_version}")
         body = {

data/lib/danger/scm_source/git_repo.rb

@@ -55,7 +55,8 @@ module Danger
     def exec(string)
       require "open3"
       Dir.chdir(self.folder || ".") do
-        Open3.popen2(default_env, "git #{string}") do |_stdin, stdout, _wait_thr|
+        git_command = string.split(" ").dup.unshift("git")
+        Open3.popen2(default_env, *git_command) do |_stdin, stdout, _wait_thr|
           stdout.read.rstrip
         end
       end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "8.4.2".freeze
+  VERSION = "9.2.0".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

data/lib/danger.rb

@@ -25,6 +25,7 @@ module Danger
     if Gem::Specification.find_all_by_name(GEM_NAME).empty?
       raise "Couldn't find gem directory for 'danger'"
     end
+
     return Gem::Specification.find_by_name(GEM_NAME).gem_dir
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 8.4.2
+  version: 9.2.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-10 00:00:00.000000000 Z
+date: 2023-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -40,33 +40,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.9.2
 - !ruby/object:Gem::Dependency
-  name: git
+  name: colored2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
-  name: colored2
+  name: cork
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -76,7 +76,7 @@ dependencies:
         version: 0.9.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -86,7 +86,7 @@ dependencies:
         version: 0.9.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: faraday-http-cache
   requirement: !ruby/object:Gem::Requirement
@@ -102,95 +102,95 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: kramdown
+  name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
-  name: kramdown-parser-gfm
+  name: kramdown
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
-  name: octokit
+  name: kramdown-parser-gfm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: terminal-table
+  name: no_proxy_fix
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: cork
+  name: octokit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: no_proxy_fix
+  name: terminal-table
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
 description: Stop Saying 'You Forgot To…' in Code Review
 email:
 - orta.therox@gmail.com
@@ -206,6 +206,7 @@ files:
 - lib/assets/DangerfileTemplate
 - lib/danger.rb
 - lib/danger/ci_source/appcenter.rb
+- lib/danger/ci_source/appcircle.rb
 - lib/danger/ci_source/appveyor.rb
 - lib/danger/ci_source/azure_pipelines.rb
 - lib/danger/ci_source/bamboo.rb
@@ -243,7 +244,6 @@ files:
 - lib/danger/ci_source/surf.rb
 - lib/danger/ci_source/teamcity.rb
 - lib/danger/ci_source/travis.rb
-- lib/danger/ci_source/vsts.rb
 - lib/danger/ci_source/xcode_cloud.rb
 - lib/danger/ci_source/xcode_server.rb
 - lib/danger/clients/rubygems_client.rb
@@ -271,6 +271,7 @@ files:
 - lib/danger/comment_generators/gitlab.md.erb
 - lib/danger/comment_generators/gitlab_inline.md.erb
 - lib/danger/comment_generators/vsts.md.erb
+- lib/danger/comment_generators/vsts_inline.md.erb
 - lib/danger/core_ext/file_list.rb
 - lib/danger/core_ext/string.rb
 - lib/danger/danger_core/dangerfile.rb
@@ -335,14 +336,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.

data/lib/danger/ci_source/vsts.rb

@@ -1,73 +0,0 @@
-require "danger/request_sources/github/github"
-require "danger/request_sources/vsts"
-
-module Danger
-  # ### CI Setup
-  #
-  # You need to go to your project's build definition. Then add a "Command Line" Task with the "Tool" field set to  "bundle"
-  # and the "Arguments" field set to "exec danger".
-  #
-  # ### Token Setup
-  #
-  # #### GitHub
-  #
-  # You need to add the `DANGER_GITHUB_API_TOKEN` environment variable, to do this, go to your build definition's variables tab.
-  #
-  # Make sure that `DANGER_GITHUB_API_TOKEN` is not set to secret since vsts does not expose secret variables while building.
-  #
-  # #### VSTS
-  #
-  # You need to add the `DANGER_VSTS_API_TOKEN` and `DANGER_VSTS_HOST` environment variable, to do this,
-  # go to your build definition's variables tab. The `DANGER_VSTS_API_TOKEN` is your vsts personal access token.
-  # Instructions for creating a personal access token can be found [here](https://www.visualstudio.com/en-us/docs/setup-admin/team-services/use-personal-access-tokens-to-authenticate).
-  # For the `DANGER_VSTS_HOST` variable the suggested value is `$(System.TeamFoundationCollectionUri)$(System.TeamProject)`
-  # which will automatically get your vsts domain and your project name needed for the vsts api.
-  #
-  # Make sure that `DANGER_VSTS_API_TOKEN` is not set to secret since vsts does not expose secret variables while building.
-  #
-  class VSTS < CI
-    class << self
-      def github_slug(env)
-        env["BUILD_REPOSITORY_NAME"]
-      end
-
-      def vsts_slug(env)
-        project_name = env["SYSTEM_TEAMPROJECT"]
-        repo_name = env["BUILD_REPOSITORY_NAME"]
-
-        "#{project_name}/#{repo_name}"
-      end
-    end
-
-    def self.validates_as_ci?(env)
-      has_all_variables = ["SYSTEM_TEAMFOUNDATIONCOLLECTIONURI", "BUILD_REPOSITORY_PROVIDER"].all? { |x| env[x] && !env[x].empty? }
-
-      is_support_source_control = ["GitHub", "TfsGit"].include?(env["BUILD_REPOSITORY_PROVIDER"])
-
-      has_all_variables && is_support_source_control
-    end
-
-    def self.validates_as_pr?(env)
-      has_all_variables = ["BUILD_SOURCEBRANCH", "BUILD_REPOSITORY_URI", "BUILD_REASON", "BUILD_REPOSITORY_NAME"].all? { |x| env[x] && !env[x].empty? }
-
-      has_all_variables && env["BUILD_REASON"] == "PullRequest"
-    end
-
-    def supported_request_sources
-      @supported_request_sources ||= [Danger::RequestSources::GitHub, Danger::RequestSources::VSTS]
-    end
-
-    def initialize(env)
-      case env["BUILD_REPOSITORY_PROVIDER"]
-      when "GitHub"
-        self.repo_slug = self.class.github_slug(env)
-      when "TfsGit"
-        self.repo_slug = self.class.vsts_slug(env)
-      end
-
-      repo_matches = env["BUILD_SOURCEBRANCH"].match(%r{refs\/pull\/([0-9]+)\/merge})
-      self.pull_request_id = repo_matches[1] unless repo_matches.nil?
-      self.repo_url = env["BUILD_REPOSITORY_URI"]
-    end
-  end
-end