danger 8.2.0 → 8.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a23a15079e019e675afdc325babf115a1a6f38ddbd06a5ba11dd93243ea1dfa0
-  data.tar.gz: 380335b8eb423be1096f3b25b3f2602d24d7288b70deb69e8b9991e6dcf09d16
+  metadata.gz: 3930680bc519ec86948df5375ea6ffad444929619c7faf3190e204eee827767b
+  data.tar.gz: 6ca8c826a895e9d0ef6bf66343e70110026a8a77fafddc6e72f26b129c37801d
 SHA512:
-  metadata.gz: 2d68ba968f860e6b4631536548d23279677645d20e7cb5d9567c73222a87128c027664e72f176bca01a31adbbbc2b8f123f5f20997e005a428cc2321e979d023
-  data.tar.gz: 10ab5f0cb6c3810e0f4520724854a3a8e3e4aeef35c252ed7a3ac729a2407c73df382a6cb98b1682170efd215bc495a11a312fa1d47f5d1b546632bd415b8d0f
+  metadata.gz: '0267983777b8a27f5d90f6221655d18657a0c4ed6276e475631e4984eabbe2f5329ec8df774100052dfd1e6368082b9865fd1bd87956b538fa032042f1e1538d'
+  data.tar.gz: 700097f2571dd5cb9cac5b9f74d034a53a00e73f747d3aa489cb9cae83b86b85908281a3c910bec25a2299fd828449c9eb82f796d8865f84a0742a46488d2dd3

data/README.md

@@ -51,7 +51,7 @@ Some quick links: [Guides Index](https://danger.systems/guides.html), [DSL Refer
 
 Brilliant. So, let's get you set up.
 
-``` sh
+```sh
 git clone https://github.com/danger/danger.git
 cd danger
 bundle install

data/lib/danger/ci_source/appcenter.rb

@@ -7,7 +7,7 @@ module Danger
   #
   # Add a script step to your appcenter-post-build.sh:
   #
-  # ``` shell
+  # ```shell
   #   #!/usr/bin/env bash
   #   bundle install
   #   bundle exec danger

data/lib/danger/ci_source/appveyor.rb

@@ -3,6 +3,7 @@ module Danger
   # ### CI Setup
   #
   # Install dependencies and add a danger step to your `appveyor.yml`.
+  #
   # ```yaml
   # install:
   # - cmd: >-
@@ -19,6 +20,7 @@ module Danger
   # For public repositories, add your plain token to environment variables in `appveyor.yml`.
   # Encrypted environment variables will not be decrypted on PR builds.
   # see here: https://www.appveyor.com/docs/build-configuration/#secure-variables
+  #
   # ```yaml
   # environment:
   #   DANGER_GITHUB_API_TOKEN: <YOUR_TOKEN_HERE>
@@ -26,6 +28,7 @@ module Danger
   #
   # For private repositories, enter your token in `Settings>Environment>Environment variables>Add variable` and turn on `variable encryption`.
   # You will see encrypted variable text in `Settings>Export YAML` so just copy to your `appveyor.yml`.
+  #
   # ```yaml
   # environment:
   #   DANGER_GITHUB_API_TOKEN:

data/lib/danger/ci_source/azure_pipelines.rb

@@ -7,7 +7,7 @@ module Danger
   #
   # Add a script step:
   #
-  # ``` shell
+  # ```shell
   #   #!/usr/bin/env bash
   #   bundle install
   #   bundle exec danger

data/lib/danger/ci_source/bitbucket_pipelines.rb

@@ -2,6 +2,7 @@ module Danger
   # ### CI Setup
   #
   # Install dependencies and add a danger step to your `bitbucket-pipelines.yml`.
+  #
   # ```yaml
   #   script:
   #     - bundle exec danger --verbose

data/lib/danger/ci_source/buildkite.rb

@@ -9,7 +9,7 @@ module Danger
   # With BuildKite you run the server yourself, so you will want to run  it as a part of your build process.
   # It is common to have build steps, so we would recommend adding this to your scrip:
   #
-  #  ``` shell
+  #  ```shell
   #   echo "--- Running Danger"
   #   bundle exec danger
   #  ```

data/lib/danger/ci_source/circle.rb

@@ -19,7 +19,7 @@ module Danger
   #
   # e.g.
   #
-  #  ``` yaml
+  #  ```yaml
   #  - run: bundle exec danger --verbose
   #  ```
   #

data/lib/danger/ci_source/concourse.rb

@@ -10,7 +10,7 @@ module Danger
   #
   # With Concourse, you run the docker images yourself, so you will want to add `yarn danger ci` within one of your build jobs.
   #
-  #   ``` shell
+  #   ```shell
   #    build:
   #      image: golang
   #        commands:

data/lib/danger/ci_source/drone.rb

@@ -8,7 +8,7 @@ module Danger
   # With Drone you run the docker images yourself, so you will want to add `bundle exec danger` at the end of
   # your `.drone.yml`.
   #
-  #  ``` shell
+  #  ```shell
   #   build:
   #     image: golang
   #     commands:
@@ -24,7 +24,7 @@ module Danger
   # Drone secrets: http://readme.drone.io/usage/secret-guide/
   # NOTE: This is a new syntax in DroneCI 0.6+
   #
-  # ```
+  # ```yml
   #   build:
   #     image: golang
   #     secrets:

data/lib/danger/ci_source/github_actions.rb

@@ -6,7 +6,7 @@ module Danger
   # You can use `danger/danger` Action in your `.github/workflows/xxx.yml`.
   # And so, you can use GITHUB_TOKEN secret as `DANGER_GITHUB_API_TOKEN` environment variable.
   #
-  #  ```
+  #  ```yml
   #  ...
   #    steps:
   #      - uses: actions/checkout@v1

data/lib/danger/ci_source/gitlab_ci.rb

@@ -7,6 +7,7 @@ module Danger
   # ### CI Setup
   #
   # Install dependencies and add a danger step to your .gitlab-ci.yml:
+  #
   # ```yml
   # before_script:
   #  - bundle install
@@ -14,6 +15,7 @@ module Danger
   #   script:
   #    - bundle exec danger
   # ```
+  #
   # ### Token Setup
   #
   # Add the `DANGER_GITLAB_API_TOKEN` to your pipeline env variables if you

data/lib/danger/ci_source/screwdriver.rb

@@ -6,7 +6,8 @@ module Danger
   # ### CI Setup
   #
   # Install dependencies and add a danger step to your screwdriver.yaml:
-  # ``` yml
+  #
+  # ```yml
   # jobs:
   #   danger:
   #     requires: [~pr, ~commit]

data/lib/danger/ci_source/teamcity.rb

@@ -27,6 +27,7 @@ module Danger
   # branch="%teamcity.build.branch%"
   # export GITHUB_PULL_REQUEST_ID=(${branch//\// })
   # ```
+  #
   # Or if you are using the pull request feature you can set an environment parameter called `GITHUB_PULL_REQUEST_ID`
   # to the value of: `%teamcity.pullRequest.number`
   #
@@ -59,6 +60,7 @@ module Danger
   #
   # You will also need to set the `BITBUCKET_BRANCH_NAME` environment variable.
   # TeamCity provides `%teamcity.build.branch%`, which you can use at the top of your Simple Command Runner:
+  #
   # ```sh
   # export BITBUCKET_BRANCH_NAME="%teamcity.build.branch%"
   # ```

data/lib/danger/commands/dry_run.rb

@@ -22,7 +22,7 @@ module Danger
       super
 
       if argv.flag?("pry", false)
-        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path)
+        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path, DryRun.command)
       end
     end
 

data/lib/danger/commands/init.rb

@@ -277,7 +277,7 @@ module Danger
       ui.say "- You can look at the following Dangerfiles to get some more ideas:"
       ui.pause 0.6
       ui.link "https://github.com/danger/danger/blob/master/Dangerfile"
-      ui.link "https://github.com/artsy/eigen/blob/master/Dangerfile"
+      ui.link "https://github.com/artsy/eigen/blob/master/dangerfile.ts"
       ui.pause 1
     end
 

data/lib/danger/commands/local.rb

@@ -32,7 +32,7 @@ module Danger
       super
 
       if argv.flag?("pry", false)
-        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path)
+        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path, Local.command)
       end
     end
 

data/lib/danger/commands/local_helpers/pry_setup.rb

@@ -4,9 +4,9 @@ module Danger
       @cork = cork
     end
 
-    def setup_pry(dangerfile_path)
+    def setup_pry(dangerfile_path, command)
       return dangerfile_path if dangerfile_path.empty?
-      validate_pry_available
+      validate_pry_available(command)
       FileUtils.cp dangerfile_path, DANGERFILE_COPY
       File.open(DANGERFILE_COPY, "a") do |f|
         f.write("\nbinding.pry; File.delete(\"#{DANGERFILE_COPY}\")")
@@ -20,10 +20,10 @@ module Danger
 
     DANGERFILE_COPY = "_Dangerfile.tmp".freeze
 
-    def validate_pry_available
+    def validate_pry_available(command)
       Kernel.require "pry"
     rescue LoadError
-      cork.warn "Pry was not found, and is required for 'danger pr --pry'."
+      cork.warn "Pry was not found, and is required for 'danger #{command} --pry'."
       cork.print_warnings
       abort
     end

data/lib/danger/commands/pr.rb

@@ -37,7 +37,7 @@ module Danger
       @dangerfile_path = dangerfile if File.exist?(dangerfile)
 
       if argv.flag?("pry", false)
-        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path)
+        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path, PR.command)
       end
     end
 

data/lib/danger/commands/staging.rb

@@ -23,7 +23,7 @@ module Danger
       super
 
       if argv.flag?("pry", false)
-        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path)
+        @dangerfile_path = PrySetup.new(cork).setup_pry(@dangerfile_path, Staging.command)
       end
     end
 

data/lib/danger/danger_core/plugins/dangerfile_bitbucket_cloud_plugin.rb

@@ -97,7 +97,7 @@ module Danger
     # @return [String]
     #
     def pr_author
-      @bs.pr_json[:author][:username]
+      @bs.pr_json[:author][:nickname]
     end
 
     # @!group PR Commit Metadata

data/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb

@@ -33,6 +33,11 @@ module Danger
   #
   #          danger.import_dangerfile(github: "ruby-grape/danger", branch: "custom", path: "path/to/Dangerfile")
   #
+  # @example Import a plugin available over HTTP
+  #
+  #          custom_url = "https://custom.bitbucket.com/project-name/Dangerfile?raw"
+  #          danger.import_dangerfile(url: custom_url)
+  #
   # @see  danger/danger
   # @tags core, plugins
 
@@ -84,8 +89,10 @@ module Danger
           import_dangerfile_from_path(opts[:path])
         elsif opts.key?(:gem)
           import_dangerfile_from_gem(opts[:gem])
+        elsif opts.key?(:url)
+          import_dangerfile_from_url(opts[:url])
         else
-          raise "`import` requires a Hash with either :github, :gitlab, :gem, or :path"
+          raise "`import` requires a Hash with either :github, :gitlab, :gem, :path or :url"
         end
       else
         raise "`import` requires a Hash"
@@ -180,6 +187,19 @@ module Danger
       @dangerfile.parse(Pathname.new(local_path))
     end
 
+    # @!group Danger
+    # Download and execute a remote Dangerfile.
+    #
+    # @param    [String] url
+    #           A https url where the Dangerfile is.
+    # @return   [void]
+    #
+    def import_dangerfile_from_url(url)
+      raise "`import_dangerfile_from_url` requires a string" unless url.kind_of?(String)
+      local_path = download(url)
+      @dangerfile.parse(Pathname.new(local_path))
+    end
+
     # @!group Plugins
     # Download a local or remote plugin or Dangerfile.
     # This method will not import the file for you, use plugin.import instead

data/lib/danger/request_sources/bitbucket_cloud_api.rb

@@ -57,7 +57,8 @@ module Danger
       def fetch_comments
         values = []
         # TODO: use a url parts encoder to encode the query
-        uri = "#{pr_api_endpoint}/comments?pagelen=100&q=deleted+%7E+false+AND+user.username+%7E+%22#{@username}%22"
+        corrected_uuid = @my_uuid[1...-1] if !@my_uuid.nil? # Endpoint doesnt support curly brackets for this, so remove them for this
+        uri = "#{pr_api_endpoint}/comments?pagelen=100&q=deleted+%7E+false+AND+user.uuid+%7E+%22#{corrected_uuid}%22"
 
         while uri
           json = fetch_json(URI(uri))

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "8.2.0".freeze
+  VERSION = "8.2.1".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 8.2.0
+  version: 8.2.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-26 00:00:00.000000000 Z
+date: 2020-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide