danger 5.6.0 → 5.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9973389d96fb5038948aadcc696a845877b934df
-  data.tar.gz: 23a75796bf999b53a9fb9cd75ab76cb0a22168b9
+  metadata.gz: ec36701168c14090f3c64ea1b7fb6b3dd5439623
+  data.tar.gz: df080085b72b8261e85cf50d0c7ab8f3e0a16311
 SHA512:
-  metadata.gz: 6c5986ae5c49a22d58f641e70c28db3705a38aa8c63ce8cf0cbccca87098bce89c2546144ef5431cf356f5ff5054a9cea5c91893c52767b816607e4885f95689
-  data.tar.gz: fe1764de97f55c1cd740bbdac32517795835de5bc19265b2eb18e58c37d215cd133bee754e2aee55afa8e0f0c3dfe6a26e6212d134f40423e4d21f72aff7dc1d
+  metadata.gz: fdc16ebb0194bc7ce2765b0e642ac5009e750859fb770dd1cd5009de42d00c9ce9a87446f3f428961b4cfcec0eb5e08fee08132aee08d4e532ce7b5f0df07e2a
+  data.tar.gz: 81804bf81d9a6168a8c41fb6683c5f3f8c39e94ec83e616f187ffd8c84a2f34bed9e0d5a167364cc71eec2354517f98783a9c2f046a981539476eacfc9eaa603

data/README.md

@@ -13,7 +13,7 @@ Formalize your Pull Request etiquette.
     <a href="#what-is-danger">What is Danger?</a> &bull;
     <a href="VISION.md">Vision</a> &bull;
     <a href="#im-here-to-help-out">Helping Out</a> &bull;
-    <a href="http://danger.systems/guides/creating_your_first_plugin.html">Plugin Development</a>
+    <a href="https://danger.systems/guides/creating_your_first_plugin.html">Plugin Development</a>
 </p>
 
 -------
@@ -43,9 +43,9 @@ Danger provides the glue to let _you_ build out the rules specific to your team'
 
 Alright. So, actually, you may be in the wrong place. From here on in, this README is going to be for people who are interested in working on and improving on Danger.
 
-We keep all of the end-user documentation at [http://danger.systems](http://danger.systems).
+We keep all of the end-user documentation at [https://danger.systems](https://danger.systems).
 
-Some quick links: [Guides Index](http://danger.systems/guides.html), [DSL Reference](http://danger.systems/reference.html), [Getting Started](http://danger.systems/guides/getting_started.html) and [What does Danger Do?](http://danger.systems/guides/what_does_danger_do.html).
+Some quick links: [Guides Index](https://danger.systems/guides.html), [DSL Reference](https://danger.systems/reference.html), [Getting Started](https://danger.systems/guides/getting_started.html) and [What does Danger Do?](https://danger.systems/guides/what_does_danger_do.html).
 
 ## I'm here to help out!
 
@@ -76,7 +76,7 @@ I'd strongly recommend using `bundle exec guard` to run your tests as you work.
 
 #### Debugging
 
-Ruby is super dynamic. One of the best ways to debug Ruby code is by using [pry](http://pryrepl.org/). We include pry for developers: when you have a problem, copy these two lines just before your problem and follow the instructions from "[I Want To Be A Danger Wizard](http://danger.systems/guides/troubleshooting.html#i-want-to-be-a-danger-wizard)."
+Ruby is super dynamic. One of the best ways to debug Ruby code is by using [pry](http://pryrepl.org/). We include pry for developers: when you have a problem, copy these two lines just before your problem and follow the instructions from "[I Want To Be A Danger Wizard](https://danger.systems/guides/troubleshooting.html#i-want-to-be-a-danger-wizard)."
 
 ```ruby
 require 'pry'

data/lib/danger/ci_source/gitlab_ci.rb

@@ -17,13 +17,15 @@ module Danger
   #
   # Add the `DANGER_GITLAB_API_TOKEN` to your pipeline env variables.
   class GitLabCI < CI
+    attr_reader :project_url
+
     def self.validates_as_ci?(env)
       env.key? "GITLAB_CI"
     end
 
     def self.validates_as_pr?(env)
       exists = [
-        "GITLAB_CI", "CI_PROJECT_ID"
+        "GITLAB_CI", "CI_PROJECT_PATH"
       ].all? { |x| env[x] }
 
       exists && determine_merge_request_id(env).to_i > 0
@@ -33,11 +35,11 @@ module Danger
       return env["CI_MERGE_REQUEST_ID"] if env["CI_MERGE_REQUEST_ID"]
       return 0 unless env["CI_COMMIT_SHA"]
 
-      project_id = env["CI_PROJECT_ID"]
+      project_path = env["CI_PROJECT_PATH"]
       base_commit = env["CI_COMMIT_SHA"]
       client = RequestSources::GitLab.new(nil, env).client
 
-      merge_requests = client.merge_requests(project_id, state: :opened)
+      merge_requests = client.merge_requests(project_path, state: :opened)
       merge_request = merge_requests.auto_paginate.find do |mr|
         mr.sha == base_commit
       end
@@ -46,12 +48,17 @@ module Danger
     end
 
     def initialize(env)
-      self.repo_slug = env["CI_PROJECT_ID"]
-      self.pull_request_id = self.class.determine_merge_request_id(env)
+      @env = env
+      @repo_slug = env["CI_PROJECT_PATH"]
+      @project_url = env["CI_PROJECT_URL"]
     end
 
     def supported_request_sources
       @supported_request_sources ||= [Danger::RequestSources::GitLab]
     end
+
+    def pull_request_id
+      @pull_request_id ||= self.class.determine_merge_request_id(@env)
+    end
   end
 end

data/lib/danger/commands/init.rb

@@ -255,7 +255,7 @@ module Danger
       ui.say "You need to expose a token called " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Access Token."
       ui.say "Depending on the CI system, this may need to be done on the machine (in the " + "~/.bashprofile".yellow + ") or in a web UI somewhere."
       ui.say "We have a guide for all supported CI systems on danger.systems:"
-      ui.link "http://danger.systems/guides/getting_started.html#setting-up-danger-to-run-on-your-ci"
+      ui.link "https://danger.systems/guides/getting_started.html#setting-up-danger-to-run-on-your-ci"
     end
 
     def note_about_clicking_links

data/lib/danger/commands/plugins/plugin_lint.rb

@@ -21,7 +21,7 @@ module Danger
 
     self.description = <<-DESC
       Converts a collection of file paths of Danger plugins into a JSON format.
-      Note: Before 1.0, it will also parse the represented JSON to validate whether http://danger.systems would
+      Note: Before 1.0, it will also parse the represented JSON to validate whether https://danger.systems would
       show the plugin on the website.
     DESC
 

data/lib/danger/comment_generators/github.md.erb

@@ -51,5 +51,5 @@
 <%# the previous line has to be aligned far to the left, otherwise markdown can break easily %>
 <%- end -%>
 <p align="right" data-meta="generated_by_<%= @danger_id %>">
-  Generated by :no_entry_sign: <a href="http://danger.systems/">Danger</a>
+  Generated by :no_entry_sign: <a href="https://danger.systems/">Danger</a>
 </p>

data/lib/danger/danger_core/environment_manager.rb

@@ -111,7 +111,7 @@ module Danger
       ui.puts subtitle
       ui.puts "\nFound these keys in your ENV: #{env.keys.join(', '.freeze)}."
       ui.puts "\nFailing the build, Danger cannot run without API access.".freeze
-      ui.puts "You can see more information at http://danger.systems/guides/getting_started.html".freeze
+      ui.puts "You can see more information at https://danger.systems/guides/getting_started.html".freeze
     end
 
     def travis_note

data/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

@@ -192,15 +192,11 @@ module Danger
     def html_link(paths, full_path: true)
       paths = [paths] unless paths.kind_of?(Array)
       commit = head_commit
-      same_repo = mr_json["project_id"] == mr_json["source_project_id"]
-      sender_repo = mr_author + "/" + env.ci_source.repo_slug.split("/")[1]
-      repo = same_repo ? env.ci_source.repo_slug : sender_repo
-      host = @gitlab.host
 
       paths = paths.map do |path|
         url_path = path.start_with?("/") ? path : "/#{path}"
         text = full_path ? path : File.basename(path)
-        create_link("https://#{host}/#{repo}/blob/#{commit}#{url_path}", text)
+        create_link("#{env.ci_source.project_url}/blob/#{commit}#{url_path}", text)
       end
 
       return paths.first if paths.count < 2

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.6.0".freeze
+  VERSION = "5.6.1".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.6.0
+  version: 5.6.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-17 00:00:00.000000000 Z
+date: 2018-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -292,7 +292,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.