danger 5.4.0 → 5.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 06752bbffec806b31893a0befbc36c7a9fdb2fae
-  data.tar.gz: a040e75f604c3efaa4fef0f9a4ef5525986d56f6
+  metadata.gz: d6ab9271203b201cc6f55cd14b8e56035da246d0
+  data.tar.gz: e72f44993af9e3926facdb74026e01f98dea28a3
 SHA512:
-  metadata.gz: f67e7ec2195c040f6005238e1dc522b0be4e7976972aa110b3f91c213e420436ad3dcc1ab4d720aa5dc34c0242d321d4bdb69ce3c4b41353ce25a498e0696946
-  data.tar.gz: b510818c68d7ff4a88152158f1254b84d02e9daa07c2d612c424a6b127561a2aec8b982b52786c453aa7692ca5d8d32726daba85c5c7f97062585e1938b41e95
+  metadata.gz: 863158d3cadaf5ed8506d349eebb66bc94aabf9fcde1643c36dd5603cec4e759443775624eb55d14d559f6046c896466b9a4128b1973831e543185703c7634fe
+  data.tar.gz: 5a9f08b4521ead063766e7486980fa52123754ff628cfceae5422198ac2aa837a3a89859c34c1a82ef895d13f5e56892554b7bbafbf098e372155422063e3e9e

data/lib/danger/danger_core/dangerfile.rb

@@ -10,6 +10,7 @@ require "danger/danger_core/plugins/dangerfile_github_plugin"
 require "danger/danger_core/plugins/dangerfile_gitlab_plugin"
 require "danger/danger_core/plugins/dangerfile_bitbucket_server_plugin"
 require "danger/danger_core/plugins/dangerfile_bitbucket_cloud_plugin"
+require "danger/danger_core/plugins/dangerfile_vsts_plugin"
 
 module Danger
   class Dangerfile
@@ -37,7 +38,7 @@ module Danger
 
     # The ones that everything would break without
     def self.essential_plugin_classes
-      [DangerfileMessagingPlugin, DangerfileGitPlugin, DangerfileDangerPlugin, DangerfileGitHubPlugin, DangerfileGitLabPlugin, DangerfileBitbucketServerPlugin, DangerfileBitbucketCloudPlugin]
+      [DangerfileMessagingPlugin, DangerfileGitPlugin, DangerfileDangerPlugin, DangerfileGitHubPlugin, DangerfileGitLabPlugin, DangerfileBitbucketServerPlugin, DangerfileBitbucketCloudPlugin, DangerfileVSTSPlugin]
     end
 
     # Both of these methods exist on all objects

data/lib/danger/danger_core/plugins/dangerfile_vsts_plugin.rb

@@ -0,0 +1,191 @@
+# coding: utf-8
+
+require "danger/plugin_support/plugin"
+
+module Danger
+  # Handles interacting with VSTS inside a Dangerfile. Provides a few functions which wrap `pr_json` and also
+  # through a few standard functions to simplify your code.
+  #
+  # @example Warn when a PR is classed as work in progress
+  #
+  #          warn "PR is classed as Work in Progress" if vsts.pr_title.include? "[WIP]"
+  #
+  # @example Declare a PR to be simple to avoid specific Danger rules
+  #
+  #          declared_trivial = (vsts.pr_title + vsts.pr_body).include?("#trivial")
+  #
+  # @example Ensure there is a summary for a PR
+  #
+  #          fail "Please provide a summary in the Pull Request description" if vsts.pr_body.length < 5
+  #
+  # @example Only accept PRs to the develop branch
+  #
+  #          fail "Please re-submit this PR to develop, we may have already fixed your issue." if vsts.branch_for_base != "develop"
+  #
+  # @example Highlight when a celebrity makes a pull request
+  #
+  #          message "Welcome, Danger." if vsts.pr_author == "dangermcshane"
+  #
+  # @example Ensure that all PRs have an assignee
+  #
+  #          warn "This PR does not have any assignees yet." unless vsts.pr_json["reviewers"].length == 0
+  #
+  # @example Send a message with links to a collection of specific files
+  #
+  #          if git.modified_files.include? "config/*.js"
+  #            config_files = git.modified_files.select { |path| path.include? "config/" }
+  #            message "This PR changes #{ vsts.markdown_link(config_files) }"
+  #          end
+  #
+  # @example Highlight with a clickable link if a Package.json is changed
+  #
+  #         warn "#{vsts.markdown_link("Package.json")} was edited." if git.modified_files.include? "Package.json"
+  #
+  # @example Note an issue with a particular line on a file using the #L[num] syntax, e.g. `#L23`
+  #
+  #         linter_json = `my_linter lint "file"`
+  #         results = JSON.parse linter_json
+  #         unless results.empty?
+  #           file, line, warning = result.first
+  #           warn "#{vsts.markdown_link("#{file}#L#{line}")} has linter issue: #{warning}."
+  #         end
+  #
+  #
+  # @see  danger/danger
+  # @tags core, vsts
+  #
+  class DangerfileVSTSPlugin < Plugin
+    # So that this init can fail.
+    def self.new(dangerfile)
+      return nil if dangerfile.env.request_source.class != Danger::RequestSources::VSTS
+      super
+    end
+
+    # The instance name used in the Dangerfile
+    # @return [String]
+    #
+    def self.instance_name
+      "vsts"
+    end
+
+    def initialize(dangerfile)
+      super(dangerfile)
+      @source = dangerfile.env.request_source
+    end
+
+    # @!group VSTS Misc
+    # The hash that represents the PR's JSON. For an example of what this looks like
+    # see the [Danger Fixture'd one](https://raw.githubusercontent.com/danger/danger/master/spec/fixtures/vsts_api/pr_response.json).
+    # @return [Hash]
+    def pr_json
+      @source.pr_json
+    end
+
+    # @!group PR Metadata
+    # The title of the Pull Request.
+    # @return [String]
+    #
+    def pr_title
+      @source.pr_json[:title].to_s
+    end
+
+    # @!group PR Metadata
+    # The body text of the Pull Request.
+    # @return [String]
+    #
+    def pr_description
+      @source.pr_json[:description].to_s
+    end
+    alias pr_body pr_description
+
+    # @!group PR Metadata
+    # The username of the author of the Pull Request.
+    # @return [String]
+    #
+    def pr_author
+      @source.pr_json[:createdBy][:displayName].to_s
+    end
+
+    # @!group PR Commit Metadata
+    # The branch to which the PR is going to be merged into.
+    # @return [String]
+    #
+    def branch_for_base
+      branch_name(:targetRefName)
+    end
+
+    # @!group PR Commit Metadata
+    # A href that represents the current PR
+    # @return [String]
+    #
+    def pr_link
+      repo_path = @source.pr_json[:repository][:remoteUrl].to_s
+      pull_request_id = @source.pr_json[:pullRequestId].to_s
+
+      "#{repo_path}/pullRequest/#{pull_request_id}"
+    end
+
+    # @!group PR Commit Metadata
+    # The branch to which the PR is going to be merged from.
+    # @return [String]
+    #
+    def branch_for_head
+      branch_name(:sourceRefName)
+    end
+
+    # @!group PR Commit Metadata
+    # The base commit to which the PR is going to be merged as a parent.
+    # @return [String]
+    #
+    def base_commit
+      @source.pr_json[:lastMergeTargetCommit][:commitId].to_s
+    end
+
+    # @!group PR Commit Metadata
+    # The head commit to which the PR is requesting to be merged from.
+    # @return [String]
+    #
+    def head_commit
+      @source.pr_json[:lastMergeSourceCommit][:commitId].to_s
+    end
+
+    # @!group VSTS Misc
+    # Returns a list of Markdown links for a file, or files in the head repository.
+    # It returns a string of multiple links if passed an array.
+    # @param    [String or Array<String>] paths
+    #           A list of strings to convert to Markdown links
+    # @param    [Bool] full_path
+    #           Shows the full path as the link's text, defaults to `true`.
+    #
+    # @return [String]
+    #
+    def markdown_link(paths, full_path: true)
+      paths = [paths] unless paths.kind_of?(Array)
+      commit = head_commit
+      repo = pr_json[:repository][:remoteUrl].to_s
+
+      paths = paths.map do |path|
+        path, line = path.split("#L")
+        url_path = path.start_with?("/") ? path : "/#{path}"
+        text = full_path ? path : File.basename(path)
+        url_path.gsub!(" ", "%20")
+        line_ref = line ? "&line=#{line}" : ""
+        create_markdown_link("#{repo}/commit/#{commit}?path=#{url_path}&_a=contents#{line_ref}", text)
+      end
+
+      return paths.first if paths.count < 2
+      paths.first(paths.count - 1).join(", ") + " & " + paths.last
+    end
+
+    private
+
+    def create_markdown_link(href, text)
+      "[#{text}](#{href})"
+    end
+
+    def branch_name(key)
+      repo_matches = @source.pr_json[key].to_s.match(%r{refs\/heads\/(.*)})
+      repo_matches[1] unless repo_matches.nil?
+    end
+  end
+end

data/lib/danger/request_sources/github/github.rb

@@ -21,7 +21,7 @@ module Danger
       end
 
       def self.optional_env_vars
-        ["DANGER_GITHUB_HOST", "DANGER_GITHUB_API_BASE_URL"]
+        ["DANGER_GITHUB_HOST", "DANGER_GITHUB_API_BASE_URL", "DANGER_OCTOKIT_VERIFY_SSL"]
       end
 
       def initialize(ci_source, environment)
@@ -45,6 +45,10 @@ module Danger
         @host = @environment["DANGER_GITHUB_HOST"] || "github.com"
       end
 
+      def verify_ssl
+        @environment["DANGER_OCTOKIT_VERIFY_SSL"] == "false" ? false : true
+      end
+
       # `DANGER_GITHUB_API_HOST` is the old name kept for legacy reasons and
       # backwards compatibility. `DANGER_GITHUB_API_BASE_URL` is the new
       # correctly named variable.
@@ -58,8 +62,10 @@ module Danger
 
       def client
         raise "No API token given, please provide one using `DANGER_GITHUB_API_TOKEN`" if !@token && !support_tokenless_auth
-
         @client ||= begin
+          Octokit.configure do |config|
+            config.connection_options[:ssl] = { verify: verify_ssl }
+          end
           Octokit::Client.new(access_token: @token, auto_paginate: true, api_endpoint: api_url)
         end
       end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.4.0".freeze
+  VERSION = "5.4.1".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.4.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-02 00:00:00.000000000 Z
+date: 2017-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -437,6 +437,7 @@ files:
 - lib/danger/danger_core/plugins/dangerfile_github_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb
 - lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb
+- lib/danger/danger_core/plugins/dangerfile_vsts_plugin.rb
 - lib/danger/danger_core/standard_error.rb
 - lib/danger/helpers/array_subclass.rb
 - lib/danger/helpers/comment.rb