danger 5.16.1 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 133d839f0f6c3eedc50601b624f25f793f9fa29e
-  data.tar.gz: d946b6c8c735b6953da0aa10c25f1d79e973a37c
+SHA256:
+  metadata.gz: 4d07daba46ea8c061e649a70aea12ae0861e959401e6231f4fa234bb90f6ca41
+  data.tar.gz: d61955050a1978795d286e1fd871ba7a00171ba219be928d14a5eb78c3dea86d
 SHA512:
-  metadata.gz: 87d8c1b18b032a8cbba94c2ab7286014c2a302d3ea23f7fc54cb6e7d731c8908c9a4851703a8b574609b5f12e151cbce27d84c208929afdd0ca7c5203a9a12a7
-  data.tar.gz: 4be777c012951b447e52f431c6ec9537159011c584a2f52928ec6543ca747a8a7f583bcde36941838380b5e4efc34fb9b152c9c3ab339f602008ceeeddf3632f
+  metadata.gz: 58c8913b443458cfebfd6d7cb257fc5bbebe7c1d024f37aeec9d9b9a11c7c629bf31e610e1a965c3a574270aa86f7268f5ecb6d47e57539e02a4c421b6e51555
+  data.tar.gz: 8b497b276d5c04fda4704c1c018d088dbd9b729b6a91750b988e7e1aac6d9cd8ab24975fac75b1f3371638278e13fe62bcf888b0606f775557dba7bd8f25e72a

data/README.md

@@ -91,4 +91,4 @@ We try to keep as much discussion as possible in GitHub issues, but also have a
 
 > This project subscribes to the [Moya Contributors Guidelines](https://github.com/Moya/contributors) which TLDR: means we give out push access easily and often.
 
-> Contributors subscribe to the [Contributor Code of Conduct](http://contributor-covenant.org/version/1/3/0/) based on the [Contributor Covenant](http://contributor-covenant.org) version 1.3.0.
+> Contributors subscribe to the [Contributor Code of Conduct](https://contributor-covenant.org/version/1/3/0/) based on the [Contributor Covenant](https://contributor-covenant.org) version 1.3.0.

data/lib/danger/request_sources/github/github.rb

@@ -375,6 +375,12 @@ module Danger
         pattern = "+++ b/" + message.file + "\n"
         file_start = diff_lines.index(pattern)
 
+        # Files containing spaces sometimes have a trailing tab
+        if file_start.nil?
+          pattern = "+++ b/" + message.file + "\t\n"
+          file_start = diff_lines.index(pattern)
+        end
+
         return nil if file_start.nil?
 
         position = -1

data/lib/danger/request_sources/gitlab.rb

@@ -399,26 +399,33 @@ module Danger
             end
           end
 
-          if matching_comments.empty?
-            params = {
-              body: body,
-              position: {
-                position_type: 'text',
-                new_path: m.file,
-                new_line: m.line,
-                base_sha: self.mr_json.diff_refs.base_sha,
-                start_sha: self.mr_json.diff_refs.start_sha,
-                head_sha: self.mr_json.diff_refs.head_sha
+          begin
+            if matching_comments.empty?
+              params = {
+                body: body,
+                position: {
+                  position_type: 'text',
+                  new_path: m.file,
+                  new_line: m.line,
+                  base_sha: self.mr_json.diff_refs.base_sha,
+                  start_sha: self.mr_json.diff_refs.start_sha,
+                  head_sha: self.mr_json.diff_refs.head_sha
+                }
               }
-            }
-            client.create_merge_request_discussion(ci_source.repo_slug, ci_source.pull_request_id, params)
-          else
-            # Remove the surviving comment so we don't strike it out
-            danger_comments.reject! { |c| matching_comments.include? c }
+              client.create_merge_request_discussion(ci_source.repo_slug, ci_source.pull_request_id, params)
+            else
+              # Remove the surviving comment so we don't strike it out
+              danger_comments.reject! { |c| matching_comments.include? c }
 
-            # Update the comment to remove the strikethrough if present
-            comment = matching_comments.first
-            client.update_merge_request_discussion_note(ci_source.repo_slug, ci_source.pull_request_id, comment["discussion_id"], comment["id"], body)
+              # Update the comment to remove the strikethrough if present
+              comment = matching_comments.first
+              client.update_merge_request_discussion_note(ci_source.repo_slug, ci_source.pull_request_id, comment["discussion_id"], comment["id"], body)
+            end
+          rescue Gitlab::Error::Error => e
+            message = [e, "body: #{body}", "position: #{params[:position].inspect}"].join("\n")
+            puts message
+
+            next false
           end
 
           # Remove this element from the array

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.16.1".freeze
+  VERSION = "6.0.0".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.16.1
+  version: 6.0.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-28 00:00:00.000000000 Z
+date: 2019-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -96,33 +96,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: octokit
+  name: kramdown
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: kramdown
+  name: kramdown-parser-gfm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: octokit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
@@ -294,7 +308,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -302,7 +316,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.