danger 5.16.0 → 5.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 3b40ff7a6e2e8ad3341d4e706e8d185a8c4287016e8ae5ed92e1b5609f9a4bf7
-  data.tar.gz: 152b14f3da15104d3e57dc1ade876c21a1558faea572d779760f65818340fb3f
+SHA1:
+  metadata.gz: 133d839f0f6c3eedc50601b624f25f793f9fa29e
+  data.tar.gz: d946b6c8c735b6953da0aa10c25f1d79e973a37c
 SHA512:
-  metadata.gz: c65cc6fa247104fe197ba532d02b7130558e1b3ee014818ca50cb03c31625b07c938d9a4b0fe909bfa136a7feb705c0c23f348e8713cd1d96cab058f6297a70a
-  data.tar.gz: 31da304ece4f45a98fe54ea148998750c5f7a4f3a0dec9dd57e2f0b3b907586695d740a32dd423e642c227e9fd33d1f2ce4d10093830a4184d75cb0569354b18
+  metadata.gz: 87d8c1b18b032a8cbba94c2ab7286014c2a302d3ea23f7fc54cb6e7d731c8908c9a4851703a8b574609b5f12e151cbce27d84c208929afdd0ca7c5203a9a12a7
+  data.tar.gz: 4be777c012951b447e52f431c6ec9537159011c584a2f52928ec6543ca747a8a7f583bcde36941838380b5e4efc34fb9b152c9c3ab339f602008ceeeddf3632f

data/lib/danger/request_sources/gitlab.rb

@@ -90,11 +90,26 @@ module Danger
 
       def mr_diff
         @mr_diff ||= begin
-          client.merge_request_changes(ci_source.repo_slug, ci_source.pull_request_id)
+          mr_changes
             .changes.map { |change| change["diff"] }.join("\n")
         end
       end
 
+      def mr_changed_paths
+        @mr_changed_paths ||= begin
+          mr_changes
+            .changes.map { |change| change["new_path"] }
+        end
+
+        @mr_changed_paths
+      end
+
+      def mr_changes
+        @mr_changes ||= begin
+          client.merge_request_changes(ci_source.repo_slug, ci_source.pull_request_id)
+        end
+      end
+
       def setup_danger_branches
         base_branch = self.mr_json.source_branch
         head_branch = self.mr_json.target_branch
@@ -359,10 +374,8 @@ module Danger
         messages.reject do |m|
           next false unless m.file && m.line
 
-          # position = find_position_in_diff diff_lines, m, kind
-
-          # Keep the change if it's line is not in the diff and not in dismiss mode
-          # next dismiss_out_of_range_messages_for(kind) if position.nil?
+          # Keep the change it's in a file changed in this diff
+          next if !mr_changed_paths.include?(m.file)
 
           # Once we know we're gonna submit it, we format it
           if is_markdown_content

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "5.16.0".freeze
+  VERSION = "5.16.1".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 5.16.0
+  version: 5.16.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-27 00:00:00.000000000 Z
+date: 2019-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -302,7 +302,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.