danger 4.0.4 → 4.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a944b517b8e33c5204a68e0380be5f0066b8df5
-  data.tar.gz: aeb83608871b332acba8321c43157893ade21a1d
+  metadata.gz: 2b38a6e168e6dcf728c7b4b6f21508898d541403
+  data.tar.gz: ff70b2d646014a8ad369e5ed58a8e8a23ff8fdd7
 SHA512:
-  metadata.gz: 1ca07fc21a6fc3168a8ab9db590017b90dc2872a49f536046646269e209acb19ff56df18f7103dee270c94f169ce283b1ea49be7808e64aedc7c075e9cc2d6c4
-  data.tar.gz: bc1ac336880de4d918c3da36351c49506c692fe12c17b3632a7fc496109395c7066e687da3c8791ec626dd02860354eac06da59cd756719fe96f28e1ca5d2300
+  metadata.gz: c1e063484128d9082a71d2988b8204a5161b8311935979997c120d03b30c4cc4110617f9d2a908826538bb406e59046299136058b3bf90ab023724ceae2d89c9
+  data.tar.gz: 4330a18b4774180d562017580484e3bc7fe9f6e97cf54f10611b86f0bc2f20938bfe4400ce4637c45564a4c5162b0b142cfef6a7374183e68ff3daa73222a870

data/lib/danger/ci_source/support/pull_request_finder.rb

@@ -116,7 +116,15 @@ module Danger
 
     def client
       require "octokit"
-      Octokit::Client.new(access_token: ENV["DANGER_GITHUB_API_TOKEN"])
+      Octokit::Client.new(access_token: ENV["DANGER_GITHUB_API_TOKEN"], api_endpoint: api_url)
+    end
+
+    def api_url
+      ENV.fetch("DANGER_GITHUB_API_HOST") do
+        ENV.fetch("DANGER_GITHUB_API_BASE_URL") do
+          "https://api.github.com/".freeze
+        end
+      end
     end
   end
 end

data/lib/danger/comment_generators/github.md.erb

@@ -14,7 +14,7 @@
      </tr>
   </thead>
   <tbody>
-    <%- max_num_violations = 700 -%>
+    <%- max_num_violations = FindMaxNumViolations.new(table[:content]).call -%>
     <%- table[:content].take(max_num_violations).each do |violation| -%>
     <tr>
       <td>:<%= table[:emoji] %>:</td>

data/lib/danger/helpers/comments_helper.rb

@@ -1,6 +1,7 @@
 require "kramdown"
 require "danger/helpers/comments_parsing_helper"
 require "danger/helpers/emoji_mapper"
+require "danger/helpers/find_max_num_violations"
 
 # rubocop:disable Metrics/ModuleLength
 

data/lib/danger/helpers/find_max_num_violations.rb

@@ -0,0 +1,31 @@
+# Find max_num_violations in lib/danger/comment_generators/github.md.erb.
+class FindMaxNumViolations
+  # Save ~ 5000 for contents other than violations to avoid exceeded 65536 max comment length limit.
+  LIMIT = 60_000
+
+  def initialize(violations)
+    @violations = violations
+  end
+
+  def call
+    total = 0
+    num_of_violations_allowed = 0
+
+    violations.each do |violation|
+      message_length = violation.message.length + 80 # 80 is ~ the size of html wraps violation message.
+
+      if total + message_length < LIMIT
+        total += message_length
+        num_of_violations_allowed += 1
+      else
+        break
+      end
+    end
+
+    num_of_violations_allowed
+  end
+
+  private
+
+  attr_reader :violations
+end

data/lib/danger/request_sources/github.rb

@@ -353,8 +353,8 @@ module Danger
           end
 
           # We are past the line position, just abort
-          break if message.line < range_start
-          next unless message.line >= range_start && message.line <= range_end
+          break if message.line.to_i < range_start
+          next unless message.line.to_i >= range_start && message.line.to_i <= range_end
 
           file_line = range_start
         end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "4.0.4".freeze
+  VERSION = "4.0.5".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 4.0.4
+  version: 4.0.5
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-29 00:00:00.000000000 Z
+date: 2017-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -422,6 +422,7 @@ files:
 - lib/danger/helpers/comments_helper.rb
 - lib/danger/helpers/comments_parsing_helper.rb
 - lib/danger/helpers/emoji_mapper.rb
+- lib/danger/helpers/find_max_num_violations.rb
 - lib/danger/plugin_support/gems_resolver.rb
 - lib/danger/plugin_support/plugin.rb
 - lib/danger/plugin_support/plugin_file_resolver.rb