danger 4.0.3 → 4.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df8c1995d113ffee76f38ee1a0d6decbc98cc274
-  data.tar.gz: f4cdebe97e60d72775f9d2a843ca0aabdeffdd78
+  metadata.gz: 4a944b517b8e33c5204a68e0380be5f0066b8df5
+  data.tar.gz: aeb83608871b332acba8321c43157893ade21a1d
 SHA512:
-  metadata.gz: 1f0df2202227ada072997c7a8606969c39a106d0df00f2e7c602e60c943e8f6a89cb4268cf09cb1d7ad26881a5926d7ddafa86e5d2b5fe610c3e939eceeadd88
-  data.tar.gz: f48dfe0b356f6291ae22f6e475874c1edb826a6c08923c57b2584abdcb813469b629a19bc13d83a4974d829be492d5d7dfe161ae6a40ef8f36650c4f9dd9e02f
+  metadata.gz: 1ca07fc21a6fc3168a8ab9db590017b90dc2872a49f536046646269e209acb19ff56df18f7103dee270c94f169ce283b1ea49be7808e64aedc7c075e9cc2d6c4
+  data.tar.gz: bc1ac336880de4d918c3da36351c49506c692fe12c17b3632a7fc496109395c7066e687da3c8791ec626dd02860354eac06da59cd756719fe96f28e1ca5d2300

data/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb

@@ -205,19 +205,22 @@ module Danger
     # @return [void]
     def import_local(path)
       Dir[path].each do |file|
-        validate_file_contains_plugin!(file)
+        validate_file_contains_plugin!(file) do
+          # Without the expand_path it would fail if the path doesn't start with ./
+          require File.expand_path(file)
+        end
 
-        # Without the expand_path it would fail if the path doesn't start with ./
-        require File.expand_path(file)
         refresh_plugins
       end
     end
 
+    # Raises an error when the given block does not register a plugin.
     def validate_file_contains_plugin!(file)
-      content = IO.read(file)
+      plugin_count_was = Danger::Plugin.all_plugins.length
+      yield
 
-      if content.scan(/class\s+(?<plugin_class>[\w]+)\s+<\s+((Danger::)?Plugin)/i).empty?
-        raise("#{file} doesn't contain any valid danger plugin.")
+      if Danger::Plugin.all_plugins.length == plugin_count_was
+        raise("#{file} doesn't contain any valid danger plugins.")
       end
     end
   end

data/lib/danger/plugin_support/gems_resolver.rb

@@ -9,20 +9,27 @@ module Danger
 
     # Returns an Array of paths (plugin lib file paths) and gems (of metadata)
     def call
+      path_gems = []
+
       Bundler.with_clean_env do
         Dir.chdir(dir) do
           create_gemfile_from_gem_names
           `bundle install --path vendor/gems`
+          path_gems = all_gems_metadata
         end
       end
 
-      return paths, gems
+      return path_gems
     end
 
     private
 
     attr_reader :gem_names, :dir
 
+    def all_gems_metadata
+      return paths, gems
+    end
+
     def create_gemfile_from_gem_names
       gemfile = File.new("Gemfile", "w")
       gemfile.write "source 'https://rubygems.org'"

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "4.0.3".freeze
+  VERSION = "4.0.4".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 4.0.3
+  version: 4.0.4
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-07 00:00:00.000000000 Z
+date: 2016-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -442,9 +442,7 @@ homepage: https://github.com/danger/danger
 licenses:
 - MIT
 metadata: {}
-post_install_message: |-
-  Thanks for installing Danger!
-  If you are updating from 3.0, we recommend reading the CHANGELOG: https://github.com/danger/danger/blob/master/CHANGELOG.md
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -460,7 +458,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Like Unit Tests, but for your Team Culture.