danger 3.6.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 829cfd070afd91b790b2aac00e62a09d0e8e169e
-  data.tar.gz: 5d52205da94c5a538fb1f148be5719733864c76a
+  metadata.gz: 21f670d087989c2099520be07dd3e1204a9c2eef
+  data.tar.gz: 3fbfee83973b73b19496f8c8bd74dd2ecbd8e09d
 SHA512:
-  metadata.gz: 8b540ce368e451e7287f5fa711281c1426c0f1118c9b8b753244425d7e9626251f16e50cc4bfce19dc42dab9ded3b33cf6bde007b872cd8dc52045593ab0efdb
-  data.tar.gz: ee493e7e72148446b71082a52fef7a23efee22f0ec3bc92bbb6c9e3005b5d7fffaea04abf51eba94b6e4bcfcc4f564ea52f82358d7b862a7322dc17a6adba8cc
+  metadata.gz: 11595711e242836e3328f7f0b1f4ef3ab54d60b561c2507052ddc74b0209f323f6fe04e5c96a1525026e055745b5f3a3eb86fee550e70bcb0df7cdfafc9a902e
+  data.tar.gz: 0367b7abdc0e048bc0cbcb7fbb7f324520952ed13b0b4de3e4eea87cc6bafae900ff0bbf3cb97baa9ff7be89d8f0f93910cd840de9e362012c0aa4f3673a95f3

data/lib/danger/danger_core/plugins/dangerfile_gitlab_plugin.rb

@@ -28,15 +28,15 @@ module Danger
   #
   #          fail "Please re-submit this MR to develop, we may have already fixed your issue." if gitlab.branch_for_merge != "develop"
   #
-  # @example Note when MRs don't reference a milestone, which goes away when it does.
+  # @example Note when MRs don't reference a milestone, make the warning stick around on subsequent runs
   #
   #          has_milestone = gitlab.mr_json["milestone"] != nil
-  #          warn("This MR does not refer to an existing milestone", sticky: false) unless has_milestone
+  #          warn("This MR does not refer to an existing milestone", sticky: true) unless has_milestone
   #
-  # @example Note when a MR cannot be manually merged, which goes away when you can.
+  # @example Note when a MR cannot be manually merged
   #
   #          can_merge = gitlab.mr_json["mergeable"]
-  #          warn("This MR cannot be merged yet.", sticky: false) unless can_merge
+  #          warn("This MR cannot be merged yet.") unless can_merge
   #
   # @example Highlight when a celebrity makes a merge request.
   #

data/lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb

@@ -8,12 +8,13 @@ module Danger
   #
   # The message within which Danger communicates back is amended on each run in a session.
   #
-  # Each of `message`, `warn` and `fail` have a `sticky` flag, `true` by default, which
-  # means that the message will be crossed out instead of being removed. If it's not use on
-  # subsequent runs.
+  # Each of `message`, `warn` and `fail` have a `sticky` flag, `false` by default, which
+  # when `true` means that the message will be crossed out instead of being removed.
+  # If it's not called again on subsequent runs.
   #
   # By default, using `fail` would fail the corresponding build. Either via an API call, or
-  # via the return value for the danger command.
+  # via the return value for the danger command. If you have linters with errors for this call
+  # you can use `messaging.fail` instead.
   #
   # It is possible to have Danger ignore specific warnings or errors by writing `Danger: Ignore "[warning/error text]"`.
   #
@@ -23,9 +24,9 @@ module Danger
   #
   #          fail "This build didn't pass tests"
   #
-  # @example Failing a build, but not keeping its value around on subsequent runs
+  # @example Failing a build, and note that on subsequent runs
   #
-  #          fail("This build didn't pass tests", sticky: false)
+  #          fail("This build didn't pass tests", sticky: true)
   #
   # @example Passing a warning
   #
@@ -87,14 +88,14 @@ module Danger
     #           The message to present to the user
     # @param    [Boolean] sticky
     #           Whether the message should be kept after it was fixed,
-    #           defaults to `true`.
+    #           defaults to `false`.
     # @param    [String] file
     #           Optional. Path to the file that the message is for.
     # @param    [String] line
     #           Optional. The line in the file to present the message in.
     # @return   [void]
     #
-    def message(message, sticky: true, file: nil, line: nil)
+    def message(message, sticky: false, file: nil, line: nil)
       @messages << Violation.new(message, sticky, file, line)
     end
 
@@ -105,14 +106,14 @@ module Danger
     #           The message to present to the user
     # @param    [Boolean] sticky
     #           Whether the message should be kept after it was fixed,
-    #           defaults to `true`.
+    #           defaults to `false`.
     # @param    [String] file
     #           Optional. Path to the file that the message is for.
     # @param    [String] line
     #           Optional. The line in the file to present the message in.
     # @return   [void]
     #
-    def warn(message, sticky: true, file: nil, line: nil)
+    def warn(message, sticky: false, file: nil, line: nil)
       return if should_ignore_violation(message)
       @warnings << Violation.new(message, sticky, file, line)
     end
@@ -124,14 +125,14 @@ module Danger
     #           The message to present to the user
     # @param    [Boolean] sticky
     #           Whether the message should be kept after it was fixed,
-    #           defaults to `true`.
+    #           defaults to `false`.
     # @param    [String] file
     #           Optional. Path to the file that the message is for.
     # @param    [String] line
     #           Optional. The line in the file to present the message in.
     # @return   [void]
     #
-    def fail(message, sticky: true, file: nil, line: nil)
+    def fail(message, sticky: false, file: nil, line: nil)
       return if should_ignore_violation(message)
       @errors << Violation.new(message, sticky, file, line)
     end

data/lib/danger/request_sources/gitlab.rb

@@ -1,5 +1,4 @@
 # coding: utf-8
-require "gitlab"
 require "danger/helpers/comments_helper"
 require "danger/helpers/comment"
 
@@ -29,10 +28,19 @@ module Danger
       def client
         token = @environment["DANGER_GITLAB_API_TOKEN"]
         raise "No API token given, please provide one using `DANGER_GITLAB_API_TOKEN`" unless token
+
+        # The require happens inline so that it won't cause exceptions when just using the `danger` gem.
+        require "gitlab"
+
         params = { private_token: token }
         params[:endpoint] = endpoint
 
         @client ||= Gitlab.client(params)
+
+      rescue LoadError
+        puts "The GitLab gem was not installed, you will need to change your Gem from `danger` to `danger-gitlab`.".red
+        puts "\n - See https://github.com/danger/danger/blob/master/CHANGELOG.md#400"
+        abort
       end
 
       def validates_as_api_source?

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "3.6.0".freeze
+  VERSION = "4.0.0".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 3.6.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Orta Therox
-- Felix Krause
+- Juanito Fatas
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -151,20 +151,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
-- !ruby/object:Gem::Dependency
-  name: gitlab
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.7.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 3.7.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -364,7 +350,7 @@ dependencies:
 description: Stop Saying 'You Forgot To…' in Code Review
 email:
 - orta.therox@gmail.com
-- danger@krausefx.com
+- katehuang0320@gmail.com
 executables:
 - danger
 extensions: []
@@ -454,7 +440,9 @@ homepage: https://github.com/danger/danger
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: |-
+  Thanks for installing Danger!
+  If you are updating from 3.0, we recommend reading the CHANGELOG: https://github.com/danger/danger/blob/master/CHANGELOG.md
 rdoc_options: []
 require_paths:
 - lib