danger 3.3.2 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 423ee19a94a521cfab7f662fd5897bc0130ad848
-  data.tar.gz: dff351383ef77ef6ed555687d51584a8b733e037
+  metadata.gz: 331ec016762064e8a92668e5b9b56521e5873f50
+  data.tar.gz: 69fb9998dbe05c5465301a4a0396a28ce4ebf1ca
 SHA512:
-  metadata.gz: 5b44215d3633c38174e8cacc523169c76c23999f19e6b134f50be7214cc5a763d39e514e92e4118f9c332130911c8b2123f4b67cf5680ee2eee2689710a5980d
-  data.tar.gz: fa3be34a121bbe67101086fb3ecd6d2d0598c13bc048a28bbdf14cd4da4228168c9dcb002243877df714358e27e21660a3bead61c8831e72892e89b3cc41b7fa
+  metadata.gz: 0abf5fed8d027d3368573054d82b87c4010bf806ef83d0d41f8b964d438e44fd35dd99f822de9ebc581c3d3d59ea6810145235a08b7ed7a20682f4ae35e80019
+  data.tar.gz: 2189b8616f4a18ee79d12863c5ce0db5dc803996635c5e14b6f56f66050b97207cb76198fc36cadad80399e4b3ed6c0901814f653972236d57ab4a5f37015583

data/lib/danger/ci_source/local_git_repo.rb

@@ -46,7 +46,7 @@ module Danger
       ).call
 
       pull_request_id, sha = MergedPullRequestFinder.new(
-        env["LOCAL_GIT_PR_ID"] || "",
+        env.fetch("LOCAL_GIT_PR_ID") { "" },
         run_git("log --oneline -1000000".freeze)
       ).call
 

data/lib/danger/ci_source/support/merged_pull_request_finder.rb

@@ -17,20 +17,20 @@ module Danger
 
     # @return [String] "#42"
     def pull_request_ref
-      specific_pull_request_id ? "##{specific_pull_request_id}" : "".freeze
+      !specific_pull_request_id.empty? ? "##{specific_pull_request_id}" : "#\\d+".freeze
     end
 
     # @return [String] Log line of format: "Merge pull request #42"
     def most_recent_merged_pull_request
       @most_recent_merged_pull_request ||= begin
-        git_logs.lines.grep(/Merge pull request #{pull_request_ref}/)[0]
+        git_logs.lines.grep(/Merge pull request #{pull_request_ref} from/)[0]
       end
     end
 
     # @return [String] Log line of format: "description (#42)"
     def most_recent_squash_and_merged_pull_request
       @most_recent_squash_and_merged_pull_request ||= begin
-        git_logs.lines.grep(/#{pull_request_ref}/)[0]
+        git_logs.lines.grep(/\(#{pull_request_ref}\)/)[0]
       end
     end
 
@@ -38,16 +38,45 @@ module Danger
     def merged_pull_request
       return if pull_request_ref.empty?
 
-      if most_recent_merged_pull_request
+      if both_present?
+        pick_the_most_recent_one_from_two_matches
+      elsif only_merged_pull_request_present?
         most_recent_merged_pull_request
-      elsif most_recent_squash_and_merged_pull_request
+      elsif only_squash_and_merged_pull_request_present?
         most_recent_squash_and_merged_pull_request
       end
     end
 
+    def both_present?
+      most_recent_merged_pull_request && most_recent_squash_and_merged_pull_request
+    end
+
+    def only_merged_pull_request_present?
+      return false if most_recent_squash_and_merged_pull_request
+
+      !most_recent_merged_pull_request.nil? && !most_recent_merged_pull_request.empty?
+    end
+
+    def only_squash_and_merged_pull_request_present?
+      return false if most_recent_merged_pull_request
+
+      !most_recent_squash_and_merged_pull_request.nil? && !most_recent_squash_and_merged_pull_request.empty?
+    end
+
+    def pick_the_most_recent_one_from_two_matches
+      merged_index = git_logs.lines.index(most_recent_merged_pull_request)
+      squash_and_merged_index = git_logs.lines.index(most_recent_squash_and_merged_pull_request)
+
+      if merged_index > squash_and_merged_index # smaller index is more recent
+        most_recent_squash_and_merged_pull_request
+      else
+        most_recent_merged_pull_request
+      end
+    end
+
     def check_if_any_merged_pull_request!
       if merged_pull_request.to_s.empty?
-        if specific_pull_request_id
+        if !specific_pull_request_id.empty?
           raise "Could not find the Pull Request (#{specific_pull_request_id}) inside the git history for this repo."
         else
           raise "No recent Pull Requests found for this repo, danger requires at least one Pull Request for the local mode.".freeze

data/lib/danger/ci_source/teamcity.rb

@@ -32,7 +32,7 @@ module Danger
   class TeamCity < CI
     class << self
       def validates_as_github_pr?(env)
-        ["GITHUB_PULL_REQUEST_ID", "GITHUB_REPO_URL", "GITHUB_REPO_URL"].all? { |x| env[x] && !env[x].empty? }
+        ["GITHUB_PULL_REQUEST_ID", "GITHUB_REPO_URL"].all? { |x| env[x] && !env[x].empty? }
       end
 
       def validates_as_gitlab_pr?(env)

data/lib/danger/commands/init.rb

@@ -93,7 +93,7 @@ module Danger
       ui.pause 1
 
       if considered_an_oss_repo?
-        ui.say "#{@bot_name} does not need privilidged access to your repo or org. This is because Danger will only"
+        ui.say "#{@bot_name} does not need privileged access to your repo or org. This is because Danger will only"
         ui.say "be writing comments, and you do not need special access for that."
       else
         ui.say "#{@bot_name} will need access to your repo. Simply because the code is not available for the public"

data/lib/danger/commands/local.rb

@@ -9,6 +9,14 @@ module Danger
     self.summary = "Run the Dangerfile locally."
     self.command = "local"
 
+    def self.options
+      [
+        ["--use-merged-pr=[#id]", "The ID of an already merged PR inside your history to use as a reference for the local run."],
+        ["--clear-http-cache", "Clear the local http cache before running Danger locally."],
+        ["--pry", "Drop into a Pry shell after evaluating the Dangerfile."]
+      ]
+    end
+
     def initialize(argv)
       @pr_num = argv.option("use-merged-pr")
       @clear_http_cache = argv.flag?("clear-http-cache", false)
@@ -39,14 +47,6 @@ module Danger
       abort
     end
 
-    def self.options
-      [
-        ["--use-merged-pr=[#id]", "The ID of an already merged PR inside your history to use as a reference for the local run."],
-        ["--clear-http-cache", "Clear the local http cache before running Danger locally."],
-        ["--pry", "Drop into a Pry shell after evaluating the Dangerfile."]
-      ].concat(super)
-    end
-
     def validate!
       super
       unless @dangerfile_path
@@ -67,7 +67,7 @@ module Danger
         builder.adapter Faraday.default_adapter
       end
 
-      env = EnvironmentManager.new(ENV)
+      env = EnvironmentManager.new(ENV, cork)
       dm = Dangerfile.new(env, cork)
       dm.init_plugins
 

data/lib/danger/commands/runner.rb

@@ -8,10 +8,12 @@ module Danger
     require "claide_plugin"
     @subcommands << CLAide::Command::Plugins
     CLAide::Plugins.config =
-      CLAide::Plugins::Configuration.new("Danger",
-                                         "danger",
-                                         "https://raw.githubusercontent.com/danger/danger.systems/master/plugins-search-generated.json",
-                                         "https://github.com/danger/danger-plugin-template")
+      CLAide::Plugins::Configuration.new(
+        "Danger",
+        "danger",
+        "https://raw.githubusercontent.com/danger/danger.systems/master/plugins-search-generated.json",
+        "https://github.com/danger/danger-plugin-template"
+      )
 
     require "danger/commands/plugins/plugin_lint"
     require "danger/commands/plugins/plugin_json"
@@ -27,9 +29,10 @@ module Danger
 
     def initialize(argv)
       dangerfile = argv.option("dangerfile", "Dangerfile")
-      @dangerfile_path = dangerfile if File.exist? dangerfile
+      @dangerfile_path = dangerfile if File.exist?(dangerfile)
       @base = argv.option("base")
       @head = argv.option("head")
+      @fail_on_errors = argv.option("fail-on-errors", false)
       @danger_id = argv.option("danger_id", "danger")
       @cork = Cork::Board.new(silent: argv.option("silent", false),
                               verbose: argv.option("verbose", false))
@@ -39,7 +42,7 @@ module Danger
     def validate!
       super
       if self.class == Runner && !@dangerfile_path
-        help! "Could not find a Dangerfile."
+        help!("Could not find a Dangerfile.")
       end
     end
 
@@ -47,16 +50,20 @@ module Danger
       [
         ["--base=[master|dev|stable]", "A branch/tag/commit to use as the base of the diff"],
         ["--head=[master|dev|stable]", "A branch/tag/commit to use as the head"],
+        ["--fail-on-errors=<true|false>", "Should always fail the build process, defaults to false"],
         ["--dangerfile=<path/to/dangerfile>", "The location of your Dangerfile"],
         ["--danger_id=<id>", "The identifier of this Danger instance"]
       ].concat(super)
     end
 
     def run
-      Executor.new(ENV).run(base: @base,
-                       head: @head,
-                       dangerfile_path: @dangerfile_path,
-                       danger_id: @danger_id)
+      Executor.new(ENV).run(
+        base: @base,
+        head: @head,
+        dangerfile_path: @dangerfile_path,
+        danger_id: @danger_id,
+        fail_on_errors: @fail_on_errors
+      )
     end
   end
 end

data/lib/danger/danger_core/dangerfile.rb

@@ -233,6 +233,54 @@ module Danger
       end
     end
 
+    def failed?
+      violation_report[:errors].count > 0
+    end
+
+    def post_results(danger_id)
+      violations = violation_report
+
+      env.request_source.update_pull_request!(
+        warnings: violations[:warnings],
+        errors: violations[:errors],
+        messages: violations[:messages],
+        markdowns: status_report[:markdowns],
+        danger_id: danger_id
+      )
+    end
+
+    def setup_for_running(base_branch, head_branch)
+      env.ensure_danger_branches_are_setup
+      env.scm.diff_for_folder(".".freeze, from: base_branch, to: head_branch)
+    end
+
+    def run(base_branch, head_branch, dangerfile_path, danger_id)
+      # Setup internal state
+      init_plugins
+      env.fill_environment_vars
+
+      begin
+        # Sets up the git environment
+        setup_for_running(base_branch, head_branch)
+
+        # Parse the local Dangerfile
+        parse(Pathname.new(dangerfile_path))
+
+        # Push results to the API
+        # Pass along the details of the run to the request source
+        # to send back to the code review site.
+        post_results(danger_id)
+
+        # Print results in the terminal
+        print_results
+      ensure
+        # Makes sure that Danger specific git branches are cleaned
+        env.clean_up
+      end
+
+      failed?
+    end
+
     private
 
     def print_list(title, rows)

data/lib/danger/danger_core/environment_manager.rb

@@ -3,7 +3,7 @@ require "danger/request_sources/request_source"
 
 module Danger
   class EnvironmentManager
-    attr_accessor :ci_source, :request_source, :scm
+    attr_accessor :ci_source, :request_source, :scm, :ui
 
     # Finds a Danger::CI class based on the ENV
     def self.local_ci_source(env)
@@ -15,9 +15,10 @@ module Danger
       local_ci_source(env).validates_as_pr?(env)
     end
 
-    def initialize(env)
+    def initialize(env, ui)
       ci_klass = self.class.local_ci_source(env)
       self.ci_source = ci_klass.new(env)
+      self.ui = ui
 
       RequestSources::RequestSource.available_request_sources.each do |klass|
         next unless self.ci_source.supports?(klass)
@@ -28,7 +29,7 @@ module Danger
         self.request_source = request_source
       end
 
-      raise "Could not find a Request Source for #{ci_klass}\nCI: #{ci_source.inspect}".red unless self.request_source
+      raise_error_for_no_request_source(env, ui) unless self.request_source
       self.scm = self.request_source.scm
     end
 
@@ -67,5 +68,53 @@ module Danger
     def self.danger_base_branch
       "danger_base"
     end
+
+    def raise_error_for_no_request_source(env, ui)
+      title, subtitle = extract_title_and_subtitle_from_source(ci_source.repo_url)
+      subtitle += travis_note if env["TRAVIS_SECURE_ENV_VARS"] == "true"
+
+      ui_display_no_request_source_error_message(ui, env, title, subtitle)
+
+      exit(1)
+    end
+
+    private
+
+    def get_repo_source(repo_url)
+      if repo_url =~ /github/i
+        RequestSources::GitHub
+      elsif repo_url =~ /gitlab/i
+        RequestSources::GitLab
+      elsif repo_url =~ /bitbucket\.(org|com)/i
+        RequestSources::BitbucketCloud
+      end
+    end
+
+    def extract_title_and_subtitle_from_source(repo_url)
+      source = get_repo_source(repo_url)
+
+      if source
+        title = "For your #{source.source_name} repo, you need to expose: " + source.env_vars.join(", ").yellow
+        subtitle = "You may also need: #{source.optional_env_vars.join(', ')}" if source.optional_env_vars.any?
+      else
+        title = "For Danger to run on this project, you need to expose a set of following the ENV vars:\n#{RequestSources::RequestSource.available_source_names_and_envs.join("\n")}"
+      end
+
+      [title, (subtitle || "")]
+    end
+
+    def ui_display_no_request_source_error_message(ui, env, title, subtitle)
+      ui.title "Could not set up API to Code Review site for Danger\n".freeze
+      ui.puts title
+      ui.puts subtitle
+      ui.puts "\nFound these keys in your ENV: #{env.keys.join(', '.freeze)}."
+      ui.puts "\nFailing the build, Danger cannot run without API access.".freeze
+      ui.puts "You can see more information at http://danger.systems/guides/getting_started.html".freeze
+    end
+
+    def travis_note
+      "\nTravis note: If you have an open source project, you should ensure 'Display value in build log' enabled for these flags, so that PRs from forks work." \
+      "\nThis also means that people can see this token, so this account should have no write access to repos."
+    end
   end
 end

data/lib/danger/danger_core/executor.rb

@@ -10,61 +10,63 @@ module Danger
             base: nil,
             head: nil,
             dangerfile_path: nil,
-            danger_id: nil)
+            danger_id: nil,
+            fail_on_errors: nil)
+      # Create a silent Cork instance if cork is nil, as it's likely a test
+      cork ||= Cork::Board.new(silent: false, verbose: false)
 
-      cork ||= Cork::Board.new(silent: false,
-                              verbose: false)
+      # Run some validations
+      validate!(cork)
 
-      # Could we find a CI source at all?
-      unless EnvironmentManager.local_ci_source(@system_env)
-        abort("Could not find the type of CI for Danger to run on.".red)
-      end
-
-      # Could we determine that the CI source is inside a PR?
-      unless EnvironmentManager.pr?(@system_env)
-        cork.puts "Not a Pull Request - skipping `danger` run".yellow
-        return
-      end
-
-      # OK, then we can have some
-      env ||= EnvironmentManager.new(@system_env)
+      # OK, we now know that Danger can run in this enviroment
+      env ||= EnvironmentManager.new(system_env, cork)
       dm ||= Dangerfile.new(env, cork)
 
-      dm.init_plugins
+      ran_status = begin
+        dm.run(
+          base_branch(base),
+          head_branch(head),
+          dangerfile_path,
+          danger_id
+        )
+      end
 
-      dm.env.fill_environment_vars
+      # By default Danger will use the status API to fail a build,
+      # allowing execution to continue, this behavior isn't always
+      # optimal for everyone.
+      exit(1) if fail_on_errors && ran_status
+    end
 
-      begin
-        dm.env.ensure_danger_branches_are_setup
+    def validate!(cork)
+      validate_ci!
+      validate_pr!(cork)
+    end
 
-        # Offer the chance for a user to specify a branch through the command line
-        ci_base = base || EnvironmentManager.danger_base_branch
-        ci_head = head || EnvironmentManager.danger_head_branch
+    private
 
-        dm.env.scm.diff_for_folder(".", from: ci_base, to: ci_head)
+    attr_reader :system_env
 
-        # Parse the local Dangerfile
-        dm.parse(Pathname.new(dangerfile_path))
+    # Could we find a CI source at all?
+    def validate_ci!
+      unless EnvironmentManager.local_ci_source(system_env)
+        abort("Could not find the type of CI for Danger to run on.".red)
+      end
+    end
 
-        post_results(dm, danger_id)
-        dm.print_results
-      ensure
-        dm.env.clean_up
+    # Could we determine that the CI source is inside a PR?
+    def validate_pr!(cork)
+      unless EnvironmentManager.pr?(system_env)
+        cork.puts "Not a Pull Request - skipping `danger` run".yellow
+        exit(0)
       end
     end
 
-    def post_results(danger_file, danger_id)
-      request_source = danger_file.env.request_source
-      violations = danger_file.violation_report
-      status = danger_file.status_report
+    def base_branch(user_specified_base_branch)
+      user_specified_base_branch || EnvironmentManager.danger_base_branch
+    end
 
-      request_source.update_pull_request!(
-        warnings: violations[:warnings],
-        errors: violations[:errors],
-        messages: violations[:messages],
-        markdowns: status[:markdowns],
-        danger_id: danger_id
-      )
+    def head_branch(user_specified_head_branch)
+      user_specified_head_branch || EnvironmentManager.danger_head_branch
     end
   end
 end

data/lib/danger/danger_core/plugins/dangerfile_danger_plugin.rb

@@ -197,10 +197,20 @@ module Danger
     # @return [void]
     def import_local(path)
       Dir[path].each do |file|
+        validate_file_contains_plugin!(file)
+
         # Without the expand_path it would fail if the path doesn't start with ./
         require File.expand_path(file)
         refresh_plugins
       end
     end
+
+    def validate_file_contains_plugin!(file)
+      content = IO.read(file)
+
+      if content.scan(/class\s+(?<plugin_class>[\w]+)\s+<\s+Plugin/i).empty?
+        raise("#{file} doesn't contain any valid danger plugin.")
+      end
+    end
   end
 end

data/lib/danger/danger_core/plugins/dangerfile_git_plugin.rb

@@ -28,7 +28,7 @@ module Danger
   #
   # @example Warn when somebody tries to add nokogiri to the project
   #
-  #          diff = git.diff_for_file["Gemfile.lock"]
+  #          diff = git.diff_for_file("Gemfile.lock")
   #          if diff && diff.patch =~ "nokogiri"
   #            warn 'Please do not add nokogiri to the project. Thank you.'
   #          end

data/lib/danger/request_sources/bitbucket_cloud.rb

@@ -8,6 +8,13 @@ module Danger
       include Danger::Helpers::CommentsHelper
       attr_accessor :pr_json
 
+      def self.env_vars
+        [
+          "DANGER_BITBUCKETCLOUD_USERNAME",
+          "DANGER_BITBUCKETCLOUD_PASSWORD"
+        ]
+      end
+
       def initialize(ci_source, environment)
         self.ci_source = ci_source
         self.environment = environment
@@ -42,10 +49,12 @@ module Danger
         head_commit = self.pr_json[:source][:commit][:hash]
 
         # Next, we want to ensure that we have a version of the current branch at a known location
+        scm.ensure_commitish_exists! base_commit
         self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{base_commit}"
 
         # OK, so we want to ensure that we have a known head branch, this will always represent
         # the head of the PR ( e.g. the most recent commit that will be merged. )
+        scm.ensure_commitish_exists! head_commit
         self.scm.exec "branch #{EnvironmentManager.danger_head_branch} #{head_commit}"
       end
 

data/lib/danger/request_sources/bitbucket_server.rb

@@ -8,6 +8,14 @@ module Danger
       include Danger::Helpers::CommentsHelper
       attr_accessor :pr_json
 
+      def self.env_vars
+        [
+          "DANGER_BITBUCKETSERVER_USERNAME",
+          "DANGER_BITBUCKETSERVER_PASSWORD",
+          "DANGER_BITBUCKETSERVER_HOST"
+        ]
+      end
+
       def initialize(ci_source, environment)
         self.ci_source = ci_source
         self.environment = environment
@@ -42,10 +50,12 @@ module Danger
         head_commit = self.pr_json[:fromRef][:latestCommit]
 
         # Next, we want to ensure that we have a version of the current branch at a known location
+        scm.ensure_commitish_exists! base_commit
         self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{base_commit}"
 
         # OK, so we want to ensure that we have a known head branch, this will always represent
         # the head of the PR ( e.g. the most recent commit that will be merged. )
+        scm.ensure_commitish_exists! head_commit
         self.scm.exec "branch #{EnvironmentManager.danger_head_branch} #{head_commit}"
       end
 

data/lib/danger/request_sources/github.rb

@@ -10,16 +10,20 @@ module Danger
 
       attr_accessor :pr_json, :issue_json, :support_tokenless_auth
 
+      def self.env_vars
+        ["DANGER_GITHUB_API_TOKEN"]
+      end
+
+      def self.optional_env_vars
+        ["DANGER_GITHUB_HOST", "DANGER_GITHUB_API_BASE_URL"]
+      end
+
       def initialize(ci_source, environment)
         self.ci_source = ci_source
         self.environment = environment
         self.support_tokenless_auth = false
 
-        Octokit.auto_paginate = true
         @token = @environment["DANGER_GITHUB_API_TOKEN"]
-        if api_url
-          Octokit.api_endpoint = api_url
-        end
       end
 
       def validates_as_api_source?
@@ -34,16 +38,23 @@ module Danger
         @host = @environment["DANGER_GITHUB_HOST"] || "github.com"
       end
 
+      # `DANGER_GITHUB_API_HOST` is the old name kept for legacy reasons and
+      # backwards compatibility. `DANGER_GITHUB_API_BASE_URL` is the new
+      # correctly named variable.
       def api_url
-        # `DANGER_GITHUB_API_HOST` is the old name kept for legacy reasons and
-        # backwards compatibility. `DANGER_GITHUB_API_BASE_URL` is the new
-        # correctly named variable.
-        @environment["DANGER_GITHUB_API_HOST"] || @environment["DANGER_GITHUB_API_BASE_URL"]
+        @environment.fetch("DANGER_GITHUB_API_HOST") do
+          @environment.fetch("DANGER_GITHUB_API_BASE_URL") do
+            "https://api.github.com/".freeze
+          end
+        end
       end
 
       def client
         raise "No API token given, please provide one using `DANGER_GITHUB_API_TOKEN`" if !@token && !support_tokenless_auth
-        @client ||= Octokit::Client.new(access_token: @token)
+
+        @client ||= begin
+          Octokit::Client.new(access_token: @token, auto_paginate: true, api_endpoint: api_url)
+        end
       end
 
       def pr_diff
@@ -56,10 +67,12 @@ module Danger
         head_commit = self.pr_json["head"]["sha"]
 
         # Next, we want to ensure that we have a version of the current branch at a known location
+        scm.ensure_commitish_exists! base_commit
         self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{base_commit}"
 
         # OK, so we want to ensure that we have a known head branch, this will always represent
         # the head of the PR ( e.g. the most recent commit that will be merged. )
+        scm.ensure_commitish_exists! head_commit
         self.scm.exec "branch #{EnvironmentManager.danger_head_branch} #{head_commit}"
       end
 

data/lib/danger/request_sources/gitlab.rb

@@ -9,6 +9,14 @@ module Danger
       include Danger::Helpers::CommentsHelper
       attr_accessor :mr_json, :commits_json
 
+      def self.env_vars
+        ["DANGER_GITLAB_API_TOKEN"]
+      end
+
+      def self.optional_env_vars
+        ["DANGER_GITLAB_HOST", "DANGER_GITLAB_API_BASE_URL"]
+      end
+
       def initialize(ci_source, environment)
         self.ci_source = ci_source
         self.environment = environment
@@ -43,7 +51,7 @@ module Danger
 
       def base_commit
         first_commit_in_branch = self.commits_json.last.id
-        @base_comit ||= self.scm.exec "rev-parse #{first_commit_in_branch}^1"
+        @base_commit ||= self.scm.exec "rev-parse #{first_commit_in_branch}^1"
       end
 
       def mr_comments
@@ -64,10 +72,12 @@ module Danger
         head_commit = self.scm.head_commit
 
         # Next, we want to ensure that we have a version of the current branch at a known location
+        scm.ensure_commitish_exists! base_commit
         self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{base_commit}"
 
         # OK, so we want to ensure that we have a known head branch, this will always represent
         # the head of the PR ( e.g. the most recent commit that will be merged. )
+        scm.ensure_commitish_exists! head_commit
         self.scm.exec "branch #{EnvironmentManager.danger_head_branch} #{head_commit}"
       end
 

data/lib/danger/request_sources/request_source.rb

@@ -5,6 +5,14 @@ module Danger
 
       attr_accessor :ci_source, :environment, :scm, :host, :ignored_violations
 
+      def self.env_vars
+        raise "Subclass and overwrite self.env_vars"
+      end
+
+      def self.optional_env_vars
+        []
+      end
+
       def self.inherited(child_class)
         available_request_sources.add child_class
         super
@@ -14,6 +22,16 @@ module Danger
         @available_request_sources ||= Set.new
       end
 
+      def self.source_name
+        to_s.sub("Danger::RequestSources::".freeze, "".freeze)
+      end
+
+      def self.available_source_names_and_envs
+        available_request_sources.map do |klass|
+          " - #{klass.source_name}: #{klass.env_vars.join(', '.freeze).yellow}"
+        end
+      end
+
       def initialize(_ci_source, _environment)
         raise "Subclass and overwrite initialize"
       end

data/lib/danger/scm_source/git_repo.rb

@@ -36,15 +36,15 @@ module Danger
       exec("remote show origin -n").lines.grep(/Fetch URL/)[0].split(": ", 2)[1].chomp
     end
 
+    def ensure_commitish_exists!(commitish)
+      exec("fetch") if exec("rev-parse --quiet --verify #{commitish}").empty?
+    end
+
     private
 
     def default_env
       { "LANG" => "en_US.UTF-8" }
     end
-
-    def ensure_commitish_exists!(commitish)
-      exec "fetch" if exec("--no-pager show #{commitish}").empty?
-    end
   end
 end
 

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "3.3.2".freeze
+  VERSION = "3.4.0".freeze
   DESCRIPTION = "Like Unit Tests, but for your Team Culture.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.4.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-19 00:00:00.000000000 Z
+date: 2016-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide