danger 0.8.5 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e63c577b5aa89a7b235f6f720d3a41d025ccb56a
-  data.tar.gz: b30b994f0372f4ae66aa9dd62af48e1c96f8a595
+  metadata.gz: 730a6b52e123cb69852704e92867526da77dcaa3
+  data.tar.gz: c48c217b428923652f446788107c0d140074e967
 SHA512:
-  metadata.gz: ba6cc6f86fb8f5859dd04fadd8066443f1fa816cf6ff3b6dc4fcceb5ab6a307bbb366c5404eaa2efbeaa4d2888fe15e3cb1698c2b31be6740ebe7ba4ae434199
-  data.tar.gz: 6e1c4b7d707d8f966b9085d3a96d4fd2bba6ed504673631209a11bd1e07fb260b91b8ba074caa196c475677cb30b15aa223673f99747b214cb2143dc2da35802
+  metadata.gz: e722f6688e5a65281c751a762fb3f8df5342080a404b15b7ca62c7ec6dcf3ff501dafc4a9f9881c75a5661ca5b64f3aec4309a3dcdcd693a607d24d241c970c9
+  data.tar.gz: 4a205ad49112adbb1980182cabebecb6c79eabdab0da89f70cabd7a58b2cd669c304e9dafa26b107aab6924f09f7700203bdaeac7a0d5a0026bf27ebbe97b5aa

data/README.md

@@ -102,9 +102,12 @@ end
 #### Pinging people when a specific file has changed
 
 ```ruby
-message("@orta something changed in elan!") if modified_files.include? "/components/lib/variables/colors.json"
+markdown("@orta something changed in elan!") if modified_files.include? "/components/lib/variables/colors.json"
 ```
 
+If you wish to ping a person on a PR you'll need to use the `markdown` method rather than the `message`, `warn` or `fail` methods.
+This is because the HTML generated by the latter methods doesn't trigger GitHub's notification detection.
+
 #### Exposing aspects of CI logs into the PR discussion
 
 ```ruby

data/bin/danger

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-$LOAD_PATH.push File.expand_path('../../lib', __FILE__)
+$LOAD_PATH.push File.expand_path("../../lib", __FILE__)
 
-require 'danger'
+require "danger"
 Danger::Runner.run ARGV

data/lib/danger.rb

@@ -1,25 +1,25 @@
-require 'danger/version'
-require 'danger/danger_core/dangerfile'
-require 'danger/danger_core/environment_manager'
-require 'danger/commands/runner'
-require 'danger/plugin_support/plugin'
-require 'danger/core_ext/string'
+require "danger/version"
+require "danger/danger_core/dangerfile"
+require "danger/danger_core/environment_manager"
+require "danger/commands/runner"
+require "danger/plugin_support/plugin"
+require "danger/core_ext/string"
 
-require 'claide'
-require 'colored'
-require 'pathname'
-require 'terminal-table'
-require 'cork'
+require "claide"
+require "colored"
+require "pathname"
+require "terminal-table"
+require "cork"
 
 # Import all the Sources (CI, Request and SCM)
-Dir[File.expand_path('danger/*source/*.rb', File.dirname(__FILE__))].each do |file|
+Dir[File.expand_path("danger/*source/*.rb", File.dirname(__FILE__))].each do |file|
   require file
 end
 
 module Danger
   # @return [String] The path to the local gem directory
   def self.gem_path
-    gem_name = 'danger'
+    gem_name = "danger"
     unless Gem::Specification.find_all_by_name(gem_name).any?
       raise "Couldn't find gem directory for 'danger'"
     end

data/lib/danger/ci_source/buildkite.rb

@@ -5,16 +5,16 @@ module Danger
   module CISource
     class Buildkite < CI
       def self.validates?(env)
-        return false unless env['BUILDKITE']
-        return false unless env['BUILDKITE_REPO']
-        return false unless env['BUILDKITE_PULL_REQUEST']
+        return false unless env["BUILDKITE"]
+        return false unless env["BUILDKITE_PULL_REQUEST_REPO"] && !env["BUILDKITE_PULL_REQUEST_REPO"].empty?
+        return false unless env["BUILDKITE_PULL_REQUEST"]
 
         return true
       end
 
       def initialize(env)
-        self.repo_url = env['BUILDKITE_REPO']
-        self.pull_request_id = env['BUILDKITE_PULL_REQUEST']
+        self.repo_url = env["BUILDKITE_PULL_REQUEST_REPO"]
+        self.pull_request_id = env["BUILDKITE_PULL_REQUEST"]
 
         repo_matches = self.repo_url.match(%r{([\/:])([^\/]+\/[^\/.]+)(?:.git)?$})
         self.repo_slug = repo_matches[2] unless repo_matches.nil?

data/lib/danger/ci_source/ci_source.rb

@@ -1,4 +1,4 @@
-require 'set'
+require "set"
 
 module Danger
   module CISource
@@ -16,7 +16,7 @@ module Danger
       end
 
       def supported_request_sources
-        raise 'CISource subclass must specify the supported request sources'
+        raise "CISource subclass must specify the supported request sources"
       end
 
       def supports?(request_source)
@@ -28,7 +28,7 @@ module Danger
       end
 
       def initialize(_env)
-        raise 'Subclass and overwrite initialize'
+        raise "Subclass and overwrite initialize"
       end
     end
   end

data/lib/danger/ci_source/circle.rb

@@ -1,14 +1,14 @@
 # https://circleci.com/docs/environment-variables
-require 'uri'
-require 'danger/ci_source/circle_api'
+require "uri"
+require "danger/ci_source/circle_api"
 
 module Danger
   module CISource
     class CircleCI < CI
       def self.validates?(env)
-        return false unless env['CIRCLE_BUILD_NUM']
-        return false unless env['CIRCLE_PROJECT_USERNAME']
-        return false unless env['CIRCLE_PROJECT_REPONAME']
+        return false unless env["CIRCLE_BUILD_NUM"]
+        return false unless env["CIRCLE_PROJECT_USERNAME"]
+        return false unless env["CIRCLE_PROJECT_REPONAME"]
 
         return true
       end
@@ -27,11 +27,11 @@ module Danger
       end
 
       def pull_request_url(env)
-        url = env['CI_PULL_REQUEST']
+        url = env["CI_PULL_REQUEST"]
 
-        if url.nil? && !env['CIRCLE_PROJECT_USERNAME'].nil? && !env['CIRCLE_PROJECT_REPONAME'].nil?
-          repo_slug = env['CIRCLE_PROJECT_USERNAME'] + '/' + env['CIRCLE_PROJECT_REPONAME']
-          url = fetch_pull_request_url(repo_slug, env['CIRCLE_BUILD_NUM'])
+        if url.nil? && !env["CIRCLE_PROJECT_USERNAME"].nil? && !env["CIRCLE_PROJECT_REPONAME"].nil?
+          repo_slug = env["CIRCLE_PROJECT_USERNAME"] + "/" + env["CIRCLE_PROJECT_REPONAME"]
+          url = fetch_pull_request_url(repo_slug, env["CIRCLE_BUILD_NUM"])
         end
 
         url
@@ -40,13 +40,13 @@ module Danger
       def initialize(env)
         self.repo_url = GitRepo.new.origins # CircleCI doesn't provide a repo url env variable :/
 
-        @circle_token = env['CIRCLE_CI_API_TOKEN']
+        @circle_token = env["CIRCLE_CI_API_TOKEN"]
         url = pull_request_url(env)
 
-        if URI.parse(url).path.split('/').count == 5
-          paths = URI.parse(url).path.split('/')
+        if URI.parse(url).path.split("/").count == 5
+          paths = URI.parse(url).path.split("/")
           # The first one is an extra slash, ignore it
-          self.repo_slug = paths[1] + '/' + paths[2]
+          self.repo_slug = paths[1] + "/" + paths[2]
           self.pull_request_id = paths[4]
         end
       end

data/lib/danger/ci_source/circle_api.rb

@@ -1,4 +1,4 @@
-require 'faraday'
+require "faraday"
 
 module Danger
   class CircleAPI
@@ -9,13 +9,13 @@ module Danger
     end
 
     def client
-      @client ||= Faraday.new(url: 'https://circleci.com/api/v1')
+      @client ||= Faraday.new(url: "https://circleci.com/api/v1")
     end
 
     def fetch_build(repo_slug, build_number)
       url = "project/#{repo_slug}/#{build_number}"
-      params = { 'circle-token' => circle_token }
-      response = client.get url, params, accept: 'application/json'
+      params = { "circle-token" => circle_token }
+      response = client.get url, params, accept: "application/json"
       json = JSON.parse(response.body, symbolize_names: true)
       json
     end

data/lib/danger/ci_source/drone.rb

@@ -4,9 +4,9 @@ module Danger
   module CISource
     class Drone < CI
       def self.validates?(env)
-        return false unless env['DRONE']
-        return false unless env['DRONE_REPO']
-        return false unless env['DRONE_PULL_REQUEST'].to_i > 0
+        return false unless env["DRONE"]
+        return false unless env["DRONE_REPO"]
+        return false unless env["DRONE_PULL_REQUEST"].to_i > 0
 
         return true
       end
@@ -16,8 +16,8 @@ module Danger
       end
 
       def initialize(env)
-        self.repo_slug = env['DRONE_REPO']
-        self.pull_request_id = env['DRONE_PULL_REQUEST']
+        self.repo_slug = env["DRONE_REPO"]
+        self.pull_request_id = env["DRONE_PULL_REQUEST"]
         self.repo_url = GitRepo.new.origins # Drone doesn't provide a repo url env variable :/
       end
     end

data/lib/danger/ci_source/jenkins.rb

@@ -5,8 +5,8 @@ module Danger
   module CISource
     class Jenkins < CI
       def self.validates?(env)
-        return false unless env['ghprbPullId'].to_i > 0
-        return false unless env['GIT_URL']
+        return false unless env["ghprbPullId"].to_i > 0
+        return false unless env["GIT_URL"]
 
         return true
       end
@@ -16,8 +16,8 @@ module Danger
       end
 
       def initialize(env)
-        self.repo_url = env['GIT_URL']
-        self.pull_request_id = env['ghprbPullId']
+        self.repo_url = env["GIT_URL"]
+        self.pull_request_id = env["ghprbPullId"]
 
         repo_matches = self.repo_url.match(%r{([\/:])([^\/]+\/[^\/.]+)(?:.git)?$})
         self.repo_slug = repo_matches[2] unless repo_matches.nil?

data/lib/danger/ci_source/local_git_repo.rb

@@ -1,7 +1,7 @@
 # For more info see: https://github.com/schacon/ruby-git
 
-require 'git'
-require 'uri'
+require "git"
+require "uri"
 
 module Danger
   module CISource
@@ -9,7 +9,7 @@ module Danger
       attr_accessor :base_commit, :head_commit
 
       def self.validates?(env)
-        return !env['DANGER_USE_LOCAL_GIT'].nil?
+        return !env["DANGER_USE_LOCAL_GIT"].nil?
       end
 
       def git
@@ -25,21 +25,21 @@ module Danger
       end
 
       def initialize(env = {})
-        github_host = env['DANGER_GITHUB_HOST'] || 'github.com'
+        github_host = env["DANGER_GITHUB_HOST"] || "github.com"
 
         # get the remote URL
         remote = run_git "remote show origin -n | grep \"Fetch URL\" | cut -d ':' -f 2-"
         if remote
           remote_url_matches = remote.match(%r{#{Regexp.escape github_host}(:|/)(?<repo_slug>.+/.+?)(?:\.git)?$})
-          if !remote_url_matches.nil? and remote_url_matches['repo_slug']
-            self.repo_slug = remote_url_matches['repo_slug']
+          if !remote_url_matches.nil? and remote_url_matches["repo_slug"]
+            self.repo_slug = remote_url_matches["repo_slug"]
           else
-            puts 'Danger local requires a repository hosted on GitHub.com or GitHub Enterprise.'
+            puts "Danger local requires a repository hosted on GitHub.com or GitHub Enterprise."
           end
         end
 
-        specific_pr = env['LOCAL_GIT_PR_ID']
-        pr_ref = specific_pr ? "##{specific_pr}" : ''
+        specific_pr = env["LOCAL_GIT_PR_ID"]
+        pr_ref = specific_pr ? "##{specific_pr}" : ""
         pr_command = "log --merges --oneline | grep \"Merge pull request #{pr_ref}\" | head -n 1"
 
         # get the most recent PR merge
@@ -49,13 +49,13 @@ module Danger
           if specific_pr
             raise "Could not find the pull request (#{specific_pr}) inside the git history for this repo."
           else
-            raise 'No recent pull requests found for this repo, danger requires at least one PR for the local mode.'
+            raise "No recent pull requests found for this repo, danger requires at least one PR for the local mode."
           end
         end
 
-        self.pull_request_id = pr_merge.match('#([0-9]+)')[1]
-        sha = pr_merge.split(' ')[0]
-        parents = run_git("rev-list --parents -n 1 #{sha}").strip.split(' ')
+        self.pull_request_id = pr_merge.match("#([0-9]+)")[1]
+        sha = pr_merge.split(" ")[0]
+        parents = run_git("rev-list --parents -n 1 #{sha}").strip.split(" ")
         self.base_commit = parents[0]
         self.head_commit = parents[1]
       end

data/lib/danger/ci_source/semaphore.rb

@@ -4,9 +4,9 @@ module Danger
   module CISource
     class Semaphore < CI
       def self.validates?(env)
-        return false unless env['SEMAPHORE']
-        return false unless env['SEMAPHORE_REPO_SLUG']
-        return false unless env['PULL_REQUEST_NUMBER'].to_i > 0
+        return false unless env["SEMAPHORE"]
+        return false unless env["SEMAPHORE_REPO_SLUG"]
+        return false unless env["PULL_REQUEST_NUMBER"].to_i > 0
 
         return true
       end
@@ -16,8 +16,8 @@ module Danger
       end
 
       def initialize(env)
-        self.repo_slug = env['SEMAPHORE_REPO_SLUG']
-        self.pull_request_id = env['PULL_REQUEST_NUMBER']
+        self.repo_slug = env["SEMAPHORE_REPO_SLUG"]
+        self.pull_request_id = env["PULL_REQUEST_NUMBER"]
         self.repo_url = GitRepo.new.origins # Semaphore doesn't provide a repo url env variable :/
       end
     end

data/lib/danger/ci_source/surf.rb

@@ -0,0 +1,24 @@
+# http://github.com/surf-build/surf
+
+module Danger
+  module CISource
+    class Surf < CI
+      def self.validates?(env)
+        return ["SURF_REPO", "SURF_NWO"].all? { |x| env[x] }
+      end
+
+      def supported_request_sources
+        @supported_request_sources ||= [Danger::RequestSources::GitHub]
+      end
+
+      def initialize(env)
+        self.repo_slug = env["SURF_NWO"]
+        if env["SURF_PR_NUM"].to_i > 0
+          self.pull_request_id = env["SURF_PR_NUM"]
+        end
+
+        self.repo_url = env["SURF_REPO"]
+      end
+    end
+  end
+end

data/lib/danger/ci_source/teamcity.rb

@@ -2,7 +2,7 @@ module Danger
   module CISource
     class TeamCity < CI
       def self.validates?(env)
-        env.key? 'TEAMCITY_VERSION'
+        env.key? "TEAMCITY_VERSION"
       end
 
       def supported_request_sources
@@ -13,9 +13,9 @@ module Danger
         # NB: Unfortunately TeamCity doesn't provide these variables
         # automatically so you have to add these variables manually to your
         # project or build configuration
-        self.repo_slug       = env['GITHUB_REPO_SLUG']
-        self.pull_request_id = env['GITHUB_PULL_REQUEST_ID'].to_i
-        self.repo_url        = env['GITHUB_REPO_URL']
+        self.repo_slug       = env["GITHUB_REPO_SLUG"]
+        self.pull_request_id = env["GITHUB_PULL_REQUEST_ID"].to_i
+        self.repo_url        = env["GITHUB_REPO_URL"]
       end
     end
   end

data/lib/danger/ci_source/travis.rb

@@ -5,9 +5,9 @@ module Danger
   module CISource
     class Travis < CI
       def self.validates?(env)
-        return false unless env['HAS_JOSH_K_SEAL_OF_APPROVAL']
-        return false unless env['TRAVIS_REPO_SLUG']
-        return false unless env['TRAVIS_PULL_REQUEST']
+        return false unless env["HAS_JOSH_K_SEAL_OF_APPROVAL"]
+        return false unless env["TRAVIS_REPO_SLUG"]
+        return false unless env["TRAVIS_PULL_REQUEST"]
 
         return true
       end
@@ -17,9 +17,9 @@ module Danger
       end
 
       def initialize(env)
-        self.repo_slug = env['TRAVIS_REPO_SLUG']
-        if env['TRAVIS_PULL_REQUEST'].to_i > 0
-          self.pull_request_id = env['TRAVIS_PULL_REQUEST']
+        self.repo_slug = env["TRAVIS_REPO_SLUG"]
+        if env["TRAVIS_PULL_REQUEST"].to_i > 0
+          self.pull_request_id = env["TRAVIS_PULL_REQUEST"]
         end
         self.repo_url = GitRepo.new.origins # Travis doesn't provide a repo url env variable :/
       end

data/lib/danger/ci_source/xcode_server.rb

@@ -4,7 +4,7 @@ module Danger
   module CISource
     class XcodeServer < CI
       def self.validates?(env)
-        return false unless env['XCS_BOT_NAME']
+        return false unless env["XCS_BOT_NAME"]
 
         return true
       end
@@ -14,7 +14,7 @@ module Danger
       end
 
       def initialize(env)
-        bot_name = env['XCS_BOT_NAME']
+        bot_name = env["XCS_BOT_NAME"]
         return if bot_name.nil?
 
         repo_matches = bot_name.match(/\[(.+)\]/)

data/lib/danger/commands/init.rb

@@ -1,27 +1,27 @@
-require 'danger/commands/init_helpers/interviewer'
-require 'danger/ci_source/local_git_repo'
-require 'yaml'
+require "danger/commands/init_helpers/interviewer"
+require "danger/ci_source/local_git_repo"
+require "yaml"
 
 module Danger
   class Init < Runner
-    self.summary = 'Helps you set up Danger.'
-    self.command = 'init'
+    self.summary = "Helps you set up Danger."
+    self.command = "init"
 
     attr_accessor :ui
 
     def self.options
       [
-        ['--impatient', "'I've not got all day here. Don't add any thematic delays please.'"],
-        ['--mousey', "'Don't make me press return to continue the adventure.'"]
+        ["--impatient", "'I've not got all day here. Don't add any thematic delays please.'"],
+        ["--mousey", "'Don't make me press return to continue the adventure.'"]
       ].concat(super)
     end
 
     def initialize(argv)
-      @bot_name = File.basename(Dir.getwd).split('.').first.capitalize + 'Bot'
+      @bot_name = File.basename(Dir.getwd).split(".").first.capitalize + "Bot"
       super
       @ui = Interviewer.new(cork)
-      ui.no_delay = argv.flag?('impatient', false)
-      ui.no_waiting = argv.flag?('mousey', false)
+      ui.no_delay = argv.flag?("impatient", false)
+      ui.no_waiting = argv.flag?("mousey", false)
     end
 
     def run
@@ -43,34 +43,34 @@ module Danger
     def show_todo_state
       ui.say "We need to do the following:\n"
       ui.pause 0.6
-      ui.say ' - [ ] Create a Dangerfile and add a few simple rules.'
+      ui.say " - [ ] Create a Dangerfile and add a few simple rules."
       ui.pause 0.6
       ui.say " - [#{@account_created ? 'x' : ' '}] Create a GitHub account for Danger to use, for messaging."
       ui.pause 0.6
-      ui.say ' - [ ] Set up an access token for Danger.'
+      ui.say " - [ ] Set up an access token for Danger."
       ui.pause 0.6
       ui.say " - [ ] Set up Danger to run on your CI.\n\n"
     end
 
     def setup_dangerfile
       dir = Danger.gem_path
-      content = File.read(File.join(dir, 'lib', 'assets', 'DangerfileTemplate'))
-      File.write('Dangerfile', content)
+      content = File.read(File.join(dir, "lib", "assets", "DangerfileTemplate"))
+      File.write("Dangerfile", content)
 
-      ui.header 'Step 1: Creating a starter Dangerfile'
+      ui.header "Step 1: Creating a starter Dangerfile"
       ui.say "I've set up an example Dangerfile for you in this folder.\n"
       ui.pause 1
 
       ui.say "cat #{Dir.pwd}/Dangerfile\n".blue
       content.lines.each do |l|
-        ui.say '  ' + l.chomp.green
+        ui.say "  " + l.chomp.green
       end
-      ui.say ''
+      ui.say ""
       ui.pause 2
 
       ui.say "There's a collection of small, simple ideas in here, but Danger is about being able to easily"
-      ui.say 'iterate. The power comes from you having the ability to codify fixes for some of the problems'
-      ui.say 'that come up in day to day programming. It can be difficult to try and see those from day 1.'
+      ui.say "iterate. The power comes from you having the ability to codify fixes for some of the problems"
+      ui.say "that come up in day to day programming. It can be difficult to try and see those from day 1."
 
       ui.say "\nIf you'd like to investigate the file, and make some changes - I'll wait here,"
       ui.say "press return when you're ready to move on..."
@@ -78,7 +78,7 @@ module Danger
     end
 
     def setup_github_account
-      ui.header 'Step 2: Creating a GitHub account'
+      ui.header "Step 2: Creating a GitHub account"
 
       ui.say "In order to get the most out of Danger, I'd recommend giving her the ability to post in"
       ui.say "the code-review comment section.\n\n"
@@ -87,11 +87,11 @@ module Danger
       ui.say "IMO, it's best to do this by using the private mode of your browser. Create an account like"
       ui.say "#{@bot_name}, and don't forget a cool robot avatar.\n\n"
       ui.pause 1
-      ui.say 'Here are great resources for creative commons images of robots:'
-      ui.link 'https://www.flickr.com/search/?text=robot&license=2%2C3%2C4%2C5%2C6%2C9'
-      ui.link 'https://www.google.com/search?q=robot&tbs=sur:fmc&tbm=isch&tbo=u&source=univ&sa=X&ved=0ahUKEwjgy8-f95jLAhWI7hoKHV_UD00QsAQIMQ&biw=1265&bih=1359'
+      ui.say "Here are great resources for creative commons images of robots:"
+      ui.link "https://www.flickr.com/search/?text=robot&license=2%2C3%2C4%2C5%2C6%2C9"
+      ui.link "https://www.google.com/search?q=robot&tbs=sur:fmc&tbm=isch&tbo=u&source=univ&sa=X&ved=0ahUKEwjgy8-f95jLAhWI7hoKHV_UD00QsAQIMQ&biw=1265&bih=1359"
 
-      ui.say ''
+      ui.say ""
       note_about_clicking_links
       ui.pause 1
       ui.say "\nCool, please press return when you have your account ready (and you've verified the email...)"
@@ -99,28 +99,29 @@ module Danger
     end
 
     def setup_access_token
-      ui.header 'Step 3: Configuring a GitHub Personal Access Token'
+      ui.header "Step 3: Configuring a GitHub Personal Access Token"
 
       ui.say "Here's the link, you should open this in the private session where you just created the new GitHub account"
-      ui.link 'https://github.com/settings/tokens/new'
+      ui.link "https://github.com/settings/tokens/new"
       ui.pause 1
 
-      @is_open_source = ui.ask_with_answers("For token access rights, I need to know if this is for an Open Source or Closed Source project\n", ['Open', 'Closed'])
+      @is_open_source = ui.ask_with_answers("For token access rights, I need to know if this is for an Open Source or Closed Source project\n", ["Open", "Closed"])
 
       if considered_an_oss_repo?
         ui.say "For Open Source projects, I'd recommend giving the token the smallest scope possible."
-        ui.say 'This means only providing access to ' + 'public_repo'.yellow + " in the token.\n\n"
+        ui.say "This means only providing access to " + "public_repo".yellow + " in the token.\n\n"
         ui.pause 1
         ui.say "This token limits Danger's abilities to just writing comments on OSS projects. I recommend"
-        ui.say 'this because the token can quite easily be extracted from the environment via pull requests.'
+        ui.say "this because the token can quite easily be extracted from the environment via pull requests."
         ui.say "#{@bot_name} does not need admin access to your repo. So its ability to cause chaos is minimalized.\n"
 
-      elsif @is_open_source == 'closed'
+        ui.say "\nIt is important that you do not store this token in your repository, as GitHub will automatically revoke it when pushed.\n"
+      elsif @is_open_source == "closed"
         ui.say "For Closed Source projects, I'd recommend giving the token access to the whole repo scope."
-        ui.say 'This means only providing access to ' + 'repo'.yellow + ", and its children in the token.\n\n"
+        ui.say "This means only providing access to " + "repo".yellow + ", and its children in the token.\n\n"
         ui.pause 1
-        ui.say "It's worth noting that you " + 'should not'.bold.white + ' re-use this token for OSS repos.'
-        ui.say 'Make a new one for those repos with just ' + 'public_repo'.yellow + '.'
+        ui.say "It's worth noting that you " + "should not".bold.white + " re-use this token for OSS repos."
+        ui.say "Make a new one for those repos with just " + "public_repo".yellow + "."
         ui.pause 1
         ui.say "Additionally, don't forget to add your new GitHub account as a collaborator to your Closed Source project."
       end
@@ -130,85 +131,85 @@ module Danger
     end
 
     def considered_an_oss_repo?
-      @is_open_source == 'open'
+      @is_open_source == "open"
     end
 
     def current_repo_slug
       @git = GitRepo.new
       repo_matches = @git.origins.match(%r{([\/:])([^\/]+\/[^\/.]+)(?:.git)?$})
-      repo_matches[2] || '[Your/Repo]'
+      repo_matches[2] || "[Your/Repo]"
     end
 
     def setup_danger_ci
-      ui.header 'Step 4: Add Danger for your CI'
+      ui.header "Step 4: Add Danger for your CI"
 
-      uses_travis if File.exist? '.travis.yml'
-      uses_circle if File.exist? 'circle.yml'
-      unsure_ci unless File.exist?('.travis.yml') || File.exist?('.circle.yml')
+      uses_travis if File.exist? ".travis.yml"
+      uses_circle if File.exist? "circle.yml"
+      unsure_ci unless File.exist?(".travis.yml") || File.exist?(".circle.yml")
 
       ui.say "\nOK, I'll give you a moment to do this..."
       ui.wait_for_return
 
-      ui.header 'Final step: exposing the GitHub token as an environment build variable.'
+      ui.header "Final step: exposing the GitHub token as an environment build variable."
       ui.pause 0.4
       if considered_an_oss_repo?
-        ui.say 'As you have an Open Source repo, this token should be considered public, otherwise you cannot'
+        ui.say "As you have an Open Source repo, this token should be considered public, otherwise you cannot"
         ui.say "run Danger on pull requests from forks, limiting its use.\n"
         ui.pause 1
       end
 
-      travis_token if File.exist? '.travis.yml'
-      circle_token if File.exist? 'circle.yml'
-      unsure_token unless File.exist?('.travis.yml') || File.exist?('.circle.yml')
+      travis_token if File.exist? ".travis.yml"
+      circle_token if File.exist? "circle.yml"
+      unsure_token unless File.exist?(".travis.yml") || File.exist?(".circle.yml")
 
       ui.pause 0.6
-      ui.say 'This is the last step, I can give you a second...'
+      ui.say "This is the last step, I can give you a second..."
       ui.wait_for_return
     end
 
     def uses_travis
-      danger = 'bundle exec danger'.yellow
-      config = YAML.load(File.read('.travis.yml'))
-      if config['script']
-        ui.say 'Add ' + '- '.yellow + danger + ' as a new step in the ' + 'script'.yellow + ' section of your .travis.yml file.'
+      danger = "bundle exec danger".yellow
+      config = YAML.load(File.read(".travis.yml"))
+      if config["script"]
+        ui.say "Add " + "- ".yellow + danger + " as a new step in the " + "script".yellow + " section of your .travis.yml file."
       else
-        ui.say "I'd recommend adding " + 'script: '.yellow + danger + ' to the script section of your .travis.yml file.'
+        ui.say "I'd recommend adding " + "script: ".yellow + danger + " to the script section of your .travis.yml file."
       end
 
       ui.pause 1
-      ui.say "You shouldn't use " + 'after_success, after_failure, after_script'.red + ' as they cannot fail your builds.'
+      ui.say "You shouldn't use " + "after_success, after_failure, after_script".red + " as they cannot fail your builds."
     end
 
     def uses_circle
-      danger = '- bundle exec danger'.yellow
-      config = YAML.load(File.read('circle.yml'))
+      danger = "- bundle exec danger".yellow
+      config = YAML.load(File.read("circle.yml"))
 
-      if config['test']
-        if config['test']['post']
-          ui.say 'Add ' + danger + ' as a new step in the ' + 'test:post:'.yellow + ' section of your circle.yml file.'
+      if config["test"]
+        if config["test"]["post"]
+          ui.say "Add " + danger + " as a new step in the " + "test:post:".yellow + " section of your circle.yml file."
         else
-          ui.say 'Add ' + danger + ' as a new step in the ' + 'test:override:'.yellow + ' section of your circle.yml file.'
+          ui.say "Add " + danger + " as a new step in the " + "test:override:".yellow + " section of your circle.yml file."
         end
       else
-        ui.say 'Add this to the bottom of your circle.yml file:'
-        ui.say 'test:'.green
-        ui.say '  post:'.green
+        ui.say "Add this to the bottom of your circle.yml file:"
+        ui.say "test:".green
+        ui.say "  post:".green
         ui.say "    #{danger}".green
       end
     end
 
     def unsure_ci
-      danger = 'bundle exec danger'.yellow
+      danger = "bundle exec danger".yellow
       ui.say "As I'm not sure what CI you want to run Danger on based on the files in your repo, I'll just offer some generic"
-      ui.say 'advice. You want to run ' + danger + ' after your tests have finished running, it should still be during the testing'
-      ui.say 'process so the build can fail.'
+      ui.say "advice. You want to run " + danger + " after your tests have finished running, it should still be during the testing"
+      ui.say "process so the build can fail."
     end
 
     def travis_token
       # https://travis-ci.org/artsy/eigen/settings
-      ui.say 'In order to add an environment variable, go to:'
+      ui.say "In order to add an environment variable, go to:"
       ui.link "https://travis-ci.org/#{current_repo_slug}/settings"
-      ui.say "\nThe name is " + 'DANGER_GITHUB_API_TOKEN'.yellow + ' and the value is the GitHub Personal Access Token.'
+      ui.say "\nThe name is " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Access Token."
       if @is_open_source
         ui.say 'Make sure to have "Display value in build log" enabled.'
       end
@@ -218,44 +219,50 @@ module Danger
       # https://circleci.com/gh/artsy/eigen/edit#env-vars
       if considered_an_oss_repo?
         ui.say "Before we start, it's important to be up-front. CircleCI only really has one option to support running Danger"
-        ui.say 'for forks on OSS repos. It is quite a drastic option, and I want to let you know the best place to understand'
+        ui.say "for forks on OSS repos. It is quite a drastic option, and I want to let you know the best place to understand"
         ui.say "the ramifications of turning on a setting I'm about to advise.\n"
-        ui.link 'https://circleci.com/docs/fork-pr-builds'
-        ui.say 'TLDR: If you have anything other than Danger config settings in CircleCI, then you should not turn on the setting.'
+        ui.link "https://circleci.com/docs/fork-pr-builds"
+        ui.say "TLDR: If you have anything other than Danger config settings in CircleCI, then you should not turn on the setting."
         ui.say "I'll give you a minute to read it..."
         ui.wait_for_return
 
-        ui.say 'On Danger/Danger we turn on ' + 'Permissive building of fork pull requests'.yellow + ' this exposes the token to Danger'
-        ui.say 'You can find this setting at:'
+        ui.say "On Danger/Danger we turn on " + "Permissive building of fork pull requests".yellow + " this exposes the token to Danger"
+        ui.say "You can find this setting at:"
         ui.link "https://circleci.com/gh/#{current_repo_slug}/edit#advanced-settings\n"
         ui.say "I'll hold..."
         ui.wait_for_return
       end
 
-      ui.say 'In order to expose an environment variable, go to:'
+      ui.say "In order to expose an environment variable, go to:"
       ui.link "https://circleci.com/gh/#{current_repo_slug}/edit#env-vars"
-      ui.say 'The name is ' + 'DANGER_GITHUB_API_TOKEN'.yellow + ' and the value is the GitHub Personal Acess Token.'
+      ui.say "The name is " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Acess Token."
     end
 
     def unsure_token
-      ui.say 'You need to expose a token called ' + 'DANGER_GITHUB_API_TOKEN'.yellow + ' and the value is the GitHub Personal Acess Token.'
-      ui.say 'Depending on the CI system, this may need to be done on the machine ( in the ' + '~/.bashprofile'.yellow + ') or in a web UI somewhere.'
+      ui.say "You need to expose a token called " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Acess Token."
+      ui.say "Depending on the CI system, this may need to be done on the machine ( in the " + "~/.bashprofile".yellow + ") or in a web UI somewhere."
     end
 
     def note_about_clicking_links
-      ui.say "Note: Holding cmd ( ⌘ ) and #{ENV['ITERM_SESSION_ID'] ? '' : 'double '}clicking a link will open it in your browser."
+      modifier_key = "ctrl"
+      clicks = "clicking"
+
+      modifier_key = "cmd ( ⌘ )" if darwin?
+      clicks = "double clicking" if darwin? && !ENV["ITERM_SESSION_ID"]
+
+      ui.say "Note: Holding #{modifier_key} and #{clicks} a link will open it in your browser."
     end
 
     def info
-      ui.header 'Useful info'
-      ui.say '- One of the best ways to test out new rules locally is via ' + 'bundle exec danger local'.yellow + '.'
+      ui.header "Useful info"
+      ui.say "- One of the best ways to test out new rules locally is via " + "bundle exec danger local".yellow + "."
       ui.pause 0.6
-      ui.say '- You can have Danger output all of its variables to the console via the ' + '--verbose'.yellow + ' option.'
+      ui.say "- You can have Danger output all of its variables to the console via the " + "--verbose".yellow + " option."
       ui.pause 0.6
-      ui.say '- You can look at the following Dangerfiles to get some more ideas:'
+      ui.say "- You can look at the following Dangerfiles to get some more ideas:"
       ui.pause 0.6
-      ui.link 'https://github.com/danger/danger/blob/master/Dangerfile'
-      ui.link 'https://github.com/artsy/eigen/blob/master/Dangerfile'
+      ui.link "https://github.com/danger/danger/blob/master/Dangerfile"
+      ui.link "https://github.com/artsy/eigen/blob/master/Dangerfile"
       ui.pause 1
     end
 
@@ -264,8 +271,12 @@ module Danger
       ui.pause 0.6
 
       ui.say "And you're good to go. Danger is a collaboration between Orta Therox, Gem 'Danger' McShane and Felix Krause."
-      ui.say 'If you like it, let others know. If you want to know more, follow ' + '@orta'.yellow + ' and ' + '@KrauseFx'.yellow + ' on Twitter.'
+      ui.say "If you like it, let others know. If you want to know more, follow " + "@orta".yellow + " and " + "@KrauseFx".yellow + " on Twitter."
       ui.say "If you don't like it, help us improve it! xxx"
     end
+
+    def darwin?
+      Gem::Platform.local.os == "darwin"
+    end
   end
 end