danger 0.8.4 → 0.8.5

data/lib/danger/danger_core/plugins/dangerfile_import_plugin.rb

@@ -25,7 +25,7 @@ module Danger
 
   class DangerfileImportPlugin < Plugin
     def self.instance_name
-      "plugin"
+      'plugin'
     end
 
     # @!group Plugins
@@ -34,11 +34,13 @@ module Danger
     # @param    [String] path
     #           a local path or a https URL to the Ruby file to import
     #           a danger plugin from.
+    # @return [void]
+
     def import(path)
-      raise "`import` requires a string" unless path.kind_of?(String)
-      path += ".rb" unless path.end_with?(".rb")
+      raise '`import` requires a string' unless path.kind_of?(String)
+      path += '.rb' unless path.end_with?('.rb')
 
-      if path.start_with?("http")
+      if path.start_with?('http')
         import_url(path)
       else
         import_local(path)
@@ -52,8 +54,9 @@ module Danger
     #
     # @param    [String] url
     #           https URL to the Ruby file to use
+    # @return [void]
     def import_url(url)
-      raise "URL is not https, for security reasons `danger` only supports encrypted requests" unless url.start_with?("https://")
+      raise 'URL is not https, for security reasons `danger` only supports encrypted requests' unless url.start_with?('https://')
 
       require 'tmpdir'
       require 'faraday'
@@ -64,7 +67,7 @@ module Danger
       content = @http_client.get(url)
 
       Dir.mktmpdir do |dir|
-        path = File.join(dir, "temporary_remote_action.rb")
+        path = File.join(dir, 'temporary_remote_action.rb')
         File.write(path, content.body)
         import_local(path)
       end
@@ -76,6 +79,7 @@ module Danger
     # @param    [String] path
     #           The path to the file to import
     #           Can also be a pattern (./**/*plugin.rb)
+    # @return [void]
     def import_local(path)
       Dir[path].each do |file|
         # Without the expand_path it would fail if the path doesn't start with ./

data/lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb

@@ -54,7 +54,7 @@ module Danger
     end
 
     def self.instance_name
-      "messaging"
+      'messaging'
     end
 
     # @!group Core

data/lib/danger/plugin_support/plugin.rb

@@ -5,7 +5,7 @@ module Danger
     end
 
     def self.instance_name
-      to_s.gsub("Danger", "").danger_underscore.split('/').last
+      to_s.gsub('Danger', '').danger_underscore.split('/').last
     end
 
     # Both of these methods exist on all objects

data/lib/danger/plugin_support/plugin_file_resolver.rb

@@ -16,32 +16,32 @@ module Danger
 
       # When given a list of gems
       elsif @refs and @refs.kind_of? Array
-
-        Dir.mktmpdir do |dir|
-          gem_names = @refs
-          deps = gem_names.map { |name| Bundler::Dependency.new(name, ">= 0") }
-
-          # Use Gems from rubygems.org
-          source = Bundler::SourceList.new
-          source.add_rubygems_remote("https://rubygems.org")
-
-          # Create a definition to bundle, make sure it always updates
-          # and uses the latest version from the server
-          bundler = Bundler::Definition.new(nil, deps, source, true)
-          bundler.resolve_remotely!
-
-          # Install the gems into a tmp dir
-          options = { path: dir }
-          Bundler::Installer.install(Pathname.new(dir), bundler, options)
-
-          # Get the name'd gems out of bundler, then pull out all their paths
-          gems = gem_names.flat_map { |name| bundler.specs[name] }
-          gems.flat_map { |gem| Dir.glob(File.join(gem.gem_dir, "lib/**/**/**.rb")) }
+        Bundler.with_clean_env do
+          Dir.mktmpdir do |dir|
+            gem_names = @refs
+            deps = gem_names.map { |name| Bundler::Dependency.new(name, '>= 0') }
+
+            # Use Gems from rubygems.org
+            source = Bundler::SourceList.new
+            source.add_rubygems_remote('https://rubygems.org')
+
+            # Create a definition to bundle, make sure it always updates
+            # and uses the latest version from the server
+            bundler = Bundler::Definition.new(nil, deps, source, true)
+            bundler.resolve_remotely!
+
+            # Install the gems into a tmp dir
+            options = { path: dir }
+            Bundler::Installer.install(Pathname.new(dir), bundler, options)
+
+            # Get the name'd gems out of bundler, then pull out all their paths
+            gems = gem_names.flat_map { |name| bundler.specs[name] }
+            gems.flat_map { |gem| Dir.glob(File.join(gem.gem_dir, 'lib/**/**/**.rb')) }
+          end
         end
-
       # When empty, imply you want to test the current lib folder as a plugin
       else
-        Dir.glob(File.join(".", "lib/*.rb"))
+        Dir.glob(File.join('.', 'lib/*.rb')).map { |path| File.expand_path(path) }
       end
     end
   end

data/lib/danger/plugin_support/plugin_parser.rb

@@ -1,5 +1,37 @@
 require 'json'
 
+=begin 
+
+  So you want to improve this? Great. Hard thing is getting yourself into a position where you 
+  have access to all the tokens, so here's something you should run in `bundle exec pry` to dig in:
+
+      require 'danger'
+      require 'yard'
+      parser = Danger::PluginParser.new "spec/fixtures/plugins/example_fully_documented.rb"
+      parser.parse
+      plugins = parser.plugins_from_classes(parser.classes_in_file)
+      git = plugins.first
+      klass = git
+      parser.to_dict(plugins)
+
+  Then some helpers
+  
+      attribute_meths = klass.attributes[:instance].values.map(&:values).flatten
+
+      methods = klass.meths - klass.inherited_meths - attribute_meths
+      usable_methods = methods.select { |m| m.visibility == :public }.reject { |m| m.name == :initialize }
+
+
+  the alternative, is to add
+
+      require 'pry'
+      binding.pry
+
+  anywhere inside the source code below.
+
+=end
+
+
 module Danger
   class PluginParser
     attr_accessor :registry
@@ -47,6 +79,7 @@ module Danger
         {
           name: meth.name,
           body_md: meth.docstring,
+          params: meth.parameters,
           tags: meth.tags.map do |t|
             {
                name: t.tag_name,
@@ -64,10 +97,14 @@ module Danger
       end
 
       classes.map do |klass|
-        # Adds the class being parsed into the ruby runtime
+        # Adds the class being parsed into the ruby runtime, so that we can access it's instance_name
         require klass.file
         real_klass = Danger.const_get klass.name
         attribute_meths = klass.attributes[:instance].values.map(&:values).flatten
+
+        methods = klass.meths - klass.inherited_meths - attribute_meths
+        usable_methods = methods.select { |m| m.visibility == :public }.reject { |m| m.name == :initialize || m.name == :insance_name }
+
         {
           name: klass.name.to_s,
           body_md: klass.docstring,
@@ -76,8 +113,8 @@ module Danger
           attributes: klass.attributes[:instance].map do |pair|
             { pair.first => d_attr.call(pair.last) }
           end,
-          methods: (klass.meths - klass.inherited_meths - attribute_meths ).select { |m| m.visibility == :public }.map { |m| d_meth.call(m) },
-          tags: klass.tags.select { |t| t.tag_name == "tags" }.map(&:name).compact,
+          methods: usable_methods.map { |m| d_meth.call(m) },
+          tags: klass.tags.select { |t| t.tag_name == "tags" }.map(&:text).compact,
           see: klass.tags.select { |t| t.tag_name == "see" }.map(&:name).map(&:split).flatten.compact,
           file: klass.file.gsub(File.expand_path("."), "")
         }

data/lib/danger/request_source/github.rb

@@ -13,9 +13,9 @@ module Danger
         self.support_tokenless_auth = false
 
         Octokit.auto_paginate = true
-        @token = @environment["DANGER_GITHUB_API_TOKEN"]
-        if @environment["DANGER_GITHUB_API_HOST"]
-          Octokit.api_endpoint = @environment["DANGER_GITHUB_API_HOST"]
+        @token = @environment['DANGER_GITHUB_API_TOKEN']
+        if @environment['DANGER_GITHUB_API_HOST']
+          Octokit.api_endpoint = @environment['DANGER_GITHUB_API_HOST']
         end
       end
 
@@ -24,11 +24,11 @@ module Danger
       end
 
       def host
-        @host = @environment["DANGER_GITHUB_HOST"] || "github.com"
+        @host = @environment['DANGER_GITHUB_HOST'] || 'github.com'
       end
 
       def client
-        raise "No API token given, please provide one using `DANGER_GITHUB_API_TOKEN`" if !@token && !support_tokenless_auth
+        raise 'No API token given, please provide one using `DANGER_GITHUB_API_TOKEN`' if !@token && !support_tokenless_auth
         @client ||= Octokit::Client.new(access_token: @token)
       end
 
@@ -39,7 +39,7 @@ module Danger
       def setup_danger_branches
         # we can use a github specific feature here:
         base_commit = self.pr_json[:base][:sha]
-        head_commit = self.scm.head_commit
+        head_commit = self.pr_json[:head][:sha]
 
         # Next, we want to ensure that we have a version of the current branch at a known location
         self.scm.exec "branch #{EnvironmentManager.danger_base_branch} #{base_commit}"
@@ -119,7 +119,7 @@ module Danger
         begin
           client.create_status(ci_source.repo_slug, latest_pr_commit_ref, status, {
             description: message,
-            context: "danger/danger",
+            context: 'danger/danger',
             target_url: details_url
           })
         rescue
@@ -146,8 +146,8 @@ module Danger
       end
 
       def random_compliment
-        compliment = ["Well done.", "Congrats.", "Woo!",
-                      "Yay.", "Jolly good show.", "Good on 'ya.", "Nice work."]
+        compliment = ['Well done.', 'Congrats.', 'Woo!',
+                      'Yay.', 'Jolly good show.', "Good on 'ya.", 'Nice work.']
         compliment.sample
       end
 
@@ -166,19 +166,19 @@ module Danger
       def generate_comment(warnings: [], errors: [], messages: [], markdowns: [], previous_violations: {}, danger_id: 'danger')
         require 'erb'
 
-        md_template = File.join(Danger.gem_path, "lib/danger/comment_generators/github.md.erb")
+        md_template = File.join(Danger.gem_path, 'lib/danger/comment_generators/github.md.erb')
 
         # erb: http://www.rrn.dk/rubys-erb-templating-system
         # for the extra args: http://stackoverflow.com/questions/4632879/erb-template-removing-the-trailing-line
         @tables = [
-          table("Error", "no_entry_sign", errors, previous_violations),
-          table("Warning", "warning", warnings, previous_violations),
-          table("Message", "book", messages, previous_violations)
+          table('Error', 'no_entry_sign', errors, previous_violations),
+          table('Warning', 'warning', warnings, previous_violations),
+          table('Message', 'book', messages, previous_violations)
         ]
         @markdowns = markdowns
         @danger_id = danger_id
 
-        return ERB.new(File.read(md_template), 0, "-").result(binding)
+        return ERB.new(File.read(md_template), 0, '-').result(binding)
       end
 
       def table(name, emoji, violations, all_previous_violations)

data/lib/danger/request_source/request_source.rb

@@ -13,7 +13,7 @@ module Danger
       end
 
       def initialize(_ci_source, _environment)
-        raise "Subclass and overwrite initialize"
+        raise 'Subclass and overwrite initialize'
       end
 
       def validates?
@@ -33,15 +33,15 @@ module Danger
       end
 
       def update_pull_request!(_warnings: [], _errors: [], _messages: [], _markdowns: [])
-        raise "Subclass and overwrite update_pull_request!"
+        raise 'Subclass and overwrite update_pull_request!'
       end
 
       def setup_danger_branches
-        raise "Subclass and overwrite setup_danger_branches"
+        raise 'Subclass and overwrite setup_danger_branches'
       end
 
       def fetch_details
-        raise "Subclass and overwrite initialize"
+        raise 'Subclass and overwrite initialize'
       end
     end
   end

data/lib/danger/scm_source/git_repo.rb

@@ -6,7 +6,7 @@ module Danger
   class GitRepo
     attr_accessor :diff, :log
 
-    def diff_for_folder(folder, from: "master", to: 'HEAD')
+    def diff_for_folder(folder, from: 'master', to: 'HEAD')
       repo = Git.open folder
       self.diff = repo.diff(from, to)
       self.log = repo.log.between(from, to)
@@ -17,7 +17,7 @@ module Danger
     end
 
     def head_commit
-      exec "rev-parse HEAD"
+      exec 'rev-parse HEAD'
     end
 
     def origins

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "0.8.4".freeze
-  DESCRIPTION = "Automate your PR etiquette.".freeze
+  VERSION = '0.8.5'.freeze
+  DESCRIPTION = 'Automate your PR etiquette.'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 0.8.4
+  version: 0.8.5
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-02 00:00:00.000000000 Z
+date: 2016-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -352,7 +352,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Automate your PR etiquette.