danger 0.7.4 → 0.8.0

data/lib/danger/{request_sources → request_source}/github.rb

@@ -4,7 +4,7 @@ require 'redcarpet'
 
 module Danger
   class GitHub
-    attr_accessor :ci_source, :pr_json, :issue_json, :environment, :base_commit, :head_commit, :support_tokenless_auth, :ignored_violations, :github_host
+    attr_accessor :ci_source, :pr_json, :issue_json, :environment, :support_tokenless_auth, :ignored_violations, :github_host
 
     def initialize(ci_source, environment)
       self.ci_source = ci_source
@@ -21,10 +21,7 @@ module Danger
 
     def client
       raise "No API token given, please provide one using `DANGER_GITHUB_API_TOKEN`" if !@token && !support_tokenless_auth
-
-      @client ||= Octokit::Client.new(
-        access_token: @token
-      )
+      @client ||= Octokit::Client.new(access_token: @token)
     end
 
     def markdown_parser
@@ -48,34 +45,6 @@ module Danger
       self.issue_json = client.get(href)
     end
 
-    def base_commit
-      self.pr_json[:base][:sha]
-    end
-
-    def head_commit
-      self.pr_json[:head][:sha]
-    end
-
-    def branch_for_merge
-      self.pr_json[:base][:ref]
-    end
-
-    def pr_title
-      self.pr_json[:title].to_s
-    end
-
-    def pr_body
-      self.pr_json[:body].to_s
-    end
-
-    def pr_author
-      self.pr_json[:user][:login].to_s
-    end
-
-    def pr_labels
-      self.issue_json[:labels].map { |l| l[:name] }
-    end
-
     # Sending data to GitHub
     def update_pull_request!(warnings: [], errors: [], messages: [], markdowns: [])
       comment_result = {}

data/lib/danger/scm_source/git_repo.rb

@@ -4,8 +4,7 @@ require 'git'
 
 module Danger
   class GitRepo
-    attr_accessor :diff
-    attr_accessor :log
+    attr_accessor :diff, :log
 
     def diff_for_folder(folder, from: "master", to: 'HEAD')
       repo = Git.open folder
@@ -16,33 +15,5 @@ module Danger
     def exec(string)
       `git #{string}`.strip
     end
-
-    def added_files
-      Danger::FileList.new(@diff.select { |diff| diff.type == "new" }.map(&:path))
-    end
-
-    def deleted_files
-      Danger::FileList.new(@diff.select { |diff| diff.type == "deleted" }.map(&:path))
-    end
-
-    def modified_files
-      Danger::FileList.new(@diff.stats[:files].keys)
-    end
-
-    def lines_of_code
-      @diff.lines
-    end
-
-    def deletions
-      @diff.deletions
-    end
-
-    def insertions
-      @diff.insertions
-    end
-
-    def commits
-      log.to_a
-    end
   end
 end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "0.7.4".freeze
+  VERSION = "0.8.0".freeze
   DESCRIPTION = "Automate your PR etiquette.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 0.8.0
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2016-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -166,19 +166,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: fastlane
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.49.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.49.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -193,6 +193,62 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.38.0
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: listen
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Create a Dangerfile to introspect your pull request in CI, makes it easy
   to enforce social conventions like changelogs and tests.
 email:
@@ -209,33 +265,38 @@ files:
 - lib/assets/DangerfileTemplate
 - lib/assets/PluginTemplate.rb.template
 - lib/danger.rb
-- lib/danger/available_values.rb
 - lib/danger/ci_source/buildkite.rb
 - lib/danger/ci_source/ci_source.rb
 - lib/danger/ci_source/circle.rb
+- lib/danger/ci_source/circle_api.rb
+- lib/danger/ci_source/drone.rb
 - lib/danger/ci_source/jenkins.rb
 - lib/danger/ci_source/local_git_repo.rb
+- lib/danger/ci_source/semaphore.rb
 - lib/danger/ci_source/travis.rb
 - lib/danger/ci_source/xcode_server.rb
-- lib/danger/circle_api.rb
 - lib/danger/commands/init.rb
 - lib/danger/commands/init_helpers/interviewer.rb
 - lib/danger/commands/local.rb
 - lib/danger/commands/new_plugin.rb
 - lib/danger/commands/runner.rb
 - lib/danger/comment_generators/github.md.erb
+- lib/danger/core_ext/file_list.rb
 - lib/danger/core_ext/string.rb
-- lib/danger/dangerfile.rb
-- lib/danger/dangerfile_dsl.rb
-- lib/danger/environment_manager.rb
-- lib/danger/plugin.rb
-- lib/danger/plugins/protect_files.rb
-- lib/danger/request_sources/github.rb
-- lib/danger/scm_source/file_list.rb
+- lib/danger/danger_core/dangerfile.rb
+- lib/danger/danger_core/dangerfile_dsl.rb
+- lib/danger/danger_core/environment_manager.rb
+- lib/danger/danger_core/plugins/dangerfile_git_plugin.rb
+- lib/danger/danger_core/plugins/dangerfile_github_plugin.rb
+- lib/danger/danger_core/plugins/dangerfile_import_plugin.rb
+- lib/danger/danger_core/plugins/dangerfile_messaging_plugin.rb
+- lib/danger/danger_core/standard_error.rb
+- lib/danger/danger_core/violation.rb
+- lib/danger/plugin_support/plugin.rb
+- lib/danger/plugin_support/plugin_parser.rb
+- lib/danger/request_source/github.rb
 - lib/danger/scm_source/git_repo.rb
-- lib/danger/standard_error.rb
 - lib/danger/version.rb
-- lib/danger/violation.rb
 homepage: http://github.com/danger/danger
 licenses:
 - MIT
@@ -256,8 +317,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Automate your PR etiquette.
 test_files: []
+has_rdoc: 

data/lib/danger/available_values.rb

@@ -1,29 +0,0 @@
-module Danger
-  # Defines all the values that should be available in someone's Dangerfile
-  class AvailableValues
-    def self.all
-      self.scm + self.request_source
-    end
-
-    def self.scm
-      [
-        :lines_of_code,
-        :modified_files,
-        :deleted_files,
-        :added_files,
-        :deletions,
-        :insertions,
-        :commits
-      ]
-    end
-
-    def self.request_source
-      [
-        :pr_title,
-        :pr_body,
-        :pr_author,
-        :pr_labels
-      ]
-    end
-  end
-end

data/lib/danger/dangerfile.rb

@@ -1,123 +0,0 @@
-# So much was ripped direct from CocoaPods-Core - thanks!
-
-require 'danger/dangerfile_dsl'
-require 'danger/standard_error'
-
-module Danger
-  class Dangerfile
-    include Danger::Dangerfile::DSL
-
-    attr_accessor :env, :warnings, :errors, :messages, :markdowns, :verbose
-
-    # @return [Pathname] the path where the Dangerfile was loaded from. It is nil
-    #         if the Dangerfile was generated programmatically.
-    #
-    attr_accessor :defined_in_file
-
-    # @return [String] a string useful to represent the Dangerfile in a message
-    #         presented to the user.
-    #
-    def to_s
-      'Dangerfile'
-    end
-
-    # Iterates through the DSL's attributes, and table's the output
-    def print_known_info
-      rows = []
-
-      AvailableValues.all.each do |key|
-        value = self.send(key)
-        value = value.scan(/.{,80}/).to_a.each(&:strip!).join("\n") if key == :pr_body
-
-        # So that we either have one value per row
-        # or we have [] for an empty array
-        value = value.join("\n") if value.kind_of?(Array) && value.count > 0
-
-        rows << [key.to_s, value]
-      end
-
-      rows << ["---", "---"]
-      rows << ["SCM", env.scm.class]
-      rows << ["Source", env.ci_source.class]
-      rows << ["Requests", env.request_source.class]
-      rows << ["Base Commit", env.meta_info_for_base]
-      rows << ["Head Commit", env.meta_info_for_head]
-
-      params = {}
-      params[:rows] = rows.each { |current| current[0] = current[0].yellow }
-      params[:title] = "Danger v#{Danger::VERSION}\nDSL Attributes".green
-
-      puts ""
-      puts Terminal::Table.new(params)
-      puts ""
-    end
-
-    # Parses the file at a path, optionally takes the content of the file for DI
-    #
-    def parse(path, contents = nil)
-      print_known_info if verbose
-
-      contents ||= File.open(path, 'r:utf-8', &:read)
-
-      # Work around for Rubinius incomplete encoding in 1.9 mode
-      if contents.respond_to?(:encoding) && contents.encoding.name != 'UTF-8'
-        contents.encode!('UTF-8')
-      end
-
-      if contents.tr!('“”‘’‛', %(""'''))
-        # Changes have been made
-        puts "Your #{path.basename} has had smart quotes sanitised. " \
-                    'To avoid issues in the future, you should not use ' \
-                    'TextEdit for editing it. If you are not using TextEdit, ' \
-                    'you should turn off smart quotes in your editor of choice.'.red
-      end
-
-      if contents.include?("puts")
-        puts "You used `puts` in your Dangerfile. To print out text to GitHub use `message` instead"
-      end
-
-      self.defined_in_file = path
-      instance_eval do
-        # rubocop:disable Lint/RescueException
-        begin
-          # rubocop:disable Eval
-          eval(contents, nil, path.to_s)
-          # rubocop:enable Eval
-        rescue Exception => e
-          message = "Invalid `#{path.basename}` file: #{e.message}"
-          raise DSLError.new(message, path, e.backtrace, contents)
-        end
-        # rubocop:enable Lint/RescueException
-      end
-    end
-
-    def print_results
-      return if (self.errors + self.warnings + self.messages + self.markdowns).count == 0
-
-      puts ""
-      puts "danger results:"
-      [:errors, :warnings, :messages].each do |current|
-        params = {}
-        params[:rows] = self.send(current).collect { |a| [a.message] }
-        next unless params[:rows].count > 0
-        params[:title] = case current
-                         when :errors
-                           current.to_s.capitalize.red
-                         when :warnings
-                           current.to_s.capitalize.yellow
-                         else
-                           current.to_s.capitalize
-                         end
-
-        puts ""
-        puts Terminal::Table.new(params)
-        puts ""
-      end
-
-      puts "Markdown: ".green if self.markdowns.count > 0
-      self.markdowns.each do |current_markdown|
-        puts current_markdown
-      end
-    end
-  end
-end

data/lib/danger/dangerfile_dsl.rb

@@ -1,159 +0,0 @@
-require 'danger/violation'
-
-module Danger
-  class Dangerfile
-    module DSL
-      # @!group Enviroment
-      # @return [EnvironmentManager] Provides access to the raw Travis/Circle/Buildkite/GitHub
-      # objects, which you can use to pull out extra bits of information. _Warning_
-      # the api of these objects is **not** considered a part of the Dangerfile public
-      # API, and is viable to change occasionally on the whims of developers.
-
-      attr_reader :env
-
-      def initialize
-        self.warnings = []
-        self.errors = []
-        self.messages = []
-        self.markdowns = []
-
-        load_default_plugins
-      end
-
-      def import(path)
-        raise "`import` requires a string" unless path.kind_of?(String)
-        path += ".rb" unless path.end_with?(".rb")
-
-        if path.start_with?("http")
-          import_url(path)
-        else
-          import_local(path)
-        end
-      end
-
-      # Download a remote plugin and use it locally
-      #
-      # @param    [String] url
-      #           https URL to the Ruby file to use
-      def import_url(url)
-        raise "URL is not https, for security reasons `danger` only supports encrypted requests" unless url.start_with?("https://")
-
-        require 'tmpdir'
-        require 'faraday'
-        require 'faraday_middleware'
-
-        @http_client ||= Faraday.new do |b|
-          b.use FaradayMiddleware::FollowRedirects
-          b.adapter :net_http
-        end
-        content = @http_client.get(url)
-
-        Dir.mktmpdir do |dir|
-          path = File.join(dir, "temporary_remote_action.rb")
-          File.write(path, content.body)
-          import_local(path)
-        end
-      end
-
-      # Import one or more local plugins
-      #
-      # @param    [String] path
-      #           The path to the file to import
-      #           Can also be a pattern (./**/*plugin.rb)
-      def import_local(path)
-        Dir[path].each do |file|
-          require File.expand_path(file) # without the expand_path it would fail if the path doesn't start with ./
-        end
-      end
-
-      def should_ignore_violation(message)
-        env.request_source.ignored_violations.include? message
-      end
-
-      # Declares a CI blocking error
-      #
-      # @param    [String] message
-      #           The message to present to the user
-      # @param    [Boolean] sticky
-      #           Whether the message should be kept after it was fixed
-      def fail(message, sticky: true)
-        return if should_ignore_violation(message)
-        self.errors << Violation.new(message, sticky)
-        puts "Raising error '#{message}'"
-      end
-
-      # Specifies a problem, but not critical
-      #
-      # @param    [String] message
-      #           The message to present to the user
-      # @param    [Boolean] sticky
-      #           Whether the message should be kept after it was fixed
-      def warn(message, sticky: true)
-        return if should_ignore_violation(message)
-        self.warnings << Violation.new(message, sticky)
-        puts "Printing warning '#{message}'"
-      end
-
-      # Print out a generate message on the PR
-      #
-      # @param    [String] message
-      #           The message to present to the user
-      # @param    [Boolean] sticky
-      #           Whether the message should be kept after it was fixed
-      def message(message, sticky: true)
-        self.messages << Violation.new(message, sticky)
-        puts "Printing message '#{message}'"
-      end
-
-      # Print markdown to below the table
-      #
-      # @param    [String] message
-      #           The markdown based message to be printed below the table
-      def markdown(message)
-        self.markdowns << message
-        puts "Printing markdown #{message}"
-      end
-
-      # When an undefined method is called, we check to see if it's something
-      # that either the `scm` or the `request_source` can handle.
-      # This opens us up to letting those object extend themselves naturally.
-      # This will also look for plugins
-      def method_missing(method_sym, *arguments, &_block)
-        # SCM Source
-        if AvailableValues.scm.include?(method_sym)
-          return env.scm.send(method_sym)
-        end
-
-        # Request Source
-        if AvailableValues.request_source.include?(method_sym)
-          return env.request_source.send(method_sym)
-        end
-
-        # Plugins
-        class_name = method_sym.to_s.danger_class
-        if Danger::Dangerfile::DSL.const_defined?(class_name)
-          plugin_ref = Danger::Dangerfile::DSL.const_get(class_name)
-          if plugin_ref < Plugin
-            plugin_ref.new(self).run(*arguments)
-          else
-            raise "'#{method_sym}' is not a valid danger plugin".red
-          end
-        else
-          raise "Unknown method '#{method_sym}', please check out the documentation for available plugins".red
-        end
-      end
-
-      private
-
-      def load_default_plugins
-        Dir["./lib/danger/plugins/*.rb"].each do |file|
-          require File.expand_path(file)
-        end
-
-        Dir["./danger_plugins/*.rb"].each do |file|
-          require File.expand_path(file)
-        end
-      end
-    end
-  end
-end