danger 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bdced6826bdfbe8f06cdc77e9f6b58336140e17c
-  data.tar.gz: 669ebaaf2d49f985c70a485018ff4bf6e8f4360f
+  metadata.gz: d97659425a77d1d4f21f22f7ba9fd43afd47d974
+  data.tar.gz: 4d3eb4ce159a4deb8326bebb05073e81cc91e233
 SHA512:
-  metadata.gz: adbef18ddcb2de50eb915991a82334bf8e559c1b6af8cc00230d8038a1440e09d268f1380aff7936411b9dd6c5d26bef8ae17f10f1a09f9b5a02c42d6b096b7e
-  data.tar.gz: c91f0a03be03e79d026b6b64c2da6bcc486eeb87883c00fe13d3869b64477bef72c121dd3b8f53c7e724fd341bd2285b884a1b2a16334148b1b960104a21e552
+  metadata.gz: 6ba7e1f9b4fb554dc663d81bf58b260a51914625c245ef9a30b6265f67155e1a1ba164df8c7db9a4c6895897b0761301df2bbe1f7a896bbf61dd5f6f7e70b002
+  data.tar.gz: bd2495aa7cc47436669f8c4d9d190a501bf7273cb53997b97f93abb1541c2eabf17e8b8906d9b2b7f8ee4f580225680243804e58776a59b642ba2c08ae0ef84f

data/lib/danger/commands/init.rb

@@ -23,7 +23,7 @@ module Danger
 
     def run
       ui = Interviewer.new
-      ui.say "\nOK, thanks #{ENV['LOGNAME']}, grab a seat and we'll get you started.\n".yellow
+      ui.say "\nOK, thanks #{ENV['LOGNAME']}, have a seat and we'll get you started.\n".yellow
       ui.pause 1
 
       show_todo_state
@@ -43,11 +43,11 @@ module Danger
     end
 
     def show_todo_state
-      ui.say "We need to do the following steps:\n"
+      ui.say "We need to do the following:\n"
       ui.pause 0.6
       ui.say " - [ ] Create a Dangerfile and add a few simple rules."
       ui.pause 0.6
-      ui.say " - [#{@account_created ? 'x' : ' '}] Create a GitHub account for Danger use for messaging."
+      ui.say " - [#{@account_created ? 'x' : ' '}] Create a GitHub account for Danger to use, for messaging."
       ui.pause 0.6
       ui.say " - [ ] Set up an access token for Danger."
       ui.pause 0.6
@@ -71,7 +71,7 @@ module Danger
       ui.pause 2
 
       ui.say "There's a collection of small, simple ideas in here, but Danger is about being able to easily"
-      ui.say "iterate. The power comes from you have the ability to codify fixes to some of the problems"
+      ui.say "iterate. The power comes from you having the ability to codify fixes for some of the problems"
       ui.say "that come up in day to day programming. It can be difficult to try and see those from day 1."
 
       ui.say "\nIf you'd like to investigate the file, and make some changes - I'll wait here,"
@@ -113,7 +113,7 @@ module Danger
         ui.say "For Open Source projects, I'd recommend giving the token the smallest scope possible."
         ui.say "This means only providing access to " + "public_repo".yellow + " in the token.\n\n"
         ui.pause 1
-        ui.say "This token limits Danger's abilities to just to writing comments on OSS projects. I recommend"
+        ui.say "This token limits Danger's abilities to just writing comments on OSS projects. I recommend"
         ui.say "this because the token can quite easily be extracted from the environment via pull requests."
         ui.say "#{@bot_name} does not need admin access to your repo. So its ability to cause chaos is minimalized.\n"
 
@@ -148,7 +148,7 @@ module Danger
       ui.say "\nOK, I'll give you a moment to do this..."
       ui.wait_for_return
 
-      ui.say "Final step: exposing the GitHub token as an environment build variable."
+      ui.header "Final step: exposing the GitHub token as an environment build variable."
       ui.pause 0.4
       if considered_an_oss_repo?
         ui.say "As you have an Open Source repo, this token should be considered public, otherwise you cannot"
@@ -207,7 +207,7 @@ module Danger
       # https://travis-ci.org/artsy/eigen/settings
       ui.say "In order to add an environment variable, go to:"
       ui.link "https://travis-ci.org/#{current_repo_slug}/settings"
-      ui.say "\nThe name is " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Acess Token."
+      ui.say "\nThe name is " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Access Token."
       if @is_open_source
         ui.say "Make sure to have \"Display value in build log\" enabled."
       end
@@ -262,7 +262,7 @@ module Danger
       ui.say "\n\n🎉"
       ui.pause 0.6
 
-      ui.say "And you're set. Danger is a collaboration between Orta Therox, Gem 'Danger' McShane and Felix Krause."
+      ui.say "And you're good to go. Danger is a collaboration between Orta Therox, Gem 'Danger' McShane and Felix Krause."
       ui.say "If you like it, let others know. If you want to know more, follow " + "@orta".yellow + " and " + "@KrauseFx".yellow + " on Twitter."
       ui.say "If you don't like it, help us improve it! xxx"
     end

data/lib/danger/core_ext/string.rb

@@ -3,6 +3,10 @@ class String
     split('_').collect!(&:capitalize).join
   end
 
+  def danger_pluralize(count)
+    "#{count} #{self}#{'s' unless count == 1}"
+  end
+
   def danger_underscore
     self.gsub(/::/, '/').
       gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').

data/lib/danger/plugin.rb

@@ -9,8 +9,7 @@ module Danger
         # Since we have a reference to the DSL containing all the information
         # We need to redirect the self calls to the DSL
         def method_missing(method_sym, *arguments, &_block)
-          return @dsl.send(method_sym, *arguments) if @dsl.respond_to?(method_sym)
-          return @dsl.method_missing(method_sym, *arguments)
+          @dsl.send(method_sym, *arguments)
         end
 
         def run

data/lib/danger/request_sources/github.rb

@@ -20,7 +20,7 @@ module Danger
     end
 
     def client
-      raise "No API given, please provide one using `DANGER_GITHUB_API_TOKEN`" if !@token && !support_tokenless_auth
+      raise "No API token given, please provide one using `DANGER_GITHUB_API_TOKEN`" if !@token && !support_tokenless_auth
 
       @client ||= Octokit::Client.new(
         access_token: @token
@@ -129,7 +129,7 @@ module Danger
       # use a read-only GitHub account
       if errors.count > 0
         # We need to fail the actual build here
-        abort("\nDanger has failed this build. \nFound #{errors.count} error(s) and I don't have write access to the PR set a PR status.")
+        abort("\nDanger has failed this build. \nFound #{'error'.danger_pluralize(errors.count)} and I don't have write access to the PR set a PR status.")
       else
         puts message
       end
@@ -156,8 +156,8 @@ module Danger
         return "All green. #{random_compliment}"
       else
         message = "⚠ "
-        message += "#{errors.count} Error#{errors.count == 1 ? '' : 's'}. " unless errors.empty?
-        message += "#{warnings.count} Warning#{warnings.count == 1 ? '' : 's'}. " unless warnings.empty?
+        message += "#{'Error'.danger_pluralize(errors.count)}. " unless errors.empty?
+        message += "#{'Warning'.danger_pluralize(warnings.count)}. " unless warnings.empty?
         message += "Don't worry, everything is fixable."
         return message
       end

data/lib/danger/scm_source/git_repo.rb

@@ -5,10 +5,12 @@ require 'git'
 module Danger
   class GitRepo
     attr_accessor :diff
+    attr_accessor :log
 
     def diff_for_folder(folder, from: "master", to: 'HEAD')
       repo = Git.open folder
       self.diff = repo.diff(from, to)
+      self.log = repo.log.between(from, to)
     end
 
     def exec(string)
@@ -38,5 +40,9 @@ module Danger
     def insertions
       @diff.insertions
     end
+
+    def commits
+      log.to_a
+    end
   end
 end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "0.7.2".freeze
+  VERSION = "0.7.3".freeze
   DESCRIPTION = "Automate your PR etiquette.".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-13 00:00:00.000000000 Z
+date: 2016-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide