danger 0.5.1 → 0.5.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/lib/danger/commands/init.rb +15 -14
- data/lib/danger/version.rb +1 -1
- metadata +1 -1
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA1:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 14a93dd351e70737bc4c56de0db56d790c223c5b
|
4
|
+
data.tar.gz: 2902696f31772f74976816570b4fa5051db637f6
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: e0a87671ee98117c019ff2d374830112d4c94c356d66315ab69553e125546d98c54a209b9a7f0bb4cf03830bdb84ddbec3e763656ced085768731f1c00641d29
|
7
|
+
data.tar.gz: 0b2fcf219ff87f2c959295f0f5884fc444820ae8831daa6452b622171331dafd049bfb08e7f749b66c4d937878eb1935d5c138311c2497f96f3374352237467b
|
data/lib/danger/commands/init.rb
CHANGED
@@ -82,11 +82,11 @@ module Danger
|
|
82
82
|
def setup_github_account
|
83
83
|
ui.header 'Step 2: Creating a GitHub account'
|
84
84
|
|
85
|
-
ui.say "In order to get the most out of Danger, I'd recommend
|
85
|
+
ui.say "In order to get the most out of Danger, I'd recommend giving her the ability to post in"
|
86
86
|
ui.say "the code-review comment section.\n\n"
|
87
87
|
ui.pause 1
|
88
88
|
|
89
|
-
ui.say "IMO, it's best do this by using the private mode of your browser. Create an account like"
|
89
|
+
ui.say "IMO, it's best to do this by using the private mode of your browser. Create an account like"
|
90
90
|
ui.say "#{@bot_name}, and don't forget a cool robot avatar.\n\n"
|
91
91
|
ui.pause 1
|
92
92
|
ui.say 'Here are great resources for creative commons images of robots:'
|
@@ -103,7 +103,7 @@ module Danger
|
|
103
103
|
def setup_access_token
|
104
104
|
ui.header 'Step 3: Configuring a GitHub Personal Access Token'
|
105
105
|
|
106
|
-
ui.say "Here's the link, you should open this in
|
106
|
+
ui.say "Here's the link, you should open this in the private session where you just created the new GitHub account"
|
107
107
|
ui.link "https://github.com/settings/tokens/new"
|
108
108
|
ui.pause 1
|
109
109
|
|
@@ -114,14 +114,15 @@ module Danger
|
|
114
114
|
ui.say "This means only providing access to " + "public_info".yellow + " in the token.\n\n"
|
115
115
|
ui.pause 1
|
116
116
|
ui.say "This token limits Danger's abilities to just to writing comments on OSS projects. I recommend"
|
117
|
-
ui.say "this because the token can
|
118
|
-
ui.say "#{@bot_name} does not need admin access to your repo. So
|
117
|
+
ui.say "this because the token can quite easily be extracted from the environment via pull requests."
|
118
|
+
ui.say "#{@bot_name} does not need admin access to your repo. So its ability to cause chaos is minimalized.\n"
|
119
119
|
|
120
120
|
elsif @is_open_source == "closed"
|
121
121
|
ui.say "For Closed Source projects, I'd recommend giving the token access to the whole repo scope."
|
122
|
-
ui.say "This means only providing access to " + "repo".yellow + ", and
|
122
|
+
ui.say "This means only providing access to " + "repo".yellow + ", and its children in the token.\n\n"
|
123
123
|
ui.pause 1
|
124
|
-
ui.say "It's worth noting that you " + "should not".bold.white + " re-use this token for OSS repos.
|
124
|
+
ui.say "It's worth noting that you " + "should not".bold.white + " re-use this token for OSS repos."
|
125
|
+
ui.say "Make a new one for those repos with just " + "public_info".yellow + "."
|
125
126
|
end
|
126
127
|
|
127
128
|
ui.say "\n👍, please press return when you have your token set up…"
|
@@ -147,11 +148,11 @@ module Danger
|
|
147
148
|
ui.say "\nOK, I'll give you a moment to do this…"
|
148
149
|
ui.wait_for_return
|
149
150
|
|
150
|
-
ui.say "Final step: exposing the GitHub token as
|
151
|
+
ui.say "Final step: exposing the GitHub token as an environment build variable."
|
151
152
|
ui.pause 0.4
|
152
153
|
if considered_an_oss_repo?
|
153
154
|
ui.say "As you have an Open Source repo, this token should be considered public, otherwise you cannot"
|
154
|
-
ui.say "run Danger on pull requests from forks, limiting
|
155
|
+
ui.say "run Danger on pull requests from forks, limiting its use.\n"
|
155
156
|
ui.pause 1
|
156
157
|
end
|
157
158
|
|
@@ -197,8 +198,8 @@ module Danger
|
|
197
198
|
|
198
199
|
def unsure_ci
|
199
200
|
danger = "bundle exec danger".yellow
|
200
|
-
ui.say "As I'm not sure what CI you want to run Danger on
|
201
|
-
ui.say "advice. You want to run " + danger + " after your tests have finished running, it should be during the testing"
|
201
|
+
ui.say "As I'm not sure what CI you want to run Danger on based on the files in your repo, I'll just offer some generic"
|
202
|
+
ui.say "advice. You want to run " + danger + " after your tests have finished running, it should still be during the testing"
|
202
203
|
ui.say "process so the build can fail."
|
203
204
|
end
|
204
205
|
|
@@ -215,9 +216,9 @@ module Danger
|
|
215
216
|
def circle_token
|
216
217
|
# https://circleci.com/gh/artsy/eigen/edit#env-vars
|
217
218
|
if considered_an_oss_repo?
|
218
|
-
ui.say "Before we start, it's important to be up-front.
|
219
|
+
ui.say "Before we start, it's important to be up-front. CircleCI only really has one option to support running Danger"
|
219
220
|
ui.say "for forks on OSS repos. It is quite a drastic option, and I want to let you know the best place to understand"
|
220
|
-
ui.say "the
|
221
|
+
ui.say "the ramifications of turning on a setting I'm about to advise.\n"
|
221
222
|
ui.link "https://circleci.com/docs/fork-pr-builds"
|
222
223
|
ui.say "TLDR: If you have anything other than Danger config settings in CircleCI, then you should not turn on the setting."
|
223
224
|
ui.say "I'll give you a minute to read it…"
|
@@ -248,7 +249,7 @@ module Danger
|
|
248
249
|
ui.header "Useful info"
|
249
250
|
ui.say "- One of the best ways to test out new rules locally is via " + "bundle exec danger local".yellow + "."
|
250
251
|
ui.pause 0.6
|
251
|
-
ui.say "- You can have Danger output all of
|
252
|
+
ui.say "- You can have Danger output all of its variables to the console via the " + "--verbose".yellow + "option."
|
252
253
|
ui.pause 0.6
|
253
254
|
ui.say "- You can look at the following Dangerfiles to get some more ideas:"
|
254
255
|
ui.pause 0.6
|
data/lib/danger/version.rb
CHANGED