danger 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b830d9fd6b6ce7b6a2141b4cb7e5b801f44ae202
-  data.tar.gz: 9769485c2b763df4caa907614622913f70042921
+  metadata.gz: 25ffbe9e81d58bb03a50c0813b2340802520b827
+  data.tar.gz: 11b7151376d9c471c80d522a81eb17a88c487e1c
 SHA512:
-  metadata.gz: 8948ed48eb28381972bec1dd6832281aae83ae2e87f57a43f8df5ba003d002424b1d472013d58637cf73041a362a2b7fc8499763cc7bc7fb225ec65fcb6ec3bb
-  data.tar.gz: afcd5b7b1e16111a4ec5760ade4987c6e540c191fbfa409225bfb3d9379c32f1123dbd58d00db00a4ea3a6cba06f0f5dabcb1e1c8b8b34446185ac765c4f1f45
+  metadata.gz: 744f9c2444f90270cb142684ba457a31f889d49031cb582526c6a3ad13b5b8e05a3c0320e79bff2d31a6b24767baa53c7aea45c3f33d95094944781189b9397e
+  data.tar.gz: b94a33faeb13e99218c602e18dca552eada52d22836cab057417d2e15e203254a634b8c2fc3a01822a3641d070d5d16e8d6743822d0f9b87166817263d5d8035

data/README.md

@@ -26,11 +26,19 @@ Add this line to your application's [Gemfile](https://guides.cocoapods.org/using
 gem 'danger'
 ```
 
-and then run the following, which will help walk you through getting set up: `bundle exec danger init`.
+To get up and running quickly, just run
+
+```
+bundle exec danger init
+```
 
 ## Usage on CI
 
-In CI run `bundle exec danger`. This will look at your `Dangerfile` and provide feedback. While you are setting up, you may want to use: `--verbose`.
+```
+bundle exec danger
+```
+
+This will look at your `Dangerfile` and update the pull request accordingly. While you are setting up Danger, you may want to use: `--verbose` for more debug information. 
 
 ## What happens?
 
@@ -53,7 +61,7 @@ The `Dangerfile` is a ruby file, so really, you can do anything. However, at thi
 
 #### Dealing with WIP pull requests
 
-``` ruby
+```ruby
 # Sometimes its a README fix, or something like that - which isn't relevant for
 # including in a CHANGELOG for example
 declared_trivial = pr_title.include? "#trivial"
@@ -72,28 +80,32 @@ fail("Developer Specific file shouldn't be changed") if files_modified.include?(
 made_analytics_changes = files_modified.include?("/Artsy/App/ARAppDelegate+Analytics.m")
 made_analytics_specs_changes = files_modified.include?("/Artsy_Tests/Analytics_Tests/ARAppAnalyticsSpec.m")
 if made_analytics_changes
-    fail("Analytics changes should have reflected specs changes") if !made_analytics_specs_changes
+  fail("Analytics changes should have reflected specs changes") if !made_analytics_specs_changes
 
-    # And pay extra attention anyway
-    message('Analytics dict changed, double check for ?: `@""` on new entries')
-    message('Also, double check the [Analytics Eigen schema](https://docs.google.com/spreadsheets/u/1/d/1bLbeOgVFaWzLSjxLOBDNOKs757-zBGoLSM1lIz3OPiI/edit#gid=497747862) if the changes are non-trivial.')
+  # And pay extra attention anyway
+  message('Analytics dict changed, double check for ?: `@""` on new entries')
+  message('Also, double check the [Analytics Eigen schema](https://docs.google.com/spreadsheets/u/1/d/1bLbeOgVFaWzLSjxLOBDNOKs757-zBGoLSM1lIz3OPiI/edit#gid=497747862) if the changes are non-trivial.')
 end
 ```
 
 #### Pinging people when a specific file has changed
 
-``` ruby
+```ruby
 message("@orta something changed in elan!") if files_modified.include? "/components/lib/variables/colors.json"
 ```
 
 #### Exposing aspects of CI logs into the PR discussion
 
-``` ruby
-build_log = File.read( File.join(ENV["CIRCLE_ARTIFACTS"], "xcode_test_raw.log") )
+```ruby
+build_log = File.read(File.join(ENV["CIRCLE_ARTIFACTS"], "xcode_test_raw.log"))
 snapshots_url = build_log.match(%r{https://eigen-ci.s3.amazonaws.com/\d+/index.html})
 fail("There were [snapshot errors](#{snapshots_url})") if snapshots_url
 ```
 
+## Support
+
+Danger currently is supported on Travis CI, Circle CI, BuildKite and Jenkins. These work via environment variables, so it's easy to extend to include your own.
+
 ## Advanced
 
 You can access more detailed information by accessing the following variables
@@ -104,6 +116,9 @@ You can access more detailed information by accessing the following variables
 `env.scm.diff` | The full [Diff](https://github.com/mojombo/grit/blob/master/lib/grit/diff.rb) file for the diff.
 `env.ci_source` | To get information like the repo slug or pull request ID
 
+These are considered implementation details though, and may be subject to change in future releases. We're very
+open to turning useful bits into the official API.
+
 ## Test locally with `danger local`
 
 Using `danger local` will look for the last merged pull request in your git history, and apply your current
@@ -114,6 +129,8 @@ Using `danger local` will look for the last merged pull request in your git hist
 * You can set the base branch in the command line arguments see: `bundle exec danger --help`, if you commonly merge into non-master branches.
 * Appending `--verbose` to `bundle exec danger` will expose all of the variables that Danger provides, and their values in the shell.
 
+Here are some real-world Dangerfiles: [artsy/eigen](https://github.com/artsy/eigen/blob/master/Dangerfile), [danger/danger](https://github.com/danger/danger/blob/master/Dangerfile), [artsy/elan](https://github.com/artsy/elan/blob/master/Dangerfile) and more!
+
 ## License, Contributor's Guidelines and Code of Conduct
 
 > This project is open source under the MIT license, which means you have full access to the source code and can modify it to fit your own needs.

data/lib/danger/commands/init.rb

@@ -231,7 +231,7 @@ module Danger
       end
 
       ui.say "In order to expose an environment variable, go to:"
-      ui.link "https://circleci.com/gh/#{repo_slug}/edit#env-vars"
+      ui.link "https://circleci.com/gh/#{current_repo_slug}/edit#env-vars"
       ui.say "The name is " + "DANGER_GITHUB_API_TOKEN".yellow + " and the value is the GitHub Personal Acess Token."
     end
 
@@ -262,7 +262,7 @@ module Danger
       ui.pause 0.6
 
       ui.say "And you're set. Danger is a collaboration between Orta Therox, Gem 'Danger' McShane and Felix Krause."
-      ui.say "If you like it, let others know. If you want to know more, follow " + "@orta".yellow + " and " + "@krausefx".yellow + " on twitter."
+      ui.say "If you like it, let others know. If you want to know more, follow " + "@orta".yellow + " and " + "@KrauseFx".yellow + " on Twitter."
       ui.say "If you don't like it, help us improve it! xxx"
     end
   end

data/lib/danger/commands/runner.rb

@@ -15,7 +15,7 @@ module Danger
 
     def validate!
       super
-      unless @dangerfile_path
+      if self.class == Runner && !@dangerfile_path
         help! "Could not find a Dangerfile."
       end
     end

data/lib/danger/version.rb

@@ -1,4 +1,4 @@
 module Danger
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
   DESCRIPTION = "Automate your PR etiquette."
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Orta Therox
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-28 00:00:00.000000000 Z
+date: 2016-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: claide
@@ -248,8 +248,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Automate your PR etiquette.
 test_files: []
+has_rdoc: