danger-xcprofiler 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58787f96f3db5f505748ca1532c89bc7686fc084
-  data.tar.gz: fbe9fd4ef7f9e6e970b2a4ac2e86af6ae8639967
+  metadata.gz: d53c2adc425beb4ac13b96c331b14aae3778cc8f
+  data.tar.gz: c2b35bcfbafdb557ff76b38e5a11b6037c3540c9
 SHA512:
-  metadata.gz: 17e3d2e656fac5bb7ae49c74ac8a51427f71abf96a4cee082c7e1515c40dab02aa284d37bcd6ab85949e652d19d2b8803af09b109f72b2608b7411e0cb2328d3
-  data.tar.gz: ee1878fb82f7845d4540d3661d199e62f1735b25d0f730e291a2ead922f7f7846e41769777b6e5b9b3f2ef4b9d6710a752b2caac3ac94ad8feed195042279e0b
+  metadata.gz: c520d168973faa82f5cfb25988dcbb390c6ecb68b91fff925d49f92a00252aaf53bde9504c8f95858d1df72a2dc018ad57f2b0e0d9ed7c44c315e9feabab00b8
+  data.tar.gz: 1b0470efd3c6da2002ab7d4362c52df4a555067aa34665b83b6fedda9ead81d02923cd9c5427947f782616de930b6039a65a833aec52dfb25de7306947e79584

data/.rubocop.yml

@@ -1,3 +1,6 @@
+Metrics/ModuleLength:
+  Max: 120
+
 Metrics/MethodLength:
   Enabled: false
 
@@ -11,4 +14,5 @@ Metrics/BlockLength:
 Style/Documentation:
   Enabled: false
 
-
+Metrics/AbcSize:
+  Max: 25

data/.travis.yml

@@ -4,7 +4,6 @@ cache:
     - bundle
 
 rvm:
-  - 2.0
   - 2.1.3
   - 2.3.1
 

data/lib/xcprofiler/danger_reporter.rb

@@ -12,13 +12,21 @@ module Danger
     end
 
     def report!(executions)
+      if @inline_mode
+        inline_report(executions)
+      else
+        markdown_report(executions)
+      end
+    end
+
+    private
+
+    def inline_report(executions)
       executions.each do |execution|
         options = {}
-        if @inline_mode
-          options[:file] = relative_path(execution.path)
-          options[:line] = execution.line
-        end
-        message = message(execution)
+        options[:file] = relative_path(execution.path)
+        options[:line] = execution.line
+        message = "`#{execution.method_name}` takes #{execution.time} ms to build"
 
         if execution.time >= @thresholds[:fail]
           @dangerfile.fail(message, options)
@@ -28,17 +36,38 @@ module Danger
       end
     end
 
-    private
+    def markdown_report(executions)
+      warning_executions = executions.select do |e|
+        e.time >= @thresholds[:warn] && e.time < @thresholds[:fail]
+      end
+      error_executions = executions.select do |e|
+        e.time >= @thresholds[:fail]
+      end
+
+      return if warning_executions.empty? && error_executions.empty?
 
-    def message(execution)
-      message = "`#{execution.method_name}` takes #{execution.time} ms to build"
-      return message if @inline_mode
-      "[#{execution.filename}] #{message}"
+      message = "### Xcprofiler found issues\n\n"
+      message << markdown_issues(warning_executions, 'Warnings') unless warning_executions.empty?
+      message << markdown_issues(error_executions, 'Errors') unless error_executions.empty?
+      @dangerfile.markdown(message, {})
     end
 
     def relative_path(path)
       working_dir = Pathname.new(@working_dir)
       Pathname.new(path).relative_path_from(working_dir).to_s
     end
+
+    def markdown_issues(executions, heading)
+      message = "#### #{heading}\n\n"
+
+      message << "| File | Line | Method Name | Build Time (ms) |\n"
+      message << "| ---- | ---- | ----------- | --------------- |\n"
+
+      executions.each do |e|
+        message << "| #{e.filename} | #{e.line} | #{e.method_name} | #{e.time} |\n"
+      end
+
+      message
+    end
   end
 end

data/lib/xcprofiler/gem_version.rb

@@ -1,3 +1,3 @@
 module DangerXcprofiler
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.3.0'.freeze
 end

data/spec/xcprofiler_spec.rb

@@ -24,6 +24,7 @@ module Danger
         @xcprofiler.working_dir = ''
         allow(@dangerfile).to receive(:warn)
         allow(@dangerfile).to receive(:fail)
+        allow(@dangerfile).to receive(:markdown)
         allow(Xcprofiler::Profiler).to receive(:by_product_name).with(product_name).and_return(profiler)
         allow(derived_data).to receive(:flag_enabled?).and_return(true)
         allow(derived_data).to receive(:executions).and_return([execution0, execution1])
@@ -92,18 +93,26 @@ module Danger
         context 'with slow execution' do
           let(:time0) { 49.9 }
           let(:time1) { 50 }
+          message = "### Xcprofiler found issues\n\n"
+          message << "#### Warnings\n\n"
+          message << "| File | Line | Method Name | Build Time (ms) |\n"
+          message << "| ---- | ---- | ----------- | --------------- |\n"
+          message << "| Source.swift | 20 | doSomething() | 50.0 |\n"
           it 'asserts warning' do
             @xcprofiler.report(product_name)
-            expect(@dangerfile).to have_received(:warn)
-              .with('[Source.swift] `doSomething()` takes 50.0 ms to build', {})
+            expect(@dangerfile).to have_received(:markdown).with(message, {})
           end
         end
 
         context 'with very slow execution' do
+          message = "### Xcprofiler found issues\n\n"
+          message << "#### Errors\n\n"
+          message << "| File | Line | Method Name | Build Time (ms) |\n"
+          message << "| ---- | ---- | ----------- | --------------- |\n"
+          message << "| Source.swift | 20 | doSomething() | 100.0 |\n"
           it 'asserts failure' do
             @xcprofiler.report(product_name)
-            expect(@dangerfile).to have_received(:fail)
-              .with('[Source.swift] `doSomething()` takes 100.0 ms to build', {})
+            expect(@dangerfile).to have_received(:markdown).with(message, {})
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcprofiler
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - giginet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-11 00:00:00.000000000 Z
+date: 2017-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcprofiler