danger-xcodebuild 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e64658c29cf07253dd9cc5b037582d59a75155ab
-  data.tar.gz: 81da85368c2827f9a75b2bd254c89523f52ac57f
+  metadata.gz: cc2d72bf13b78e81c22dbdfda0d47b0c77efda80
+  data.tar.gz: d70faff0e519ce80fe7d632a8fe9f3ce708990c7
 SHA512:
-  metadata.gz: ace20c3da72cff0ef7a271993745ddf019e9d216b89367e10fe6502e9bbf9543a976ad3b9ab27ef108ae45d2d6eccc0f09a7836263c72f5173370884f7e08d88
-  data.tar.gz: 2111c49a248ed3ad9919259c71ef4e2344b925a66ba3c52960a209dedd4e4f31ee11d7dae98d8ce3f3a052dd829e015b8fab470bf7146294696ce37d63e41748
+  metadata.gz: 2617f5f06c452356db13e67fca6ce2c8b5432d8dde250deda83bd3423cfa669397c419c2fbf4e70893ea4c6f53459760f80e1d07d79ad6d57344e90276e98b46
+  data.tar.gz: abdfafcde92bb8bb636d26381a3fea2efd61ebfa8270fa4fe41b797081c3b33c595c602d9426c289e45a34f731dfab86146bd44c716fa82e8c34376460de87cd

data/Gemfile.lock

@@ -1,15 +1,15 @@
 PATH
   remote: .
   specs:
-    danger-xcodebuild (0.0.4)
+    danger-xcodebuild (0.0.5)
       danger (~> 3.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.4.0)
-    claide (1.0.0)
-    claide-plugins (0.9.1)
+    claide (1.0.1)
+    claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)

data/README.md

@@ -12,10 +12,14 @@ Exposes warnings, errors and test results. It requires a JSON generated using [x
 
     xcodebuild.json_file = "./fastlane/reports/xcpretty-json-formatter-results.json"
 
-    xcodebuild.parse_warnings
-    xcodebuild.parse_errors
-    xcodebuild.parse_tests
-    xcodebuild.perfect_build
+    xcodebuild.parse_warnings # returns number of warnings
+    xcodebuild.parse_errors # returns number of errors
+    xcodebuild.parse_tests # returns number of test failures
+    xcodebuild.perfect_build # returns a bool indicating if the build was perfect
+
+Messages are posted by default. You can stop them like this:
+
+    xcodebuild.post_messages = false
 
 ## Development
 

data/lib/xcodebuild/gem_version.rb

@@ -1,3 +1,3 @@
 module Xcodebuild
-  VERSION = "0.0.4".freeze
+  VERSION = "0.0.5".freeze
 end

data/lib/xcodebuild/plugin.rb

@@ -21,6 +21,7 @@ module Danger
       @error_count = 0
       @test_failures_count = 0
       @xcodebuild_json = nil
+      @post_messages = true
     end
 
     # Allows you to specify a build title to prefix all the reported messages.
@@ -39,6 +40,11 @@ module Danger
       @xcodebuild_json = JSON.parse(File.open(value, 'r').read)
     end
 
+    # Allows you to specify whether default messages should be posted when parsing
+    # @return   [Bool]
+    #
+    attr_accessor :post_messages
+
     # Parses and exposes eventual warnings.
     # @return   [warning_count]
     #
@@ -46,7 +52,7 @@ module Danger
       @warning_count = @xcodebuild_json["warnings"].count
       @warning_count = @warning_count + @xcodebuild_json["ld_warnings"].count
       @warning_count = @warning_count + @xcodebuild_json["compile_warnings"].count
-      if @warning_count > 0
+      if @warning_count > 0 && post_messages
         warning_string = @warning_count == 1 ? "warning" : "warnings"
         message = Array.new
         message.push (@build_title) unless @build_title.nil?
@@ -65,7 +71,7 @@ module Danger
       errors += @xcodebuild_json["file_missing_errors"].map {|x| "`[#{x["file_path"].split("/").last}] #{x["reason"]}`"}
       errors += @xcodebuild_json["undefined_symbols_errors"].map {|x| "`#{x["message"]}`"}
       errors += @xcodebuild_json["duplicate_symbols_errors"].map {|x| "`#{x["message"]}`"}
-      if errors.count > 0
+      if errors.count > 0 && post_messages
         error_string = errors.count == 1 ? "error" : "errors"
         message = Array.new
         message.push (@build_title) unless @build_title.nil?
@@ -88,7 +94,7 @@ module Danger
         test_failures += value.map {|x| "`[#{x["file_path"].split("/").last}] [#{x["test_case"]}] #{x["reason"]}`"}
       end
 
-      if test_failures.count > 0
+      if test_failures.count > 0 && post_messages
         test_string = test_failures.count == 1 ? "error" : "errors"
         message = Array.new
         message.push (@build_title) unless @build_title.nil?
@@ -107,10 +113,12 @@ module Danger
     #
     def perfect_build
       is_perfect_build = @warning_count == 0 && @error_count == 0 && @test_failures_count == 0
-      message = Array.new
-      message.push (@build_title) unless @build_title.nil?
-      message.push ("Perfect build 👍🏻")
-      message(message.reject(&:empty?).join(" ")) if is_perfect_build
+      if post_messages
+          message = Array.new
+          message.push (@build_title) unless @build_title.nil?
+          message.push ("Perfect build 👍🏻")
+          message(message.reject(&:empty?).join(" ")) if is_perfect_build
+      end
       return is_perfect_build
     end
 

data/spec/xcodebuild_spec.rb

@@ -137,6 +137,57 @@ module Danger
 
       end
 
+      describe "with post messages set to false" do
+
+          before do
+              data = {
+                :warnings => ['warning1', 'warning2'],
+                :ld_warnings => ['ld_warnings'],
+                :compile_warnings => ['compile_warnings'],
+                :errors => ['error1', 'error2'],
+                :compile_errors => [
+                  { :file_path => '/tmp/file1.m', :reason => 'reason1' },
+                  { :file_path => '/tmp/file2.m', :reason => 'reason2' }
+                ],
+                :file_missing_errors => [
+                  { :file_path => '/tmp/missing_file1.m', :reason => 'reason1' },
+                  { :file_path => '/tmp/missing_file2.m', :reason => 'reason2' }
+                ],
+                :undefined_symbols_errors => [{ :message => 'undefined_symbols' }],
+                :duplicate_symbols_errors => [{ :message => 'duplicate_symbols' }],
+                :tests_failures => {
+                  :suite1 => [{ :file_path => '/tmp/file1.m', :test_case => "testCase1", :reason => 'reason1' }],
+                  :suite2 => [{ :file_path => '/tmp/file2.m', :test_case => "testCase2", :reason => 'reason2' }]
+                }
+              }.to_json
+
+              filename = 'xcodebuild_tests.json'
+              allow(File).to receive(:open).with(filename, 'r').and_return(StringIO.new(data))
+
+              @xcodebuild.json_file = filename
+          end
+
+          it "must not post messages" do
+              @xcodebuild.post_messages = false
+              warnings = @xcodebuild.parse_warnings
+              errors = @xcodebuild.parse_errors
+              tests_failures = @xcodebuild.parse_tests
+              is_perfect_build = @xcodebuild.perfect_build
+
+              expect(warnings).to eq(4)
+              expect(@dangerfile.status_report[:warnings]).to be_empty
+
+              expect(errors).to eq(8)
+              expect(tests_failures).to eq(2)
+              expect(@dangerfile.status_report[:errors]).to be_empty
+
+              expect(is_perfect_build).to eq(false)
+              expect(@dangerfile.status_report[:messages]).to be_empty
+              expect(@dangerfile.status_report[:markdowns]).to be_empty
+          end
+
+      end
+
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcodebuild
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Valerio Mazzeo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-27 00:00:00.000000000 Z
+date: 2016-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger