danger-xcode_summary 1.0.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03c3c535aacaf5147fbaa8a5bb2d77b54c89b56fd72de75071f16655903b5b95
-  data.tar.gz: 4f1b7450d3f00cf969ddf63a74c4c4917b3dc7399c2bf27f5951bc6759485daf
+  metadata.gz: f7f4af287c0370b31f01a690b01e813461929e52ab57fce3285aa66bcaff49c4
+  data.tar.gz: ed22370ea6a8c18a4fe031ab7b8dac06654ddbc31a45862d7232520b4b98955e
 SHA512:
-  metadata.gz: c4cdc7816df1c0d50682cd387bce49b47f8fd7a99aff6b0c56dfce0252e9421c4e02be8cfc6c637109abd52b767ca29842c761031e1961ff835dd8ef90d731e0
-  data.tar.gz: 39d7f4bbee347d2f7f7e0f25dbff37dd43b486f1277cf22890d15c11531fed69794e8ce8049828d71924f8ee15f414ce3b15b5cd271a78fda6da4e9abc7ae5f1
+  metadata.gz: 6fb83b4b61b89603f5b4075c67039cabcf1221defda9106583ac9b569be141fcc7cbb33475f4369eaca4c77eabd86868a9ae99cd891ee2a820764de805fcf6b9
+  data.tar.gz: b8ce24b92d313924532bf56626f4493cd8a1e2a9fa57beaeea66ac50cc08b40a5e5ed09c2aa8721bcce6d18a71d33820e777584e98a368517ed4d888fdea821b

data/.github/workflows/ruby.yml

@@ -0,0 +1,38 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    branches: [ "master" ]
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+
+    runs-on: macos-latest
+    strategy:
+      matrix:
+        ruby-version: ['3.2.2']
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+    # uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake spec

data/.ruby-version

@@ -0,0 +1 @@
+3.2.2

data/Gemfile.lock

@@ -1,17 +1,18 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (1.0.1)
+    danger-xcode_summary (1.3.0)
       danger-plugin-api (~> 1.0)
       xcresult (~> 0.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
+    addressable (2.8.6)
+      public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
-    claide (1.0.3)
+    base64 (0.2.0)
+    claide (1.1.0)
     claide-plugins (0.9.2)
       cork
       nap
@@ -20,48 +21,34 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (8.4.0)
+    danger (9.4.3)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
-      faraday (>= 0.9.0, < 2.0)
+      faraday (>= 0.9.0, < 3.0)
       faraday-http-cache (~> 2.0)
-      git (~> 1.7)
+      git (~> 1.13)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
-      octokit (~> 4.7)
+      octokit (>= 4.0)
       terminal-table (>= 1, < 4)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.4.4)
-    faraday (1.8.0)
-      faraday-em_http (~> 1.0)
-      faraday-em_synchrony (~> 1.0)
-      faraday-excon (~> 1.1)
-      faraday-httpclient (~> 1.0.1)
-      faraday-net_http (~> 1.0)
-      faraday-net_http_persistent (~> 1.1)
-      faraday-patron (~> 1.0)
-      faraday-rack (~> 1.0)
-      multipart-post (>= 1.2, < 3)
-      ruby2_keywords (>= 0.0.4)
-    faraday-em_http (1.0.0)
-    faraday-em_synchrony (1.0.0)
-    faraday-excon (1.1.0)
-    faraday-http-cache (2.2.0)
+    diff-lcs (1.5.1)
+    faraday (2.9.0)
+      faraday-net_http (>= 2.0, < 3.2)
+    faraday-http-cache (2.5.1)
       faraday (>= 0.8)
-    faraday-httpclient (1.0.1)
-    faraday-net_http (1.0.1)
-    faraday-net_http_persistent (1.2.0)
-    faraday-patron (1.0.0)
-    faraday-rack (1.0.0)
-    ffi (1.15.4)
-    formatador (0.3.0)
-    git (1.9.1)
+    faraday-net_http (3.1.0)
+      net-http
+    ffi (1.16.3)
+    formatador (1.1.0)
+    git (1.19.1)
+      addressable (~> 2.8)
       rchardet (~> 1.8)
-    guard (2.18.0)
+    guard (2.18.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -75,77 +62,85 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (2.3.1)
+    json (2.7.1)
+    kramdown (2.4.0)
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
-    listen (3.7.0)
+    language_server-protocol (3.17.0.3)
+    listen (3.8.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.8)
+    lumberjack (1.2.10)
     method_source (1.0.0)
-    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
+    net-http (0.4.1)
+      uri
     no_proxy_fix (0.1.2)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.21.0)
-      faraday (>= 0.9)
-      sawyer (~> 0.8.0, >= 0.5.3)
+    octokit (8.1.0)
+      base64
+      faraday (>= 1, < 3)
+      sawyer (~> 0.9)
     open4 (1.3.4)
-    parallel (1.21.0)
-    parser (3.0.2.0)
+    parallel (1.24.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
-    pry (0.14.1)
+      racc
+    pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (4.0.6)
-    rainbow (3.0.0)
-    rake (13.0.6)
-    rb-fsevent (0.11.0)
+    public_suffix (5.0.4)
+    racc (1.7.3)
+    rainbow (3.1.1)
+    rake (13.1.0)
+    rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     rchardet (1.8.0)
-    regexp_parser (2.1.1)
-    rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    rubocop (1.22.1)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.0)
+    rubocop (1.60.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.12.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.12.0)
-      parser (>= 3.0.1.1)
-    ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.5)
-    sawyer (0.8.2)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    ruby-progressbar (1.13.0)
+    sawyer (0.9.2)
       addressable (>= 2.3.5)
-      faraday (> 0.8, < 2.0)
+      faraday (>= 0.17.3, < 3)
     shellany (0.0.1)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
-    thor (1.1.0)
-    unicode-display_width (2.1.0)
+    thor (1.3.0)
+    unicode-display_width (2.5.0)
+    uri (0.13.0)
     xcresult (0.2.1)
-    yard (0.9.26)
+    yard (0.9.34)
 
 PLATFORMS
   ruby
@@ -164,4 +159,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   2.2.26
+   2.3.0

data/README.md

@@ -56,6 +56,24 @@ A [Danger](http://danger.systems) plugin that shows all build errors, warnings a
   </tbody>
 </table>
 
+<table>
+  <thead>
+    <tr>
+      <th width="50"></th>
+      <th width="100%">
+          1 Message
+      </th>
+     </tr>
+  </thead>
+  <tbody>
+    <tr>
+      <td><g-emoji alias="book" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f4d6.png">📖</g-emoji></td>
+      <td>TestTarget: Executed 5 tests, with 1 failure (0 unexpected) in 0.032 (0.065) seconds</td>
+    </tr>
+      </tr>
+  </tbody>
+</table>
+
 ## Installation
 
 Add this line to your Gemfile:
@@ -106,6 +124,13 @@ xcode_summary.inline_mode = true
 xcode_summary.report 'MyApp.xcresult'
 ```
 
+You can use `strict` to reporting errors as warnings thereby don't block merge PR.
+
+ ```ruby
+ # If value is `false`, then errors will be reporting as warnings
+ xcode_summary.strict = false
+ ```
+
 You can get warning and error number by calling `warning_error_count`. The return will be a JSON string contains warning and error count, e.g `{"warnings":1,"errors":3}`:
 
 ```ruby

data/lib/xcode_summary/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module XcodeSummary
-  VERSION = '1.0.1'
+  VERSION = '1.3.0'
 end

data/lib/xcode_summary/plugin.rb

@@ -21,6 +21,7 @@ module Danger
   class DangerXcodeSummary < Plugin
     Location = Struct.new(:file_name, :file_path, :line)
     Result = Struct.new(:message, :location)
+    Warning = Struct.new(:message, :sticky, :location)
 
     # The project root, which will be used to make the paths relative.
     # Defaults to `pwd`.
@@ -39,10 +40,30 @@ module Danger
     # A block that filters specific results.
     # An example would be `lambda { |result| result.message.start_with?('ld') }` to ignore results for ld_warnings.
     #
-    # @param    [Block value
+    # @param    [Block] value
     # @return   [Block]
     attr_accessor :ignored_results
 
+    # Defines if the test summary will be sticky or not.
+    # Defaults to `false`.
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :sticky_summary
+
+    # Defines if the build summary is shown or not.
+    # Defaults to `true`.
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :test_summary
+
+    # A block that sorts the warning results.
+    # An example would be `lambda { |warning| warning.message.include?("deprecated") ? 1 : 0 }` to sort results for
+    # deprecated warnings.
+    #
+    # @param    [Block] value
+    # @return   [Block]
+    attr_accessor :sort_warnings_by
+
     # Defines if using inline comment or not.
     # Defaults to `false`.
     # @param    [Boolean] value
@@ -55,6 +76,12 @@ module Danger
     # @return   [Boolean]
     attr_accessor :ignores_warnings
 
+    # Defines errors strict. If value is `false`, then errors will be reporting as warnings.
+    # Defaults to `true`
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :strict
+
     # rubocop:disable Lint/DuplicateMethods
     def project_root
       root = @project_root || Dir.pwd
@@ -66,10 +93,22 @@ module Danger
       [@ignored_files].flatten.compact
     end
 
+    def sort_warnings_by(&block)
+      @sort_warnings_by ||= block
+    end
+
     def ignored_results(&block)
       @ignored_results ||= block
     end
 
+    def sticky_summary
+      @sticky_summary || false
+    end
+
+    def test_summary
+      @test_summary.nil? ? true : @test_summary
+    end
+
     def inline_mode
       @inline_mode || false
     end
@@ -78,8 +117,14 @@ module Danger
       @ignores_warnings || false
     end
 
+    def strict
+      @strict.nil? ? true : @strict
+    end
+
     # Pick a Dangerfile plugin for a chosen request_source and cache it
     # based on https://github.com/danger/danger/blob/master/lib/danger/plugin_support/plugin.rb#L31
+    #
+    # @return   [void]
     def plugin
       plugins = Plugin.all_plugins.select { |plugin| Dangerfile.essential_plugin_classes.include? plugin }
       @plugin ||= plugins.select { |p| p.method_defined? :html_link }.map { |p| p.new(@dangerfile) }.compact.first
@@ -122,23 +167,72 @@ module Danger
     private
 
     def format_summary(xcode_summary)
+      messages(xcode_summary).each { |s| message(s, sticky: sticky_summary) }
+      all_warnings = []
       xcode_summary.actions_invocation_record.actions.each do |action|
         warnings(action).each do |result|
+          warning_object = nil
           if inline_mode && result.location
-            warn(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            warning_object = Warning.new(result.message, false, result.location)
           else
-            warn(result.message, sticky: false)
+            warning_object = Warning.new(result.message, false, nil)
           end
+          all_warnings << warning_object
         end
-        # rubocop:disable Lint/UnreachableLoop
         errors(action).each do |result|
           if inline_mode && result.location
-            fail(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            if strict
+              fail(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            else
+              warn(result.message, sticky: false, file: result.location.file_path, line: result.location.line)
+            end
           else
-            fail(result.message, sticky: false)
+            if strict
+              fail(result.message, sticky: false)
+            else
+              warn(result.message, sticky: false)
+            end
           end
         end
-        # rubocop:enable Lint/UnreachableLoop
+      end
+      sort_and_log_warnings(all_warnings)
+    end
+
+    def sort_and_log_warnings(all_warnings)
+      all_warnings = all_warnings.sort_by(&sort_warnings_by)
+      all_warnings.each do |warning|
+        if inline_mode && warning.location
+          warn(warning.message, sticky: warning.sticky, file: warning.location.file_path, line: warning.location.line)
+        else
+          warn(warning.message, sticky: warning.sticky)
+        end
+      end
+    end
+
+    def messages(xcode_summary)
+      if test_summary
+        test_messages = xcode_summary.action_test_plan_summaries.map do |test_plan_summaries|
+          test_plan_summaries.summaries.map do |summary|
+            summary.testable_summaries.map do |test_summary|
+              test_summary.tests.filter_map do |action_test_object|
+                if action_test_object.instance_of? XCResult::ActionTestSummaryGroup
+                  subtests = action_test_object.all_subtests
+                  subtests_duration = subtests.map(&:duration).sum
+                  test_text_infix = subtests.count == 1 ? 'test' : 'tests'
+                  failed_tests_count = subtests.reject { |test| test.test_status == 'Success' }.count
+                  expected_failed_tests_count = subtests.select { |test| test.test_status == 'Expected Failure' }.count
+
+                  "#{test_summary.target_name}: Executed #{subtests.count} #{test_text_infix}, " \
+                    "with #{failed_tests_count} failures (#{expected_failed_tests_count} expected) in " \
+                    "#{subtests_duration.round(3)} (#{action_test_object.duration.round(3)}) seconds"
+                end
+              end
+            end
+          end
+        end
+        test_messages.flatten.uniq.compact.map(&:strip)
+      else
+        []
       end
     end
 
@@ -179,13 +273,15 @@ module Danger
     end
 
     def parse_location(document_location)
-      return nil if document_location.nil?
+      return nil if document_location&.url.nil?
 
       file_path = document_location.url.gsub('file://', '').split('#').first
       file_name = file_path.split('/').last
       fragment = document_location.url.split('#').last
       params = CGI.parse(fragment).transform_values(&:first)
-      line = params['StartingLineNumber'].to_i + 1 # StartingLineNumber is 0-based, but we need a 1-based value
+      line_number = params['StartingLineNumber']
+      # StartingLineNumber is 0-based, but we need a 1-based value
+      line = line_number.nil? || line_number.empty? ? 0 : line_number.to_i + 1
       Location.new(file_name, relative_path(file_path), line)
     end
 
@@ -225,6 +321,8 @@ module Danger
     end
 
     def format_test_failure(result, producing_target, test_case_name)
+      return escape_reason(result.message) if result.location.nil?
+
       path = result.location.file_path
       path_link = format_path(path, result.location.line)
       suite_name = "#{producing_target}.#{test_case_name}"

data/spec/xcode_summary_spec.rb

@@ -23,6 +23,26 @@ module Danger
         expect(@dangerfile.status_report[:errors]).to eq ['summary file not found']
       end
 
+      describe 'summary' do
+        context 'enabled' do
+          it 'formats summary messages' do
+            @xcode_summary.test_summary = true
+            @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
+            expect(@dangerfile.status_report[:messages]).to eq [
+              'SwiftLintFrameworkTests: Executed 540 tests, with 1 failures (0 expected) in 114.029 (27.922) seconds'
+            ]
+          end
+        end
+
+        context 'disabled' do
+          it 'shows no summary messages' do
+            @xcode_summary.test_summary = false
+            @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
+            expect(@dangerfile.status_report[:messages]).to eq []
+          end
+        end
+      end
+
       context 'reporting' do
         it 'formats compile warnings' do
           @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
@@ -172,6 +192,71 @@ module Danger
             expect(result).to eq '{"warnings":19,"errors":1}'
           end
         end
+
+        context 'without strict' do
+          before do
+            @xcode_summary.strict = false
+          end
+
+          it 'shows errors as warnings' do
+            @xcode_summary.report('spec/fixtures/build_error.xcresult')
+            expect(@dangerfile.status_report[:warnings].count).to_not eq 0
+            expect(@dangerfile.status_report[:errors]).to eq []
+          end
+
+          it 'report warning and error counts' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/build_error.xcresult')
+            expect(result).to eq '{"warnings":21,"errors":3}'
+          end
+        end
+
+        context 'with sort_warnings_by' do
+          before do
+            @xcode_summary.sort_warnings_by do |warning|
+              warning.message.include?('TODOs') ? 0 : 1
+            end
+          end
+          it 'sorts compile warnings' do
+            @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
+            expect(@dangerfile.status_report[:warnings]).to eq [
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L492'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L492</a>**: Todo Violation: TODOs should be resolved (Should raise error if subnode ...). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L379'>Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L379</a>**: Todo Violation: TODOs should be resolved (YAML supports keys other than ...). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L714'>Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L714</a>**: Todo Violation: TODOs should be resolved (local tag parsing). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Representer.swift#L187'>Carthage/Checkouts/Yams/Sources/Yams/Representer.swift#L187</a>**: Todo Violation: TODOs should be resolved (Support `Float80`). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L405'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L405</a>**: Todo Violation: TODOs should be resolved (YAML supports keys other than ...). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L430'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L430</a>**: Todo Violation: TODOs should be resolved (Should raise error on other th...). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L450'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L450</a>**: Todo Violation: TODOs should be resolved (YAML supports Hashable element...). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L478'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L478</a>**: Todo Violation: TODOs should be resolved (Should raise error if subnode ...). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Emitter.swift#L340'>Carthage/Checkouts/Yams/Sources/Yams/Emitter.swift#L340</a>**: Todo Violation: TODOs should be resolved (Support tags). (todo)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L538'>Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L538</a>**: 'public' modifier is redundant for instance method declared in a public extension",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L552'>Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L552</a>**: 'public' modifier is redundant for instance method declared in a public extension",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L88'>Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L88</a>**: Legacy Hashing Violation: Prefer using the `hash(into:)` function instead of overriding `hashValue` (legacy_hashing)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Result/Result/NoError.swift#L8'>Carthage/Checkouts/Result/Result/NoError.swift#L8</a>**: Will never be executed",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L109'>Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L109</a>**: Legacy Hashing Violation: Prefer using the `hash(into:)` function instead of overriding `hashValue` (legacy_hashing)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Decoder.swift#L102'>Carthage/Checkouts/Yams/Sources/Yams/Decoder.swift#L102</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Node.swift#L191'>Carthage/Checkouts/Yams/Sources/Yams/Node.swift#L191</a>**: Legacy Hashing Violation: Prefer using the `hash(into:)` function instead of overriding `hashValue` (legacy_hashing)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Encoder.swift#L139'>Carthage/Checkouts/Yams/Sources/Yams/Encoder.swift#L139</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Parser.swift#L441'>Carthage/Checkouts/Yams/Sources/Yams/Parser.swift#L441</a>**: File Line Length Violation: File should contain 400 lines or less: currently contains 441 (file_length)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L924'>Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L924</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L937'>Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L937</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L253'>Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L253</a>**: Superfluous Disable Command Violation: 'unused_private_declaration' is not a valid SwiftLint rule. Please remove it from the disable command. (superfluous_disable_command)"
+            ]
+          end
+
+          it 'formats errors' do
+            @xcode_summary.report('spec/fixtures/build_error.xcresult')
+            expect(@dangerfile.status_report[:errors]).to eq [
+              'Testing cancelled because the build failed.',
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L13'>Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L13</a>**: Use of unresolved identifier 'queue'",
+              "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L17'>Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L17</a>**: Use of unresolved identifier 'queue'"
+            ]
+          end
+
+          it 'report warning and error counts' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/build_error.xcresult')
+            expect(result).to eq '{"warnings":21,"errors":3}'
+          end
+        end
       end
     end
 

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Diogo Tridapalli
 - Marcelo Fabri
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-10-11 00:00:00.000000000 Z
+date: 2024-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xcresult
@@ -146,9 +146,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitattributes"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".ruby-version"
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -296,7 +297,7 @@ homepage: https://github.com/diogot/danger-xcode_summary
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -311,8 +312,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: A [Danger](http://danger.systems) plugin that shows all build errors, warnings
   and unit tests results generated from `xcodebuild`.

data/.travis.yml

@@ -1,19 +0,0 @@
-language: ruby
-cache:
-  directories:
-    - bundle
-
-os: osx
-osx_image: xcode11
-
-rvm:
-  - 2.6.0
-  - 2.5.3
-
-# install bundler 2.x
-before_install:
-    - gem update --system
-    - gem install bundler
-
-script:
-    - bundle exec rake spec