danger-xcode_summary 0.5.1 → 1.0.1

data/spec/fixtures/swiftlint.xcresult/Info.plist

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>dateCreated</key>
+	<date>2019-09-27T03:04:10Z</date>
+	<key>externalLocations</key>
+	<array/>
+	<key>rootId</key>
+	<dict>
+		<key>hash</key>
+		<string>0~aBrGz65aeXPVqACvo49xELHeqBawlmly6M_SmRa-iT99yzTiBp2st43mhwZEOVIgvsBEHLkKbH5oQpqjWgkueA==</string>
+	</dict>
+	<key>storage</key>
+	<dict>
+		<key>backend</key>
+		<string>fileBacked2</string>
+		<key>compression</key>
+		<string>standard</string>
+	</dict>
+	<key>version</key>
+	<dict>
+		<key>major</key>
+		<integer>3</integer>
+		<key>minor</key>
+		<integer>21</integer>
+	</dict>
+</dict>
+</plist>

data/spec/spec_helper.rb

@@ -2,8 +2,8 @@
 
 require 'pathname'
 ROOT = Pathname.new(File.expand_path('..', __dir__))
-$LOAD_PATH.unshift((ROOT + 'lib').to_s)
-$LOAD_PATH.unshift((ROOT + 'spec').to_s)
+$LOAD_PATH.unshift("#{ROOT}lib".to_s)
+$LOAD_PATH.unshift("#{ROOT}spec".to_s)
 
 require 'bundler/setup'
 require 'pry'
@@ -18,6 +18,9 @@ RSpec.configure do |config|
   config.filter_gems_from_backtrace 'bundler'
   config.color = true
   config.tty = true
+  config.expect_with :rspec do |c|
+    c.max_formatted_output_length = nil # n is number of lines, or nil for no truncation.
+  end
 end
 
 # These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
@@ -60,7 +63,9 @@ def testing_bitbucket_env
     'CHANGE_ID' => '4d4c0f31857e3185b51b6865a0700525bc0cb2bb',
     'JENKINS_URL' => 'http://jenkins.server.com/',
     'DANGER_BITBUCKETCLOUD_USERNAME' => 'username',
-    'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password'
+    'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password',
+    'DANGER_BITBUCKETCLOUD_UUID' => 'c91be865-efc6-49a6-93c5-24e1267c479b',
+    'ghprbPullId' => '2080'
   }
 end
 

data/spec/xcode_summary_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Layout/LineLength
+
 require File.expand_path('spec_helper', __dir__)
 
 module Danger
@@ -8,105 +10,84 @@ module Danger
       expect(Danger::DangerXcodeSummary.new(nil)).to be_a Danger::Plugin
     end
 
-    #
-    # You should test your custom attributes and methods here
-    #
     describe 'with Dangerfile' do
       before do
         @dangerfile = testing_dangerfile
         @xcode_summary = @dangerfile.xcode_summary
-        @xcode_summary.env.request_source.pr_json = JSON.parse(IO.read('spec/fixtures/pr_json.json'))
-        @xcode_summary.project_root = '/Users/diogo/src/MyWeight'
-      end
-
-      it 'sets sticky_summary to false as default' do
-        expect(@xcode_summary.sticky_summary).to eq false
-      end
-
-      it 'sets test_summary to true as default' do
-        expect(@xcode_summary.test_summary).to eq true
+        @xcode_summary.env.request_source.pr_json = JSON.parse(File.read('spec/fixtures/pr_json.json'))
+        @xcode_summary.project_root = '/Users/marcelofabri/SwiftLint/'
       end
 
       it 'fail if file does not exist' do
-        @xcode_summary.report('spec/fixtures/inexistent_file.json')
+        @xcode_summary.report('spec/fixtures/inexistent_file.xcresult')
         expect(@dangerfile.status_report[:errors]).to eq ['summary file not found']
       end
 
-      describe 'summary' do
-        context 'enabled' do
-          it 'formats summary messages' do
-            @xcode_summary.test_summary = true
-            @xcode_summary.report('spec/fixtures/summary_messages.json')
-            expect(@dangerfile.status_report[:messages]).to eq [
-              'Executed 4 tests, with 0 failures (0 unexpected) in 0.012 (0.017) seconds'
-            ]
-          end
-        end
-
-        context 'disabled' do
-          it 'shows no summary messages' do
-            @xcode_summary.test_summary = false
-            @xcode_summary.report('spec/fixtures/summary_messages.json')
-            expect(@dangerfile.status_report[:messages]).to eq []
-          end
-        end
-
+      context 'reporting' do
         it 'formats compile warnings' do
-          @xcode_summary.report('spec/fixtures/summary.json')
+          @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
-            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```",
-            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m#L176'>MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m#L176</a>**: 'NSUndefinedDateComponent' is deprecated: first deprecated in iOS 8.0 - Use NSDateComponentUndefined instead [-Wdeprecated-declarations]  <br />```\n                month_or_week = NSUndefinedDateComponent,\n```"
-            # rubocop:enable LineLength
-          ]
-        end
-
-        it 'formats compile warnings with empty line' do
-          @xcode_summary.report('spec/fixtures/summary_with_empty_line.json')
-          expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
-            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/Users/marcelofabri/Developer/MyAwesomeProject/MyAwesomeProject/Classes/AppDelegate.swift#L10001'>/Users/marcelofabri/Developer/MyAwesomeProject/MyAwesomeProject/Classes/AppDelegate.swift#L10001</a>**: File should contain 400 lines or less: currently contains 10001  <br />"
-            # rubocop:enable LineLength
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L88'>Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L88</a>**: Legacy Hashing Violation: Prefer using the `hash(into:)` function instead of overriding `hashValue` (legacy_hashing)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L109'>Carthage/Checkouts/Yams/Sources/Yams/Tag.swift#L109</a>**: Legacy Hashing Violation: Prefer using the `hash(into:)` function instead of overriding `hashValue` (legacy_hashing)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Decoder.swift#L102'>Carthage/Checkouts/Yams/Sources/Yams/Decoder.swift#L102</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Node.swift#L191'>Carthage/Checkouts/Yams/Sources/Yams/Node.swift#L191</a>**: Legacy Hashing Violation: Prefer using the `hash(into:)` function instead of overriding `hashValue` (legacy_hashing)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Representer.swift#L187'>Carthage/Checkouts/Yams/Sources/Yams/Representer.swift#L187</a>**: Todo Violation: TODOs should be resolved (Support `Float80`). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Encoder.swift#L139'>Carthage/Checkouts/Yams/Sources/Yams/Encoder.swift#L139</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Parser.swift#L441'>Carthage/Checkouts/Yams/Sources/Yams/Parser.swift#L441</a>**: File Line Length Violation: File should contain 400 lines or less: currently contains 441 (file_length)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L405'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L405</a>**: Todo Violation: TODOs should be resolved (YAML supports keys other than ...). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L430'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L430</a>**: Todo Violation: TODOs should be resolved (Should raise error on other th...). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L450'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L450</a>**: Todo Violation: TODOs should be resolved (YAML supports Hashable element...). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L478'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L478</a>**: Todo Violation: TODOs should be resolved (Should raise error if subnode ...). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L492'>Carthage/Checkouts/Yams/Sources/Yams/Constructor.swift#L492</a>**: Todo Violation: TODOs should be resolved (Should raise error if subnode ...). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Sources/Yams/Emitter.swift#L340'>Carthage/Checkouts/Yams/Sources/Yams/Emitter.swift#L340</a>**: Todo Violation: TODOs should be resolved (Support tags). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L379'>Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L379</a>**: Todo Violation: TODOs should be resolved (YAML supports keys other than ...). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L714'>Carthage/Checkouts/Yams/Tests/YamsTests/SpecTests.swift#L714</a>**: Todo Violation: TODOs should be resolved (local tag parsing). (todo)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L924'>Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L924</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L937'>Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L937</a>**: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L253'>Carthage/Checkouts/Yams/Tests/YamsTests/EncoderTests.swift#L253</a>**: Superfluous Disable Command Violation: 'unused_private_declaration' is not a valid SwiftLint rule. Please remove it from the disable command. (superfluous_disable_command)",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L538'>Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L538</a>**: 'public' modifier is redundant for instance method declared in a public extension",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L552'>Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L552</a>**: 'public' modifier is redundant for instance method declared in a public extension",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Result/Result/NoError.swift#L8'>Carthage/Checkouts/Result/Result/NoError.swift#L8</a>**: Will never be executed"
           ]
         end
 
         it 'ignores file when ignored_files matches' do
-          @xcode_summary.ignored_files = '**/Pods/**'
-          @xcode_summary.report('spec/fixtures/summary.json')
+          @xcode_summary.ignored_files = 'Carthage/**/Yams/**'
+          @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
-            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```"
-            # rubocop:enable LineLength
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L538'>Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L538</a>**: 'public' modifier is redundant for instance method declared in a public extension",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L552'>Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift#L552</a>**: 'public' modifier is redundant for instance method declared in a public extension",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Result/Result/NoError.swift#L8'>Carthage/Checkouts/Result/Result/NoError.swift#L8</a>**: Will never be executed"
           ]
         end
 
         it 'ignores file when ignored_files is an array and matches' do
-          @xcode_summary.ignored_files = ['**/Pods/**', '*.m']
-          @xcode_summary.report('spec/fixtures/summary.json')
-          expect(@dangerfile.status_report[:warnings]).to eq []
+          @xcode_summary.ignored_files = ['Carthage/**/Yams/**', 'Carthage/**/SWXMLHash/**']
+          @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
+          expect(@dangerfile.status_report[:warnings]).to eq [
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Carthage/Checkouts/Result/Result/NoError.swift#L8'>Carthage/Checkouts/Result/Result/NoError.swift#L8</a>**: Will never be executed"
+          ]
         end
 
         it 'formats test errors' do
-          @xcode_summary.report('spec/fixtures/test_errors.json')
+          @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
           expect(@dangerfile.status_report[:errors]).to eq [
-            # rubocop:disable LineLength
-            '**MyWeight.MyWeightSpec**: works_with_success, expected to eventually not be nil, got \<nil\>  <br />  ' \
-            "<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/MyWeightTests/Tests.swift#L86'>MyWeight/MyWeightTests/Tests.swift#L86</a>"
-            # rubocop:enable LineLength
+            "**SwiftLintFrameworkTests.ColonRuleTests.testColonWithoutApplyToDictionaries()**: XCTAssertEqual failed: (\"0\") is not equal to (\"1\")  <br />  <a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Tests/SwiftLintFrameworkTests/TestHelpers.swift#L169'>Tests/SwiftLintFrameworkTests/TestHelpers.swift#L169</a>"
           ]
         end
 
         it 'formats errors' do
-          @xcode_summary.report('spec/fixtures/errors.json')
+          @xcode_summary.report('spec/fixtures/build_error.xcresult')
           expect(@dangerfile.status_report[:errors]).to eq [
-            'some error',
-            'another error'
+            'Testing cancelled because the build failed.',
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L13'>Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L13</a>**: Use of unresolved identifier 'queue'",
+            "**<a href='https://github.com/realm/SwiftLint/blob/f211694e7def13785ff62047386437534541d7b3/Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L17'>Source/SwiftLintFramework/Extensions/QueuedPrint.swift#L17</a>**: Use of unresolved identifier 'queue'"
           ]
         end
 
-        it 'report waring and error counts' do
-          result = @xcode_summary.warning_error_count('spec/fixtures/summary.json')
-          expect(result).to eq '{"warnings":2,"errors":0}'
+        it 'report warning and error counts' do
+          result = @xcode_summary.warning_error_count('spec/fixtures/build_error.xcresult')
+          expect(result).to eq '{"warnings":21,"errors":3}'
         end
 
         context 'with inline_mode' do
@@ -116,78 +97,79 @@ module Danger
 
           it 'asserts errors on the line' do
             allow(@xcode_summary).to receive(:fail)
-            @xcode_summary.report('spec/fixtures/test_errors.json')
+            @xcode_summary.report('spec/fixtures/build_error.xcresult')
             expect(@xcode_summary).to have_received(:fail).with(
               instance_of(String),
               sticky: false,
-              file: 'MyWeight/MyWeightTests/Tests.swift',
-              line: 86
+              file: 'Source/SwiftLintFramework/Extensions/QueuedPrint.swift',
+              line: 13
+            )
+            expect(@xcode_summary).to have_received(:fail).with(
+              instance_of(String),
+              sticky: false,
+              file: 'Source/SwiftLintFramework/Extensions/QueuedPrint.swift',
+              line: 17
+            )
+            expect(@xcode_summary).to have_received(:fail).with(
+              'Testing cancelled because the build failed.',
+              sticky: false
             )
           end
 
           it 'asserts warning on the line' do
             allow(@xcode_summary).to receive(:warn)
-            @xcode_summary.report('spec/fixtures/summary.json')
-            expect(@xcode_summary).to have_received(:warn).with(
-              instance_of(String),
-              sticky: false,
-              file: 'Bla.m',
-              line: 32
-            )
+            @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
             expect(@xcode_summary).to have_received(:warn).with(
               instance_of(String),
               sticky: false,
-              file: 'ISO8601DateFormatter.m',
-              line: 176
+              file: 'Carthage/Checkouts/SWXMLHash/Source/XMLIndexer+XMLIndexerDeserializable.swift',
+              line: 538
             )
           end
         end
 
-        context 'with ignored_results' do
+        context 'with ignores_warnings' do
           before do
-            @xcode_summary.ignored_results { |result| result.message.start_with? 'some' }
-          end
-
-          it 'asserts no errors' do
-            @xcode_summary.report('spec/fixtures/errors.json')
-            expect(@dangerfile.status_report[:errors]).to eq ['another error']
+            @xcode_summary.ignores_warnings = true
           end
 
-          it 'asserts no warnings' do
-            @xcode_summary.report('spec/fixtures/ld_warnings.json')
-            expect(@dangerfile.status_report[:warnings]).to eq ['another warning']
+          it 'shows no warnings' do
+            @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
+            expect(@dangerfile.status_report[:warnings]).to eq []
           end
 
-          it 'report warning and error counts with no errors' do
-            result = @xcode_summary.warning_error_count('spec/fixtures/errors.json')
-            expect(result).to eq '{"warnings":0,"errors":1}'
+          it 'shows errors' do
+            @xcode_summary.report('spec/fixtures/build_error.xcresult')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+            expect(@dangerfile.status_report[:errors].count).to_not eq 0
           end
 
-          it 'report waring and error counts with no warnings' do
-            result = @xcode_summary.warning_error_count('spec/fixtures/ld_warnings.json')
-            expect(result).to eq '{"warnings":1,"errors":0}'
+          it 'reports warning and error counts with no warnings' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/build_error.xcresult')
+            expect(result).to eq '{"warnings":0,"errors":3}'
           end
         end
 
-        context 'with ignores_warnings' do
+        context 'with ignored_results' do
           before do
-            @xcode_summary.ignores_warnings = true
+            @xcode_summary.ignored_results do |result|
+              result.message.include?('public extension') || result.message.include?('unresolved')
+            end
           end
 
-          it 'asserts no ld warnings' do
-            @xcode_summary.report('spec/fixtures/ld_warnings.json')
-            expect(@dangerfile.status_report[:warnings]).to eq []
+          it 'asserts no errors' do
+            @xcode_summary.report('spec/fixtures/build_error.xcresult')
+            expect(@dangerfile.status_report[:errors].count).to eq 1
           end
 
-          it 'asserts no errors' do
-            @xcode_summary.report('spec/fixtures/warnings_errors.json')
-            expect(@dangerfile.status_report[:warnings]).to eq []
-            expect(@dangerfile.status_report[:errors]).to eq ['some error', 'another error']
+          it 'asserts no warnings' do
+            @xcode_summary.report('spec/fixtures/swiftlint.xcresult')
+            expect(@dangerfile.status_report[:warnings].count).to eq 19
           end
 
-          it 'report warning and error counts with no warning' do
-            result = @xcode_summary.warning_error_count('spec/fixtures/warnings_errors.json')
-            expect(result).to eq '{"warnings":0,"errors":2}'
+          it 'report warning and error counts' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/build_error.xcresult')
+            expect(result).to eq '{"warnings":19,"errors":1}'
           end
         end
       end
@@ -198,18 +180,17 @@ module Danger
       before do
         @dangerfile = testing_bitbucket_dangerfile
         @xcode_summary = @dangerfile.xcode_summary
-        # rubocop:disable LineLength
-        @xcode_summary.env.request_source.pr_json = JSON.parse(IO.read('spec/fixtures/bitbucket_pr.json'), symbolize_names: true)
-        # rubocop:enable LineLength
+        @xcode_summary.env.request_source.pr_json = JSON.parse(File.read('spec/fixtures/bitbucket_pr.json'), symbolize_names: true)
         @xcode_summary.project_root = '/Users/diogo/src/danger-xcode_summary'
       end
 
       describe 'where request source' do
         it 'should be bitbucket' do
-          path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb:3')
-          expect(path).to eq 'lib/xcode_summary/plugin.rb:3'
+          path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb', 3)
+          expect(path).to eq 'lib/xcode_summary/plugin.rb'
         end
       end
     end
   end
 end
+# rubocop:enable Layout/LineLength