danger-xcode_summary 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e6def5cba1b9a73d4f4f07a6c30d16589ae999b7
-  data.tar.gz: 17ad38af9f1e987e0acd218e18e2d3767729dac3
+  metadata.gz: e222df89970744f0a9e0e9ec76408480aaa6020c
+  data.tar.gz: f07bbe188cf33ef8cd5707742bbd4d68b965da8f
 SHA512:
-  metadata.gz: be044a5264cc74bccf5a51d57749ac77e242b74a00d021cb633504cb4eedd887e07537f63e06ec52bd3b3dc4f95c388cc8f2a22b9d1c99ffbb45e4beb0d4e626
-  data.tar.gz: 768deca527d4006812c55fe34162bb4312d31d4c0a64247553c506af8985efc85832b3f0ab8347b07da1c5ac5b7f0a2754e228e32c5c90bafbab78f9b22a7f97
+  metadata.gz: fb7531300b28f2307a50ce66562c28e3bec695d6e70223220f811b822b5522137e5022677359f92509a7fa651f0fd9beaa3a6d084733df7e76016ab5ef5e8d0d
+  data.tar.gz: 70d9df94ff7603adb1b340650cb5b4f6b350c228797aa5b89ea790b99de1c5792439ed0ac5eaf7663c94ec45f9261865c827828a58150e27437856a463971d11

data/.rubocop.yml

@@ -12,7 +12,7 @@ Lint/UselessAssignment:
     - '**/spec/**/*'
 
 # HoundCI doesn't like this rule
-Style/DotPosition:
+Layout/DotPosition:
   Enabled: false
 
 # Cop supports --auto-correct.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (0.4.0)
+    danger-xcode_summary (0.5.0)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -9,7 +9,7 @@ GEM
   specs:
     addressable (2.5.2)
       public_suffix (>= 2.0.2, < 4.0)
-    ast (2.3.0)
+    ast (2.4.0)
     claide (1.0.2)
     claide-plugins (0.9.2)
       cork
@@ -19,7 +19,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.5.6)
+    danger (5.5.10)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -34,11 +34,11 @@ GEM
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.3)
-    faraday (0.13.1)
+    faraday (0.14.0)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
-    ffi (1.9.18)
+    ffi (1.9.23)
     formatador (0.2.5)
     git (1.3.0)
     guard (2.14.2)
@@ -72,16 +72,16 @@ GEM
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parallel (1.12.1)
-    parser (2.4.0.2)
-      ast (~> 2.3)
+    parser (2.5.0.2)
+      ast (~> 2.4.0)
     powerpack (0.1.1)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    public_suffix (3.0.1)
+    public_suffix (3.0.2)
     rainbow (3.0.0)
     rake (10.5.0)
-    rb-fsevent (0.10.2)
+    rb-fsevent (0.10.3)
     rb-inotify (0.9.10)
       ffi (>= 0.5.0, < 2)
     rspec (3.7.0)
@@ -96,7 +96,7 @@ GEM
     rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
-    rspec-support (3.7.0)
+    rspec-support (3.7.1)
     rubocop (0.52.1)
       parallel (~> 1.10)
       parser (>= 2.4.0.2, < 3.0)
@@ -132,4 +132,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   1.16.0
+   1.16.1

data/README.md

@@ -96,10 +96,11 @@ xcode_summary.report 'xcodebuild.json'
 ```
 
 You can also ignore warnings from certain files by setting `ignored_files`: 
+Warning: `ignored_files` patterns applied on relative paths.  
 
 ```ruby
 # Ignoring warnings from Pods
-xcode_summary.ignored_files = '**/Pods/**'
+xcode_summary.ignored_files = 'Pods/**'
 
 # Ignoring specific warnings
 xcode_summary.ignored_results { |result|
@@ -109,6 +110,12 @@ xcode_summary.ignored_results { |result|
 xcode_summary.report 'xcodebuild.json'
 ```
 
+You can use `ignores_warnings` to supress warnings and shows only errors.
+
+```ruby
+xcode_summary.ignores_warnings = true
+```
+
 You can use `inline_mode`.
 When this value is enabled, each warnings and errors are commented on each lines.
 
@@ -118,6 +125,12 @@ xcode_summary.inline_mode = true
 xcode_summary.report 'xcodebuild.json'
 ```
 
+You can get warning and error number by calling `warning_error_count`. The return will be a JSON string contains warning and error count, e.g {"warnings":1,"errors":3}:
+
+```ruby
+result = xcode_summary.warning_error_count 'xcodebuild.json'
+```
+
 ## License
 
 danger-xcode_summary is released under the MIT license. See [LICENSE.txt](LICENSE.txt) for details.

data/lib/xcode_summary/gem_version.rb

@@ -1,3 +1,3 @@
 module XcodeSummary
-  VERSION = '0.4.0'.freeze
+  VERSION = '0.5.0'.freeze
 end

data/lib/xcode_summary/plugin.rb

@@ -60,6 +60,12 @@ module Danger
     # @return   [Boolean]
     attr_accessor :inline_mode
 
+    # Defines if warnings should be included or not
+    # Defaults to `false`.
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :ignores_warnings
+
     # rubocop:disable Lint/DuplicateMethods
     def project_root
       root = @project_root || Dir.pwd
@@ -86,6 +92,10 @@ module Danger
     def inline_mode
       @inline_mode || false
     end
+
+    def ignores_warnings
+      @ignores_warnings || false
+    end
     # rubocop:enable Lint/DuplicateMethods
 
     # Reads a file with JSON Xcode summary and reports it.
@@ -148,6 +158,10 @@ module Danger
     end
 
     def warnings(xcode_summary)
+      if ignores_warnings
+        return []
+      end
+
       warnings = [
         xcode_summary.fetch(:warnings, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:ld_warnings, []).map { |message| Result.new(message, nil) },

data/spec/fixtures/warnings_errors.json

@@ -0,0 +1,32 @@
+{
+  "warnings": [
+    "some warning",
+    "another warning"
+  ],
+  "ld_warnings": [
+
+  ],
+  "compile_warnings": [
+
+  ],
+  "errors": [
+    "some error",
+    "another error"
+  ],
+  "compile_errors": [
+
+  ],
+  "file_missing_errors": [
+
+  ],
+  "undefined_symbols_errors": [
+
+  ],
+  "duplicate_symbols_errors": [
+
+  ],
+  "tests_failures": {
+  },
+  "tests_summary_messages": [
+  ]
+}

data/spec/spec_helper.rb

@@ -55,6 +55,7 @@ end
 def testing_bitbucket_env
   {
     'GIT_URL' => 'https://github.com/diogot/danger-xcode_summary.git',
+    'CHANGE_ID' => '4d4c0f31857e3185b51b6865a0700525bc0cb2bb',
     'JENKINS_URL' => 'http://jenkins.server.com/',
     'DANGER_BITBUCKETCLOUD_USERNAME' => 'username',
     'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password'

data/spec/xcode_summary_spec.rb

@@ -156,7 +156,7 @@ module Danger
             expect(@dangerfile.status_report[:warnings]).to eq ['another warning']
           end
 
-          it 'report waring and error counts with no errors' do
+          it 'report warning and error counts with no errors' do
             result = @xcode_summary.warning_error_count('spec/fixtures/errors.json')
             expect(result).to eq '{"warnings":0,"errors":1}'
           end
@@ -166,6 +166,28 @@ module Danger
             expect(result).to eq '{"warnings":1,"errors":0}'
           end
         end
+
+        context 'with ignores_warnings' do
+          before do
+            @xcode_summary.ignores_warnings = true
+          end
+
+          it 'asserts no ld warnings' do
+            @xcode_summary.report('spec/fixtures/ld_warnings.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+          end
+
+          it 'asserts no errors' do
+            @xcode_summary.report('spec/fixtures/warnings_errors.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+            expect(@dangerfile.status_report[:errors]).to eq ['some error', 'another error']
+          end
+
+          it 'report warning and error counts with no warning' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/warnings_errors.json')
+            expect(result).to eq '{"warnings":0,"errors":2}'
+          end
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Diogo Tridapalli
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-07 00:00:00.000000000 Z
+date: 2018-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -153,6 +153,7 @@ files:
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json
 - spec/fixtures/test_errors.json
+- spec/fixtures/warnings_errors.json
 - spec/spec_helper.rb
 - spec/xcode_summary_spec.rb
 homepage: https://github.com/diogot/danger-xcode_summary
@@ -189,5 +190,6 @@ test_files:
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json
 - spec/fixtures/test_errors.json
+- spec/fixtures/warnings_errors.json
 - spec/spec_helper.rb
 - spec/xcode_summary_spec.rb