danger-xcode_summary 0.3.0 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5c8ef354ef9c12bcc5723808141d089f5d4fd05b
-  data.tar.gz: 2981e63d2cc178680dced1007ecfe7887e7b4475
+SHA256:
+  metadata.gz: 3207822c2dfeb0e69985f941835fa80d06ed3d0ae43e27576a2bcc72bfe8aea3
+  data.tar.gz: 17cb5713024a7874cf08d0f1fb1708bfacf53d865f889eaa1b76dbe2fa28342f
 SHA512:
-  metadata.gz: 5fdc7f726b98a2f83ee3167a6455cc000e31a60309f48f63604d64338db0caa68cd2c4f16f988dd1ca51d11c8acb87eb3a6917459be8035c332f7e15d462ba95
-  data.tar.gz: cf9c0a266144a0e6eb6af5cbc190a7e25289a68426e52c381cb442677e951837463e5ce62a16e14b065a85814fcef2d2cbd4f2db0cc462e26d52beac8c65258b
+  metadata.gz: 8ee02ac8c805c7f49a739e4384b656cfe24e81c04f2ff0ae108b0e78616d4b84a5ed846fa9784af99801016254434fe027541b1f4044f26265e31363de25147d
+  data.tar.gz: ba9211234bc2a64d42fbabee964bbe55ad12e18a48b6e6f7df53d4dee15809c20bb7e4615e66cf669d49ed4e86378cd7678c2f8b3f164b101f1a1e3cafb880ea

data/.rubocop.yml

@@ -2,17 +2,13 @@
 Style/ClassCheck:
   EnforcedStyle: kind_of?
 
-# It's better to be more explicit about the type
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 # specs sometimes have useless assignments, which is fine
 Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
 # HoundCI doesn't like this rule
-Style/DotPosition:
+Layout/DotPosition:
   Enabled: false
 
 # Cop supports --auto-correct.
@@ -54,8 +50,8 @@ Metrics/CyclomaticComplexity:
   Max: 17
 
 # Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 120
+Layout/LineLength:
+  Max: 130
 
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:

data/.travis.yml

@@ -4,9 +4,8 @@ cache:
     - bundle
 
 rvm:
-  - 2.0
-  - 2.1.3
-  - 2.3.1
+  - 2.6.0
+  - 2.5.3
 
 script:
-    - bundle exec rake spec
+    - bundle exec rake spec

data/Gemfile.lock

@@ -1,49 +1,63 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (0.3.0)
+    danger-xcode_summary (0.5.3)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.1)
-      public_suffix (~> 2.0, >= 2.0.2)
-    ast (2.3.0)
-    claide (1.0.1)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.2)
+    claide (1.0.3)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
-    coderay (1.1.1)
+    coderay (1.1.3)
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (4.3.3)
+    danger (8.2.3)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
-      faraday (~> 0.9)
-      faraday-http-cache (~> 1.0)
-      git (~> 1)
-      kramdown (~> 1.5)
-      octokit (~> 4.2)
-      terminal-table (~> 1)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.7)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 4.7)
+      terminal-table (>= 1, < 4)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.3)
-    faraday (0.12.0.1)
+    diff-lcs (1.4.4)
+    faraday (1.4.2)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
       multipart-post (>= 1.2, < 3)
-    faraday-http-cache (1.3.1)
-      faraday (~> 0.8)
-    ffi (1.9.18)
+      ruby2_keywords (>= 0.0.4)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.1.0)
+    ffi (1.15.1)
     formatador (0.2.5)
-    git (1.3.0)
-    guard (2.14.1)
+    git (1.8.1)
+      rchardet (~> 1.8)
+    guard (2.17.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
-      lumberjack (~> 1.0)
+      lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
       pry (>= 0.9.12)
@@ -54,80 +68,92 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (1.13.2)
+    kramdown (2.3.1)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.11)
-    method_source (0.8.2)
-    multipart-post (2.0.0)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
-    notiffany (0.1.1)
+    no_proxy_fix (0.1.2)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.7.0)
+    octokit (4.21.0)
+      faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    parser (2.4.0.0)
-      ast (~> 2.2)
-    powerpack (0.1.1)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    public_suffix (2.0.5)
-    rainbow (2.2.1)
-    rake (10.5.0)
-    rb-fsevent (0.9.8)
-    rb-inotify (0.9.8)
-      ffi (>= 0.5.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    parallel (1.20.1)
+    parser (3.0.1.1)
+      ast (~> 2.4.1)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.6)
+    rainbow (3.0.0)
+    rake (13.0.3)
+    rb-fsevent (0.11.0)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.48.1)
-      parser (>= 2.3.3.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    rubocop (1.15.0)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.5.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.5.0)
+      parser (>= 3.0.1.1)
+    ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.4)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
     shellany (0.0.1)
-    slop (3.6.0)
-    terminal-table (1.7.3)
-      unicode-display_width (~> 1.1.1)
-    thor (0.19.4)
-    unicode-display_width (1.1.3)
-    yard (0.9.8)
+    terminal-table (3.0.1)
+      unicode-display_width (>= 1.1.1, < 3)
+    thor (1.1.0)
+    unicode-display_width (2.0.0)
+    yard (0.9.26)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.3)
+  bundler (>= 2.2.10)
   danger
   danger-xcode_summary!
   guard (~> 2.14)
   guard-rspec (~> 4.7)
   listen (= 3.0.7)
   pry
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.4)
   rubocop
   yard
 
 BUNDLED WITH
-   1.14.6
+   2.2.17

data/README.md

@@ -3,7 +3,6 @@
 [![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](LICENSE.txt)
 [![Gem Version](https://badge.fury.io/rb/danger-xcode_summary.svg)](https://badge.fury.io/rb/danger-xcode_summary)
 [![Build Status](https://travis-ci.org/diogot/danger-xcode_summary.svg?branch=master)](https://travis-ci.org/diogot/danger-xcode_summary)
-[![Dependency Status](https://dependencyci.com/github/diogot/danger-xcode_summary/badge)](https://dependencyci.com/github/diogot/danger-xcode_summary)
 
 A [Danger](http://danger.systems) plugin that shows all build errors, warnings and unit tests results generated from `xcodebuild`.
 
@@ -11,6 +10,8 @@ You need to use [xcpretty](https://github.com/supermarin/xcpretty) with
 [xcpretty-json-formatter](https://github.com/marcelofabri/xcpretty-json-formatter) 
 to generate a JSON file that this plugin can read.
 
+**Using [danger-swift](https://github.com/danger/swift)**? You may want to take a look at [danger-swift-xcodesummary](https://github.com/f-meloni/danger-swift-xcodesummary).
+
 ## How does it look?
 
 <table>
@@ -96,19 +97,26 @@ xcode_summary.report 'xcodebuild.json'
 ```
 
 You can also ignore warnings from certain files by setting `ignored_files`: 
+Warning: `ignored_files` patterns applied on relative paths.  
 
 ```ruby
 # Ignoring warnings from Pods
-xcode_summary.ignored_files = '**/Pods/**'
+xcode_summary.ignored_files = 'Pods/**'
 
 # Ignoring specific warnings
 xcode_summary.ignored_results { |result|
-  result.message.start_with 'ld' # Ignore ld_warnings
+  result.message.start_with? 'ld' # Ignore ld_warnings
 }
 
 xcode_summary.report 'xcodebuild.json'
 ```
 
+You can use `ignores_warnings` to supress warnings and shows only errors.
+
+```ruby
+xcode_summary.ignores_warnings = true
+```
+
 You can use `inline_mode`.
 When this value is enabled, each warnings and errors are commented on each lines.
 
@@ -118,6 +126,12 @@ xcode_summary.inline_mode = true
 xcode_summary.report 'xcodebuild.json'
 ```
 
+You can get warning and error number by calling `warning_error_count`. The return will be a JSON string contains warning and error count, e.g {"warnings":1,"errors":3}:
+
+```ruby
+result = xcode_summary.warning_error_count 'xcodebuild.json'
+```
+
 ## License
 
 danger-xcode_summary is released under the MIT license. See [LICENSE.txt](LICENSE.txt) for details.

data/danger-xcode_summary.gemspec

@@ -21,11 +21,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = ">= 2.4.0"
+
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
 
   # General ruby development
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler', '>= 2.2.10'
+  spec.add_development_dependency 'rake', '~> 13.0'
 
   #  Testing support
   spec.add_development_dependency 'rspec', '~> 3.4'

data/lib/danger_plugin.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'xcode_summary/plugin'

data/lib/danger_xcode_summary.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'xcode_summary/gem_version'

data/lib/xcode_summary/gem_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module XcodeSummary
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.5.3'
 end

data/lib/xcode_summary/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Danger
@@ -60,6 +62,13 @@ module Danger
     # @return   [Boolean]
     attr_accessor :inline_mode
 
+    # Defines if warnings should be included or not
+    # Defaults to `false`.
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :ignores_warnings
+
+    # rubocop:disable Lint/DuplicateMethods
     def project_root
       root = @project_root || Dir.pwd
       root += '/' unless root.end_with? '/'
@@ -86,6 +95,18 @@ module Danger
       @inline_mode || false
     end
 
+    def ignores_warnings
+      @ignores_warnings || false
+    end
+
+    # Pick a Dangerfile plugin for a chosen request_source and cache it
+    # based on https://github.com/danger/danger/blob/master/lib/danger/plugin_support/plugin.rb#L31
+    def plugin
+      plugins = Plugin.all_plugins.select { |plugin| Dangerfile.essential_plugin_classes.include? plugin }
+      @plugin ||= plugins.select { |p| p.method_defined? :html_link }.map { |p| p.new(@dangerfile) }.compact.first
+    end
+    # rubocop:enable Lint/DuplicateMethods
+
     # Reads a file with JSON Xcode summary and reports it.
     #
     # @param    [String] file_path Path for Xcode summary in JSON format.
@@ -99,6 +120,22 @@ module Danger
       end
     end
 
+    # Reads a file with JSON Xcode summary and reports its warning and error count.
+    #
+    # @param    [String] file_path Path for Xcode summary in JSON format.
+    # @return   [String] JSON string with warningCount and errorCount
+    def warning_error_count(file_path)
+      if File.file?(file_path)
+        xcode_summary = JSON.parse(File.read(file_path), symbolize_names: true)
+        warning_count = warnings(xcode_summary).count
+        error_count = errors(xcode_summary).count
+        result = { warnings: warning_count, errors: error_count }
+        result.to_json
+      else
+        fail 'summary file not found'
+      end
+    end
+
     private
 
     def format_summary(xcode_summary)
@@ -110,6 +147,7 @@ module Danger
           warn(result.message, sticky: false)
         end
       end
+      # rubocop:disable Lint/UnreachableLoop
       errors(xcode_summary).each do |result|
         if inline_mode && result.location
           fail(result.message, sticky: false, file: result.location.file_name, line: result.location.line)
@@ -117,6 +155,7 @@ module Danger
           fail(result.message, sticky: false)
         end
       end
+      # rubocop:enable Lint/UnreachableLoop
     end
 
     def messages(xcode_summary)
@@ -130,6 +169,10 @@ module Danger
     end
 
     def warnings(xcode_summary)
+      if ignores_warnings
+        return []
+      end
+
       warnings = [
         xcode_summary.fetch(:warnings, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:ld_warnings, []).map { |message| Result.new(message, nil) },
@@ -164,9 +207,10 @@ module Danger
       errors.delete_if(&ignored_results)
     end
 
-    def parse_location(h)
-      file_path, line, _column = h[:file_path].split(':')
-      Location.new(h[:file_name], file_path, line.to_i)
+    def parse_location(input)
+      file_path, line, _column = input[:file_path].split(':')
+      file_name = relative_path(file_path)
+      Location.new(file_name, file_path, line.to_i)
     end
 
     def parse_test_location(failure)
@@ -176,27 +220,24 @@ module Danger
     end
 
     def format_path(path)
-      clean_path, line = parse_filename(path)
-      path = clean_path + '#L' + line if clean_path && line
-
-      # Pick a Dangerfile plugin for a chosen request_source
-      # based on https://github.com/danger/danger/blob/master/lib/danger/plugin_support/plugin.rb#L31
-      plugins = Plugin.all_plugins.select { |plugin| Dangerfile.essential_plugin_classes.include? plugin }
-      plugin = plugins.select { |p| p.method_defined? :html_link }.map { |p| p.new(@dangerfile) }.compact.first
-
-      plugin.html_link(path)
+      if plugin
+        clean_path, line = parse_filename(path)
+        path = "#{clean_path}#L#{line}" if clean_path && line
+        plugin.html_link(path)
+      else
+        path
+      end
     end
 
     def parse_filename(path)
       regex = /^(.*?):(\d*):?\d*$/
       match = path.match(regex)
-      if match
-        match.captures
-      end
+      match&.captures
     end
 
     def relative_path(path)
       return nil if project_root.nil?
+
       path.gsub(project_root, '')
     end
 
@@ -210,38 +251,38 @@ module Danger
       reason.gsub('>', '\>').gsub('<', '\<')
     end
 
-    def format_compile_warning(h)
-      path = relative_path(h[:file_path])
+    def format_compile_warning(input)
+      path = relative_path(input[:file_path])
       return nil if should_ignore_warning?(path)
 
       path_link = format_path(path)
 
-      warning = "**#{path_link}**: #{escape_reason(h[:reason])}  <br />"
-      if h[:line] && !h[:line].empty?
+      warning = "**#{path_link}**: #{escape_reason(input[:reason])}  <br />"
+      if input[:line] && !input[:line].empty?
         "#{warning}" \
           "```\n" \
-          "#{h[:line]}\n" \
+          "#{input[:line]}\n" \
           '```'
       else
         warning
       end
     end
 
-    def format_format_file_missing_error(h)
-      path = relative_path(h[:file_path])
+    def format_format_file_missing_error(input)
+      path = relative_path(input[:file_path])
       path_link = format_path(path)
-      "**#{escape_reason(h[:reason])}**: #{path_link}"
+      "**#{escape_reason(input[:reason])}**: #{path_link}"
     end
 
-    def format_undefined_symbols(h)
-      "#{h[:message]}  <br />" \
-        "> Symbol: #{h[:symbol]}  <br />" \
-        "> Referenced from: #{h[:reference]}"
+    def format_undefined_symbols(input)
+      "#{input[:message]}  <br />" \
+        "> Symbol: #{input[:symbol]}  <br />" \
+        "> Referenced from: #{input[:reference]}"
     end
 
-    def format_duplicate_symbols(h)
-      "#{h[:message]}  <br />" \
-        "> #{h[:file_paths].map { |path| path.split('/').last }.join('<br /> ')}"
+    def format_duplicate_symbols(input)
+      "#{input[:message]}  <br />" \
+        "> #{input[:file_paths].map { |path| path.split('/').last }.join('<br /> ')}"
     end
 
     def format_test_failure(suite_name, failure)

data/spec/fixtures/warnings_errors.json

@@ -0,0 +1,32 @@
+{
+  "warnings": [
+    "some warning",
+    "another warning"
+  ],
+  "ld_warnings": [
+
+  ],
+  "compile_warnings": [
+
+  ],
+  "errors": [
+    "some error",
+    "another error"
+  ],
+  "compile_errors": [
+
+  ],
+  "file_missing_errors": [
+
+  ],
+  "undefined_symbols_errors": [
+
+  ],
+  "duplicate_symbols_errors": [
+
+  ],
+  "tests_failures": {
+  },
+  "tests_summary_messages": [
+  ]
+}

data/spec/spec_helper.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'pathname'
-ROOT = Pathname.new(File.expand_path('../../', __FILE__))
-$LOAD_PATH.unshift((ROOT + 'lib').to_s)
-$LOAD_PATH.unshift((ROOT + 'spec').to_s)
+ROOT = Pathname.new(File.expand_path('..', __dir__))
+$LOAD_PATH.unshift("#{ROOT}lib".to_s)
+$LOAD_PATH.unshift("#{ROOT}spec".to_s)
 
 require 'bundler/setup'
 require 'pry'
@@ -55,9 +57,12 @@ end
 def testing_bitbucket_env
   {
     'GIT_URL' => 'https://github.com/diogot/danger-xcode_summary.git',
+    'CHANGE_ID' => '4d4c0f31857e3185b51b6865a0700525bc0cb2bb',
     'JENKINS_URL' => 'http://jenkins.server.com/',
     'DANGER_BITBUCKETCLOUD_USERNAME' => 'username',
-    'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password'
+    'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password',
+    'DANGER_BITBUCKETCLOUD_UUID' => 'c91be865-efc6-49a6-93c5-24e1267c479b',
+    'ghprbPullId' => '2080'
   }
 end
 

data/spec/xcode_summary_spec.rb

@@ -1,4 +1,6 @@
-require File.expand_path('../spec_helper', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerXcodeSummary do
@@ -52,19 +54,19 @@ module Danger
         it 'formats compile warnings' do
           @xcode_summary.report('spec/fixtures/summary.json')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
+            # rubocop:disable Layout/LineLength
             "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```",
             "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m#L176'>MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m#L176</a>**: 'NSUndefinedDateComponent' is deprecated: first deprecated in iOS 8.0 - Use NSDateComponentUndefined instead [-Wdeprecated-declarations]  <br />```\n                month_or_week = NSUndefinedDateComponent,\n```"
-            # rubocop:enable LineLength
+            # rubocop:enable Layout/LineLength
           ]
         end
 
         it 'formats compile warnings with empty line' do
           @xcode_summary.report('spec/fixtures/summary_with_empty_line.json')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
+            # rubocop:disable Layout/LineLength
             "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/Users/marcelofabri/Developer/MyAwesomeProject/MyAwesomeProject/Classes/AppDelegate.swift#L10001'>/Users/marcelofabri/Developer/MyAwesomeProject/MyAwesomeProject/Classes/AppDelegate.swift#L10001</a>**: File should contain 400 lines or less: currently contains 10001  <br />"
-            # rubocop:enable LineLength
+            # rubocop:enable Layout/LineLength
           ]
         end
 
@@ -72,9 +74,9 @@ module Danger
           @xcode_summary.ignored_files = '**/Pods/**'
           @xcode_summary.report('spec/fixtures/summary.json')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
-            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```",
-            # rubocop:enable LineLength
+            # rubocop:disable Layout/LineLength
+            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```"
+            # rubocop:enable Layout/LineLength
           ]
         end
 
@@ -87,10 +89,8 @@ module Danger
         it 'formats test errors' do
           @xcode_summary.report('spec/fixtures/test_errors.json')
           expect(@dangerfile.status_report[:errors]).to eq [
-            # rubocop:disable LineLength
             '**MyWeight.MyWeightSpec**: works_with_success, expected to eventually not be nil, got \<nil\>  <br />  ' \
-            "<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/MyWeightTests/Tests.swift#L86'>MyWeight/MyWeightTests/Tests.swift#L86</a>",
-            # rubocop:enable LineLength
+            "<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/MyWeightTests/Tests.swift#L86'>MyWeight/MyWeightTests/Tests.swift#L86</a>"
           ]
         end
 
@@ -102,6 +102,11 @@ module Danger
           ]
         end
 
+        it 'report waring and error counts' do
+          result = @xcode_summary.warning_error_count('spec/fixtures/summary.json')
+          expect(result).to eq '{"warnings":2,"errors":0}'
+        end
+
         context 'with inline_mode' do
           before do
             @xcode_summary.inline_mode = true
@@ -124,13 +129,13 @@ module Danger
             expect(@xcode_summary).to have_received(:warn).with(
               instance_of(String),
               sticky: false,
-              file: 'Bla.m',
+              file: 'MyWeight/Bla.m',
               line: 32
             )
             expect(@xcode_summary).to have_received(:warn).with(
               instance_of(String),
               sticky: false,
-              file: 'ISO8601DateFormatter.m',
+              file: 'MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m',
               line: 176
             )
           end
@@ -150,6 +155,38 @@ module Danger
             @xcode_summary.report('spec/fixtures/ld_warnings.json')
             expect(@dangerfile.status_report[:warnings]).to eq ['another warning']
           end
+
+          it 'report warning and error counts with no errors' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/errors.json')
+            expect(result).to eq '{"warnings":0,"errors":1}'
+          end
+
+          it 'report waring and error counts with no warnings' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/ld_warnings.json')
+            expect(result).to eq '{"warnings":1,"errors":0}'
+          end
+        end
+
+        context 'with ignores_warnings' do
+          before do
+            @xcode_summary.ignores_warnings = true
+          end
+
+          it 'asserts no ld warnings' do
+            @xcode_summary.report('spec/fixtures/ld_warnings.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+          end
+
+          it 'asserts no errors' do
+            @xcode_summary.report('spec/fixtures/warnings_errors.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+            expect(@dangerfile.status_report[:errors]).to eq ['some error', 'another error']
+          end
+
+          it 'report warning and error counts with no warning' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/warnings_errors.json')
+            expect(result).to eq '{"warnings":0,"errors":2}'
+          end
         end
       end
     end
@@ -159,18 +196,14 @@ module Danger
       before do
         @dangerfile = testing_bitbucket_dangerfile
         @xcode_summary = @dangerfile.xcode_summary
-        # rubocop:disable LineLength
         @xcode_summary.env.request_source.pr_json = JSON.parse(IO.read('spec/fixtures/bitbucket_pr.json'), symbolize_names: true)
-        # rubocop:enable LineLength
         @xcode_summary.project_root = '/Users/diogo/src/danger-xcode_summary'
       end
 
       describe 'where request source' do
         it 'should be bitbucket' do
-          path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb#L3')
-          # rubocop:disable LineLength
-          expect(path).to eq "<a href='https://github.com/diogot/danger-xcode_summary/lib/xcode_summary/plugin.rb?at=4d4c0f31857e3185b51b6865a0700525bc0cb2bb#L3'>lib/xcode_summary/plugin.rb</a>"
-          # rubocop:enable LineLength
+          path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb:3')
+          expect(path).to eq 'lib/xcode_summary/plugin.rb:3'
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.3
 platform: ruby
 authors:
 - Diogo Tridapalli
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-31 00:00:00.000000000 Z
+date: 2021-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -29,30 +29,30 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 2.2.10
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 2.2.10
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -153,6 +153,7 @@ files:
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json
 - spec/fixtures/test_errors.json
+- spec/fixtures/warnings_errors.json
 - spec/spec_helper.rb
 - spec/xcode_summary_spec.rb
 homepage: https://github.com/diogot/danger-xcode_summary
@@ -167,15 +168,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A [Danger](http://danger.systems) plugin that shows all build errors, warnings
@@ -189,5 +189,6 @@ test_files:
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json
 - spec/fixtures/test_errors.json
+- spec/fixtures/warnings_errors.json
 - spec/spec_helper.rb
 - spec/xcode_summary_spec.rb