danger-xcode_summary 0.2.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9083b1f9a94a9e18886d600ccc26e1431a1b40e6
-  data.tar.gz: af442fcaaddcd6913e0c6b1087cadab547e07e70
+SHA256:
+  metadata.gz: 53f29c0e11a10b8eccb342cc72a8d578f04a8e30290fb6805b4bd0848462bb31
+  data.tar.gz: f711a75b72b460f4bb4f8a5b6ca43f1d0fb4d1218e1f5f6019cf7923b70c847e
 SHA512:
-  metadata.gz: 96d3e7856eee79099c5fa5e201f980444fd1e1debf6baaac0589887bf5185633728fe0b383a87213268ad7ddae4116dfae634527c6dbeb350ef6281449c3a1ea
-  data.tar.gz: c4247af5ab105a800bc2d7ccd29917f978f49e03fc8aa48bd5804f294e5285ed63f9ae01534011bcc8c3198a376f314510395668d0e9b82c75c65a05b6ea566d
+  metadata.gz: b83113e47379c130f54d41f431d05f7374814cda752b5235e57dc409dfedea217f5079d81cf4c2cbd2e40aa438da1c5193f83fc24a1c45e0a2232f37a73b1f0c
+  data.tar.gz: cb9ff766abbbfcfe7c5bbed3c2a5861e9f42bfdf75c95f7f926b39512671005fe03e444532f9e29d385245fb76d4c06c9b5ab0a08d605887511c87d3f617f227

data/.rubocop.yml

@@ -2,17 +2,13 @@
 Style/ClassCheck:
   EnforcedStyle: kind_of?
 
-# It's better to be more explicit about the type
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 # specs sometimes have useless assignments, which is fine
 Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
 # HoundCI doesn't like this rule
-Style/DotPosition:
+Layout/DotPosition:
   Enabled: false
 
 # Cop supports --auto-correct.
@@ -54,8 +50,8 @@ Metrics/CyclomaticComplexity:
   Max: 17
 
 # Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 120
+Layout/LineLength:
+  Max: 130
 
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:

data/.travis.yml

@@ -4,9 +4,9 @@ cache:
     - bundle
 
 rvm:
-  - 2.0
-  - 2.1.3
-  - 2.3.1
+  - 2.6.0
+  - 2.5.3
+  - 2.4.5
 
 script:
-    - bundle exec rake spec
+    - bundle exec rake spec

data/Gemfile.lock

@@ -1,49 +1,52 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (0.2.1)
+    danger-xcode_summary (0.5.2)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.1)
-      public_suffix (~> 2.0, >= 2.0.2)
-    ast (2.3.0)
-    claide (1.0.1)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.1)
+    claide (1.0.3)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
-    coderay (1.1.1)
+    coderay (1.1.3)
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (4.3.3)
+    danger (8.0.2)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
-      faraday (~> 0.9)
-      faraday-http-cache (~> 1.0)
-      git (~> 1)
-      kramdown (~> 1.5)
-      octokit (~> 4.2)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.7)
+      kramdown (~> 2.0)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 4.7)
       terminal-table (~> 1)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.3)
-    faraday (0.12.0.1)
+    diff-lcs (1.4.4)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    faraday-http-cache (1.3.1)
-      faraday (~> 0.8)
-    ffi (1.9.18)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    ffi (1.13.1)
     formatador (0.2.5)
-    git (1.3.0)
-    guard (2.14.1)
+    git (1.7.0)
+      rchardet (~> 1.8)
+    guard (2.16.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
-      lumberjack (~> 1.0)
+      lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
       pry (>= 0.9.12)
@@ -54,64 +57,75 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (1.13.2)
+    kramdown (2.3.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.11)
-    method_source (0.8.2)
-    multipart-post (2.0.0)
+    lumberjack (1.2.6)
+    method_source (1.0.0)
+    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
-    notiffany (0.1.1)
+    no_proxy_fix (0.1.2)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.7.0)
+    octokit (4.18.0)
+      faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    parser (2.4.0.0)
-      ast (~> 2.2)
-    powerpack (0.1.1)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    public_suffix (2.0.5)
-    rainbow (2.2.1)
-    rake (10.5.0)
-    rb-fsevent (0.9.8)
-    rb-inotify (0.9.8)
-      ffi (>= 0.5.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.5)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    rb-fsevent (0.10.4)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    regexp_parser (1.7.1)
+    rexml (3.2.4)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.48.1)
-      parser (>= 2.3.3.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (0.86.0)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
+      rexml
+      rubocop-ast (>= 0.0.3, < 1.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.1.0)
+      parser (>= 2.7.0.1)
+    ruby-progressbar (1.10.1)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
     shellany (0.0.1)
-    slop (3.6.0)
-    terminal-table (1.7.3)
-      unicode-display_width (~> 1.1.1)
-    thor (0.19.4)
-    unicode-display_width (1.1.3)
-    yard (0.9.8)
+    terminal-table (1.8.0)
+      unicode-display_width (~> 1.1, >= 1.1.1)
+    thor (1.0.1)
+    unicode-display_width (1.7.0)
+    yard (0.9.25)
 
 PLATFORMS
   ruby
@@ -124,10 +138,10 @@ DEPENDENCIES
   guard-rspec (~> 4.7)
   listen (= 3.0.7)
   pry
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.4)
   rubocop
   yard
 
 BUNDLED WITH
-   1.14.6
+   1.17.2

data/README.md

@@ -3,7 +3,6 @@
 [![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](LICENSE.txt)
 [![Gem Version](https://badge.fury.io/rb/danger-xcode_summary.svg)](https://badge.fury.io/rb/danger-xcode_summary)
 [![Build Status](https://travis-ci.org/diogot/danger-xcode_summary.svg?branch=master)](https://travis-ci.org/diogot/danger-xcode_summary)
-[![Dependency Status](https://dependencyci.com/github/diogot/danger-xcode_summary/badge)](https://dependencyci.com/github/diogot/danger-xcode_summary)
 
 A [Danger](http://danger.systems) plugin that shows all build errors, warnings and unit tests results generated from `xcodebuild`.
 
@@ -11,6 +10,8 @@ You need to use [xcpretty](https://github.com/supermarin/xcpretty) with
 [xcpretty-json-formatter](https://github.com/marcelofabri/xcpretty-json-formatter) 
 to generate a JSON file that this plugin can read.
 
+**Using [danger-swift](https://github.com/danger/swift)**? You may want to take a look at [danger-swift-xcodesummary](https://github.com/f-meloni/danger-swift-xcodesummary).
+
 ## How does it look?
 
 <table>
@@ -96,13 +97,26 @@ xcode_summary.report 'xcodebuild.json'
 ```
 
 You can also ignore warnings from certain files by setting `ignored_files`: 
+Warning: `ignored_files` patterns applied on relative paths.  
 
 ```ruby
 # Ignoring warnings from Pods
-xcode_summary.ignored_files = '**/Pods/**'
+xcode_summary.ignored_files = 'Pods/**'
+
+# Ignoring specific warnings
+xcode_summary.ignored_results { |result|
+  result.message.start_with? 'ld' # Ignore ld_warnings
+}
+
 xcode_summary.report 'xcodebuild.json'
 ```
 
+You can use `ignores_warnings` to supress warnings and shows only errors.
+
+```ruby
+xcode_summary.ignores_warnings = true
+```
+
 You can use `inline_mode`.
 When this value is enabled, each warnings and errors are commented on each lines.
 
@@ -112,6 +126,12 @@ xcode_summary.inline_mode = true
 xcode_summary.report 'xcodebuild.json'
 ```
 
+You can get warning and error number by calling `warning_error_count`. The return will be a JSON string contains warning and error count, e.g {"warnings":1,"errors":3}:
+
+```ruby
+result = xcode_summary.warning_error_count 'xcodebuild.json'
+```
+
 ## License
 
 danger-xcode_summary is released under the MIT license. See [LICENSE.txt](LICENSE.txt) for details.

data/danger-xcode_summary.gemspec

@@ -21,11 +21,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = ">= 2.4.0"
+
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
 
   # General ruby development
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
 
   #  Testing support
   spec.add_development_dependency 'rspec', '~> 3.4'

data/lib/danger_plugin.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'xcode_summary/plugin'

data/lib/danger_xcode_summary.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'xcode_summary/gem_version'

data/lib/xcode_summary/gem_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module XcodeSummary
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.5.2'
 end

data/lib/xcode_summary/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Danger
@@ -35,6 +37,13 @@ module Danger
     # @return   [[String]]
     attr_accessor :ignored_files
 
+    # A block that filters specific results.
+    # An example would be `lambda { |result| result.message.start_with?('ld') }` to ignore results for ld_warnings.
+    #
+    # @param    [Block value
+    # @return   [Block]
+    attr_accessor :ignored_results
+
     # Defines if the test summary will be sticky or not.
     # Defaults to `false`.
     # @param    [Boolean] value
@@ -53,6 +62,13 @@ module Danger
     # @return   [Boolean]
     attr_accessor :inline_mode
 
+    # Defines if warnings should be included or not
+    # Defaults to `false`.
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :ignores_warnings
+
+    # rubocop:disable Lint/DuplicateMethods
     def project_root
       root = @project_root || Dir.pwd
       root += '/' unless root.end_with? '/'
@@ -63,6 +79,10 @@ module Danger
       [@ignored_files].flatten.compact
     end
 
+    def ignored_results(&block)
+      @ignored_results ||= block
+    end
+
     def sticky_summary
       @sticky_summary || false
     end
@@ -75,6 +95,18 @@ module Danger
       @inline_mode || false
     end
 
+    def ignores_warnings
+      @ignores_warnings || false
+    end
+
+    # Pick a Dangerfile plugin for a chosen request_source and cache it
+    # based on https://github.com/danger/danger/blob/master/lib/danger/plugin_support/plugin.rb#L31
+    def plugin
+      plugins = Plugin.all_plugins.select { |plugin| Dangerfile.essential_plugin_classes.include? plugin }
+      @plugin ||= plugins.select { |p| p.method_defined? :html_link }.map { |p| p.new(@dangerfile) }.compact.first
+    end
+    # rubocop:enable Lint/DuplicateMethods
+
     # Reads a file with JSON Xcode summary and reports it.
     #
     # @param    [String] file_path Path for Xcode summary in JSON format.
@@ -88,6 +120,22 @@ module Danger
       end
     end
 
+    # Reads a file with JSON Xcode summary and reports its warning and error count.
+    #
+    # @param    [String] file_path Path for Xcode summary in JSON format.
+    # @return   [String] JSON string with warningCount and errorCount
+    def warning_error_count(file_path)
+      if File.file?(file_path)
+        xcode_summary = JSON.parse(File.read(file_path), symbolize_names: true)
+        warning_count = warnings(xcode_summary).count
+        error_count = errors(xcode_summary).count
+        result = { warnings: warning_count, errors: error_count }
+        result.to_json
+      else
+        fail 'summary file not found'
+      end
+    end
+
     private
 
     def format_summary(xcode_summary)
@@ -119,17 +167,22 @@ module Danger
     end
 
     def warnings(xcode_summary)
-      [
+      if ignores_warnings
+        return []
+      end
+
+      warnings = [
         xcode_summary.fetch(:warnings, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:ld_warnings, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:compile_warnings, {}).map do |h|
           Result.new(format_compile_warning(h), parse_location(h))
         end
       ].flatten.uniq.compact.reject { |result| result.message.nil? }
+      warnings.delete_if(&ignored_results)
     end
 
     def errors(xcode_summary)
-      [
+      errors = [
         xcode_summary.fetch(:errors, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:compile_errors, {}).map do |h|
           Result.new(format_compile_warning(h), parse_location(h))
@@ -149,11 +202,12 @@ module Danger
           end
         end
       ].flatten.uniq.compact.reject { |result| result.message.nil? }
+      errors.delete_if(&ignored_results)
     end
 
-    def parse_location(h)
-      file_path, line, _column = h[:file_path].split(':')
-      Location.new(h[:file_name], file_path, line.to_i)
+    def parse_location(input)
+      file_path, line, _column = input[:file_path].split(':')
+      Location.new(input[:file_name], file_path, line.to_i)
     end
 
     def parse_test_location(failure)
@@ -163,27 +217,24 @@ module Danger
     end
 
     def format_path(path)
-      clean_path, line = parse_filename(path)
-      path = clean_path + '#L' + line if clean_path && line
-
-      # Pick a Dangerfile plugin for a chosen request_source
-      # based on https://github.com/danger/danger/blob/master/lib/danger/plugin_support/plugin.rb#L31
-      plugins = Plugin.all_plugins.select { |plugin| Dangerfile.essential_plugin_classes.include? plugin }
-      plugin = plugins.select { |p| p.method_defined? :html_link }.map { |p| p.new(@dangerfile) }.compact.first
-
-      plugin.html_link(path)
+      if plugin
+        clean_path, line = parse_filename(path)
+        path = clean_path + '#L' + line if clean_path && line
+        plugin.html_link(path)
+      else
+        path
+      end
     end
 
     def parse_filename(path)
       regex = /^(.*?):(\d*):?\d*$/
       match = path.match(regex)
-      if match
-        match.captures
-      end
+      match&.captures
     end
 
     def relative_path(path)
       return nil if project_root.nil?
+
       path.gsub(project_root, '')
     end
 
@@ -197,38 +248,38 @@ module Danger
       reason.gsub('>', '\>').gsub('<', '\<')
     end
 
-    def format_compile_warning(h)
-      path = relative_path(h[:file_path])
+    def format_compile_warning(input)
+      path = relative_path(input[:file_path])
       return nil if should_ignore_warning?(path)
 
       path_link = format_path(path)
 
-      warning = "**#{path_link}**: #{escape_reason(h[:reason])}  <br />"
-      if h[:line] && !h[:line].empty?
+      warning = "**#{path_link}**: #{escape_reason(input[:reason])}  <br />"
+      if input[:line] && !input[:line].empty?
         "#{warning}" \
           "```\n" \
-          "#{h[:line]}\n" \
+          "#{input[:line]}\n" \
           '```'
       else
         warning
       end
     end
 
-    def format_format_file_missing_error(h)
-      path = relative_path(h[:file_path])
+    def format_format_file_missing_error(input)
+      path = relative_path(input[:file_path])
       path_link = format_path(path)
-      "**#{escape_reason(h[:reason])}**: #{path_link}"
+      "**#{escape_reason(input[:reason])}**: #{path_link}"
     end
 
-    def format_undefined_symbols(h)
-      "#{h[:message]}  <br />" \
-        "> Symbol: #{h[:symbol]}  <br />" \
-        "> Referenced from: #{h[:reference]}"
+    def format_undefined_symbols(input)
+      "#{input[:message]}  <br />" \
+        "> Symbol: #{input[:symbol]}  <br />" \
+        "> Referenced from: #{input[:reference]}"
     end
 
-    def format_duplicate_symbols(h)
-      "#{h[:message]}  <br />" \
-        "> #{h[:file_paths].map { |path| path.split('/').last }.join('<br /> ')}"
+    def format_duplicate_symbols(input)
+      "#{input[:message]}  <br />" \
+        "> #{input[:file_paths].map { |path| path.split('/').last }.join('<br /> ')}"
     end
 
     def format_test_failure(suite_name, failure)

data/spec/fixtures/ld_warnings.json

@@ -0,0 +1,31 @@
+{
+  "warnings": [
+
+  ],
+  "ld_warnings": [
+    "some warning",
+    "another warning"
+  ],
+  "compile_warnings": [
+
+  ],
+  "errors": [
+
+  ],
+  "compile_errors": [
+
+  ],
+  "file_missing_errors": [
+
+  ],
+  "undefined_symbols_errors": [
+
+  ],
+  "duplicate_symbols_errors": [
+
+  ],
+  "tests_failures": {
+  },
+  "tests_summary_messages": [
+  ]
+}

data/spec/fixtures/warnings_errors.json

@@ -0,0 +1,32 @@
+{
+  "warnings": [
+    "some warning",
+    "another warning"
+  ],
+  "ld_warnings": [
+
+  ],
+  "compile_warnings": [
+
+  ],
+  "errors": [
+    "some error",
+    "another error"
+  ],
+  "compile_errors": [
+
+  ],
+  "file_missing_errors": [
+
+  ],
+  "undefined_symbols_errors": [
+
+  ],
+  "duplicate_symbols_errors": [
+
+  ],
+  "tests_failures": {
+  },
+  "tests_summary_messages": [
+  ]
+}

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'pathname'
-ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+ROOT = Pathname.new(File.expand_path('..', __dir__))
 $LOAD_PATH.unshift((ROOT + 'lib').to_s)
 $LOAD_PATH.unshift((ROOT + 'spec').to_s)
 
@@ -55,9 +57,12 @@ end
 def testing_bitbucket_env
   {
     'GIT_URL' => 'https://github.com/diogot/danger-xcode_summary.git',
+    'CHANGE_ID' => '4d4c0f31857e3185b51b6865a0700525bc0cb2bb',
     'JENKINS_URL' => 'http://jenkins.server.com/',
     'DANGER_BITBUCKETCLOUD_USERNAME' => 'username',
-    'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password'
+    'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password',
+    'DANGER_BITBUCKETCLOUD_UUID' => 'c91be865-efc6-49a6-93c5-24e1267c479b',
+    'ghprbPullId' => '2080'
   }
 end
 

data/spec/xcode_summary_spec.rb

@@ -1,4 +1,6 @@
-require File.expand_path('../spec_helper', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerXcodeSummary do
@@ -52,19 +54,19 @@ module Danger
         it 'formats compile warnings' do
           @xcode_summary.report('spec/fixtures/summary.json')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
+            # rubocop:disable Layout/LineLength
             "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```",
             "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m#L176'>MyWeight/Pods/ISO8601DateFormatter/ISO8601DateFormatter.m#L176</a>**: 'NSUndefinedDateComponent' is deprecated: first deprecated in iOS 8.0 - Use NSDateComponentUndefined instead [-Wdeprecated-declarations]  <br />```\n                month_or_week = NSUndefinedDateComponent,\n```"
-            # rubocop:enable LineLength
+            # rubocop:enable Layout/LineLength
           ]
         end
 
         it 'formats compile warnings with empty line' do
           @xcode_summary.report('spec/fixtures/summary_with_empty_line.json')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
+            # rubocop:disable Layout/LineLength
             "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/Users/marcelofabri/Developer/MyAwesomeProject/MyAwesomeProject/Classes/AppDelegate.swift#L10001'>/Users/marcelofabri/Developer/MyAwesomeProject/MyAwesomeProject/Classes/AppDelegate.swift#L10001</a>**: File should contain 400 lines or less: currently contains 10001  <br />"
-            # rubocop:enable LineLength
+            # rubocop:enable Layout/LineLength
           ]
         end
 
@@ -72,9 +74,9 @@ module Danger
           @xcode_summary.ignored_files = '**/Pods/**'
           @xcode_summary.report('spec/fixtures/summary.json')
           expect(@dangerfile.status_report[:warnings]).to eq [
-            # rubocop:disable LineLength
-            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```",
-            # rubocop:enable LineLength
+            # rubocop:disable Layout/LineLength
+            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```"
+            # rubocop:enable Layout/LineLength
           ]
         end
 
@@ -87,10 +89,10 @@ module Danger
         it 'formats test errors' do
           @xcode_summary.report('spec/fixtures/test_errors.json')
           expect(@dangerfile.status_report[:errors]).to eq [
-            # rubocop:disable LineLength
+            # rubocop:disable Layout/LineLength
             '**MyWeight.MyWeightSpec**: works_with_success, expected to eventually not be nil, got \<nil\>  <br />  ' \
-            "<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/MyWeightTests/Tests.swift#L86'>MyWeight/MyWeightTests/Tests.swift#L86</a>",
-            # rubocop:enable LineLength
+            "<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/MyWeightTests/Tests.swift#L86'>MyWeight/MyWeightTests/Tests.swift#L86</a>"
+            # rubocop:enable Layout/LineLength
           ]
         end
 
@@ -102,6 +104,11 @@ module Danger
           ]
         end
 
+        it 'report waring and error counts' do
+          result = @xcode_summary.warning_error_count('spec/fixtures/summary.json')
+          expect(result).to eq '{"warnings":2,"errors":0}'
+        end
+
         context 'with inline_mode' do
           before do
             @xcode_summary.inline_mode = true
@@ -135,6 +142,54 @@ module Danger
             )
           end
         end
+
+        context 'with ignored_results' do
+          before do
+            @xcode_summary.ignored_results { |result| result.message.start_with? 'some' }
+          end
+
+          it 'asserts no errors' do
+            @xcode_summary.report('spec/fixtures/errors.json')
+            expect(@dangerfile.status_report[:errors]).to eq ['another error']
+          end
+
+          it 'asserts no warnings' do
+            @xcode_summary.report('spec/fixtures/ld_warnings.json')
+            expect(@dangerfile.status_report[:warnings]).to eq ['another warning']
+          end
+
+          it 'report warning and error counts with no errors' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/errors.json')
+            expect(result).to eq '{"warnings":0,"errors":1}'
+          end
+
+          it 'report waring and error counts with no warnings' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/ld_warnings.json')
+            expect(result).to eq '{"warnings":1,"errors":0}'
+          end
+        end
+
+        context 'with ignores_warnings' do
+          before do
+            @xcode_summary.ignores_warnings = true
+          end
+
+          it 'asserts no ld warnings' do
+            @xcode_summary.report('spec/fixtures/ld_warnings.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+          end
+
+          it 'asserts no errors' do
+            @xcode_summary.report('spec/fixtures/warnings_errors.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+            expect(@dangerfile.status_report[:errors]).to eq ['some error', 'another error']
+          end
+
+          it 'report warning and error counts with no warning' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/warnings_errors.json')
+            expect(result).to eq '{"warnings":0,"errors":2}'
+          end
+        end
       end
     end
 
@@ -143,18 +198,14 @@ module Danger
       before do
         @dangerfile = testing_bitbucket_dangerfile
         @xcode_summary = @dangerfile.xcode_summary
-        # rubocop:disable LineLength
         @xcode_summary.env.request_source.pr_json = JSON.parse(IO.read('spec/fixtures/bitbucket_pr.json'), symbolize_names: true)
-        # rubocop:enable LineLength
         @xcode_summary.project_root = '/Users/diogo/src/danger-xcode_summary'
       end
 
       describe 'where request source' do
         it 'should be bitbucket' do
-          path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb#L3')
-          # rubocop:disable LineLength
-          expect(path).to eq "<a href='https://github.com/diogot/danger-xcode_summary/lib/xcode_summary/plugin.rb?at=4d4c0f31857e3185b51b6865a0700525bc0cb2bb#L3'>lib/xcode_summary/plugin.rb</a>"
-          # rubocop:enable LineLength
+          path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb:3')
+          expect(path).to eq 'lib/xcode_summary/plugin.rb:3'
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Diogo Tridapalli
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-10 00:00:00.000000000 Z
+date: 2020-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -147,11 +147,13 @@ files:
 - lib/xcode_summary/plugin.rb
 - spec/fixtures/bitbucket_pr.json
 - spec/fixtures/errors.json
+- spec/fixtures/ld_warnings.json
 - spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json
 - spec/fixtures/test_errors.json
+- spec/fixtures/warnings_errors.json
 - spec/spec_helper.rb
 - spec/xcode_summary_spec.rb
 homepage: https://github.com/diogot/danger-xcode_summary
@@ -166,15 +168,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A [Danger](http://danger.systems) plugin that shows all build errors, warnings
@@ -182,10 +183,12 @@ summary: A [Danger](http://danger.systems) plugin that shows all build errors, w
 test_files:
 - spec/fixtures/bitbucket_pr.json
 - spec/fixtures/errors.json
+- spec/fixtures/ld_warnings.json
 - spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json
 - spec/fixtures/summary_with_empty_line.json
 - spec/fixtures/test_errors.json
+- spec/fixtures/warnings_errors.json
 - spec/spec_helper.rb
 - spec/xcode_summary_spec.rb