danger-xcode_summary 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9083b1f9a94a9e18886d600ccc26e1431a1b40e6
-  data.tar.gz: af442fcaaddcd6913e0c6b1087cadab547e07e70
+  metadata.gz: 5c8ef354ef9c12bcc5723808141d089f5d4fd05b
+  data.tar.gz: 2981e63d2cc178680dced1007ecfe7887e7b4475
 SHA512:
-  metadata.gz: 96d3e7856eee79099c5fa5e201f980444fd1e1debf6baaac0589887bf5185633728fe0b383a87213268ad7ddae4116dfae634527c6dbeb350ef6281449c3a1ea
-  data.tar.gz: c4247af5ab105a800bc2d7ccd29917f978f49e03fc8aa48bd5804f294e5285ed63f9ae01534011bcc8c3198a376f314510395668d0e9b82c75c65a05b6ea566d
+  metadata.gz: 5fdc7f726b98a2f83ee3167a6455cc000e31a60309f48f63604d64338db0caa68cd2c4f16f988dd1ca51d11c8acb87eb3a6917459be8035c332f7e15d462ba95
+  data.tar.gz: cf9c0a266144a0e6eb6af5cbc190a7e25289a68426e52c381cb442677e951837463e5ce62a16e14b065a85814fcef2d2cbd4f2db0cc462e26d52beac8c65258b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (0.2.1)
+    danger-xcode_summary (0.3.0)
       danger-plugin-api (~> 1.0)
 
 GEM

data/README.md

@@ -100,6 +100,12 @@ You can also ignore warnings from certain files by setting `ignored_files`:
 ```ruby
 # Ignoring warnings from Pods
 xcode_summary.ignored_files = '**/Pods/**'
+
+# Ignoring specific warnings
+xcode_summary.ignored_results { |result|
+  result.message.start_with 'ld' # Ignore ld_warnings
+}
+
 xcode_summary.report 'xcodebuild.json'
 ```
 

data/lib/xcode_summary/gem_version.rb

@@ -1,3 +1,3 @@
 module XcodeSummary
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.3.0'.freeze
 end

data/lib/xcode_summary/plugin.rb

@@ -35,6 +35,13 @@ module Danger
     # @return   [[String]]
     attr_accessor :ignored_files
 
+    # A block that filters specific results.
+    # An example would be `lambda { |result| result.message.start_with?('ld') }` to ignore results for ld_warnings.
+    #
+    # @param    [Block value
+    # @return   [Block]
+    attr_accessor :ignored_results
+
     # Defines if the test summary will be sticky or not.
     # Defaults to `false`.
     # @param    [Boolean] value
@@ -63,6 +70,10 @@ module Danger
       [@ignored_files].flatten.compact
     end
 
+    def ignored_results(&block)
+      @ignored_results ||= block
+    end
+
     def sticky_summary
       @sticky_summary || false
     end
@@ -119,17 +130,18 @@ module Danger
     end
 
     def warnings(xcode_summary)
-      [
+      warnings = [
         xcode_summary.fetch(:warnings, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:ld_warnings, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:compile_warnings, {}).map do |h|
           Result.new(format_compile_warning(h), parse_location(h))
         end
       ].flatten.uniq.compact.reject { |result| result.message.nil? }
+      warnings.delete_if(&ignored_results)
     end
 
     def errors(xcode_summary)
-      [
+      errors = [
         xcode_summary.fetch(:errors, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:compile_errors, {}).map do |h|
           Result.new(format_compile_warning(h), parse_location(h))
@@ -149,6 +161,7 @@ module Danger
           end
         end
       ].flatten.uniq.compact.reject { |result| result.message.nil? }
+      errors.delete_if(&ignored_results)
     end
 
     def parse_location(h)

data/spec/fixtures/ld_warnings.json

@@ -0,0 +1,31 @@
+{
+  "warnings": [
+
+  ],
+  "ld_warnings": [
+    "some warning",
+    "another warning"
+  ],
+  "compile_warnings": [
+
+  ],
+  "errors": [
+
+  ],
+  "compile_errors": [
+
+  ],
+  "file_missing_errors": [
+
+  ],
+  "undefined_symbols_errors": [
+
+  ],
+  "duplicate_symbols_errors": [
+
+  ],
+  "tests_failures": {
+  },
+  "tests_summary_messages": [
+  ]
+}

data/spec/xcode_summary_spec.rb

@@ -135,6 +135,22 @@ module Danger
             )
           end
         end
+
+        context 'with ignored_results' do
+          before do
+            @xcode_summary.ignored_results { |result| result.message.start_with? 'some' }
+          end
+
+          it 'asserts no errors' do
+            @xcode_summary.report('spec/fixtures/errors.json')
+            expect(@dangerfile.status_report[:errors]).to eq ['another error']
+          end
+
+          it 'asserts no warnings' do
+            @xcode_summary.report('spec/fixtures/ld_warnings.json')
+            expect(@dangerfile.status_report[:warnings]).to eq ['another warning']
+          end
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Diogo Tridapalli
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-10 00:00:00.000000000 Z
+date: 2017-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -147,6 +147,7 @@ files:
 - lib/xcode_summary/plugin.rb
 - spec/fixtures/bitbucket_pr.json
 - spec/fixtures/errors.json
+- spec/fixtures/ld_warnings.json
 - spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json
@@ -182,6 +183,7 @@ summary: A [Danger](http://danger.systems) plugin that shows all build errors, w
 test_files:
 - spec/fixtures/bitbucket_pr.json
 - spec/fixtures/errors.json
+- spec/fixtures/ld_warnings.json
 - spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json