danger-xcode_summary 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ef0a41da411d5fedee16a908c63a787016845a4
-  data.tar.gz: 8c9907a822c190b740071ec03d5ec697165fffb5
+  metadata.gz: b206c998ed6da63ed6db8f95fba23cd5462bf647
+  data.tar.gz: 53c168e9094af71f1ffc4f56bdfb6884e9c09b5c
 SHA512:
-  metadata.gz: 7fb0cc0bffa225a4e92e0a489502400dc411521f9c315286820262f4473d78d88ee009db84704f6fd33cfb58a1128c9f8b0615d98bb38bca9c8f44777ff9d7b1
-  data.tar.gz: ed3e60b481fc7becd59935525706655b75c27fdfe6c9a3371087d146692fc8b15ac96258b0c77b2c88c4f6edd78803b5f0f9e933e8a10a67ecbb9a5f1295e4c3
+  metadata.gz: ca7b8d6828da186b54c5d23d91af79a6022c08fc1e5b9f7854cc3ea1f71a7976c8b83af9dcfd98c6ee7ed1c8b2ed503d9099eafb193836b1b12cbcdea3c57bb0
+  data.tar.gz: 54bc8cee7c7e293a29e167ec8c875cd2b86b6a0c2f02f72236f57d880ecba354347d9cf72d10c4093cbae2ce9cab451d0a874b7f4a7c38690eb5618ca463f1fc

data/.rubocop.yml

@@ -42,6 +42,10 @@ Style/RedundantReturn:
 Style/IfUnlessModifier:
   Enabled: false
 
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 320

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    danger-xcode_summary (0.1.2)
+    danger-xcode_summary (0.1.4)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.0)
+    addressable (2.5.1)
       public_suffix (~> 2.0, >= 2.0.2)
     ast (2.3.0)
     claide (1.0.1)
@@ -20,7 +20,7 @@ GEM
     colored2 (3.1.2)
     cork (0.2.0)
       colored (~> 1.2)
-    danger (4.3.0)
+    danger (4.3.3)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -33,15 +33,15 @@ GEM
       terminal-table (~> 1)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.2.5)
-    faraday (0.11.0)
+    diff-lcs (1.3)
+    faraday (0.12.0.1)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
-    ffi (1.9.14)
+    ffi (1.9.18)
     formatador (0.2.5)
     git (1.3.0)
-    guard (2.14.0)
+    guard (2.14.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (~> 1.0)
@@ -51,7 +51,7 @@ GEM
       shellany (~> 0.0)
       thor (>= 0.18.1)
     guard-compat (1.2.1)
-    guard-rspec (4.7.2)
+    guard-rspec (4.7.3)
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
@@ -59,18 +59,18 @@ GEM
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.10)
+    lumberjack (1.0.11)
     method_source (0.8.2)
     multipart-post (2.0.0)
     nap (1.1.0)
     nenv (0.3.0)
-    notiffany (0.1.0)
+    notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.6.2)
+    octokit (4.7.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    parser (2.3.1.2)
+    parser (2.4.0.0)
       ast (~> 2.2)
     powerpack (0.1.1)
     pry (0.10.4)
@@ -78,16 +78,16 @@ GEM
       method_source (~> 0.8.1)
       slop (~> 3.4)
     public_suffix (2.0.5)
-    rainbow (2.1.0)
+    rainbow (2.2.1)
     rake (10.5.0)
-    rb-fsevent (0.9.7)
-    rb-inotify (0.9.7)
+    rb-fsevent (0.9.8)
+    rb-inotify (0.9.8)
       ffi (>= 0.5.0)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)
       rspec-expectations (~> 3.5.0)
       rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.1)
+    rspec-core (3.5.4)
       rspec-support (~> 3.5.0)
     rspec-expectations (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
@@ -96,8 +96,8 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
-    rubocop (0.41.2)
-      parser (>= 2.3.1.1, < 3.0)
+    rubocop (0.48.1)
+      parser (>= 2.3.3.1, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
@@ -108,11 +108,11 @@ GEM
       faraday (~> 0.8, < 1.0)
     shellany (0.0.1)
     slop (3.6.0)
-    terminal-table (1.7.0)
-      unicode-display_width (~> 1.1)
-    thor (0.19.1)
-    unicode-display_width (1.1.0)
-    yard (0.9.1)
+    terminal-table (1.7.3)
+      unicode-display_width (~> 1.1.1)
+    thor (0.19.4)
+    unicode-display_width (1.1.3)
+    yard (0.9.8)
 
 PLATFORMS
   ruby

data/lib/xcode_summary/gem_version.rb

@@ -1,3 +1,3 @@
 module XcodeSummary
-  VERSION = '0.1.2'.freeze
+  VERSION = '0.1.4'.freeze
 end

data/lib/xcode_summary/plugin.rb

@@ -116,7 +116,12 @@ module Danger
       clean_path, line = parse_filename(path)
       path = clean_path + '#L' + line if clean_path && line
 
-      github.html_link(path)
+      # Pick a Dangerfile plugin for a chosen request_source
+      # based on https://github.com/danger/danger/blob/master/lib/danger/plugin_support/plugin.rb#L31
+      plugins = Plugin.all_plugins.select { |plugin| Dangerfile.essential_plugin_classes.include? plugin }
+      plugin = plugins.select { |p| p.method_defined? :html_link }.map { |p| p.new(@dangerfile) }.compact.first
+
+      plugin.html_link(path)
     end
 
     def parse_filename(path)

data/spec/fixtures/bitbucket_pr.json

@@ -0,0 +1,14 @@
+{
+	"fromRef": {
+		"repository": {
+			"links": {
+				"self": [
+					{
+						"href": "https://github.com/diogot/danger-xcode_summary"
+					}
+				]
+			}
+		},
+		"latestCommit": "4d4c0f31857e3185b51b6865a0700525bc0cb2bb"
+	}
+}

data/spec/spec_helper.rb

@@ -52,8 +52,23 @@ def testing_env
   }
 end
 
+def testing_bitbucket_env
+  {
+    'GIT_URL' => 'https://github.com/diogot/danger-xcode_summary.git',
+    'JENKINS_URL' => 'http://jenkins.server.com/',
+    'DANGER_BITBUCKETCLOUD_USERNAME' => 'username',
+    'DANGER_BITBUCKETCLOUD_PASSWORD' => 'password'
+  }
+end
+
 # A stubbed out Dangerfile for use in tests
 def testing_dangerfile
   env = Danger::EnvironmentManager.new(testing_env)
   Danger::Dangerfile.new(env, testing_ui)
 end
+
+# A stubbed out Dangerfile with Bitbucket as a request_source for use in tests
+def testing_bitbucket_dangerfile
+  env = Danger::EnvironmentManager.new(testing_bitbucket_env)
+  Danger::Dangerfile.new(env, testing_ui)
+end

data/spec/xcode_summary_spec.rb

@@ -95,5 +95,26 @@ module Danger
         end
       end
     end
+
+    # Second environment with different request_source
+    describe 'with bitbucket request_source' do
+      before do
+        @dangerfile = testing_bitbucket_dangerfile
+        @xcode_summary = @dangerfile.xcode_summary
+        # rubocop:disable LineLength
+        @xcode_summary.env.request_source.pr_json = JSON.parse(IO.read('spec/fixtures/bitbucket_pr.json'), symbolize_names: true)
+        # rubocop:enable LineLength
+        @xcode_summary.project_root = '/Users/diogo/src/danger-xcode_summary'
+      end
+
+      describe 'where request source' do
+        it 'should be bitbucket' do
+          path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb#L3')
+          # rubocop:disable LineLength
+          expect(path).to eq "<a href='https://github.com/diogot/danger-xcode_summary/lib/xcode_summary/plugin.rb?at=4d4c0f31857e3185b51b6865a0700525bc0cb2bb#L3'>lib/xcode_summary/plugin.rb</a>"
+          # rubocop:enable LineLength
+        end
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-xcode_summary
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
 platform: ruby
 authors:
 - Diogo Tridapalli
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-05 00:00:00.000000000 Z
+date: 2017-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -145,6 +145,7 @@ files:
 - lib/danger_xcode_summary.rb
 - lib/xcode_summary/gem_version.rb
 - lib/xcode_summary/plugin.rb
+- spec/fixtures/bitbucket_pr.json
 - spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json
@@ -178,6 +179,7 @@ specification_version: 4
 summary: A [Danger](http://danger.systems) plugin that shows all build errors, warnings
   and unit tests results generated from `xcodebuild`.
 test_files:
+- spec/fixtures/bitbucket_pr.json
 - spec/fixtures/pr_json.json
 - spec/fixtures/summary.json
 - spec/fixtures/summary_messages.json