danger-wcc 0.1.0 → 0.1.1

data/spec/wcc/dependencies_spec.rb

@@ -42,7 +42,7 @@ module Danger
         # act
         subject.perform
 
-        expect(@dangerfile.violation_report[:errors])
+        expect(@dangerfile.violation_report[:warnings])
           .to eq([Violation.new(
             'Dangerous change! react-instantsearch was updated '\
             'from 5.3.2 to 5.7.0 without a corresponding '\
@@ -78,7 +78,7 @@ module Danger
         # act
         subject.perform
 
-        expect(@dangerfile.violation_report[:errors])
+        expect(@dangerfile.violation_report[:warnings])
           .to eq([Violation.new(
             'Dangerous change! lodash was updated '\
             'from 4.17.15 to 4.18.1 without a corresponding '\
@@ -90,6 +90,40 @@ module Danger
             type: :error
           )])
       end
+
+      it 'ignores all changes when top level major version changes' do
+        allow(File).to receive(:readlines).with('yarn.lock')
+          .and_return(
+            load_fixture('dependencies/yarn.lock_second_level_effect.lock')
+            .split("\n")
+          )
+        allow(File).to receive(:read).with('package.json')
+          .and_return(
+            load_fixture('dependencies/'\
+              'package.json_second_level_effect.json')
+          )
+
+        allow(subject).to receive(:run_and_diff)
+          .with(/yarn list/)
+          .and_return(load_fixture(
+                        'dependencies/yarn_list_second_level_effect.txt.diff'
+                      ))
+        allow(@git).to receive(:diff)
+          .and_return(
+            [
+              load_diff(
+                'package.json',
+                'dependencies/package.json_second_level_effect'
+              )
+            ]
+          )
+
+        # act
+        subject.perform
+
+        expect(@dangerfile.violation_report[:warnings].map(&:message))
+          .to eq([])
+      end
     end
   end
 end

data/spec/wcc/plugin_spec.rb

@@ -17,11 +17,14 @@ module Danger
 
     describe 'all' do
       it 'runs all default and passes default options' do
-        %i[rubocop_exceptions flay todos brakeman dependencies].each do |check|
+        %i[
+          rubocop_exceptions todos brakeman
+          dependencies yarn_deduplicate
+        ].each do |check|
           expect(@my_plugin).to receive(check)
             .with({})
         end
-        %i[commit_lint reek jshint].each do |check|
+        %i[commit_lint flay reek jshint].each do |check|
           expect(@my_plugin).to_not receive(check)
         end
 
@@ -47,6 +50,7 @@ module Danger
       it 'runs only enabled checks' do
         options = {
           rubocop_exceptions: false,
+          yarn_deduplicate: false,
           todos: false,
           brakeman: false,
           reek: true
@@ -54,7 +58,7 @@ module Danger
 
         # expect
         expect(@my_plugin).to receive(:reek)
-        expect(@my_plugin).to receive(:flay)
+        expect(@my_plugin).to receive(:dependencies)
         expect(@my_plugin).to_not receive(:rubocop_exceptions)
         expect(@my_plugin).to_not receive(:commit_lint)
 

data/spec/wcc/yarn_deduplicate_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require File.expand_path('../spec_helper', __dir__)
+
+module Danger
+  describe Danger::DangerWCC do
+    before do
+      @dangerfile = testing_dangerfile
+      @my_plugin = @dangerfile.wcc
+      @git = @dangerfile.git
+      @github = @dangerfile.github
+
+      allow(@github).to receive(:pr_json)
+        .and_return(JSON.parse(load_fixture('github_pr.json')))
+      allow(subject).to receive(:run)
+        .with(/npm/)
+        .and_return('')
+      allow(subject).to receive(:run_and_diff)
+        .and_return(load_fixture('yarn_deduplicate/list.diff'))
+
+      allow(File).to receive(:exist?).and_call_original
+      allow(File).to receive(:read).and_call_original
+      allow(File).to receive(:exist?).with('yarn.lock')
+        .and_return(true)
+      allow(File).to receive(:readlines).with('yarn.lock')
+        .and_return(load_fixture('yarn_deduplicate/yarn.lock').split("\n"))
+    end
+
+    describe 'yarn_deduplicate' do
+      let(:subject) { Danger::DangerWCC::YarnDeduplicate.new(@my_plugin) }
+
+      it 'runs yarn-deduplicate and parses diff' do
+        # act
+        subject.perform
+
+        # assert
+        warnings = @dangerfile.violation_report[:warnings]
+        expect(warnings.length).to eq(2)
+
+        expect(warnings[0].message)
+          .to include('You have an opportunity to deduplicate "@babel/core".')
+        expect(warnings[0].message)
+          .to include('It wants >=7.1.0 and could unify with 7.12.10,'\
+            ' but instead 7.4.0')
+        expect(warnings[0].message)
+          .to include('npx yarn-deduplicate -s fewer --packages "@babel/core"')
+        expect(warnings[0].file).to eq('yarn.lock')
+        expect(warnings[0].line).to eq(24)
+
+        expect(warnings[1].message)
+          .to include('npx yarn-deduplicate -s fewer --packages "@babel/core"')
+        expect(warnings[1].file).to eq('yarn.lock')
+        expect(warnings[1].line).to eq(24)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-wcc
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Watermark Dev
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-19 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -294,14 +294,15 @@ files:
 - lib/wcc/default.jshintrc
 - lib/wcc/defaults.reek
 - lib/wcc/dependencies.rb
-- lib/wcc/dependencies/yarn_info.rb
 - lib/wcc/github.rb
 - lib/wcc/jshint.rb
 - lib/wcc/plugin.rb
 - lib/wcc/reek.rb
 - lib/wcc/rubocop_exceptions.rb
 - lib/wcc/todos.rb
+- lib/wcc/util/yarn_info.rb
 - lib/wcc/utils.rb
+- lib/wcc/yarn_deduplicate.rb
 - spec/fixtures/brakeman/a.tmp
 - spec/fixtures/brakeman/b.tmp
 - spec/fixtures/brakeman/brakeman.diff
@@ -310,8 +311,13 @@ files:
 - spec/fixtures/dependencies/package.json.diff
 - spec/fixtures/dependencies/package.json_patch_bumps_minor.diff
 - spec/fixtures/dependencies/package.json_patch_bumps_minor.json
+- spec/fixtures/dependencies/package.json_second_level_effect.diff
+- spec/fixtures/dependencies/package.json_second_level_effect.json
 - spec/fixtures/dependencies/yarn.lock
 - spec/fixtures/dependencies/yarn.lock_patch_bumps_minor.lock
+- spec/fixtures/dependencies/yarn.lock_second_level_effect.lock
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt.diff
 - spec/fixtures/dependencies/yarn_minor_version.diff
 - spec/fixtures/dependencies/yarn_minor_version.txt
 - spec/fixtures/dependencies/yarn_old.txt
@@ -342,6 +348,10 @@ files:
 - spec/fixtures/todo_link_same_line.diff
 - spec/fixtures/todo_no_link.diff
 - spec/fixtures/todo_removed.diff
+- spec/fixtures/yarn_deduplicate/list.a.txt
+- spec/fixtures/yarn_deduplicate/list.b.txt
+- spec/fixtures/yarn_deduplicate/list.diff
+- spec/fixtures/yarn_deduplicate/yarn.lock
 - spec/fixtures_helper.rb
 - spec/spec_helper.rb
 - spec/wcc/commit_lint_spec.rb
@@ -353,12 +363,13 @@ files:
 - spec/wcc/rubocop_exceptions_spec.rb
 - spec/wcc/todos_spec.rb
 - spec/wcc/utils_spec.rb
+- spec/wcc/yarn_deduplicate_spec.rb
 - spec/wcc_spec.rb
 homepage: https://github.com/watermarkchurch/danger-wcc
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -373,9 +384,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
+rubyforge_project:
 rubygems_version: 2.5.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: A Danger plugin for Watermark Church custom rules.
 test_files:
@@ -387,8 +398,13 @@ test_files:
 - spec/fixtures/dependencies/package.json.diff
 - spec/fixtures/dependencies/package.json_patch_bumps_minor.diff
 - spec/fixtures/dependencies/package.json_patch_bumps_minor.json
+- spec/fixtures/dependencies/package.json_second_level_effect.diff
+- spec/fixtures/dependencies/package.json_second_level_effect.json
 - spec/fixtures/dependencies/yarn.lock
 - spec/fixtures/dependencies/yarn.lock_patch_bumps_minor.lock
+- spec/fixtures/dependencies/yarn.lock_second_level_effect.lock
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt
+- spec/fixtures/dependencies/yarn_list_second_level_effect.txt.diff
 - spec/fixtures/dependencies/yarn_minor_version.diff
 - spec/fixtures/dependencies/yarn_minor_version.txt
 - spec/fixtures/dependencies/yarn_old.txt
@@ -419,6 +435,10 @@ test_files:
 - spec/fixtures/todo_link_same_line.diff
 - spec/fixtures/todo_no_link.diff
 - spec/fixtures/todo_removed.diff
+- spec/fixtures/yarn_deduplicate/list.a.txt
+- spec/fixtures/yarn_deduplicate/list.b.txt
+- spec/fixtures/yarn_deduplicate/list.diff
+- spec/fixtures/yarn_deduplicate/yarn.lock
 - spec/fixtures_helper.rb
 - spec/spec_helper.rb
 - spec/wcc/commit_lint_spec.rb
@@ -430,4 +450,5 @@ test_files:
 - spec/wcc/rubocop_exceptions_spec.rb
 - spec/wcc/todos_spec.rb
 - spec/wcc/utils_spec.rb
+- spec/wcc/yarn_deduplicate_spec.rb
 - spec/wcc_spec.rb